Re: [OE-core] [PATCH 1/2] mdamd: Switch to git recipe
Upstream project has got new maintainer last month. I'm contacting him to see what's the plan is. They were doing release every 2-3 years before and 4.2 has been released in 2021 (Dec 30th :) ) so not so long time ago. -- Pavel On Mon, Jan 22, 2024, at 12:09, Richard Purdie wrote: > On Mon, 2024-01-22 at 11:17 +0100, Alexander Kanavin wrote: > > On Mon, 22 Jan 2024 at 09:55, Pavel Zhukov wrote: > > > > > > mdadm latest official release was long time while development is > > > ongoing. This caused growing number of downstream patches in the layer. > > > Switch to git recipe and cleanup patches. > > > > Wait. > > > > Did you engage with upstream to find out if/when they're making a new > > release? Switching to a random commit in the middle of a development > > cycle needs to be carefully considered, and preferably, confirmed with > > upstream. Even if the last release was a long time ago, and > > maintenance burden with custom patches is growing. > > We did discuss this one a little on the tech call or bug triage. mdadm > is proving to be a pain, the tests are broken and we have a growing set > of patches. > > It seems upstream are happy working in git and weren't going to make > official releases, I'm not sure where I head that though. > > Whilst I generally prefer releases, moving over to git does seem like > the right thing to do in this case. > > Cheers, > > Richard > > > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#194144): https://lists.openembedded.org/g/openembedded-core/message/194144 Mute This Topic: https://lists.openembedded.org/mt/103882790/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/2] mdamd: Switch to git recipe
On Mon, 2024-01-22 at 11:17 +0100, Alexander Kanavin wrote: > On Mon, 22 Jan 2024 at 09:55, Pavel Zhukov wrote: > > > > mdadm latest official release was long time while development is > > ongoing. This caused growing number of downstream patches in the layer. > > Switch to git recipe and cleanup patches. > > Wait. > > Did you engage with upstream to find out if/when they're making a new > release? Switching to a random commit in the middle of a development > cycle needs to be carefully considered, and preferably, confirmed with > upstream. Even if the last release was a long time ago, and > maintenance burden with custom patches is growing. We did discuss this one a little on the tech call or bug triage. mdadm is proving to be a pain, the tests are broken and we have a growing set of patches. It seems upstream are happy working in git and weren't going to make official releases, I'm not sure where I head that though. Whilst I generally prefer releases, moving over to git does seem like the right thing to do in this case. Cheers, Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#194143): https://lists.openembedded.org/g/openembedded-core/message/194143 Mute This Topic: https://lists.openembedded.org/mt/103882790/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH 1/2] mdamd: Switch to git recipe
On Mon, 22 Jan 2024 at 09:55, Pavel Zhukov wrote:
>
> mdadm latest official release was long time while development is
> ongoing. This caused growing number of downstream patches in the layer.
> Switch to git recipe and cleanup patches.
Wait.
Did you engage with upstream to find out if/when they're making a new
release? Switching to a random commit in the middle of a development
cycle needs to be carefully considered, and preferably, confirmed with
upstream. Even if the last release was a long time ago, and
maintenance burden with custom patches is growing.
> --- a/meta/recipes-extended/mdadm/mdadm_4.2.bb
> +++ b/meta/recipes-extended/mdadm/mdadm_git.bb
This breaks PV monotonically increasing. You need to keep it at 4.2,
and add '+git' in the recipe.
> EXTRA_OEMAKE = 'CHECK_RUN_DIR=0 CXFLAGS="${CFLAGS}"
> SYSTEMD_DIR=${systemd_system_unitdir} \
> -BINDIR="${base_sbindir}"
> UDEVDIR="${nonarch_base_libdir}/udev"'
> +BINDIR="${base_sbindir}"
> UDEVDIR="${nonarch_base_libdir}/udev" LDFLAGS="${LDFLAGS}"'
>
> DEBUG_OPTIMIZATION:append = " -Wno-error"
>
> @@ -91,7 +77,7 @@ do_install_ptest() {
> cp -R --no-dereference --preserve=mode,links -v ${S}/tests
> ${D}${PTEST_PATH}/tests
> cp ${S}/test ${D}${PTEST_PATH}
> sed -e 's!sleep 0.*!sleep 1!g; s!/var/tmp!/mdadm-testing-dir!g' -i
> ${D}${PTEST_PATH}/test
> - sed -e 's!/var/tmp!/mdadm-testing-dir!g' -i ${D}${PTEST_PATH}/tests/*
> + find ${D}${PTEST_PATH}/tests -type f -maxdepth 1 -exec sed -e
> 's!/var/tmp!/mdadm-testing-dir!g' -i {} \;
> sed -i -e '/echo -ne "$_script... "/d' \
> -e 's/echo "succeeded"/echo -e "PASS: $_script"/g' \
> -e '/save_log fail/N; /_fail=1/i\\t\t\techo -ne "FAIL:
> $_script"' \
Why these changes?
Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#194134):
https://lists.openembedded.org/g/openembedded-core/message/194134
Mute This Topic: https://lists.openembedded.org/mt/103882790/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
