Re: [OE-core] pseudo FTBFS with recent glibc
On Mon, 2022-01-03 at 20:09 +0100, Andrej Shadura wrote: > On 03/01/2022 20:04, Andrej Shadura wrote: > > Hi, > > > > On 03/01/2022 14:47, Richard Purdie wrote: > > > On Fri, 2021-12-31 at 21:40 +0100, Andrew Shadura wrote: > > > > pseudo started failing to build from the source apparently after a glibc > > > > update [1] we had in Debian: > > > > > > > > > > In file included from pseudo_wrappers.c:46: > > > > > > ports/unix/guts/symlinkat.c: In function ‘wrap_symlinkat’: > > > > > > pseudo_client.h:14:65: error: ‘_STAT_VER’ undeclared (first use in > > > > > > this function) > > > > > > 14 | #define base_fstatat(dirfd, path, buf, flags) > > > > > > real___fxstatat64(_STAT_VER, dirfd, path, buf, flags) > > > > > > > > > > > > > > > > > > > ^ > > > > > > ports/unix/guts/symlinkat.c:37:14: note: in expansion of macro > > > > > > ‘base_fstatat’ > > > > > > 37 | rc = base_fstatat(dirfd, newpath, , > > > > > > AT_SYMLINK_NOFOLLOW); > > > > > > | ^~~~ > > > > > > > > A similar issue has been reported against fakeroot [2]. I guess, > > > > something similar is required for pseudo as well. > > > > > > > > [0]: https://bugs.debian.org/1002136 > > > > [1]: https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=8ed005daf0 > > > > [2]: https://salsa.debian.org/clint/fakeroot/-/merge_requests/10/diffs > > > > > > > > > > That looks to be a fairly old version of pseudo. This was fixed here: > > > > > > https://git.yoctoproject.org/pseudo/commit/?h=oe-core=f332f5633b5dd73fa2b6e5d605eb33e4a446d7ad > > > > > > I see. I didn’t realise the development moved to a different branch. How > > about deleting the master branch and making oe-core the default one if > > master is no longer in use? I think many more people may be missing out > > on updates if they only fetch the master branch. > > Oh, I’m being stupid. I did discover this fact in July 2020, and even > updated the watch file, but since I added it as a third source and the > package tracker doesn’t seem to support it, there was nothing to remind > me when I forgot about it. > > Nevertheless, I still think the branches need to get sorted somehow. > Also, how about tagging a release? :) It's complicated. We'd hoped the original author/maintainer might be able to find time and help review the patches as I've made any of these changes and I'm not really the expert on it. As time goes on that becomes increasingly unlikely so we probably do need to move to the master branch at some point. The same reason has put me off releases. Cheers, Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#160149): https://lists.openembedded.org/g/openembedded-core/message/160149 Mute This Topic: https://lists.openembedded.org/mt/88062641/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] pseudo FTBFS with recent glibc
On 03/01/2022 20:04, Andrej Shadura wrote: Hi, On 03/01/2022 14:47, Richard Purdie wrote: On Fri, 2021-12-31 at 21:40 +0100, Andrew Shadura wrote: pseudo started failing to build from the source apparently after a glibc update [1] we had in Debian: In file included from pseudo_wrappers.c:46: ports/unix/guts/symlinkat.c: In function ‘wrap_symlinkat’: pseudo_client.h:14:65: error: ‘_STAT_VER’ undeclared (first use in this function) 14 | #define base_fstatat(dirfd, path, buf, flags) real___fxstatat64(_STAT_VER, dirfd, path, buf, flags) | ^ ports/unix/guts/symlinkat.c:37:14: note: in expansion of macro ‘base_fstatat’ 37 | rc = base_fstatat(dirfd, newpath, , AT_SYMLINK_NOFOLLOW); | ^~~~ A similar issue has been reported against fakeroot [2]. I guess, something similar is required for pseudo as well. [0]: https://bugs.debian.org/1002136 [1]: https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=8ed005daf0 [2]: https://salsa.debian.org/clint/fakeroot/-/merge_requests/10/diffs That looks to be a fairly old version of pseudo. This was fixed here: https://git.yoctoproject.org/pseudo/commit/?h=oe-core=f332f5633b5dd73fa2b6e5d605eb33e4a446d7ad I see. I didn’t realise the development moved to a different branch. How about deleting the master branch and making oe-core the default one if master is no longer in use? I think many more people may be missing out on updates if they only fetch the master branch. Oh, I’m being stupid. I did discover this fact in July 2020, and even updated the watch file, but since I added it as a third source and the package tracker doesn’t seem to support it, there was nothing to remind me when I forgot about it. Nevertheless, I still think the branches need to get sorted somehow. Also, how about tagging a release? :) -- Cheers, Andrej -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#160147): https://lists.openembedded.org/g/openembedded-core/message/160147 Mute This Topic: https://lists.openembedded.org/mt/88062641/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] pseudo FTBFS with recent glibc
Hi, On 03/01/2022 14:47, Richard Purdie wrote: On Fri, 2021-12-31 at 21:40 +0100, Andrew Shadura wrote: pseudo started failing to build from the source apparently after a glibc update [1] we had in Debian: In file included from pseudo_wrappers.c:46: ports/unix/guts/symlinkat.c: In function ‘wrap_symlinkat’: pseudo_client.h:14:65: error: ‘_STAT_VER’ undeclared (first use in this function) 14 | #define base_fstatat(dirfd, path, buf, flags) real___fxstatat64(_STAT_VER, dirfd, path, buf, flags) | ^ ports/unix/guts/symlinkat.c:37:14: note: in expansion of macro ‘base_fstatat’ 37 | rc = base_fstatat(dirfd, newpath, , AT_SYMLINK_NOFOLLOW); | ^~~~ A similar issue has been reported against fakeroot [2]. I guess, something similar is required for pseudo as well. [0]: https://bugs.debian.org/1002136 [1]: https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=8ed005daf0 [2]: https://salsa.debian.org/clint/fakeroot/-/merge_requests/10/diffs That looks to be a fairly old version of pseudo. This was fixed here: https://git.yoctoproject.org/pseudo/commit/?h=oe-core=f332f5633b5dd73fa2b6e5d605eb33e4a446d7ad I see. I didn’t realise the development moved to a different branch. How about deleting the master branch and making oe-core the default one if master is no longer in use? I think many more people may be missing out on updates if they only fetch the master branch. -- Cheers, Andrej -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#160145): https://lists.openembedded.org/g/openembedded-core/message/160145 Mute This Topic: https://lists.openembedded.org/mt/88062641/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] pseudo FTBFS with recent glibc
Hi, On Fri, 2021-12-31 at 21:40 +0100, Andrew Shadura wrote: > Hi, > > pseudo started failing to build from the source apparently after a glibc > update [1] we had in Debian: > > > > In file included from pseudo_wrappers.c:46: > > > ports/unix/guts/symlinkat.c: In function ‘wrap_symlinkat’: > > > pseudo_client.h:14:65: error: ‘_STAT_VER’ undeclared (first use in this > > > function) > > >14 | #define base_fstatat(dirfd, path, buf, flags) > > > real___fxstatat64(_STAT_VER, dirfd, path, buf, flags) > > > | > > > ^ > > > ports/unix/guts/symlinkat.c:37:14: note: in expansion of macro > > > ‘base_fstatat’ > > >37 | rc = base_fstatat(dirfd, newpath, , > > > AT_SYMLINK_NOFOLLOW); > > > | ^~~~ > > A similar issue has been reported against fakeroot [2]. I guess, > something similar is required for pseudo as well. > > [0]: https://bugs.debian.org/1002136 > [1]: https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=8ed005daf0 > [2]: https://salsa.debian.org/clint/fakeroot/-/merge_requests/10/diffs > That looks to be a fairly old version of pseudo. This was fixed here: https://git.yoctoproject.org/pseudo/commit/?h=oe-core=f332f5633b5dd73fa2b6e5d605eb33e4a446d7ad Cheers, Richard -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#160116): https://lists.openembedded.org/g/openembedded-core/message/160116 Mute This Topic: https://lists.openembedded.org/mt/88062641/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
