Re: [oe] [PATCH] meta-oe: php, given "_append", remove superfluous "+="

[Robert P. J. Day]

On Thu, 18 Aug 2016, Martin Jansa wrote:

> Don't resend, it's already in master-next (all 4 squashed into one) and I
> would keep the space before \ because we always use space before \ even
> when it's not really necessary.

  that's what i thought, which is why i left it there. good to know,
thanks. time to start writing a style guide, methinks.

rday

-- 


Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:   http://twitter.com/rpjday
LinkedIn:   http://ca.linkedin.com/in/rpjday


-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [PATCH] meta-oe: php, given "_append", remove superfluous "+="

[Martin Jansa]

Don't resend, it's already in master-next (all 4 squashed into one) and I
would keep the space before \ because we always use space before \ even
when it's not really necessary.

On Thu, Aug 18, 2016 at 8:09 PM, Robert P. J. Day 
wrote:

> On Thu, 18 Aug 2016, Khem Raj wrote:
>
> >
> > > On Aug 18, 2016, at 2:37 AM, Robert P. J. Day 
> wrote:
> > >
> > >
> > > Signed-off-by: Robert P. J. Day 
> > >
> > > ---
> > >
> > >  again, not compile-tested since it seems obvious
> > >
> > > diff --git a/meta-oe/recipes-devtools/php/php.inc
> b/meta-oe/recipes-devtools/php/php.inc
> > > index ee7a143..23de2b1 100644
> > > --- a/meta-oe/recipes-devtools/php/php.inc
> > > +++ b/meta-oe/recipes-devtools/php/php.inc
> > > @@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/
> php-${PV}.tar.bz2 \
> > >file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch
> \
> > >   "
> > >
> > > -SRC_URI_append_class-target += " \
> > > +SRC_URI_append_class-target = “ \
> >
> > nitpick: You do not need a space here since its already added after
> newline
>
>   since i did that more than once, i'll resubmit those patches. if i'm
> going to be annoyingly nitpicky, i might as well do it correctly.
>
> rday
>
> --
>
> 
> Robert P. J. Day Ottawa, Ontario, CANADA
> http://crashcourse.ca
>
> Twitter:   http://twitter.com/rpjday
> LinkedIn:   http://ca.linkedin.com/in/rpjday
> 
>
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [PATCH] meta-oe: php, given "_append", remove superfluous "+="

[Robert P. J. Day]

On Thu, 18 Aug 2016, Khem Raj wrote:

>
> > On Aug 18, 2016, at 2:37 AM, Robert P. J. Day  wrote:
> >
> >
> > Signed-off-by: Robert P. J. Day 
> >
> > ---
> >
> >  again, not compile-tested since it seems obvious
> >
> > diff --git a/meta-oe/recipes-devtools/php/php.inc 
> > b/meta-oe/recipes-devtools/php/php.inc
> > index ee7a143..23de2b1 100644
> > --- a/meta-oe/recipes-devtools/php/php.inc
> > +++ b/meta-oe/recipes-devtools/php/php.inc
> > @@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 
> > \
> >file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch \
> >   "
> >
> > -SRC_URI_append_class-target += " \
> > +SRC_URI_append_class-target = “ \
>
> nitpick: You do not need a space here since its already added after newline
>
> > file://iconv.patch \
> > file://imap-fix-autofoo.patch \
> > file://pear-makefile.patch \
> >

  ah, quite so.

rday

-- 


Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:   http://twitter.com/rpjday
LinkedIn:   http://ca.linkedin.com/in/rpjday
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [PATCH] meta-oe: php, given "_append", remove superfluous "+="

[Robert P. J. Day]

On Thu, 18 Aug 2016, Khem Raj wrote:

>
> > On Aug 18, 2016, at 2:37 AM, Robert P. J. Day  wrote:
> >
> >
> > Signed-off-by: Robert P. J. Day 
> >
> > ---
> >
> >  again, not compile-tested since it seems obvious
> >
> > diff --git a/meta-oe/recipes-devtools/php/php.inc 
> > b/meta-oe/recipes-devtools/php/php.inc
> > index ee7a143..23de2b1 100644
> > --- a/meta-oe/recipes-devtools/php/php.inc
> > +++ b/meta-oe/recipes-devtools/php/php.inc
> > @@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 
> > \
> >file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch \
> >   "
> >
> > -SRC_URI_append_class-target += " \
> > +SRC_URI_append_class-target = “ \
>
> nitpick: You do not need a space here since its already added after newline

  since i did that more than once, i'll resubmit those patches. if i'm
going to be annoyingly nitpicky, i might as well do it correctly.

rday

-- 


Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:   http://twitter.com/rpjday
LinkedIn:   http://ca.linkedin.com/in/rpjday
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [oe] [PATCH] meta-oe: php, given "_append", remove superfluous "+="

[Khem Raj]

> On Aug 18, 2016, at 2:37 AM, Robert P. J. Day  wrote:
> 
> 
> Signed-off-by: Robert P. J. Day 
> 
> ---
> 
>  again, not compile-tested since it seems obvious
> 
> diff --git a/meta-oe/recipes-devtools/php/php.inc 
> b/meta-oe/recipes-devtools/php/php.inc
> index ee7a143..23de2b1 100644
> --- a/meta-oe/recipes-devtools/php/php.inc
> +++ b/meta-oe/recipes-devtools/php/php.inc
> @@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \
>file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch \
>   "
> 
> -SRC_URI_append_class-target += " \
> +SRC_URI_append_class-target = “ \

nitpick: You do not need a space here since its already added after newline

> file://iconv.patch \
> file://imap-fix-autofoo.patch \
> file://pear-makefile.patch \
> 
> --
> 
> 
> Robert P. J. Day Ottawa, Ontario, CANADA
>http://crashcourse.ca
> 
> Twitter:   http://twitter.com/rpjday
> LinkedIn:   http://ca.linkedin.com/in/rpjday
> 
> 
> --
> ___
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel



signature.asc
Description: Message signed with OpenPGP using GPGMail
-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

[oe] [PATCH] meta-oe: php, given "_append", remove superfluous "+="

[Robert P. J. Day]

Signed-off-by: Robert P. J. Day 

---

  again, not compile-tested since it seems obvious

diff --git a/meta-oe/recipes-devtools/php/php.inc 
b/meta-oe/recipes-devtools/php/php.inc
index ee7a143..23de2b1 100644
--- a/meta-oe/recipes-devtools/php/php.inc
+++ b/meta-oe/recipes-devtools/php/php.inc
@@ -15,7 +15,7 @@ SRC_URI = "http://php.net/distributions/php-${PV}.tar.bz2 \
file://0001-acinclude-use-pkgconfig-for-libxml2-config.patch \
   "

-SRC_URI_append_class-target += " \
+SRC_URI_append_class-target = " \
 file://iconv.patch \
 file://imap-fix-autofoo.patch \
 file://pear-makefile.patch \

-- 


Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:   http://twitter.com/rpjday
LinkedIn:   http://ca.linkedin.com/in/rpjday


-- 
___
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel