Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-783994-ara into lp:openobject-addons
Review: Needs Fixing please put the _check_date constraint into the attribute _constraints of account.move.line. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-783994-ara/+merge/61545 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-783994-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-764855-aag into lp:openobject-addons
FYI: i fixed the icon too (terp-go-home) -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-764855-aag/+merge/58276 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-764855-aag. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-777803-ron into lp:openobject-addons
Review: Needs Fixing 0 is an acceptable value -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-777803-ron/+merge/60147 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-777803-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-777803-ron into lp:openobject-addons
i fixed -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-777803-ron/+merge/60147 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-777803-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-hr-search-psi into lp:openobject-addons
next time, create a LP bug and link it to the merge prop. thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-hr-search-psi/+merge/59777 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-hr-search-psi. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-765559-ron into lp:openobject-addons
Review: Needs Fixing i don't think you can change the order = parent_left, it's used for the hierarchy computation.. Need to check that -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-765559-ron/+merge/59498 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-765559-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-account-asset-add-date-field-bde into lp:~openerp-dev/openobject-addons/trunk-account-asset
Review: Needs Fixing btw, i'd like also that you apply the same layout for the depreciaiton method and duration of asset than in asset category form view. otherwise, for the feature improved here: 1) when we select 'ending period' as choice, the field during (interval) should be set invisible 2) the entries created are not good. I think that what you didn't understand is that this new field date is used instead of the total depreciation to do. If you set purchase value: 10 000€ salvage value: 0€ depr. all (periods): 12 during (interval): 5 (but not visible, and it won't be used in computation) ending period date: 08/28/2012 = then it should compute 2 depreciation lines, with 5000 foreach. Currently the amount on each is 2000 because at the time of computation it consider that we have to make 5 depreciation entries, and in that case it's wrong. Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-account-asset-add-date-field-bde/+merge/62604 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-account-asset. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-rework-product-terminlg-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Review: Needs Fixing I fixed that. Please have a look 1) did a case-insensitive str.replace import re pattern = re.compile(hello, re.IGNORECASE) pattern.sub(bye, hello HeLLo HELLO) 2) already_id in def execute was unused 3) if i understand correctly what you've done, already_id in translation_done method was used only for menus, because the name of menu are translate=True, then you need to write on the existing translation instead of creating a new one, right? well this was not good: - it's not taking into account the normal fields with translate=True - the code is really complex for nothing and unreadable 4) the name of variables and functions should be more appropriated. example: make_translations() instead of translations_done() 5) ir.ui.menu and ir.model.fields are not enough... we need that also for ir.act.window + for menu tips and help tooltips of fields and once i've done that, i merged that branch in trunk. Please be more accurate next time. Thanks, Quentin -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-product-terminlg-aag/+merge/61345 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-change-label-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-payroll-change-label-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-change-label-mtr/+merge/61114 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-change-label-mtr/+merge/61114 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-contribution-report-psi into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing report layout should be improved in order to: *use same style as other reports *display the selected dates of the wizard in header *add a column quantity *add a row for total *display the payslip name and the rest of information on the same row *row header for amount should be 'Amount' and the currency should be added in each column. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-contribution-report-psi/+merge/61374 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-add-fields-on-payslip-run-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing :( no, what i meant by in the wizard is: while running the wizard. I see that you've added those fields on the wizard. so what we want is: fields on the payslip run, when i run the wizard, i see only the list of employee. When i select some and generate the payslip for the selected employees it is using the information (dates, boolean) incoming from the payslip run (not from the wizard as there is only one field on it which is hte m2m to employees) -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-add-fields-on-payslip-run-mtr/+merge/61913 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-python-code-browse-using-dot-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing categories.BASIC + (categories.ALW or 0.0) this rule doesn't work if there is no ALW category. Find a way to solve that. also, as the change from localdict = category_dict is meaningless please revert it -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-python-code-browse-using-dot-mtr/+merge/61954 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-account-remove-fields-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-account-remove-fields-mtr/+merge/61090 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-contribution-report-psi into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing conflicting. Please resubmit -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-contribution-report-psi/+merge/61374 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-contribution-report-psi into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing what? something isn't good in hr_payroll/hr_payroll_report.xml. I see plenty of new reports among some on removed object like hr.payroll.advice... also in pyroll.py: remove the commented code you jsut added for contribution register: bazaar is your historian. please fix that -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-contribution-report-psi/+merge/61374 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-account-asset-onchange-asset-account-bde into lp:~openerp-dev/openobject-addons/trunk-account-asset
Review: Needs Fixing merge and solve conflicts please -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-account-asset-onchange-asset-account-bde/+merge/61209 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-account-asset. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-account-asset-usability-bde into lp:~openerp-dev/openobject-addons/trunk-account-asset
Review: Needs Fixing replace tabs and solve conflicts -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-account-asset-usability-bde/+merge/61218 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-account-asset. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-account-asset-invoice_asset_state-uco into lp:~openerp-dev/openobject-addons/trunk-account-asset
i merged but you should improve to create the asset accordingly to the value of depreciation fields of asset category selected = you have to run the onchange on the asset to fill those fields thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-account-asset-invoice_asset_state-uco/+merge/61369 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-account-asset. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-add-fields-on-payslip-run-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing :( this is not good at all. The generated payslip have to use the value we're setting on the payslip run otherwise it's just useless so *make the date from and date to required on the payslip run *add default value for those fields as they have on payslip *in the wizard, write the dates incoming from the payslip run *in the wizard, also write the boolean 'credit note' on generated payslip thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-add-fields-on-payslip-run-mtr/+merge/61913 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-python-code-browse-using-dot-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing
use this instead of inheritency of InputLine:
+categories_dict = {}
+categories_obj = BrowsableObject(self.pool, cr, uid,
payslip.employee_id.id, categories_dict)
Then for the renaming of the variable localdict into categories_dict: i didn't
test but are you sure the localdict where we evaluate the python will contain
the last value computed for the categories?
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-python-code-browse-using-dot-mtr/+merge/61954
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-payroll.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-account-remove-fields-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
pad updated please check it in order to complete the merge proposal. Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-account-remove-fields-mtr/+merge/61090 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-change-label-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing as discussed with mra, please change the field name too in order to make input.SALEURO.amount insteead of .quantity Also fix the typo in the help tooltip (quantity instead of qunatity) thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-change-label-mtr/+merge/61114 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-732419-ara into lp:openobject-addons
Review: Needs Fixing i do not agree: when you holiday request is refused, you want to know who (which manager) refused it. So we need to save the user that press the refuse button. Moreover, previously it was saving the refusing manager always in the same field whatever if it was already approved once. This need to be fixed as well. Finally, if the leave type needs only 1 step to be approved, we should display only one manager field, not both. Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-732419-ara/+merge/54314 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-732419-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-730885-skh into lp:openobject-addons
Review: Needs Information i should already have fixed that 2 weeks ago, so i'm rejecting this merge prop for the sake of clarity in LP. Please resubmit if the bug is confirmed again. Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-730885-skh/+merge/55318 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-730885-skh. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-730885-skh into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-730885-skh into lp:openobject-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-730885-skh/+merge/55318 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-730885-skh/+merge/55318 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-730885-skh. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-742283-ara into lp:openobject-addons
Review: Needs Fixing there is no need of 2 functions, 1 is enough. i don't understand this line: + if voucher.pay_now == 'pay_later': You should probably use the amount_residual field of account.move.line to test if it's paid, it will save some code. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-742283-ara/+merge/55722 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-742283-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-742100-ron into lp:openobject-addons
Review: Needs Fixing the unit price is messing even without the second pricelist: i'm creating a uom:pack of 2 units with bategory = unit, factor = 2 and rounding = 1. Then when i want to encode a sale.order.line with 1 PCE of PC1 = 450 per unit 1 pack of 2 of PC1 = 1800 per pack instead of 900 Please check it. thnaks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-742100-ron/+merge/55734 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-742100-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-742100-ron into lp:openobject-addons
Review: Approve oops, sorry i was checking the wrong branch... it's working as expected -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-742100-ron/+merge/55734 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-742100-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-752876-pso into lp:openobject-addons
Review: Needs Information
how could this work? what's that clause?? ('journal_id', '=', journal_id)
journal_id field doesn't exist in account.account ?!
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-752876-pso/+merge/56761
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-752876-pso.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-hr_timesheet_fix_yml-ara into lp:openobject-addons
Review: Needs Information i don't get the same diff when trying to merge the branch in the main trunk that here. Is it stacked on good repository? -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-hr_timesheet_fix_yml-ara/+merge/59775 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-hr_timesheet_fix_yml-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-782293-ara into lp:openobject-addons
Review: Needs Fixing I just noticed that there was a company search criteria in tax codes and not taxes. So for symmetry, the same search criteria should be added in view_account_tax_search. please do so -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-782293-ara/+merge/61219 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-782293-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa into lp:~openerp-dev/openobject-server/trunk-temporal-db
Review: Needs Fixing 67 + # avoid creating history records when writing on a reocrd that is already an history record 68 + if record.temporal_parent_id: 69 + return False replace the return False statement with continue -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa/+merge/60367 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-temporal-db. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-account-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
i merged another branch that i made but which is based on this one. so i'm rejecting this merge proposal to clear my pending merge to do list Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-account-mtr/+merge/60745 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-account-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-payroll-account-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-account-mtr/+merge/60745 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-account-mtr/+merge/60745 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-configuration-rework-company-imp-rpa into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Review: Needs Fixing use multi='address' in every new functional fields that could be computed in the same time. -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework-company-imp-rpa/+merge/60784 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-configuration-rework-company-imp-rpa into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Review: Needs Fixing another enhancement: use the first _default_ address instead of the first address. For that, use the address_get function defined on res.partner object. Thanks -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework-company-imp-rpa/+merge/60784 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-rework-company-view-imp-rpa into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
it's merged, the res_model had to be changed as well thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework-company-view-imp-rpa/+merge/60783 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa into lp:~openerp-dev/openobject-server/trunk-temporal-db
Review: Needs Fixing
few comments, just by reading the diff:
line 21-22 of the diff are useless as context isn't used later in the code of
the function. Can be removed for better readability.
line 24: why this ids.reverse()? is it to treat the case where we have records
A,B,C respectively in timeline, then change the temporal_date_from of C and set
something between A and B (to get A,C,B)? in that case, i would have seen a
search with order by temporal_date_from.. I need information here.
line 29: why this break?
in get_next_id_in_timeline
line35: unused
line37: the params of the search seem wrong. I would have seen something like:
reference_field = record.temporal_parent_id and record.temporal_parent_id.id or
record.id
['|',('temporal_parent_id', '=', reference_field), ('id', '=',
reference_field),('temporal_date_from', '=', record.temporal_date_to)]
line 38: you return always the last value of search_id, it means that if you
pass a list of ids like [1,2,3,4] or [4] it will have exactly the same behavior.
code of write() can be improved
line 77-78: can be removed i think
if context.get('temporal_mode', True) and not vals.get('temporal_date_from'):
line 69: i don't see the point to do ids.pop(), it will simply not work doing
that. Just a continue would be enough
code of browse: didn't checked yet, i had set this point as not needed in the
pad because in theory it should already work currently as the browse is only
using search and read... But keep a patch for that in case of... ;-) (but
remove it from this merge prop please
thanks,
Quentin
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-read-search-unlink-ksa/+merge/60367
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-server/trunk-temporal-db.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-configuration-server-ksa into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Review: Needs Information
i don't know the tempfile python module.
+ tempfileid, tempfilename= tempfile.mkstemp('.rml', 'openerp_')
will it work with any Operating System?
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-server-ksa/+merge/59346
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-server/trunk-configuration-rework.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing
in hr_payroll/wizard/hr_payroll_payslips_by_employees.py, abuot lines 335-346:
the behavior seems really weird to me: you call the onchange with [] as ids,
then create the payslip, then create the input lines...
you can do everything in one operation in you pass the good value for that
field in the create. Check the example bellow (to create some order lines at
the time of SO creation):
vals.update({'order_line': [(0, 0, {'product_id': 1, 'product_uom_qty':
3, 'product_uom': 1, 'name': 'test', 'price_unit': 100, 'type':
'make_to_stock'}), (0, 0, {'product_id': 1, 'product_uom_qty': 3,
'product_uom': 1, 'name': 'test', 'price_unit': 100, 'type':
'make_to_stock'})]})
res = super(sale_order, self).create(cr, uid, vals, context=context)
Also: when opening a payslip from the payslip.run object, i don't know why but
the note and structure_id fields are readonly although they aren't if i open
the same payslip from the payslip menu.
Something new: we need also to keep track of the state of payslip.run: [(draft,
Draft), (close, Close)] and
*the button generate payslip is only visible if the run is draft
*on a payslip, we can only select a payslip.run in draft
Thanks,
Quentin
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-payroll.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-payslip-on-payslip-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing no, it needs fixing: we need to take into account also if the payslip is a credite note or not: in that case it should subtract pl.total so i didn't merged it, and thus you will be very nice to include in your next try the change i proposed above. ;-) Thanks, Quentin -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-payslip-on-payslip-mtr/+merge/60055 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-rename_salary_head-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing i just realized: we should take care to rename it into salary rule category instead of salary category :-s sorry for the double-work -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-rename_salary_head-mtr/+merge/60498 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-rename_salary_head-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-payroll-rename_salary_head-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll has been updated. Status: Merged = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-rename_salary_head-mtr/+merge/60498 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-rename_salary_head-mtr/+merge/60498 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-748178-pso into lp:openobject-addons
why did you removed average_price from view? -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-748178-pso/+merge/57449 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-748178-pso. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-748178-pso into lp:openobject-addons
Review: Approve i remember the problem, :-) it's cool like this -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-748178-pso/+merge/57449 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-748178-pso. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-715470-ara into lp:openobject-addons
Review: Approve i aproove and set Olivier as reviewer (in order to clean my merge proposal list) and as we are waiting for his patch server side. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-715470-ara/+merge/51288 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-715470-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751299-skh into lp:openobject-addons
i fixed this: priority of new view set to 35 in order to low its priority (should only be seen when in configuration\holidays\leave type it's merged now -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751299-skh/+merge/58634 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-751299-skh. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751299-skh into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-751299-skh into lp:openobject-addons has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751299-skh/+merge/58634 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751299-skh/+merge/58634 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-751299-skh. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-760412-pso into lp:openobject-addons
Review: Needs Fixing you cannot use voucher.account_id as this account is already used for the counter part (its meaningless to use the same account for both the debit the credit of the same operation). Instead, use the default accounts defined on the journal accordingly if the move will be a credit or a debit (default_debit_account or default_credit_account). Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-760412-pso/+merge/58228 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-760412-pso. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-759444-skh into lp:openobject-addons
next time: don't forget to encapsulate your strings with _(my string) in order to enable the translation for it. I fixed and merged it. Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-759444-skh/+merge/59458 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-759444-skh. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso into lp:openobject-addons
Review: Needs Fixing for this bug, i'm not sure this is the god way to solve the problem. I would have prefer to have a new fields.float to save the percentage used t compute the amount in company currency, then in the _get_amount function we can just call super() and apply this percentage to the result to get the final result. It seems more interesting because: 1)it reuses the code of super and do not compute again by its own the amount in currency (which is error prone, btw there is an error in this method: you should have passed a date in the context in compute() in order to use the rate at the good date... so maybe there are other errors) 2)it stores a new information that seems very valuable for any future needs Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-717198-pso/+merge/57623 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-717198-pso. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-753835-ara into lp:openobject-addons
don't you find it's really confusing to use a variable named stock_dest_id for the source or stock move?? i made my own fix for that (and it's already merged so this branch is rejected although it contains a working fix), which is similar but with better variable names. Think about that next time. Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-753835-ara/+merge/56884 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-753835-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-753835-ara into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-753835-ara into lp:openobject-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-753835-ara/+merge/56884 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-753835-ara/+merge/56884 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-753835-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp into lp:openobject-addons
Review: Needs Fixing
i checked and for me it's solving all the known problems of the partner ledger.
The only problem with this merge proposal is that it is creating error in yaml
test because of the new constraint we've added.
[2011-05-04 14:46:25,524][trunk_mai_03] INFO:init:module account: loading
test/account_report.yml
File /home/qdp/tinydev/addons/trunk/account/account_move_line.py, line 102,
in _query_get
raise osv.except_osv(_('Warning !'),_(You haven't supplied enough argument
to compute the initial balance))
Please check it,
thanks,
Quentin
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-744789-qdp/+merge/58334
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp into lp:openobject-addons
while testing i found out that there was another bug: if i select the periods from 01/2011 - 05/2011 it was displaying also the opening entries though it should have been added in the initial balance. So i used this branch to fix that too. ;-) It will be merged into the trunk as soon as the errors in yaml will be fixed. Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-744789-qdp/+merge/58334 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp into lp:openobject-addons
a last thought: we should replace the boolean 'include reconciled entries' by a fourth option in the filter selection box Unreconciled Entries. So, the 4 options would be: filter by: No filter filter by: Date filter by: Periods filter by: Unreconciled Entries so that we will be sure that the initial balance is always complete. Can you do that do before i merge in the trunk? Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-744789-qdp/+merge/58334 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-temporal-db-rpa into lp:~openerp-dev/openobject-server/trunk-temporal-db
Review: Approve FYI: append() is twice as fast as list concatenation :-) Well done! -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-temporal-db-rpa/+merge/59450 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-temporal-db. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron into lp:openobject-addons
similar patch already landed in trunk. SO i reject for the sake of clarity. thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-718609-ron/+merge/59325 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron into lp:openobject-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-718609-ron/+merge/59325 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-718609-ron/+merge/59325 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-718609-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-768430-ron into lp:openobject-addons
Review: Needs Information i cannot reproduce this bug. Am i missing something? -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-768430-ron/+merge/59170 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-768430-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron into lp:openobject-addons
Review: Needs Information bug has been passed back into confirmed status. Please check it -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751222-ron/+merge/57112 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-751222-ron. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp into lp:openobject-addons
qdp (OpenERP) has proposed merging
lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp into
lp:openobject-addons.
Requested reviews:
Purnendu Singh (OpenERP) (psi-tinyerp)
Olivier Dony (OpenERP) (odo)
Related bugs:
Bug #744789 in OpenERP Addons: [V6] Third party ledger : Initial Balance
https://bugs.launchpad.net/openobject-addons/+bug/744789
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-744789-qdp/+merge/58334
in the query_get() of account.move.line, if we don't give any other criteria in
the context than the fiscalyear when computing an initial balance then it
simply means that the entries returned will be exactly the same as without
initial balance, which lead to count the entries twice...
this hack is a little nasty (not so say a lot nasty), but i can't think to
something else.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-744789-qdp/+merge/58334
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp.
=== modified file 'account/account_move_line.py'
--- account/account_move_line.py 2011-04-25 06:11:14 +
+++ account/account_move_line.py 2011-04-28 07:25:56 +
@@ -82,17 +82,25 @@
period_ids = fiscalperiod_obj.search(cr, uid, [('id', 'in', context['periods'])], order='date_start', limit=1)
if period_ids and period_ids[0]:
first_period = fiscalperiod_obj.browse(cr, uid, period_ids[0], context=context)
+where_move_lines_by_date = AND +obj+.move_id IN (SELECT id FROM account_move WHERE date ' +first_period.date_start+')
# Find the old periods where date start of those periods less then Start period
periods = fiscalperiod_obj.search(cr, uid, [('date_start', '', first_period.date_start)])
periods = ','.join([str(x) for x in periods])
if periods:
query = obj+.state 'draft' AND +obj+.period_id IN (SELECT id FROM account_period WHERE fiscalyear_id IN (%s) AND id IN (%s)) %s %s % (fiscalyear_clause, periods, where_move_state, where_move_lines_by_date)
+else:
+query = obj+.state 'draft' AND +obj+.period_id IN (SELECT id FROM account_period WHERE fiscalyear_id IN (%s)) %s %s % (fiscalyear_clause, where_move_state, where_move_lines_by_date)
else:
ids = ','.join([str(x) for x in context['periods']])
query = obj+.state 'draft' AND +obj+.period_id IN (SELECT id FROM account_period WHERE fiscalyear_id IN (%s) AND id IN (%s)) %s %s % (fiscalyear_clause, ids, where_move_state, where_move_lines_by_date)
else:
query = obj+.state 'draft' AND +obj+.period_id IN (SELECT id FROM account_period WHERE fiscalyear_id IN (%s)) %s %s % (fiscalyear_clause, where_move_state, where_move_lines_by_date)
+if initial_bal and not context.get('periods', False) and not where_move_lines_by_date:
+#we didn't pass any filter in the context, and the initial balance can't be computed using only the fiscalyear otherwise entries will be summed twice
+#so we have to invalidate this query
+raise osv.except_osv(_('Warning !'),_(You haven't supplied enough argument to compute the initial balance))
+
if context.get('journal_ids', False):
query += ' AND '+obj+'.journal_id IN (%s)' % ','.join(map(str, context['journal_ids']))
=== modified file 'account/report/account_partner_ledger.py'
--- account/report/account_partner_ledger.py 2011-01-14 00:11:01 +
+++ account/report/account_partner_ledger.py 2011-04-28 07:25:56 +
@@ -58,10 +58,11 @@
obj_partner = self.pool.get('res.partner')
self.query = obj_move._query_get(self.cr, self.uid, obj='l', context=data['form'].get('used_context', {}))
ctx2 = data['form'].get('used_context',{}).copy()
-ctx2.update({'initial_bal': True})
+self.initial_balance = data['form'].get('initial_balance', True)
+if self.initial_balance:
+ctx2.update({'initial_bal': True})
self.init_query = obj_move._query_get(self.cr, self.uid, obj='l', context=ctx2)
self.reconcil = data['form'].get('reconcil', True)
-self.initial_balance = data['form'].get('initial_balance', True)
self.result_selection = data['form'].get('result_selection', 'customer')
self.amount_currency = data['form'].get('amount_currency', False)
self.target_move = data['form'].get('target_move', 'all')
=== modified file 'account/wizard/account_report_partner_ledger.py'
--- account/wizard/account_report_partner_ledger.py 2011-04-15 10:09:01 +
+++ account/wizard/account_report_partner_ledger.py 2011-04-28 07:25:56 +
@@ -39,9 +39,22 @@
}
_defaults = {
'reconcil': True,
- 'initial_balance': True
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-tooltips-psi into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing it's not really meaningfull i think. i'd prefer something like: The code of salary rules can be used as reference in computation of other rules. In that case, it is case sensitive. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-tooltips-psi/+merge/59048 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Needs Fixing few points to correct: 1) [2011-04-28 15:14:35,238][payroll_avr_28] WARNING:init:object hr.payslip.groups (hr.payslip.groups) has no access rules! 2) when selecting a category, i should search for employees in that category but also for employees in a category child of this category 3) wwhen computing the payslip of employees, you must call the onchange_employee_id method otherwise the input lines for him won't be created and when openerp is trying to compute them it's raising error like invalid quantity for meal voucher rule (because there isn't an input line with code = WORK100) 4) add the m2o on the payslip form view too, in the tab other information thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-wizard_payslip_employee_category-wise-psi/+merge/58953 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp into lp:openobject-addons has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-744789-qdp/+merge/58334 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-744789-qdp/+merge/58334 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-749958-xrg into lp:openobject-addons
Review: Needs Information i'm waiting the validation by the bug reporter that your patch is doing the trick, Panos. :-) -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-749958-xrg/+merge/58487 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-749958-xrg. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-722832-pso into lp:openobject-addons
Review: Needs Information
having just a fast look, i'm wondering about those lines:
6 def sum_cr(self):
7 if self.res_bl['type'] == _('Net Loss'):
8 - self.result_sum_cr += self.res_bl['balance']
9 + self.result_sum_dr += self.res_bl['balance']
we are in sum_cr method and we use result_sum_dr ? are those lines correcting
the bug or it's a hunk that wouldn't have landed on the branch?
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-722832-pso/+merge/56115
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-722832-pso.
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-719063-pso into lp:openobject-addons
Review: Needs Fixing patch for payroll is wrong: HR / Officer should be able to see all the payslips of him or of employess for which he's the manager. But this will be addressed in the RD project related to hr_payroll, so you can simply remove that hunk. second path for timesheet is correct, but i'm not sure that there isn't any other patch needed. More investigation is needed, in the meanwhile you can already remove the 1st patch Priyesh. Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-719063-pso/+merge/55337 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-719063-pso. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-configuration-rework into lp:openobject-server
The proposal to merge lp:~openerp-dev/openobject-server/trunk-configuration-rework into lp:openobject-server has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework/+merge/53209 -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework/+merge/53209 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-configuration-rework into lp:openobject-server
it's not yet ready and even not fully tested, so i reject it for the sake of clarity ^^ -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework/+merge/53209 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-commiter/openobject-server/trunk-fix-uninstallation-sus into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Review: Disapprove i think this branch isn't stacked on the good one (should be the main project branch, not the trunk-addons) and thus it's giving here a wrong diff. Please Sudhir resubmit a correct branch so that we can see the diff directly. Thanks -- https://code.launchpad.net/~openerp-commiter/openobject-server/trunk-fix-uninstallation-sus/+merge/52526 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-commiter/openobject-server/trunk-fix-uninstallation-sus into lp:~openerp-dev/openobject-server/trunk-configuration-rework
The proposal to merge lp:~openerp-commiter/openobject-server/trunk-fix-uninstallation-sus into lp:~openerp-dev/openobject-server/trunk-configuration-rework has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-commiter/openobject-server/trunk-fix-uninstallation-sus/+merge/52526 -- https://code.launchpad.net/~openerp-commiter/openobject-server/trunk-fix-uninstallation-sus/+merge/52526 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework
Review: Needs Fixing ha yes, i didn't though to you could do it with simply a col=2. Great! but not exatly what they want as usability :-s, as they want something i could summary like this: *The list of application is col=4 and each application name has a colspan of 2. *under each installed application, a separator of colspan=4 and 2 columns of the available modules for this application (each application with a colspan of 2 also) so i just sent you a drawing of what they want. Thanks -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag/+merge/59032 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
Review: Needs Fixing cfr my comment in same proposal for server side -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag/+merge/59165 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag into lp:~openerp-dev/openobject-server/trunk-configuration-rework
what is that??? -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-rework-21Apr-server-aag/+merge/59032 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag into lp:~openerp-dev/openobject-addons/trunk-configuration-rework
wtf? can someone exaplin me what this have to do with config-rework? -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-rework-21Apr-addons-aag/+merge/59019 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-746544-ara into lp:openobject-addons
Review: Needs Fixing not a good idea, set ondelete=cascade on the field move_id of aaccount.analytic.line please -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-746544-ara/+merge/55924 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-746544-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-746422-pso into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-746422-pso into lp:openobject-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-746422-pso/+merge/55896 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-746422-pso/+merge/55896 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-746422-pso. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-739562-skh into lp:openobject-addons
Review: Approve don't forget to include the context in the browse next time ;-) -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-739562-skh/+merge/56343 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-739562-skh. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751299-skh into lp:openobject-addons
Review: Disapprove it's not the proper way to fix. The bug purpose is about: we shouldn't see computed fields when going in list view of leave types in configuration. So we should define a new list view without the fields: field name=max_leaves/ field name=leaves_taken/ field name=remaining_leaves/ with low priority and assign this view to the menuitem in configuration. thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751299-skh/+merge/56516 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-751299-skh. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-751299-skh into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-751299-skh into lp:openobject-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751299-skh/+merge/56516 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-751299-skh/+merge/56516 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-751299-skh. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-755609-pso into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-755609-pso into lp:openobject-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-755609-pso/+merge/57140 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-755609-pso/+merge/57140 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-755609-pso. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-716300-ara into lp:openobject-addons
Review: Needs Information what's the link with the bug report? -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-716300-ara/+merge/57670 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-716300-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp into lp:openobject-addons
qdp (OpenERP) has proposed merging
lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp into
lp:openobject-addons.
Requested reviews:
Olivier Dony (OpenERP) (odo)
Related bugs:
Bug #744789 in OpenERP Addons: [V6] Third party ledger : Initial Balance
https://bugs.launchpad.net/openobject-addons/+bug/744789
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-744789-qdp/+merge/58334
in the query_get() of account.move.line, if we don't give any other criteria in
the context than the fiscalyear when computing an initial balance then it
simply means that the entries returned will be exactly the same as without
initial balance, which lead to count the entries twice...
this hack is a little nasty (not so say a lot nasty), but i can't think to
something else.
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-744789-qdp/+merge/58334
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-744789-qdp.
=== modified file 'account/account_move_line.py'
--- account/account_move_line.py 2011-03-25 15:38:54 +
+++ account/account_move_line.py 2011-04-19 15:46:29 +
@@ -93,6 +93,10 @@
else:
query = obj+.state 'draft' AND +obj+.period_id IN (SELECT id FROM account_period WHERE fiscalyear_id IN (%s)) %s %s % (fiscalyear_clause, where_move_state, where_move_lines_by_date)
+if initial_bal and not context.get('periods', False) and not where_move_lines_by_date:
+#we didn't pass any filter in the context, and the initial balance can't be computed using only the fiscalyear otherwise entries will be summed twice
+#so we have to invalidate this query
+query += AND 1=2
if context.get('journal_ids', False):
query += ' AND '+obj+'.journal_id IN (%s)' % ','.join(map(str, context['journal_ids']))
___
Mailing list: https://launchpad.net/~openerp-dev-web
Post to : openerp-dev-web@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-web
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-payroll-demo-data-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll
Review: Approve after a fast review it seems correct -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-payroll-demo-data-mtr/+merge/57161 Your team OpenERP RD Team is requested to review the proposed merge of lp:~openerp-dev/openobject-addons/trunk-payroll-demo-data-mtr into lp:~openerp-dev/openobject-addons/trunk-payroll. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa into lp:openobject-addons has been updated. Status: Merged = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724820-ksa/+merge/54695 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724820-ksa/+merge/54695 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa into lp:openobject-addons
bugfix was invalid -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724820-ksa/+merge/54695 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa into lp:openobject-addons
Review: Disapprove -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-724820-ksa/+merge/54695 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-724820-ksa. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-739181-rpa into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-739181-rpa into lp:openobject-addons has been updated. Status: Merged = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-739181-rpa/+merge/54812 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-739181-rpa/+merge/54812 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-739181-rpa. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-739181-rpa into lp:openobject-addons
Review: Disapprove actually, the bug was invalid. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-739181-rpa/+merge/54812 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-739181-rpa. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-700928-ksa into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-700928-ksa into lp:openobject-addons has been updated. Status: Merged = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-700928-ksa/+merge/54691 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-700928-ksa/+merge/54691 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-700928-ksa. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-700928-ksa into lp:openobject-addons
Review: Disapprove fix reverted, ass the bug was invalid. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-700928-ksa/+merge/54691 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-700928-ksa. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/qdp-l10n_us into lp:~openerp-dev/openobject-addons/dsh-l10n_us
qdp (OpenERP) has proposed merging
lp:~openerp-dev/openobject-addons/qdp-l10n_us into
lp:~openerp-dev/openobject-addons/dsh-l10n_us.
Requested reviews:
dsh (Open ERP) (dsh-openerp)
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/qdp-l10n_us/+merge/55141
merge some of the improvements of David Mitchell from NovaPoint + redesign form
view of check
Remaining things to do:
- set defaut and demo data in order to have a check sequence given on the check
journal
- (to be discussed) set check sequence field as mandatory on account.journal if
allow_check is True
- fill the check number of voucher when posting/validating the check
- check rml improvements made by NovaPoint and merge the interesting things
Thanks,
Quentin
--
https://code.launchpad.net/~openerp-dev/openobject-addons/qdp-l10n_us/+merge/55141
Your team OpenERP RD Team is subscribed to branch
lp:~openerp-dev/openobject-addons/dsh-l10n_us.
=== modified file 'account_check_writing/__openerp__.py'
--- account_check_writing/__openerp__.py 2011-01-18 01:33:32 +
+++ account_check_writing/__openerp__.py 2011-03-28 13:09:33 +
@@ -21,7 +21,7 @@
{
name : Check writing,
version : 1.1,
-author : OpenERP SA,
+author : OpenERP SA, NovaPoint Group,
category: Generic Modules/Accounting,
description:
Module for the Check writing and check printing
@@ -30,8 +30,10 @@
'init_xml': [],
depends : [
account_voucher,
+account_accountant,
],
'update_xml': [
+'check_sequence.xml',
'account_check_writing_report.xml',
'account_view.xml',
'account_voucher_view.xml',
=== modified file 'account_check_writing/account.py'
--- account_check_writing/account.py 2010-12-23 18:25:45 +
+++ account_check_writing/account.py 2011-03-28 13:09:33 +
@@ -26,6 +26,8 @@
_columns = {
'allow_check_writing': fields.boolean('Allow Check writing', help='Fill this if the journal is to be used for writing checks.'),
+'use_preprint_check': fields.boolean('Use Preprinted Check'),
+'check_sequence': fields.many2one('ir.sequence', 'Check Sequence', help=This field contains the information related to the numbering of the check number.),
}
account_journal()
=== modified file 'account_check_writing/account_view.xml'
--- account_check_writing/account_view.xml 2011-01-18 01:33:32 +
+++ account_check_writing/account_view.xml 2011-03-28 13:09:33 +
@@ -10,11 +10,16 @@
field name=nameaccount.journal.form/field
field name=modelaccount.journal/field
field name=typeform/field
- field name=inherit_id ref=account.view_account_journal_form /
+field name=inherit_id ref=account.view_account_journal_form /
field name=arch type=xml
-field name=type on_change=onchange_type(type, currency)/
+field name=type on_change=onchange_type(type, currency) /
field name=entry_posted position=after
-field name=allow_check_writing attrs={'readonly':[('type','!=','bank')]}/
+field name=allow_check_writing attrs={'readonly':[('type','!=','bank')]} /
+field name=use_preprint_check attrs={'readonly':[('type','!=','bank')]} /
+/field
+field name=sequence_id required=0 position=after
+field name=check_sequence
+attrs={'readonly':[('allow_check_writing','=',False)]} /
/field
/field
/record
=== modified file 'account_check_writing/account_voucher.py'
--- account_check_writing/account_voucher.py 2011-02-04 01:19:58 +
+++ account_check_writing/account_voucher.py 2011-03-28 13:09:33 +
@@ -38,6 +38,7 @@
_columns = {
'amount_in_word' : fields.char(Amount in word , size=128, readonly=True, states={'draft':[('readonly',False)]}),
'allow_check' : fields.boolean('Allow Check Writing'), # attrs does not support '.' format and fields.relates get the value when v save the record
+'chk_seq' : fields.char(Check Number , size=64, readonly=True),
}
@@ -82,7 +83,6 @@
if journal_id:
allow_check_writing = self.pool.get('account.journal').browse(cr, uid, journal_id).allow_check_writing
default['value'].update({'allow_check':allow_check_writing})
-
return default
def print_check(self, cr, uid, ids, context=None):
=== modified file 'account_check_writing/account_voucher_view.xml'
--- account_check_writing/account_voucher_view.xml 2011-02-24 17:23:49 +
+++ account_check_writing/account_voucher_view.xml 2011-03-28 13:09:33 +
@@ -2,7 +2,7 @@
openerp
data
-record model=ir.ui.view id=view_vendor_payment_check_form
+!--record model=ir.ui.view id=view_vendor_payment_check_form
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-740353-ara into lp:openobject-addons
i commited in that branch how to properly use the set type. Please have a look Ashvin. By the way, why don't i see Mustufa as reviewer? Anyway, i merged this branch with my fix -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-740353-ara/+merge/54669 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-740353-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-rework into lp:openobject-addons
i'm rejecting for the sake of clarity in my merge proposal list although i didn't found any mistake (yet :p), but i have several other improvements to discuss with you, Rucha. In particular, our specifications weren't good when saying: on the module list, one click = one installed module. Actually, what is wanted is: one click = one module scheduled to install (as before) + run the wiazrd 'apply scheduled installation' (just simulate a click on this wizard). So, it will allow us to keep a validation step (the old one) before installing a module (latest improvements were quiet violent ^^) Also, before merging into trunk, i'd like to have the list of wizards ready (specified on the pad). thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework/+merge/53208 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-configuration-rework into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-configuration-rework into lp:openobject-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework/+merge/53208 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-configuration-rework/+merge/53208 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-configuration-rework. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-729602-ara into lp:openobject-addons
i agree with Bogdan Stanciu. Please update your merge proposal accordingly. Thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-729602-ara/+merge/52684 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-729602-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons
Review: Needs Fixing it's not working. I guess my suggestion wasn't good. Did you test at your side? -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728417-ara/+merge/52660 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
[Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons
The proposal to merge lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara into lp:openobject-addons has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728417-ara/+merge/52660 -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-728417-ara/+merge/52660 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-728417-ara. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
Re: [Openerp-dev-web] [Merge] lp:~openerp-dev/openobject-addons/trunk-bug-730562-xrg into lp:openobject-addons
as discussed with xrg, i'm rejecting this merge proposal that have been done only for testing purpose. -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-730562-xrg/+merge/52419 Your team OpenERP RD Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-730562-xrg. ___ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
