Will there be an API for creating materials?
It seems that currently developers can't create their own material because the abstract class Material is not designed to be subclassed, and so PhongMaterial is the only one available. Are there any plans to allow developers to subclass Material and crate their own materials? Phong is somewhat old and other shaders are more commonly used in the industry.
Re: CSS id selector with embedded dot
Fair enough. The CSS Reference Guide says " While the JavaFX CSS parser will parse valid CSS syntax, it is not a fully compliant CSS parser." Escaped characters is a case in point. On 5/10/17 11:10 AM, Doswald Michael wrote: On 5/10/17 2:02 PM, David Grieve wrote: Having an id with a dot is not valid CSS syntax. From the spec: " An ID selector contains a "number sign" (U+0023, #) immediately followed by the ID value, which must be an CSS identifiers." An identifier is defined here: https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier. The tldr; is that an identifier cannot contain a dot. But in the link you referenced it says: "Identifiers can also contain escaped characters and any ISO 10646 character as a numeric code (see next item). For instance, the identifier "B&W?" may be written as "B\&W\?" or "B\26 W\3F"." Wouldn't that include an escaped dot as a valid character for a CSS identifier?
Re: Corrections for Javadoc
I just filed a new issue to catch any last minute typos: https://bugs.openjdk.java.net/browse/JDK-8180070 I'll add your note to this new JBS bug. Thank you. -- Kevin Nir Lisker wrote: I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. I can't submit issues to the JIRA so I'll list them here. A similar issue was https://bugs.openjdk.java.net/browse/JDK-8177341. - The following use "a Observable..." instead of "an Observable...". - javafx.beans.property - ListProperty - MapProperty - ReadOnlyListPropertyBase - SetProperty - javafx.beans.binding - NumberExpression - BooleanExpression - DoubleExpression - FloatExpression - IntegerExpression - ListExpression - LongExpression - MapExpression - ObjectExpression - SetExpression - StringExpression - javafx.scene.shape.ObservableFaceArray copies its description from its superinteface ObservableIntegerArray, does not declare any API methods and is listed under package javafx.scene.shape. It's not clear at all what this interface is. As it is, it looks like it's not meant to be exposed. - javafx.collections.ObservableIntegerArray uses "a int[]" instead of "an int[]". This writing ("a int") is found in java.lang.Integer as well in a few places. Nir
Corrections for Javadoc
I'm looking at build 168 of JDK9 and there are a few mistakes in the docs. I can't submit issues to the JIRA so I'll list them here. A similar issue was https://bugs.openjdk.java.net/browse/JDK-8177341. - The following use "a Observable..." instead of "an Observable...". - javafx.beans.property - ListProperty - MapProperty - ReadOnlyListPropertyBase - SetProperty - javafx.beans.binding - NumberExpression - BooleanExpression - DoubleExpression - FloatExpression - IntegerExpression - ListExpression - LongExpression - MapExpression - ObjectExpression - SetExpression - StringExpression - javafx.scene.shape.ObservableFaceArray copies its description from its superinteface ObservableIntegerArray, does not declare any API methods and is listed under package javafx.scene.shape. It's not clear at all what this interface is. As it is, it looks like it's not meant to be exposed. - javafx.collections.ObservableIntegerArray uses "a int[]" instead of "an int[]". This writing ("a int") is found in java.lang.Integer as well in a few places. Nir
Re: CSS id selector with embedded dot
On 5/10/17 2:02 PM, David Grieve wrote: > Having an id with a dot is not valid CSS syntax. > > From the spec: " An ID selector contains a "number sign" (U+0023, #) > immediately followed by the ID value, which must be an CSS identifiers." > > An identifier is defined here: > https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier. The tldr; > is that an identifier cannot contain a dot. But in the link you referenced it says: "Identifiers can also contain escaped characters and any ISO 10646 character as a numeric code (see next item). For instance, the identifier "B&W?" may be written as "B\&W\?" or "B\26 W\3F"." Wouldn't that include an escaped dot as a valid character for a CSS identifier?
Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs
I added the missing copyright header before pushing. I will file two new issues: one to add copyright headers to all the other package.html files (which I will do in JDK 9) and one to convert all of the package.html files to package-info.java (which I will target to 10...I don't want to make that change this late in 9). Thanks again. -- Kevin Mandy Chung wrote: On May 9, 2017, at 6:52 PM, Kevin Rushforth mailto:kevin.rushfo...@oracle.com>> wrote: Thanks for the review. We currently don't use package-info.java anywhere, but I can file a separate bug for converting all of our package.html to package-info.java. That’d be good. I can add the the missing copyright headers at the same time. OK. No need for an updated webrev. Mandy -- Kevin Mandy Chung wrote: On May 9, 2017, at 6:08 PM, Kevin Rushforth wrote: Please review the following to exclude jdk.packager module from the JDK docs bundle: https://bugs.openjdk.java.net/browse/JDK-8180040 http://cr.openjdk.java.net/~kcr/8180040/webrev.00/ I also added a missing package description for the jdk.packager.services package (in the jdk.packager.services module), since the jdk.packager.services module will remain in the docs. I suggest to convert package.html to package-info.java. Also need copyright header. build.properties change looks fine. Mandy
Re: CSS id selector with embedded dot
Infact '#the.button1' means id = the, cssclass = button1 So it would match Button b ...; b.setId("the"); b.getClassNames().add("button1"); Tom Von meinem iPhone gesendet > Am 10.05.2017 um 16:02 schrieb David Grieve : > > Having an id with a dot is not valid CSS syntax. > > From the spec: " An ID selector contains a "number sign" (U+0023, #) > immediately followed by the ID value, which must be an CSS identifiers." > > An identifier is defined here: > https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier. The tldr; is > that an identifier cannot contain a dot. > > >> On 5/10/17 9:23 AM, Jens Auer wrote: >> Hi, >> >> I am working on a project which enforces unique FX Id by using a naming >> convention mirroring the hierarchical structure of the controls in the name, >> delimited by dots. So for example, we have a button "myPane.button1". I am >> not able to select this button in a css file. Here is an example program and >> the css file: >> >> import javafx.application.Application; >> import javafx.scene.Scene; >> import javafx.scene.control.Button; >> import javafx.scene.layout.VBox; >> import javafx.stage.Stage; >> >> public class CssTest extends Application { >> >> public static void main(final String[] args) { >> Application.launch(args); >> } >> >> @Override >> public void start(final Stage stage) { >> VBox vbox = new VBox(); >> Button b1 = new Button(); >> b1.setId("the.button"); >> b1.setText("BUTTON1"); >> >> Button b2 = new Button(); >> b2.setId("thebutton"); >> b2.setText("BUTTON2"); >> >> vbox.getChildren().addAll(b1, b2); >> vbox.getStylesheets().add("stylesheet.css"); >> >> final Scene scene = new Scene(vbox); >> >> stage.setScene(scene); >> stage.show(); >> } >> } >> The css file is >> >> #the\.button { >> -fx-graphic: url("Keyboard.png"); >> } >> >> #thebutton { >> -fx-graphic: url("Keyboard.png"); >> } >> >> As far as I understand the CSS definition the names are valid ids and >> escaping should work here. Is this a limitation in the JavaFX CSS parser? >> >> Best wishes, >> Jens >> >> Jens Auer >> (Softwareentwicklung) >> ___ >> Unternehmensberatung H & D GmbH >> Niederlassung Weißenthurm >> Werftstr. 5 - 56575 Weißenthurm >> Tel.:02637/94238 -110 >> Fax:02637/94238 -149 >> jens.a...@h-d-gmbh.de >> http://www.h-d-gmbh.de >> http://www.h-d-gmbh.de/impressum.html >> ___ >> >
Re: CSS id selector with embedded dot
Having an id with a dot is not valid CSS syntax. From the spec: " An ID selector contains a "number sign" (U+0023, #) immediately followed by the ID value, which must be an CSS identifiers." An identifier is defined here: https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier. The tldr; is that an identifier cannot contain a dot. On 5/10/17 9:23 AM, Jens Auer wrote: Hi, I am working on a project which enforces unique FX Id by using a naming convention mirroring the hierarchical structure of the controls in the name, delimited by dots. So for example, we have a button "myPane.button1". I am not able to select this button in a css file. Here is an example program and the css file: import javafx.application.Application; import javafx.scene.Scene; import javafx.scene.control.Button; import javafx.scene.layout.VBox; import javafx.stage.Stage; public class CssTest extends Application { public static void main(final String[] args) { Application.launch(args); } @Override public void start(final Stage stage) { VBox vbox = new VBox(); Button b1 = new Button(); b1.setId("the.button"); b1.setText("BUTTON1"); Button b2 = new Button(); b2.setId("thebutton"); b2.setText("BUTTON2"); vbox.getChildren().addAll(b1, b2); vbox.getStylesheets().add("stylesheet.css"); final Scene scene = new Scene(vbox); stage.setScene(scene); stage.show(); } } The css file is #the\.button { -fx-graphic: url("Keyboard.png"); } #thebutton { -fx-graphic: url("Keyboard.png"); } As far as I understand the CSS definition the names are valid ids and escaping should work here. Is this a limitation in the JavaFX CSS parser? Best wishes, Jens Jens Auer (Softwareentwicklung) ___ Unternehmensberatung H & D GmbH Niederlassung Weißenthurm Werftstr. 5 - 56575 Weißenthurm Tel.:02637/94238 -110 Fax:02637/94238 -149 jens.a...@h-d-gmbh.de http://www.h-d-gmbh.de http://www.h-d-gmbh.de/impressum.html ___
CSS id selector with embedded dot
Hi, I am working on a project which enforces unique FX Id by using a naming convention mirroring the hierarchical structure of the controls in the name, delimited by dots. So for example, we have a button "myPane.button1". I am not able to select this button in a css file. Here is an example program and the css file: import javafx.application.Application; import javafx.scene.Scene; import javafx.scene.control.Button; import javafx.scene.layout.VBox; import javafx.stage.Stage; public class CssTest extends Application { public static void main(final String[] args) { Application.launch(args); } @Override public void start(final Stage stage) { VBox vbox = new VBox(); Button b1 = new Button(); b1.setId("the.button"); b1.setText("BUTTON1"); Button b2 = new Button(); b2.setId("thebutton"); b2.setText("BUTTON2"); vbox.getChildren().addAll(b1, b2); vbox.getStylesheets().add("stylesheet.css"); final Scene scene = new Scene(vbox); stage.setScene(scene); stage.show(); } } The css file is #the\.button { -fx-graphic: url("Keyboard.png"); } #thebutton { -fx-graphic: url("Keyboard.png"); } As far as I understand the CSS definition the names are valid ids and escaping should work here. Is this a limitation in the JavaFX CSS parser? Best wishes, Jens Jens Auer (Softwareentwicklung) ___ Unternehmensberatung H & D GmbH Niederlassung Weißenthurm Werftstr. 5 - 56575 Weißenthurm Tel.: 02637/94238 -110 Fax: 02637/94238 -149 jens.a...@h-d-gmbh.de http://www.h-d-gmbh.de http://www.h-d-gmbh.de/impressum.html ___
[10] Review request : JDK-8089840 : Disabled menu items are invisible with 100% contrast display settings
Hi Jonathan, Request you to review following fix : Bug : https://bugs.openjdk.java.net/browse/JDK-8089840 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8089840/webrev.0/ Regards, Ajit