RFR: 8227808: Make GTK3 libraries mandatory for building on Linux
Need for the change [[JDK-8227808](https://bugs.openjdk.java.net/browse/JDK-8227808)]: Currently GTK3 is the default on Linux. However, there is build logic that will skip building glassgtk3 if the gtk3 development libraries are not installed. This creates a situation where the build will succeed, but the resulting JavaFX library will fail to run unless you explicitly force GTK2 with "-Djdk.gtk.version=2". How to verify the change: On a Linux system without gtk2 and gtk3 packages, 1. Clone jfx and run gradle sdk. -> Build should fail with an error for missing GTK3 packages. 2. Install gtk3 packages, remove build directory and run gradle clean sdk. -> Build should fail with an error for missing GTK2 packages. 3. Install gtk2 packages, remove build directory and run gradle clean sdk. -> Build should finish without any error. Build verification: 1. Run a JavaFX application with -Djdk.gtk.verbose=true Verify the verbose message, the default glassgtk3 library should be used. 2. Run a JavaFX application with -Djdk.gtk.verbose=true -Djdk.gtk.version=2 Verify the verbose message, glassgtk2 library should be used. 3. Run a JavaFX application with -Djdk.gtk.verbose=true -Djdk.gtk.version=3 Verify the verbose message, glassgtk3 library should be used. Commits: - 57157900: 8227808: Make GTK3 libraries mandatory for building on Linux Changes: https://git.openjdk.java.net/jfx/pull/61/files Webrev: https://webrevs.openjdk.java.net/jfx/61/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8227808 Stats: 18 lines in 1 file changed: 0 ins; 10 del; 8 mod Patch: https://git.openjdk.java.net/jfx/pull/61.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/61/head:pull/61 PR: https://git.openjdk.java.net/jfx/pull/61
Re: RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute
On Thu, 28 Nov 2019 13:16:19 GMT, Arun Joseph wrote: > On Wed, 20 Nov 2019 15:04:07 GMT, Kevin Rushforth wrote: > >> On Wed, 20 Nov 2019 07:05:40 GMT, Arun Joseph wrote: >> >>> Issue: Native part of WebView throws a DOMException and then, continues >>> executing the rest of the function assuming that value is present. This >>> causes the JVM to crash when retrieving the value. >>> >>> Fix: Return from the function if exception was raised (code is similar to >>> exception handling in >>> [WebKitLegacy/java/DOM/JavaTreeWalker.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebKitLegacy/java/DOM/JavaTreeWalker.cpp)) >>> >>> This fix also needs to be applied to all function calls in >>> [WebKitLegacy/java/DOM](https://github.com/openjdk/jfx/tree/master/modules/javafx.web/src/main/native/Source/WebKitLegacy/java/DOM) >>> functions which raises DOMError similar to createAttributeImpl(). >>> >>> >>> >>> Commits: >>> - acc52780: 8233747: JVM crash in >>> com.sun.webkit.dom.DocumentImpl.createAttribute >>> >>> Changes: https://git.openjdk.java.net/jfx/pull/47/files >>> Webrev: https://webrevs.openjdk.java.net/jfx/47/webrev.00 >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8233747 >>> Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod >>> Patch: https://git.openjdk.java.net/jfx/pull/47.diff >>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/47/head:pull/47 >> >> The proposed fix seems more like a workaround to me. There are dozens of >> very similar calls to `raiseOnDOMError` in this and other files, so I would >> think a more general solution is needed. > > For calls to `raiseOnDOMError()` with argument of type `ExceptionOr>`, > the returned value is again passed through `WTF::getPtr()`. This doesn't > modify the value returned, but removing it will require changing about 40 > function calls. In `createAttributeImpl` function in [JavaDocument.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebKitLegacy/java/DOM/JavaDocument.cpp), the value returned from `raiseOnDOMError` is passed to `WTF::getPtr` function. Now there are two calls to `WTF::getPtr`, one from `raiseOnDOMError` in the return statement and another in `createAttributeImpl`, instead of just one. So, this approach has an unnecessary call to `WTF::getPtr` which, if needed, has to removed at the `createAttributeImpl` end. This doesn't modify the `Attr` object returned because `WTF::getPtr` returns the same pointer when called multiple times. PR: https://git.openjdk.java.net/jfx/pull/47
Re: [Rev 03] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute
The pull request has been updated with additional changes. Added commits: - 472d77cf: Added spaces Changes: - all: https://git.openjdk.java.net/jfx/pull/47/files - new: https://git.openjdk.java.net/jfx/pull/47/files/7f6ed5bf..472d77cf Webrevs: - full: https://webrevs.openjdk.java.net/jfx/47/webrev.03 - incr: https://webrevs.openjdk.java.net/jfx/47/webrev.02-03 Issue: https://bugs.openjdk.java.net/browse/JDK-8233747 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/47.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/47/head:pull/47 PR: https://git.openjdk.java.net/jfx/pull/47
Re: RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
On Wed, 4 Dec 2019 15:29:50 GMT, Kevin Rushforth wrote:
> On Wed, 4 Dec 2019 14:50:21 GMT, Robert Lichtenberger
> wrote:
>
>> On Tue, 3 Dec 2019 05:08:49 GMT, Ambarish Rapte wrote:
>>
>>> On Mon, 21 Oct 2019 10:19:04 GMT, Robert Lichtenberger
>>> wrote:
>>>
By using the collection itself as synchronization lock we achieve
behaviour that matches java.util.Collections classes.
I've create test cases that fail with the current way of synchronizing on
a separate object.
I've removed unused constructors.
Commits:
- 7e80839f: 8232524: SynchronizedObservableMap cannot be be protected for
copying/iterating
- 8ecf3545: JDK-8232524 fixed.
Changes: https://git.openjdk.java.net/jfx/pull/17/files
Webrev: https://webrevs.openjdk.java.net/jfx/17/webrev.00
Issue: https://bugs.openjdk.java.net/browse/JDK-8232524
Stats: 120 lines in 2 files changed: 95 ins; 17 del; 8 mod
Patch: https://git.openjdk.java.net/jfx/pull/17.diff
Fetch: git fetch https://git.openjdk.java.net/jfx pull/17/head:pull/17
>>>
>>> The change looks good to me, added a comment for a small change in test.
>>>
>>> modules/javafx.base/src/test/java/test/javafx/collections/FXCollectionsTest.java
>>> line 730:
>>>
729: } catch (ConcurrentModificationException e) {
730: fail("ConcurrentModificationException should not be
thrown");
731: }
>>>
>>> The thread should be terminated here too, please add `thread.terminate();`
>>> before `fail()`
>>>
>>>
>>>
>>> Changes requested by arapte (Reviewer).
>>
>> You're right. I just pushed the fix.
>
> Note that this is still pending a second review from @arapte
@effad you can now integrate this whenever you are ready. I will sponsor it.
PR: https://git.openjdk.java.net/jfx/pull/17
Re: RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property
On Wed, 4 Dec 2019 15:51:42 GMT, Jeanette Winzenburg wrote: > On Wed, 4 Dec 2019 15:49:47 GMT, Jeanette Winzenburg > wrote: > >> fix for https://bugs.openjdk.java.net/browse/JDK-8220722 >> >> - replaces the manually registered listener with registerChangeListener(...) >> - added test that's failing before and passing after the fix (plus a sanity >> test that the skin still is listening to changes) >> >> >> >> Commits: >> - 9f4fc409: 8220722: ProgressBarSkin: adds strong listener to control's >> width >> - 61f7361d: 8235151: Nonexistent notifyQuit method referred from iOS >> GlassHelper.m >> >> Changes: https://git.openjdk.java.net/jfx/pull/59/files >> Webrev: https://webrevs.openjdk.java.net/jfx/59/webrev.00 >> Issue: https://bugs.openjdk.java.net/browse/JDK-8220722 >> Stats: 102 lines in 5 files changed: 88 ins; 0 del; 14 mod >> Patch: https://git.openjdk.java.net/jfx/pull/59.diff >> Fetch: git fetch https://git.openjdk.java.net/jfx pull/59/head:pull/59 > > hmm ... somehow my rebase went wrong, sry. Don't know what exactly, though: > Jose's changes are already integrated, so why do they appear here again? > *g Yeah, something odd with the way you did the rebase, I guess. The commit hashes are different between the commit for Jose's fix in your branch, and the one in the upstream jfx master. When you get a moment, you will need to fix it. Since the review hasn't started yet, the easiest is to rebase your local branch on top of the upstream/master and then do a force push. PR: https://git.openjdk.java.net/jfx/pull/59
Re: [Approved] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute
On Wed, 4 Dec 2019 14:07:27 GMT, Arun Joseph wrote:
> The pull request has been updated with additional changes.
>
>
>
> Added commits:
> - 7f6ed5bf: Added test for createAttribute
>
> Changes:
> - all: https://git.openjdk.java.net/jfx/pull/47/files
> - new: https://git.openjdk.java.net/jfx/pull/47/files/2bd56c11..7f6ed5bf
>
> Webrevs:
> - full: https://webrevs.openjdk.java.net/jfx/47/webrev.02
> - incr: https://webrevs.openjdk.java.net/jfx/47/webrev.01-02
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8233747
> Stats: 20 lines in 1 file changed: 20 ins; 0 del; 0 mod
> Patch: https://git.openjdk.java.net/jfx/pull/47.diff
> Fetch: git fetch https://git.openjdk.java.net/jfx pull/47/head:pull/47
I can confirm that this fixes the problem. The test case attached to the bug
and the new unit test you added fail (crash) without your fix and throw the
expected exception with your fix.
I don't quite understand your earlier comment about needing to change the
caller when the type is `ExceptionOr>`. The specific case in question is
one where object passed to `raiseDOMError` is of type `ExceptionOr>`,
and your change works fine. What am I missing?
I added a comment about formatting (missing spaces around a `+` operator) in
the test, but you can fix that before you integrate.
This will need a second reviewer, so I request @guruhb to review.
modules/javafx.web/src/test/java/test/javafx/scene/web/DOMTest.java line 431:
> 430: } catch (Throwable ex) {
> 431: fail("DOMException expected but instead threw
> "+ex.getClass().getName());
> 432: }
Minor: there should be spaces surrounding the `+` here.
Approved by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/47
Re: [Integrated] RFR: 8210955: DOMTest::testEventListenerCascade fails
Changeset: 1c27fbd2 Author:Arun Joseph Committer: Kevin Rushforth Date: 2019-12-04 16:36:40 + URL: https://git.openjdk.java.net/jfx/commit/1c27fbd2 8210955: DOMTest::testEventListenerCascade fails Reviewed-by: kcr ! modules/javafx.web/src/test/java/test/javafx/scene/web/DOMTest.java
Re: [Approved] RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
On Wed, 4 Dec 2019 14:50:19 GMT, Robert Lichtenberger wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 7c5cf198: 8232524: Test cleanup: terminate background thread upon failure. > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/17/files > - new: https://git.openjdk.java.net/jfx/pull/17/files/7e80839f..7c5cf198 > > Webrevs: > - full: https://webrevs.openjdk.java.net/jfx/17/webrev.01 > - incr: https://webrevs.openjdk.java.net/jfx/17/webrev.00-01 > > Issue: https://bugs.openjdk.java.net/browse/JDK-8232524 > Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/jfx/pull/17.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/17/head:pull/17 Looks good to me. Approved by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/17
Re: [Approved] RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
On Wed, 4 Dec 2019 14:50:19 GMT, Robert Lichtenberger wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 7c5cf198: 8232524: Test cleanup: terminate background thread upon failure. > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/17/files > - new: https://git.openjdk.java.net/jfx/pull/17/files/7e80839f..7c5cf198 > > Webrevs: > - full: https://webrevs.openjdk.java.net/jfx/17/webrev.01 > - incr: https://webrevs.openjdk.java.net/jfx/17/webrev.00-01 > > Issue: https://bugs.openjdk.java.net/browse/JDK-8232524 > Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/jfx/pull/17.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/17/head:pull/17 Approved by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/17
Re: RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property
On Wed, 4 Dec 2019 15:49:47 GMT, Jeanette Winzenburg wrote: > fix for https://bugs.openjdk.java.net/browse/JDK-8220722 > > - replaces the manually registered listener with registerChangeListener(...) > - added test that's failing before and passing after the fix (plus a sanity > test that the skin still is listening to changes) > > > > Commits: > - 9f4fc409: 8220722: ProgressBarSkin: adds strong listener to control's width > - 61f7361d: 8235151: Nonexistent notifyQuit method referred from iOS > GlassHelper.m > > Changes: https://git.openjdk.java.net/jfx/pull/59/files > Webrev: https://webrevs.openjdk.java.net/jfx/59/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8220722 > Stats: 102 lines in 5 files changed: 88 ins; 0 del; 14 mod > Patch: https://git.openjdk.java.net/jfx/pull/59.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/59/head:pull/59 hmm ... somehow my rebase went wrong, sry. Don't know what exactly, though: Jose's changes are already integrated, so why do they appear here again? *g PR: https://git.openjdk.java.net/jfx/pull/59
RFR: 8220722: ProgressBarSkin: adds strong listener to control's width property
fix for https://bugs.openjdk.java.net/browse/JDK-8220722 - replaces the manually registered listener with registerChangeListener(...) - added test that's failing before and passing after the fix (plus a sanity test that the skin still is listening to changes) Commits: - 9f4fc409: 8220722: ProgressBarSkin: adds strong listener to control's width - 61f7361d: 8235151: Nonexistent notifyQuit method referred from iOS GlassHelper.m Changes: https://git.openjdk.java.net/jfx/pull/59/files Webrev: https://webrevs.openjdk.java.net/jfx/59/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8220722 Stats: 102 lines in 5 files changed: 88 ins; 0 del; 14 mod Patch: https://git.openjdk.java.net/jfx/pull/59.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/59/head:pull/59 PR: https://git.openjdk.java.net/jfx/pull/59
Re: [Approved] RFR: 8210955: DOMTest::testEventListenerCascade fails
On Tue, 19 Nov 2019 07:11:40 GMT, Arun Joseph wrote: > Modified the test to work with WebView's ordering of capturing and bubbling > event listeners. > > > > Commits: > - cbef0069: DOMTest::testEventListenerCascade fails > > Changes: https://git.openjdk.java.net/jfx/pull/46/files > Webrev: https://webrevs.openjdk.java.net/jfx/46/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8210955 > Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod > Patch: https://git.openjdk.java.net/jfx/pull/46.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/46/head:pull/46 Approved by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/46
Re: RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
On Wed, 4 Dec 2019 14:50:21 GMT, Robert Lichtenberger
wrote:
> On Tue, 3 Dec 2019 05:08:49 GMT, Ambarish Rapte wrote:
>
>> On Mon, 21 Oct 2019 10:19:04 GMT, Robert Lichtenberger
>> wrote:
>>
>>> By using the collection itself as synchronization lock we achieve behaviour
>>> that matches java.util.Collections classes.
>>>
>>> I've create test cases that fail with the current way of synchronizing on a
>>> separate object.
>>>
>>> I've removed unused constructors.
>>>
>>>
>>>
>>> Commits:
>>> - 7e80839f: 8232524: SynchronizedObservableMap cannot be be protected for
>>> copying/iterating
>>> - 8ecf3545: JDK-8232524 fixed.
>>>
>>> Changes: https://git.openjdk.java.net/jfx/pull/17/files
>>> Webrev: https://webrevs.openjdk.java.net/jfx/17/webrev.00
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8232524
>>> Stats: 120 lines in 2 files changed: 95 ins; 17 del; 8 mod
>>> Patch: https://git.openjdk.java.net/jfx/pull/17.diff
>>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/17/head:pull/17
>>
>> The change looks good to me, added a comment for a small change in test.
>>
>> modules/javafx.base/src/test/java/test/javafx/collections/FXCollectionsTest.java
>> line 730:
>>
>>> 729: } catch (ConcurrentModificationException e) {
>>> 730: fail("ConcurrentModificationException should not be
>>> thrown");
>>> 731: }
>>
>> The thread should be terminated here too, please add `thread.terminate();`
>> before `fail()`
>>
>>
>>
>> Changes requested by arapte (Reviewer).
>
> You're right. I just pushed the fix.
Note that this is still pending a second review from @arapte
PR: https://git.openjdk.java.net/jfx/pull/17
Re: [Approved] RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
On Wed, 4 Dec 2019 14:50:19 GMT, Robert Lichtenberger wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 7c5cf198: 8232524: Test cleanup: terminate background thread upon failure. > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/17/files > - new: https://git.openjdk.java.net/jfx/pull/17/files/7e80839f..7c5cf198 > > Webrevs: > - full: https://webrevs.openjdk.java.net/jfx/17/webrev.01 > - incr: https://webrevs.openjdk.java.net/jfx/17/webrev.00-01 > > Issue: https://bugs.openjdk.java.net/browse/JDK-8232524 > Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/jfx/pull/17.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/17/head:pull/17 Looks good. I can confirm that the new tests fail without the fix and pass with the fix. Approved by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/17
Re: [Rev 01] RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
The pull request has been updated with additional changes. Added commits: - 7c5cf198: 8232524: Test cleanup: terminate background thread upon failure. Changes: - all: https://git.openjdk.java.net/jfx/pull/17/files - new: https://git.openjdk.java.net/jfx/pull/17/files/7e80839f..7c5cf198 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/17/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/17/webrev.00-01 Issue: https://bugs.openjdk.java.net/browse/JDK-8232524 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/17.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/17/head:pull/17 PR: https://git.openjdk.java.net/jfx/pull/17
Re: RFR: 8232524: SynchronizedObservableMap cannot be be protected for copying/iterating
On Tue, 3 Dec 2019 05:08:49 GMT, Ambarish Rapte wrote:
> On Mon, 21 Oct 2019 10:19:04 GMT, Robert Lichtenberger
> wrote:
>
>> By using the collection itself as synchronization lock we achieve behaviour
>> that matches java.util.Collections classes.
>>
>> I've create test cases that fail with the current way of synchronizing on a
>> separate object.
>>
>> I've removed unused constructors.
>>
>>
>>
>> Commits:
>> - 7e80839f: 8232524: SynchronizedObservableMap cannot be be protected for
>> copying/iterating
>> - 8ecf3545: JDK-8232524 fixed.
>>
>> Changes: https://git.openjdk.java.net/jfx/pull/17/files
>> Webrev: https://webrevs.openjdk.java.net/jfx/17/webrev.00
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8232524
>> Stats: 120 lines in 2 files changed: 95 ins; 17 del; 8 mod
>> Patch: https://git.openjdk.java.net/jfx/pull/17.diff
>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/17/head:pull/17
>
> The change looks good to me, added a comment for a small change in test.
>
> modules/javafx.base/src/test/java/test/javafx/collections/FXCollectionsTest.java
> line 730:
>
>> 729: } catch (ConcurrentModificationException e) {
>> 730: fail("ConcurrentModificationException should not be
>> thrown");
>> 731: }
>
> The thread should be terminated here too, please add `thread.terminate();`
> before `fail()`
>
>
>
> Changes requested by arapte (Reviewer).
You're right. I just pushed the fix.
PR: https://git.openjdk.java.net/jfx/pull/17
Re: [Rev 02] RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute
The pull request has been updated with additional changes. Added commits: - 7f6ed5bf: Added test for createAttribute Changes: - all: https://git.openjdk.java.net/jfx/pull/47/files - new: https://git.openjdk.java.net/jfx/pull/47/files/2bd56c11..7f6ed5bf Webrevs: - full: https://webrevs.openjdk.java.net/jfx/47/webrev.02 - incr: https://webrevs.openjdk.java.net/jfx/47/webrev.01-02 Issue: https://bugs.openjdk.java.net/browse/JDK-8233747 Stats: 20 lines in 1 file changed: 20 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/47.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/47/head:pull/47 PR: https://git.openjdk.java.net/jfx/pull/47
Re: [Approved] RFR: 8235150: IosApplication does not pass the required object in _leaveNestedEventLoopImpl
On Sat, 30 Nov 2019 18:23:07 GMT, Jose Pereda wrote: > In `GlassApplication.m` for iOS, the method > `Java_com_sun_glass_ui_ios_IosApplication__1leaveNestedEventLoopImpl` has > signature `(Ljava/lang/Object;)V`, however in `IosApplication.java`, > `_leaveNestedEventLoopImpl()` signature doesn't match that. > > This PR fixes this. > > > > Commits: > - e5fc04a9: Use correct signature in _leaveNestedEventLoopImpl > > Changes: https://git.openjdk.java.net/jfx/pull/57/files > Webrev: https://webrevs.openjdk.java.net/jfx/57/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8235150 > Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/jfx/pull/57.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/57/head:pull/57 Approved by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/57
Re: [Integrated] RFR: 8235151: Inexistent notifyQuit method referred from iOS GlassHelper.m
Changeset: 2d4096a8 Author:Jose Pereda Committer: Johan Vos Date: 2019-12-04 12:17:44 + URL: https://git.openjdk.java.net/jfx/commit/2d4096a8 8235151: Nonexistent notifyQuit method referred from iOS GlassHelper.m Reviewed-by: jvos ! modules/javafx.graphics/src/main/native-glass/ios/GlassApplication.m ! modules/javafx.graphics/src/main/native-glass/ios/GlassHelper.h ! modules/javafx.graphics/src/main/native-glass/ios/GlassHelper.m
