Re: [Rev 18] RFR: 8236651: Simplify and update glass gtk backend

[Thiago Milczarek Sayao]

> This proposed change does the following:
> 
> - Ports DND target to use GTK reducing code size and adding extra text / 
> image formats (such as .gif);
> - Use gtk signals instead of gdk events (also to reduce code size);
> - Simplifies geometry (sizing/positioning) with a more straightforward code 
> (less special cases), making it easier to understand and maintain;
> - Replaces (pointer and focus) grabbing with a gtk approach;
> - Reworked frame extents (the wm extension to get decoration sizes) to reduce 
> size and complexity;
> - Simplified cursor changing (for gtk3);
> - Reduced the use of gtk/gdk deprecated functions;
> - Removes Applet/Web Start code;
> - Fixes https://bugs.openjdk.java.net/browse/JDK-8237491;
> 
> In general it reduces code size and complexity and hands more work to gtk.
> 
> Updated on 2020-01-29:
> ![image](https://user-images.githubusercontent.com/30704286/73354728-2ce47d00-4275-11ea-935c-414fc26163d7.png)

The pull request has been updated with a new target base due to a merge or a 
rebase.

-

Commits:
 - 14a75ce4: Merge branch 'master' into jdk_8236651
 - e829b8e9: Better fix for initial size
 - 058a0992: Revert "Fix Initial Size"
 - 0c982d60: Fix Initial Size
 - 694641f6: JDK-8236651 Simplify and update glass gtk backend
 - 9397a748: Merge pull request #4 from openjdk/master

Changes: https://git.openjdk.java.net/jfx/pull/77/files
 Webrev: https://webrevs.openjdk.java.net/jfx/77/webrev.18
  Stats: 3360 lines in 12 files changed: 782 ins; 1797 del; 781 mod
  Patch: https://git.openjdk.java.net/jfx/pull/77.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77

PR: https://git.openjdk.java.net/jfx/pull/77

Re: RFR: 8236651: Simplify and update glass gtk backend

[Thiago Milczarek Sayao]

On Wed, 29 Jan 2020 12:16:49 GMT, Thiago Milczarek Sayao  
wrote:

>> To anyone willing to test this, here is a binary test-release for linux:
>> 
>> https://github.com/tsayao/jfx/releases/tag/test-glass-gtk
> 
> It's ready for an initial look.
> 
> If anyone has issues with Linux, I will fix it.

**Code Changes**

* glass_window.cpp / glass_window.h
* Removed WindowContextPlug and WindowContextChild (that were used for 
applets / web start) and moved everything to
one class named WindowContext (since inheritance was no required anymore)
* Changed set_enabled() to use gtk_widget_set_sensitive instead of custom 
code;
* Moved to gtk signals instead of gdk events (to use 
gtk_widget_set_sensitive and gtk_grab_add);
* Frame Extents: Removed the code to request extents and gtk already does 
it by default;
* Focus Grab: Use gtk_grab_add and gtk window group functions instead of 
custom code;
* Size calculation: Reworked size calculation code. In general, X windows 
are content size instead
of whole window size (considering extents - frame decorations). OpenJfx 
uses "whole window size" as
window sizes, so it requires a "hack" to recalculate sizes when 
set_bounds() is called with window
sizes instead of content sizes. The rework was to simplify code paths and 
make it more straightforward.
* Other Size calculation changes:
* Use gtk_window_set_default_size() for initial size which is the 
appropriate function; 
* Gravity is now ignored as it is on Windows glass impl;
* Avoid sending same sizes to Java;
* Introduced calculate_adjustments() which is a fallback when frame 
extents is not present (it's optional
to window managers to implement it);
* Geometry: Min / Max sizes - reworked it to simplify / Concentrated 
geometry changes on
  apply_geometry().
* Mouse grab: Reworked it to use to correct functions according to gtk+ 
version;
* Draw: Reworked it to use the correct calls accord to gtk+ version changes;
* Fixed JDK-8237491;
* Moved background code to paint() as gtk3 uses styles to set the 
background and other functions were deprecated;
* Reorganized function order on glass_window.cpp to match glass_window.h


* GlassCursor.cpp
* Gtk+3 uses a name-like-css approach - so it was properly ported to gtk3 
way;
* Reworked Gtk+2 to use a function instead of manual calls to find the 
cursor;

* GtkWindow.java
* Moved the extents special case to native glass;

* GlassApplication.cpp
* Removed Gdk events where possible (it's now on glass_window as signals);
* Removed applet/web start code;

* GlassView.cpp
* Changes to reflect frame extents rework on glass_window

* GlassWindow.cpp
* WindowContextTop -> WindowContext
* Removed applet / web start code;
* Removed frame extents (which is not called anymore due to GtkWindow.java 
change);

* glass_general.cpp
* Removed functions that became unused;
* Added is_grab_disabled() that is used on glass_window

* glass_window_ime.cpp
* WindowContextTop -> WindowContext;

* glass_dnd.cpp / glass_dnd.h
* Ported to Gtk signals;
* Use all possible image formats (supported by GdkPixbuf / OpenJfx) - .gif 
is now possible (for ex.);
* Allow COMPOUND_TEXT;
* Do not request content while dragging;
* Reduce overall code size.

-

PR: https://git.openjdk.java.net/jfx/pull/77

Re: [Integrated] RFR: 8231513: JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina)

[Kevin Rushforth]

Changeset: 2ab40c1c
Author:Kevin Rushforth 
Date:  2020-02-01 14:35:47 +
URL:   https://git.openjdk.java.net/jfx/commit/2ab40c1c

8231513: JavaFX cause Keystroke Receiving prompt on MacOS 10.15 (Catalina)

Reviewed-by: prr, jvos

! modules/javafx.graphics/src/main/native-glass/mac/GlassTouches.m

Re: [Integrated] RFR: 8237975: Non-embedded Animations do not play backwards after being paused

[Nir Lisker]

Changeset: 1749e854
Author:Nir Lisker 
Date:  2020-02-03 12:29:43 +
URL:   https://git.openjdk.java.net/jfx/commit/1749e854

8237975: Non-embedded Animations do not play backwards after being paused

Reviewed-by: kcr, arapte

! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/ClipEnvelope.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/FiniteClipEnvelope.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/InfiniteClipEnvelope.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/SingleLoopClipEnvelope.java
! 
modules/javafx.graphics/src/shims/java/com/sun/scenario/animation/shared/SingleLoopClipEnvelopeShim.java
! modules/javafx.graphics/src/shims/java/javafx/animation/AnimationShim.java
! 
modules/javafx.graphics/src/test/java/test/javafx/animation/AnimationSetRateTest.java

Re: [Integrated] RFR: 8237503: Update copyright header for files modified in 2020

[Kevin Rushforth]

Changeset: a4b9f24e
Author:Kevin Rushforth 
Date:  2020-02-03 15:48:52 +
URL:   https://git.openjdk.java.net/jfx/commit/a4b9f24e

8237503: Update copyright header for files modified in 2020

Reviewed-by: arapte

! buildSrc/android.gradle
! 
modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java
! 
modules/javafx.controls/src/test/java/test/javafx/scene/control/TabPaneTest.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/android/DalvikInput.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/AndroidInputDeviceRegistry.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/AndroidPlatform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/DispmanPlatform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/HeadlessPlatform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/LinuxPlatform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MX6Platform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleApplication.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/NativePlatform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/OMAPPlatform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/X11Platform.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/ClipEnvelope.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/FiniteClipEnvelope.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/InfiniteClipEnvelope.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/SingleLoopClipEnvelope.java
! modules/javafx.graphics/src/main/java/javafx/animation/Animation.java
! modules/javafx.graphics/src/main/java/javafx/scene/Scene.java
! modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java
! modules/javafx.graphics/src/main/native-glass/gtk/GlassApplication.cpp
! modules/javafx.graphics/src/main/native-glass/gtk/glass_dnd.cpp
! modules/javafx.graphics/src/main/native-glass/gtk/glass_dnd.h
! modules/javafx.graphics/src/main/native-glass/gtk/glass_general.cpp
! modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp
! modules/javafx.graphics/src/main/native-glass/monocle/EGL.c
! modules/javafx.graphics/src/main/native-glass/monocle/android/AndroidScreen.c
! modules/javafx.graphics/src/main/native-glass/monocle/android/dalvikUtils.c
! modules/javafx.graphics/src/main/native-glass/monocle/android/nativeBridge.c
! modules/javafx.graphics/src/main/native-glass/monocle/dispman/DispmanScreen.c
! modules/javafx.graphics/src/main/native-iio/jpegloader.c
! modules/javafx.graphics/src/main/native-prism-es2/monocle/MonocleGLFactory.c
! modules/javafx.graphics/src/main/native-prism-es2/monocle/eglUtils.c
! 
modules/javafx.graphics/src/shims/java/com/sun/scenario/animation/shared/SingleLoopClipEnvelopeShim.java
! modules/javafx.graphics/src/shims/java/javafx/animation/AnimationShim.java
! 
modules/javafx.graphics/src/test/java/test/javafx/animation/AnimationSetRateTest.java
! modules/javafx.graphics/src/test/java/test/javafx/animation/AnimationTest.java
! 
modules/javafx.graphics/src/test/java/test/javafx/animation/SequentialTransitionPlayTest.java
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.cpp
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.h
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.h
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.mm
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.cpp
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.h
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFSoundLevelUnit.cpp
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFSoundLevelUnit.h
! modules/javafx.web/src/main/java/javafx/scene/web/WebView.java
! modules/javafx.web/src/main/native/Source/WebCore/bindings/java/JavaDOMUtils.h
! modules/javafx.web/src/test/java/test/javafx/scene/web/DOMTest.java
! modules/javafx.web/src/test/java/test/javafx/scene/web/WebViewTest.java
! tests/system/src/test/java/test/javafx/scene/Snapshot2Test.java
! 
tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java

Re: RFR: 8208761: Update constant collections to use the new immutable collections

[Kevin Rushforth]

On Sun, 2 Feb 2020 00:15:02 GMT, Nir Lisker  wrote:

> Resubmitting from before the transition to this repo. See linked issue for 
> details.

Given the large number of changes, I'd like two reviewers to look it over for 
any possible typos.

-

PR: https://git.openjdk.java.net/jfx/pull/104

Re: [Integrated] RFR: 8237503: Update copyright header for files modified in 2020

[Kevin Rushforth]

Changeset: a4b9f24e
Author:Kevin Rushforth 
Date:  2020-02-03 15:48:52 +
URL:   https://git.openjdk.java.net/jfx/commit/a4b9f24e

8237503: Update copyright header for files modified in 2020

Reviewed-by: arapte

! buildSrc/android.gradle
! 
modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java
! 
modules/javafx.controls/src/test/java/test/javafx/scene/control/TabPaneTest.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/android/DalvikInput.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/AndroidInputDeviceRegistry.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/AndroidPlatform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/DispmanPlatform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/HeadlessPlatform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/LinuxPlatform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MX6Platform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleApplication.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/NativePlatform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/OMAPPlatform.java
! 
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/X11Platform.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/ClipEnvelope.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/FiniteClipEnvelope.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/InfiniteClipEnvelope.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/SingleLoopClipEnvelope.java
! modules/javafx.graphics/src/main/java/javafx/animation/Animation.java
! modules/javafx.graphics/src/main/java/javafx/scene/Scene.java
! modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java
! modules/javafx.graphics/src/main/native-glass/gtk/GlassApplication.cpp
! modules/javafx.graphics/src/main/native-glass/gtk/glass_dnd.cpp
! modules/javafx.graphics/src/main/native-glass/gtk/glass_dnd.h
! modules/javafx.graphics/src/main/native-glass/gtk/glass_general.cpp
! modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp
! modules/javafx.graphics/src/main/native-glass/monocle/EGL.c
! modules/javafx.graphics/src/main/native-glass/monocle/android/AndroidScreen.c
! modules/javafx.graphics/src/main/native-glass/monocle/android/dalvikUtils.c
! modules/javafx.graphics/src/main/native-glass/monocle/android/nativeBridge.c
! modules/javafx.graphics/src/main/native-glass/monocle/dispman/DispmanScreen.c
! modules/javafx.graphics/src/main/native-iio/jpegloader.c
! modules/javafx.graphics/src/main/native-prism-es2/monocle/MonocleGLFactory.c
! modules/javafx.graphics/src/main/native-prism-es2/monocle/eglUtils.c
! 
modules/javafx.graphics/src/shims/java/com/sun/scenario/animation/shared/SingleLoopClipEnvelopeShim.java
! modules/javafx.graphics/src/shims/java/javafx/animation/AnimationShim.java
! 
modules/javafx.graphics/src/test/java/test/javafx/animation/AnimationSetRateTest.java
! modules/javafx.graphics/src/test/java/test/javafx/animation/AnimationTest.java
! 
modules/javafx.graphics/src/test/java/test/javafx/animation/SequentialTransitionPlayTest.java
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.cpp
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.h
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.h
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.mm
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.cpp
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.h
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFSoundLevelUnit.cpp
! 
modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFSoundLevelUnit.h
! modules/javafx.web/src/main/java/javafx/scene/web/WebView.java
! modules/javafx.web/src/main/native/Source/WebCore/bindings/java/JavaDOMUtils.h
! modules/javafx.web/src/test/java/test/javafx/scene/web/DOMTest.java
! modules/javafx.web/src/test/java/test/javafx/scene/web/WebViewTest.java
! tests/system/src/test/java/test/javafx/scene/Snapshot2Test.java
! 
tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java

Re: RFR: 8237503: Update copyright header for files modified in 2020

[Ambarish Rapte]

On Fri, 31 Jan 2020 23:32:55 GMT, Kevin Rushforth  wrote:

> Fix for [JDK-8237503](https://bugs.openjdk.java.net/browse/JDK-8237503) to 
> update the "last modified" year in the copyright header for all files 
> modified in 2020 in the `jfx14` branch.
> 
> NOTE: I'll update this to pick up any last-minute changes integrated to 
> `jfx14` and then remove the WIP.

Looks good to me.

-

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/103

Re: Question ad creating a testcase that needs a jar on class- or module path

[Rony G. Flatscher]

Hi Kevin,

On 31.01.2020 16:38, Kevin Rushforth wrote:
> And if you need a modular jar, you might look at ModuleLauncherTest instead.

thank you very much for this important hint as well!

Having no knowledge about gradle it will take me a while to research and 
digest, but this definitely
helps me to jump start to the section where tests get carried out with 
separately configured JVMs.

Would it be o.k. to first submit a pull request for JDK-8234959
 and later, when an 
appropriate test unit using
the SPI dependent pseudo script engine is available submitting the test app 
with different pull
request? Or would it be better to submit both with the same pull request?

---rony

Re: "Internal review ID : 9062887" (Re: FXMLLoader: not supplying filename to script engine, not supplying event object as argument to script

[Rony G. Flatscher]

Hi Kevin,

On 29.01.2020 13:24, Kevin Rushforth wrote:
> The RFE you filed is now available here:
>
> https://bugs.openjdk.java.net/browse/JDK-8238080

thank you very much!

Cheers

---rony

P.S.: Have not received any automatic notification e-mail so far.

Re: RFR: 8237503: Update copyright header for files modified in 2020

[Kevin Rushforth]

On Fri, 31 Jan 2020 23:32:55 GMT, Kevin Rushforth  wrote:

> Fix for [JDK-8237503](https://bugs.openjdk.java.net/browse/JDK-8237503) to 
> update the "last modified" year in the copyright header for all files 
> modified in 2020 in the `jfx14` branch.
> 
> NOTE: I'll update this to pick up any last-minute changes integrated to 
> `jfx14` and then remove the WIP.

@arapte you can take an initial look whenever you are ready. I expect only a 
few new files to come in, which I will push as an additional commit.

-

PR: https://git.openjdk.java.net/jfx/pull/103

Re: RFR: 8237503: Update copyright header for files modified in 2020

[Ambarish Rapte]

On Fri, 31 Jan 2020 23:34:02 GMT, Kevin Rushforth  wrote:

>> Fix for [JDK-8237503](https://bugs.openjdk.java.net/browse/JDK-8237503) to 
>> update the "last modified" year in the copyright header for all files 
>> modified in 2020 in the `jfx14` branch.
>> 
>> NOTE: I'll update this to pick up any last-minute changes integrated to 
>> `jfx14` and then remove the WIP.
> 
> @arapte you can take an initial look whenever you are ready. I expect only a 
> few new files to come in, which I will push as an additional commit.

Hi @kevinrushforth , The file list look good.

-

PR: https://git.openjdk.java.net/jfx/pull/103

RFR: 8237503: Update copyright header for files modified in 2020

[Kevin Rushforth]

Fix for [JDK-8237503](https://bugs.openjdk.java.net/browse/JDK-8237503) to 
update the "last modified" year in the copyright header for all files modified 
in 2020 in the `jfx14` branch.

NOTE: I'll update this to pick up any last-minute changes integrated to `jfx14` 
and then remove the WIP.

-

Commits:
 - f6dfbd83: Pickup additional files from recent commits
 - b9e40bbc: Merge remote-tracking branch 'upstream/jfx14' into 
8237503-copyr-2020
 - 15ca17c2: 8237503: Update copyright header for files modified in 2020

Changes: https://git.openjdk.java.net/jfx/pull/103/files
 Webrev: https://webrevs.openjdk.java.net/jfx/103/webrev.00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8237503
  Stats: 53 lines in 53 files changed: 0 ins; 0 del; 53 mod
  Patch: https://git.openjdk.java.net/jfx/pull/103.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/103/head:pull/103

PR: https://git.openjdk.java.net/jfx/pull/103

Re: [Integrated] RFR: 8237975: Non-embedded Animations do not play backwards after being paused

[Nir Lisker]

Changeset: 1749e854
Author:Nir Lisker 
Date:  2020-02-03 12:29:43 +
URL:   https://git.openjdk.java.net/jfx/commit/1749e854

8237975: Non-embedded Animations do not play backwards after being paused

Reviewed-by: kcr, arapte

! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/ClipEnvelope.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/FiniteClipEnvelope.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/InfiniteClipEnvelope.java
! 
modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/SingleLoopClipEnvelope.java
! 
modules/javafx.graphics/src/shims/java/com/sun/scenario/animation/shared/SingleLoopClipEnvelopeShim.java
! modules/javafx.graphics/src/shims/java/javafx/animation/AnimationShim.java
! 
modules/javafx.graphics/src/test/java/test/javafx/animation/AnimationSetRateTest.java

Re: [Rev 01] RFR: 8237975: Non-embedded Animations do not play backwards after being paused

[Ambarish Rapte]

On Mon, 3 Feb 2020 10:16:13 GMT, Nir Lisker  wrote:

>> [8236858](https://bugs.openjdk.java.net/browse/JDK-8236858) (Animations do 
>> not play backwards after being paused) has been split to deal with 
>> [embedded](https://bugs.openjdk.java.net/browse/JDK-8237974) and [not 
>> embedded](https://bugs.openjdk.java.net/browse/JDK-8237975) animations. This 
>> is a fix for the latter.
>> The reason for the split is that embedded animations have a much more 
>> complex behavior. The current state of the relation between an animation and 
>> its clip envelope is already messy and should be corrected, even more so for 
>> embedded animations whose parent controls their behavior as well (sometimes 
>> in conflict with the child's clip envelope). This will require a redesign 
>> which can be discussed for 15. See the parent issue 
>> [8210238](https://bugs.openjdk.java.net/browse/JDK-8210238) for the list of 
>> bugs that arise from it.
>> 
>> This simple fix allows to change the current rate of a `ClipEnvelope` also 
>> when the animations is `PAUSED`. A possible issue with this approach is that 
>> it changes the buggy behavior of embedded animations to a different buggy 
>> behavior.
>> 
>> A concept test has been added, but it does not work yet since the mock clip 
>> envelope does not have sufficient behavior (`doTimePulse` does not actually 
>> do a time pulse). Open for ideas on how to make it simple, otherwise I will 
>> add a method to set a clip envelope and create a new one ad-hoc.
> 
> The pull request has been updated with 1 additional commit.

Looks good to me too.

-

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/98

Re: [Integrated] RFR: 8237944: webview native cl "-m32" unknown option for windows 32-bit build

[Guru Hb]

Changeset: aa91ebbb
Author:Guru Hb 
Date:  2020-02-03 08:51:25 +
URL:   https://git.openjdk.java.net/jfx/commit/aa91ebbb

8237944: webview native cl "-m32" unknown option for windows 32-bit build

Reviewed-by: kcr

! modules/javafx.web/src/main/native/Tools/Scripts/webkitdirs.pm