RFR: 8237504: Update copyright header for files modified in 2020
Update last modified year of copyright headers for files modified in 2020. - Commit messages: - 8237504: Update copyright header for files modified in 2020 Changes: https://git.openjdk.java.net/jfx/pull/203/files Webrev: https://webrevs.openjdk.java.net/jfx/203/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8237504 Stats: 144 lines in 144 files changed: 0 ins; 0 del; 144 mod Patch: https://git.openjdk.java.net/jfx/pull/203.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/203/head:pull/203 PR: https://git.openjdk.java.net/jfx/pull/203
Re: Gradle support for getting :web:test working properly
I went ahead and created the JBS bug that you will need for this: https://bugs.openjdk.java.net/browse/JDK-8244212 -- Kevin On 4/30/2020 11:59 AM, Jesper Skov wrote: I have created https://github.com/openjdk/jfx/pull/202 with a suggested implementation. Looking for feedback. Cheers, Jesper On Fri, Apr 24, 2020 at 5:13 PM Jesper Skov wrote: Thanks, I will give it a shot. Jesper On Thu, Apr 23, 2020 at 7:45 PM Kevin Rushforth < kevin.rushfo...@oracle.com> wrote: That's an interesting idea that might be worth pursuing. It would help mitigate what has been a long-standing pain point for developers who don't want to build media or web, but would like to run them. I would caution, though, that it is still not a substitute for building both media and WebKit yourself, since it will still not work reliably in the case where there is an interface change or some other mutually dependent change between the native media or web library and Java class files. In those cases you are stuck until a new EA build is available. If you do want to pursue this, then as long as the dependency on org.openjfx:javafx-web and org.openjfx:javafx-media is localized to the downloading and unpacking step you mentioned, this would be fine with me. Maybe others could help test it on Mac and Windows. As for the name of the new property, maybe STUB_RUNTIME_OPENJFX? The easiest way to implement this might be to set the value of `defaultStubRuntime` to the directory into which you unpack it (underneath either build or buildSrc/build). -- Kevin On 4/23/2020 1:14 AM, Jesper Skov wrote: Hi I struggled somewhat to get :web:test running with -PSTUB_RUNTIME. The JVM kept crashing by what turned out to be missing media libraries (the failure message was hidden). I tried building with -PCOMPILE_WEBKIT=true, but it takes a terrible long time on my laptop. And did not in itself fix the problem. Frustrations and lost time was the only real outcome of this :) So I would suggest adding logic to the build file to allow something like: gradlew -PSTUB_RUNTIME_USE=15-ea+4 all test This should download org.openjfx:javafx-web and org.openjfx:javafx-media artifacts in the specified version. Then unpack the shared libraries to a build folder, and make them availble via the STUB_RUNTIME logic. Plus an addition to the CONTRIBUTING.md documenting this. I would be happy to help make and/or test the changes, but am only able to work on Linux. Thanks, Jesper
Re: Gradle support for getting :web:test working properly
I have created https://github.com/openjdk/jfx/pull/202 with a suggested implementation. Looking for feedback. Cheers, Jesper On Fri, Apr 24, 2020 at 5:13 PM Jesper Skov wrote: > Thanks, I will give it a shot. > > Jesper > > > On Thu, Apr 23, 2020 at 7:45 PM Kevin Rushforth < > kevin.rushfo...@oracle.com> wrote: > >> That's an interesting idea that might be worth pursuing. It would help >> mitigate what has been a long-standing pain point for developers who >> don't want to build media or web, but would like to run them. I would >> caution, though, that it is still not a substitute for building both >> media and WebKit yourself, since it will still not work reliably in the >> case where there is an interface change or some other mutually dependent >> change between the native media or web library and Java class files. In >> those cases you are stuck until a new EA build is available. >> >> If you do want to pursue this, then as long as the dependency on >> org.openjfx:javafx-web and org.openjfx:javafx-media is localized to the >> downloading and unpacking step you mentioned, this would be fine with >> me. Maybe others could help test it on Mac and Windows. >> >> As for the name of the new property, maybe STUB_RUNTIME_OPENJFX? The >> easiest way to implement this might be to set the value of >> `defaultStubRuntime` to the directory into which you unpack it >> (underneath either build or buildSrc/build). >> >> -- Kevin >> >> >> On 4/23/2020 1:14 AM, Jesper Skov wrote: >> > Hi >> > >> > I struggled somewhat to get :web:test running with -PSTUB_RUNTIME. >> > >> > The JVM kept crashing by what turned out to be missing media >> > libraries (the failure message was hidden). >> > >> > I tried building with -PCOMPILE_WEBKIT=true, but it takes a terrible >> > long time on my laptop. And did not in itself fix the problem. >> > >> > Frustrations and lost time was the only real outcome of this :) >> > >> > >> > >> > >> > So I would suggest adding logic to the build file to allow something >> > like: >> > >> > gradlew -PSTUB_RUNTIME_USE=15-ea+4 all test >> > >> > This should download org.openjfx:javafx-web and >> > org.openjfx:javafx-media artifacts in the specified version. >> > >> > Then unpack the shared libraries to a build folder, and make them >> > availble via the STUB_RUNTIME logic. >> > >> > >> > Plus an addition to the CONTRIBUTING.md documenting this. >> > >> > >> > I would be happy to help make and/or test the changes, but am only >> > able to work on Linux. >> > >> > >> > Thanks, >> > Jesper >> >
Re: [Rev 51] RFR: 8236651: Simplify and update glass gtk backend
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove unused code (such as applets and web start); > * Prepare the ground for a possible future Wayland support. > ### Testing > ./gradlew -PEXTRA_TEST_ARGS='-Djavafx.gtk.experimental=true' -PFULL_TEST=true > -PUSE_ROBOT=true :systemTests:test Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision: - Fix build with merged linux.gradle - Merge branch 'master' into jdk_8236651 - Merge pull request #9 from openjdk/master Merge from upstream - Fix window position bug - Rename flag to javafx.gtk.experimental - Rename flag to javafx.gtk.experimental - Restore comment position - Restore deleted idea file - Smooth scrolling only possible with impl on java side - JDK-8236651 Simplify and update glass gtk backend Cleaning Cleaning + change year to 2020 Fix crash Fix crash Fix crash Revert idea files Fix flickering and sizing issues Pass more tests Small fixes Use gtk_window_set_default_size for before-map sizing which is the appropriate function Better alternative calculation for no _NET_FRAME_EXTENTS WM extension Fix dialog with owner sizing Maybe fix background Big cleanup Allow undecorated windows to be maximized. Mouse pointer grab Work on mouse grab 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute Reviewed-by: kcr, ghb 8234474: [macos 10.15] Crash in file dialog in sandbox mode Reviewed-by: arapte, prr 8236648: javadoc warning on Text::tabSizeProperty method Reviewed-by: kcr 8233798: Ctrl-L character mistakenly removed from gstreamer.md Reviewed-by: almatvee 8232589: Remove CoreAudio Utility Classes Reviewed-by: kcr, jvos 8236448: Remove unused and repair broken Android/Dalvik code Reviewed-by: kcr 8236808: javafx_iio can not be used in static environment Reviewed-by: kcr 8236733: Change JavaFX release version to 15 Reviewed-by: arapte 8232128: Better formatting for numbers Reviewed-by: rhalade, ghb 8232214: Improved internal validations Reviewed-by: ghb, rhalade 8237078: [macOS] Media build broken on XCode 11 Reviewed-by: kcr, almatvee JDK-8236651 Simplify and update glass gtk backend Cleaning Cleaning + change year to 2020 Fix crash Fix crash Fix crash Revert idea files Fix flickering and sizing issues Pass more tests Small fixes Use gtk_window_set_default_size for before-map sizing which is the appropriate function Better alternative calculation for no _NET_FRAME_EXTENTS WM extension Fix dialog with owner sizing Maybe fix background Big cleanup Allow undecorated windows to be maximized. Mouse pointer grab Work on mouse grab Fix Initial Size Revert "Fix Initial Size" This reverts commit 0c982d60 Better fix for initial size 8157224: isNPOTSupported check is too strict Reviewed-by: kcr 8233942: Update to 609.1 version of WebKit Co-authored-by: Guru HB Co-authored-by: Arun Joseph Co-authored-by: Kevin Rushforth Reviewed-by: kcr, jvos, ajoseph 8236753: Animations do not play backwards after being stopped Reviewed-by: kcr, arapte 8237823: Mark TextTest.testTabSize as unstable Reviewed-by: prr 8236912: NullPointerException when clicking in WebView with Button 4 or Button 5 Reviewed-by: ghb, kcr 8232824: Removing TabPane with strong referenced content causes memory leak from weak one Reviewed-by: kcr, aghaisas 8237372: NullPointerException in TabPaneSkin.stopDrag Reviewed-by: arapte 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree Reviewed-by: kcr 8238249: GetPrimitiveArrayCritical passed with hardcoded FALSE value Reviewed-by: kcr 8088198: Exception thrown from snapshot if dimensions are larger than max texture size Reviewed-by: arapte, kcr 8237833: Check glyph size before adding to glyph texture cache Reviewed-by: kcr 8237782: Only read advances up to the minimum of the numHorMetrics or the available font data. Reviewed-by: kcr 8237770: Error creating fragment phong shader on iOS Reviewed-by: kcr 8237944: webview native cl
Re: [Rev 50] RFR: 8236651: Simplify and update glass gtk backend
> ### Summary > * Simplify and update the Gtk glass backend, making Linux a first-class > OpenJFX platform. > > ### Goals > * Make Linux a first-class OpenJFX platform (see Motivation); > * Simplify the code and reduce it's size; > * Update to gtk3 (it was originally a port from gtk2); > * Remove unused code (such as applets and web start); > * Prepare the ground for a possible future Wayland support. > ### Testing > ./gradlew -PEXTRA_TEST_ARGS='-Djavafx.gtk.experimental=true' -PFULL_TEST=true > -PUSE_ROBOT=true :systemTests:test Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Fix window position bug - Changes: - all: https://git.openjdk.java.net/jfx/pull/77/files - new: https://git.openjdk.java.net/jfx/pull/77/files/85defa52..3e3aa584 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/77/webrev.50 - incr: https://webrevs.openjdk.java.net/jfx/77/webrev.49-50 Stats: 15 lines in 1 file changed: 2 ins; 9 del; 4 mod Patch: https://git.openjdk.java.net/jfx/pull/77.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/77/head:pull/77 PR: https://git.openjdk.java.net/jfx/pull/77
Re: [Integrated] RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()
On Thu, 9 Apr 2020 09:58:27 GMT, Jesper Skov wrote: > Make the two ways of associating a ToggleButton with a ToggleGroup interact > correctly. > > This fixes https://bugs.openjdk.java.net/browse/JDK-8198402 This pull request has now been integrated. Changeset: 3130fc80 Author:Jesper Skov Committer: Kevin Rushforth URL: https://git.openjdk.java.net/jfx/commit/3130fc80 Stats: 114 lines in 2 files changed: 10 ins; 99 del; 5 mod 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles() Reviewed-by: kcr, arapte - PR: https://git.openjdk.java.net/jfx/pull/167
Re: [Integrated] RFR: 8191758: Match WebKit's font weight rendering with JavaFX
On Tue, 14 Apr 2020 10:25:52 GMT, Bhawesh Choudhary wrote: > As per JavaFx 700 font weight is considered to be bold but webkit is using > 600 font weight for text to become bold. to > fix issue, use boldWeightValue() function which uses 700 font weight rather > than isFontWeightBold() which compare > against 600 font weight. This pull request has now been integrated. Changeset: 8ad58052 Author:bhawesh Committer: Kevin Rushforth URL: https://git.openjdk.java.net/jfx/commit/8ad58052 Stats: 26 lines in 2 files changed: 0 ins; 25 del; 1 mod 8191758: Match WebKit's font weight rendering with JavaFX Reviewed-by: kcr, ajoseph - PR: https://git.openjdk.java.net/jfx/pull/180
Re: RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list
On Thu, 30 Apr 2020 12:55:02 GMT, Ambarish Rapte wrote: > > A ready test , That's very nice of you. Yes, We can move all the four tests > to unit test. But I would prefer to do > it as another TEST_BUG. Does that sound good ? not quite complete, just nearly - attached the unit test to the issue [JDK-8244195](https://bugs.openjdk.java.net/browse/JDK-8244195) you created > > > Btw, the pattern in the listener (of collecting up additions/removals) is a > > bit smelly > > I did try to change whole implementation, but it looked like a big change for > the issue we have. The fix is very > minimal and local. good with me, as long as it covers all possible modifications to the tabs list have a nice weekend (holiday here in Berlin tomorrow, so I might be off, except that with corona there's not so much too do, except working :) - PR: https://git.openjdk.java.net/jfx/pull/201
Re: RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list
On Thu, 30 Apr 2020 11:22:33 GMT, Jeanette Winzenburg wrote: > Would you consider moving both into a unit test? Have one locally, could send > it to you .. A ready test , That's very nice of you. Yes, We can move all the four tests to unit test. But I would prefer to do it as another TEST_BUG. Does that sound good ? > Btw, the pattern in the listener (of collecting up additions/removals) is a > bit smelly I did try to change whole implementation, but it looked like a big change for the issue we have. The fix is very minimal and local. > it should not name it "permutation" Shall think of a new name when we move the tests.. - PR: https://git.openjdk.java.net/jfx/pull/201
Re: RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list
On Thu, 30 Apr 2020 07:08:24 GMT, Ambarish Rapte wrote: > The system test file `TabPanePermuteGetTabsTest` was added to address exact > similar kind of issue > [JDK-8222457](https://bugs.openjdk.java.net/browse/JDK-8222457). The current > issue > [JDK-8237602](https://bugs.openjdk.java.net/browse/JDK-8237602) is just > another case of same type. So it seems good to > add a new test with similar existing tests. I myself had fixed the previous > issue, Can't remember why did I not > consider of a unit test then 樂. yeah, if we don't document everything :))) Would you consider moving both into a unit test? Have one locally, could send it to you .. Also a minor quirk as to the naming: it should not name it "permutation" because it isn't from the perspective of the list change: the notification is a "replace". Btw, the pattern in the listener (of collecting up additions/removals) is a bit smelly - will fail as soon as you get disjoint additions (on the bright side: they don't happen in the current implementation of ObservableList but are allowed to), just something to keep in mind :) - PR: https://git.openjdk.java.net/jfx/pull/201
Re: RFR: 8237602: TabPane doesn't respect order of TabPane.getTabs() list
On Wed, 29 Apr 2020 14:42:32 GMT, Kevin Rushforth wrote: > > > The following is wrong in your Description: Thanks Kevin, the description is corrected now. - PR: https://git.openjdk.java.net/jfx/pull/201
