Re: [Integrated] RFR: 8240451: JavaFX javadoc build fails with JDK 14
Changeset: b2ac76a9 Author:Kevin Rushforth Date: 2020-03-05 20:58:03 + URL: https://git.openjdk.java.net/jfx/commit/b2ac76a9 8240451: JavaFX javadoc build fails with JDK 14 Reviewed-by: nlisker, jvos ! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanObjectProperty.java ! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanObjectPropertyBuilder.java ! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanObjectProperty.java ! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanObjectPropertyBuilder.java ! modules/javafx.base/src/main/java/javafx/beans/value/WritableObjectValue.java
Re: RFR: 8240451: JavaFX javadoc build fails with JDK 14
On Tue, 3 Mar 2020 16:12:23 GMT, Kevin Rushforth wrote: > The JDK 14 javadoc will emit a warning for an `@pram` tag of a generic > parameter if not surrounded by `<` and `>`. This will in turn fail the build, > since we treat warnings as errors. There are 5 classes in JavaFX with this > error. The fix is to replace `@param T` with `@param ` in those 5 places. > > > I have tested this fix using javadoc from both JDK 13 and JDK 14. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/133
Re: RFR: 8240451: JavaFX javadoc build fails with JDK 14
On Thu, 5 Mar 2020 17:17:57 GMT, Nir Lisker wrote: >> The JDK 14 javadoc will emit a warning for an `@pram` tag of a generic >> parameter if not surrounded by `<` and `>`. This will in turn fail the >> build, since we treat warnings as errors. There are 5 classes in JavaFX with >> this error. The fix is to replace `@param T` with `@param ` in those 5 >> places. >> >> >> I have tested this fix using javadoc from both JDK 13 and JDK 14. > > Using a rough regex search of `@param [A-Z]\s` I also found: > > `com.sun.glass.ui.Window#requestInput`: `@param M` > `com.sun.javafx.tk.TKStage#requestInput`: `@param M` > > Though those are internal. Thanks for the review. Yeah, I only looked at the public API classes. Can I get a "R"eviewer to look at this? Maybe @arapte or @aghaisas ? - PR: https://git.openjdk.java.net/jfx/pull/133
Re: RFR: 8240451: JavaFX javadoc build fails with JDK 14
On Tue, 3 Mar 2020 16:12:23 GMT, Kevin Rushforth wrote: > The JDK 14 javadoc will emit a warning for an `@pram` tag of a generic > parameter if not surrounded by `<` and `>`. This will in turn fail the build, > since we treat warnings as errors. There are 5 classes in JavaFX with this > error. The fix is to replace `@param T` with `@param ` in those 5 places. > > > I have tested this fix using javadoc from both JDK 13 and JDK 14. Using a rough regex search of `@param [A-Z]\s` I also found: `com.sun.glass.ui.Window#requestInput`: `@param M` `com.sun.javafx.tk.TKStage#requestInput`: `@param M` Though those are internal. - Marked as reviewed by nlisker (Committer). PR: https://git.openjdk.java.net/jfx/pull/133
RFR: 8240451: JavaFX javadoc build fails with JDK 14
The JDK 14 javadoc will emit a warning for an `@pram` tag of a generic parameter if not surrounded by `<` and `>`. This will in turn fail the build, since we treat warnings as errors. There are 5 classes in JavaFX with this error. The fix is to replace `@param T` with `@param ` in those 5 places. I have tested this fix using javadoc from both JDK 13 and JDK 14. - Commits: - f68f8e69: 8240451: JavaFX javadoc build fails with JDK 14 Changes: https://git.openjdk.java.net/jfx/pull/133/files Webrev: https://webrevs.openjdk.java.net/jfx/133/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8240451 Stats: 6 lines in 5 files changed: 0 ins; 1 del; 5 mod Patch: https://git.openjdk.java.net/jfx/pull/133.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/133/head:pull/133 PR: https://git.openjdk.java.net/jfx/pull/133
