Re: [jfx11u] RFR: 8262366: Update glib to version 2.66.7
On Wed, 5 May 2021 11:57:06 GMT, Kevin Rushforth wrote: > Backport glib / gstreamer update from jfx mainline to jfx11u. The backport > applied cleanly, and I ran a sanity test on Windows (I'll test on other two > platforms before integrating). works on linux and mac - Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx11u/pull/2
[jfx11u] RFR: 8262366: Update glib to version 2.66.7
Backport glib / gstreamer update from jfx mainline to jfx11u. The backport applied cleanly, and I ran a sanity test on Windows (I'll test on other two platforms before integrating). - Commit messages: - 8262366: Update glib to version 2.66.7 Changes: https://git.openjdk.java.net/jfx11u/pull/2/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=2=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262366 Stats: 39567 lines in 441 files changed: 23434 ins; 5427 del; 10706 mod Patch: https://git.openjdk.java.net/jfx11u/pull/2.diff Fetch: git fetch https://git.openjdk.java.net/jfx11u pull/2/head:pull/2 PR: https://git.openjdk.java.net/jfx11u/pull/2
Re: RFR: 8262366: Update glib to version 2.66.7 [v2]
On Thu, 1 Apr 2021 23:17:58 GMT, Alexander Matveev wrote: >> - GLib was updated to version 2.66.7 and GStreamer to version 1.18.3 >> - One bug was discovered in updated GStreamer which was causing deadlock or >> infinite loop during seek on macOS. See gstsystemclock.c for changes between >> ifdef GSTREAMER_LITE. Otherwise no changes. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > Updated .md files and added missing include files Looks good. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/447
Re: RFR: 8262366: Update glib to version 2.66.7 [v2]
On Thu, 1 Apr 2021 23:17:58 GMT, Alexander Matveev wrote: >> - GLib was updated to version 2.66.7 and GStreamer to version 1.18.3 >> - One bug was discovered in updated GStreamer which was causing deadlock or >> infinite loop during seek on macOS. See gstsystemclock.c for changes between >> ifdef GSTREAMER_LITE. Otherwise no changes. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > Updated .md files and added missing include files Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/447
Re: RFR: 8262366: Update glib to version 2.66.7
On Thu, 1 Apr 2021 23:47:15 GMT, Kevin Rushforth wrote: >> All my testing looks good on all three platforms. I'll take a look at the >> diffs next. >> >> One thing I did spot is that you need to update `gstreamer.md` and `glib.md` >> to bump the version numbers. > > It now builds for me on my old Linux box. And the changes to the /legal/ > files looks good. > > One more thing I just thought of: we should do a test build on macOS aarch64. > I have no reason to believe that there will be a problem, but worth > double-checking. It builds fine on macOS aarch64 and I did minor testing as well. No issues. - PR: https://git.openjdk.java.net/jfx/pull/447
Re: RFR: 8262366: Update glib to version 2.66.7
On Thu, 1 Apr 2021 12:19:40 GMT, Kevin Rushforth wrote: >> Alexander tried it on our CI build machine yesterday and it builds fine >> there, too. I should add that I was building on a very old Ubuntu 16.04 >> system. >> >>> Since this PR introduces memset in the audio-buffer.c file, I think it is >>> safest to include string.h in this file as well, as this removes the >>> dependency on that file to be included indirectly. >> >> I was thinking the same thing. There is one more file that should include >> ``: `qtdemux_tags.c` uses `strlen`and fails to compile on my >> system. With the change to include `string.h` in those two files, the build >> now passes on my system. > > All my testing looks good on all three platforms. I'll take a look at the > diffs next. > > One thing I did spot is that you need to update `gstreamer.md` and `glib.md` > to bump the version numbers. It now builds for me on my old Linux box. And the changes to the /legal/ files looks good. One more thing I just thought of: we should do a test build on macOS aarch64. I have no reason to believe that there will be a problem, but worth double-checking. - PR: https://git.openjdk.java.net/jfx/pull/447
Re: RFR: 8262366: Update glib to version 2.66.7 [v2]
> - GLib was updated to version 2.66.7 and GStreamer to version 1.18.3 > - One bug was discovered in updated GStreamer which was causing deadlock or > infinite loop during seek on macOS. See gstsystemclock.c for changes between > ifdef GSTREAMER_LITE. Otherwise no changes. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: Updated .md files and added missing include files - Changes: - all: https://git.openjdk.java.net/jfx/pull/447/files - new: https://git.openjdk.java.net/jfx/pull/447/files/341eb765..77640795 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=447=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=447=00-01 Stats: 14 lines in 4 files changed: 8 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jfx/pull/447.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/447/head:pull/447 PR: https://git.openjdk.java.net/jfx/pull/447
Re: RFR: 8262366: Update glib to version 2.66.7
On Thu, 1 Apr 2021 11:04:35 GMT, Kevin Rushforth wrote: >> It compiles for me (on gcc-9, 10.1 and 10.2) but I can imagine it doesn't >> compile on all configurations. `memset` is declared in `string.h` and that >> may or may not be included. >> Running gcc -H shows that on my system, `string.h` is included by >> `glib-2.0/glib/gtestutils.h` (which is included by `glib-2.0/glib.h`) but on >> other systems, that might not be the case. >> Since this PR introduces `memset` in the `audio-buffer.c` file, I think it >> is safest to include `string.h` in this file as well, as this removes the >> dependency on that file to be included indirectly. > > Alexander tried it on our CI build machine yesterday and it builds fine > there, too. I should add that I was building on a very old Ubuntu 16.04 > system. > >> Since this PR introduces memset in the audio-buffer.c file, I think it is >> safest to include string.h in this file as well, as this removes the >> dependency on that file to be included indirectly. > > I was thinking the same thing. There is one more file that should include > ``: `qtdemux_tags.c` uses `strlen`and fails to compile on my > system. With the change to include `string.h` in those two files, the build > now passes on my system. All my testing looks good on all three platforms. I'll take a look at the diffs next. One thing I did spot is that you need to update `gstreamer.md` and `glib.md` to bump the version numbers. - PR: https://git.openjdk.java.net/jfx/pull/447
Re: RFR: 8262366: Update glib to version 2.66.7
On Thu, 1 Apr 2021 08:07:56 GMT, Johan Vos wrote: >> I cannot reproduce build failure on Linux. > > It compiles for me (on gcc-9, 10.1 and 10.2) but I can imagine it doesn't > compile on all configurations. `memset` is declared in `string.h` and that > may or may not be included. > Running gcc -H shows that on my system, `string.h` is included by > `glib-2.0/glib/gtestutils.h` (which is included by `glib-2.0/glib.h`) but on > other systems, that might not be the case. > Since this PR introduces `memset` in the `audio-buffer.c` file, I think it is > safest to include `string.h` in this file as well, as this removes the > dependency on that file to be included indirectly. Alexander tried it on our CI build machine yesterday and it builds fine there, too. I should add that I was building on a very old Ubuntu 16.04 system. > Since this PR introduces memset in the audio-buffer.c file, I think it is > safest to include string.h in this file as well, as this removes the > dependency on that file to be included indirectly. I was thinking the same thing. There is one more file that should include ``: `qtdemux_tags.c` uses `strlen`and fails to compile on my system. With the change to include `string.h` in those two files, the build now passes on my system. - PR: https://git.openjdk.java.net/jfx/pull/447
Re: RFR: 8262366: Update glib to version 2.66.7
On Thu, 1 Apr 2021 01:36:01 GMT, Alexander Matveev wrote: >> I get a compilation error on Linux: >> >> ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c: >> In function 'gst_audio_buffer_map': >> ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c:158:7: >> error: implicit declaration of function 'memset' >> [-Werror=implicit-function-declaration] >> 158 | memset (buffer->map_infos, 0, >> | ^~ >> ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c:158:7: >> warning: incompatible implicit declaration of built-in function 'memset' >> ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c:26:1: >> note: include '' or provide a declaration of 'memset' >> ... >> cc1: some warnings being treated as errors >> Makefile:270: recipe for target >> 'modules/javafx.media/build/native/linux/Release/obj/gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.o' >> failed >> make: *** >> [modules/javafx.media/build/native/linux/Release/obj/gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.o] >> Error 1 >> >> This is with the gcc 10.2 compiler used for production builds. > > I cannot reproduce build failure on Linux. It compiles for me (on gcc-9, 10.1 and 10.2) but I can imagine it doesn't compile on all configurations. `memset` is declared in `string.h` and that may or may not be included. Running gcc -H shows that on my system, `string.h` is included by `glib-2.0/glib/gtestutils.h` (which is included by `glib-2.0/glib.h`) but on other systems, that might not be the case. Since this PR introduces `memset` in the `audio-buffer.c` file, I think it is safest to include `string.h` in this file as well, as this removes the dependency on that file to be included indirectly. - PR: https://git.openjdk.java.net/jfx/pull/447
Re: RFR: 8262366: Update glib to version 2.66.7
On Wed, 31 Mar 2021 19:25:09 GMT, Kevin Rushforth wrote: >> - GLib was updated to version 2.66.7 and GStreamer to version 1.18.3 >> - One bug was discovered in updated GStreamer which was causing deadlock or >> infinite loop during seek on macOS. See gstsystemclock.c for changes between >> ifdef GSTREAMER_LITE. Otherwise no changes. > > I get a compilation error on Linux: > > ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c: > In function 'gst_audio_buffer_map': > ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c:158:7: > error: implicit declaration of function 'memset' > [-Werror=implicit-function-declaration] > 158 | memset (buffer->map_infos, 0, > | ^~ > ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c:158:7: > warning: incompatible implicit declaration of built-in function 'memset' > ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c:26:1: > note: include '' or provide a declaration of 'memset' > ... > cc1: some warnings being treated as errors > Makefile:270: recipe for target > 'modules/javafx.media/build/native/linux/Release/obj/gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.o' > failed > make: *** > [modules/javafx.media/build/native/linux/Release/obj/gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.o] > Error 1 > > This is with the gcc 10.2 compiler used for production builds. I cannot reproduce build failure on Linux. - PR: https://git.openjdk.java.net/jfx/pull/447
Re: RFR: 8262366: Update glib to version 2.66.7
On Wed, 31 Mar 2021 05:15:20 GMT, Alexander Matveev wrote: > - GLib was updated to version 2.66.7 and GStreamer to version 1.18.3 > - One bug was discovered in updated GStreamer which was causing deadlock or > infinite loop during seek on macOS. See gstsystemclock.c for changes between > ifdef GSTREAMER_LITE. Otherwise no changes. I get a compilation error on Linux: ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c: In function 'gst_audio_buffer_map': ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c:158:7: error: implicit declaration of function 'memset' [-Werror=implicit-function-declaration] 158 | memset (buffer->map_infos, 0, | ^~ ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c:158:7: warning: incompatible implicit declaration of built-in function 'memset' ../../../gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.c:26:1: note: include '' or provide a declaration of 'memset' ... cc1: some warnings being treated as errors Makefile:270: recipe for target 'modules/javafx.media/build/native/linux/Release/obj/gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.o' failed make: *** [modules/javafx.media/build/native/linux/Release/obj/gstreamer-lite/gst-plugins-base/gst-libs/gst/audio/audio-buffer.o] Error 1 This is with the gcc 10.2 compiler used for production builds. - PR: https://git.openjdk.java.net/jfx/pull/447
RFR: 8262366: Update glib to version 2.66.7
- GLib was updated to version 2.66.7 and GStreamer to version 1.18.3 - One bug was discovered in updated GStreamer which was causing deadlock or infinite loop during seek on macOS. See gstsystemclock.c for changes between ifdef GSTREAMER_LITE. Otherwise no changes. - Commit messages: - 8262366: Update glib to version 2.66.7 Changes: https://git.openjdk.java.net/jfx/pull/447/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=447=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262366 Stats: 39553 lines in 439 files changed: 23426 ins; 5427 del; 10700 mod Patch: https://git.openjdk.java.net/jfx/pull/447.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/447/head:pull/447 PR: https://git.openjdk.java.net/jfx/pull/447
