Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This can be fixed with the option `cmd /s`, >> which prevents interpreting quotes on the rest of the command line. The >> result is as if the rest of the command line had been typed verbatim at the >> command prompt. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into fixes/JDK-8267059 > - Use cmd /s option when building on Windows Marked as reviewed by sykora (Author). I've tested these changes and I can confirm that it works as expected. - PR: https://git.openjdk.java.net/jfx/pull/499
Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This can be fixed with the option `cmd /s`, >> which prevents interpreting quotes on the rest of the command line. The >> result is as if the rest of the command line had been typed verbatim at the >> command prompt. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into fixes/JDK-8267059 > - Use cmd /s option when building on Windows @johanvos or @tiainen can you comment as to whether you have any concerns with this? It seems a safe fix to me. - PR: https://git.openjdk.java.net/jfx/pull/499
Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
On Fri, 27 Aug 2021 13:39:13 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since the last revision: >> >> - Merge branch 'master' into fixes/JDK-8267059 >> - Use cmd /s option when building on Windows > > @tiainen or @arapte can one of you be the second reviewer on this? @kevinrushforth I think this is a very useful fix that has been tested by three people in the last months (of which only your review counts for Skara). Can you lower the number of required reviews to 1 in order for this PR to move forward to integration? - PR: https://git.openjdk.java.net/jfx/pull/499
Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This can be fixed with the option `cmd /s`, >> which prevents interpreting quotes on the rest of the command line. The >> result is as if the rest of the command line had been typed verbatim at the >> command prompt. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into fixes/JDK-8267059 > - Use cmd /s option when building on Windows Tested this on Windows, seems to fix the issue. - Marked as reviewed by drmar...@github.com (no known OpenJDK username). PR: https://git.openjdk.java.net/jfx/pull/499
Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
On Wed, 3 Nov 2021 13:12:14 GMT, Erik Joelsson wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since the last revision: >> >> - Merge branch 'master' into fixes/JDK-8267059 >> - Use cmd /s option when building on Windows > > @drmarmac The issue with accepting the TOU should now have been fixed, so if > you click the agree box again, your review comment should be restored. @erikj79 thanks, doesn't seem to have worked though. - PR: https://git.openjdk.java.net/jfx/pull/499
Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This can be fixed with the option `cmd /s`, >> which prevents interpreting quotes on the rest of the command line. The >> result is as if the rest of the command line had been typed verbatim at the >> command prompt. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into fixes/JDK-8267059 > - Use cmd /s option when building on Windows @drmarmac The issue with accepting the TOU should now have been fixed, so if you click the agree box again, your review comment should be restored. - PR: https://git.openjdk.java.net/jfx/pull/499
Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This can be fixed with the option `cmd /s`, >> which prevents interpreting quotes on the rest of the command line. The >> result is as if the rest of the command line had been typed verbatim at the >> command prompt. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into fixes/JDK-8267059 > - Use cmd /s option when building on Windows @tiainen or @arapte can one of you be the second reviewer on this? - PR: https://git.openjdk.java.net/jfx/pull/499
Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
On Fri, 4 Jun 2021 18:14:50 GMT, Kevin Rushforth wrote: > > On Ubuntu 20.04 ... The :apps task fails before and after the fix > > Maybe something with the version of Java you are using? It runs fine my > system, and the GitHub actions build is fine. It turns out that I encountered the same issue that was [discussed on the mailing list](https://mail.openjdk.java.net/pipermail/openjfx-dev/2021-August/031470.html). - PR: https://git.openjdk.java.net/jfx/pull/499
Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This can be fixed with the option `cmd /s`, >> which prevents interpreting quotes on the rest of the command line. The >> result is as if the rest of the command line had been typed verbatim at the >> command prompt. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into fixes/JDK-8267059 > - Use cmd /s option when building on Windows Looks fine. I tested it on Windows with / without spaces in `ANT_HOME` and it does what I would expect. I sanity tested it on Linux. > On Ubuntu 20.04 ... The :apps task fails before and after the fix Maybe something with the version of Java you are using? It runs fine my system, and the GitHub actions build is fine. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/499
Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This can be fixed with the option `cmd /s`, >> which prevents interpreting quotes on the rest of the command line. The >> result is as if the rest of the command line had been typed verbatim at the >> command prompt. > > Michael Strauß has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into fixes/JDK-8267059 > - Use cmd /s option when building on Windows I've tested the `:clean` and `:apps` tasks on Windows, Linux, and macOS: On Windows 10 20H2, `:clean` and `:apps` fail before and succeed after the fix. On macOS 10.15.1, `:clean` and `:apps` succeed before and after the fix. On Ubuntu 20.04, `:clean` succeeds before and after the fix. The `:apps` task fails before and after the fix: [javac] Compiling 143 source files to /home/ubuntu/jfx/apps/samples/3DViewer/build/classes [javac] error: invalid flag: @/home/ubuntu/jfx/build/compile.args [javac] Usage: javac [javac] use --help for a list of possible options - PR: https://git.openjdk.java.net/jfx/pull/499
Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]
> This PR fixes an issue when building OpenJFX on Windows and command-line > arguments contain paths with spaces. > > The problem is that on Windows, `ant` is invoked via `cmd`, which leads to > quotes being interpreted twice. This can be fixed with the option `cmd /s`, > which prevents interpreting quotes on the rest of the command line. The > result is as if the rest of the command line had been typed verbatim at the > command prompt. Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into fixes/JDK-8267059 - Use cmd /s option when building on Windows - Changes: - all: https://git.openjdk.java.net/jfx/pull/499/files - new: https://git.openjdk.java.net/jfx/pull/499/files/b11d0b1e..111b23d6 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx=499=01 - incr: https://webrevs.openjdk.java.net/?repo=jfx=499=00-01 Stats: 1534 lines in 75 files changed: 976 ins; 254 del; 304 mod Patch: https://git.openjdk.java.net/jfx/pull/499.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/499/head:pull/499 PR: https://git.openjdk.java.net/jfx/pull/499
