Re: RFR: 8271091: Missing API docs in UI controls classes [v5]
On Thu, 28 Oct 2021 14:27:52 GMT, Ajit Ghaisas wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - >> [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085) >> - There are still 20 javadoc warnings remaining in javafx.controls module >> and 3 warnings remaining in javafx.web module. The root cause is different >> and they will be addressed under >> [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996) > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > fix review comments I didn't check the generated HTML pages or the correctness of the docs with respect to the functionality of their methods, but the docs themselves look good. - Marked as reviewed by nlisker (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/646
Re: RFR: 8271091: Missing API docs in UI controls classes [v5]
On Thu, 28 Oct 2021 14:27:52 GMT, Ajit Ghaisas wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - >> [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085) >> - There are still 20 javadoc warnings remaining in javafx.controls module >> and 3 warnings remaining in javafx.web module. The root cause is different >> and they will be addressed under >> [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996) > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > fix review comments This looks good. I confirmed that the implicit constructor for `PopupControl.CSSBridge` is `protected` in JavaFX 17, so making the explicitly added contructor be `protected` is correct. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/646
Re: RFR: 8271091: Missing API docs in UI controls classes [v5]
On Thu, 28 Oct 2021 23:30:32 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java
> line 1132:
>
>> 1130: * Constructor for subclasses to call.
>> 1131: */
>> 1132: protected CSSBridge() {
>
> Please revert this change. Since the class is protected, it's a compatible
> change, but any change to a method's signature, return type, or modifiers
> needs a CSR.
Oh! never mind. I misread this. I see that you _are_ reverting it back. That's
good then (and a good catch).
-
PR: https://git.openjdk.java.net/jfx/pull/646
Re: RFR: 8271091: Missing API docs in UI controls classes [v5]
On Thu, 28 Oct 2021 14:27:52 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under -
>> [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085)
>> - There are still 20 javadoc warnings remaining in javafx.controls module
>> and 3 warnings remaining in javafx.web module. The root cause is different
>> and they will be addressed under
>> [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996)
>
> Ajit Ghaisas has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix review comments
The doc changes look good. Please revert the access modifier change.
modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java
line 1132:
> 1130: * Constructor for subclasses to call.
> 1131: */
> 1132: protected CSSBridge() {
Please revert this change. Since the class is protected, it's a compatible
change, but any change to a method's signature, return type, or modifiers needs
a CSR.
-
Changes requested by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/646
Re: RFR: 8271091: Missing API docs in UI controls classes [v5]
> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. > Note : > - The javadoc needs to be generated with the JDK 18 EA build. > - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - > [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085) > - There are still 20 javadoc warnings remaining in javafx.controls module and > 3 warnings remaining in javafx.web module. The root cause is different and > they will be addressed under > [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996) Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision: fix review comments - Changes: - all: https://git.openjdk.java.net/jfx/pull/646/files - new: https://git.openjdk.java.net/jfx/pull/646/files/b4d5dc4f..1ab36f72 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=646&range=04 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=646&range=03-04 Stats: 10 lines in 3 files changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/jfx/pull/646.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/646/head:pull/646 PR: https://git.openjdk.java.net/jfx/pull/646
