Re: Eclipse: any way to checkout a PR for review?
A Pull Request is a GitHub feature, it doesn't exist in Git generally, so EGit (I assume that's what you also use) is oblivious to PRs. Maybe there is a special plugin for GitHubs or PRs. Also, adding a remote is a one-time operation. Most contributors are recurring, so for me reviewing amounts to a right click > pull on the remote and a double click on the branch to check it out. I don't see any inconvenience. On Wed, Jul 28, 2021 at 12:45 PM Jeanette Winzenburg < faste...@swingempire.de> wrote: > > Zitat von Nir Lisker : > > > I'm not really sure what you mean. If you pull from the remote that the > PR > > is on and checkout the remote branch, is it not good enough for a review? > > > > yeah, that's what I meant - without having been too clear - with > fork-the-fork :) What I had hoped for was some hidden eclipse magic to > directly access a PR as branch (from jfx) - something like the Pull > requests tab in GitHub Desktop. Which under the hood adds a new remote > to the fork that created the pr. And that's what I ended up with: add > that remote manually and checkout the branch. > > Thanks for your input! > > -- Jeanette > > > > > On Tue, Jul 27, 2021 at 2:16 PM Jeanette Winzenburg < > faste...@swingempire.de> > > wrote: > > > >> > >> when reviewing a PR with only a few files changed, I simply create a > >> local branch and c the changes (*cough, pretty sure there's a better > >> way, but then that's the most simple ;). > >> > >> With changes to many files (like f.i. > >> https://github.com/openjdk/jfx/pull/569) that still would be doable, > >> but rather cumbersome - so looking for something like "gh pr checkout > >> 569" (not that I ever tried that, just copied from the doc :) inside > >> Eclipse. > >> > >> An alternative might be to fork-the-fork .. ? > >> > >> -- Jeanette > >> > >> > > > >
Re: Eclipse: any way to checkout a PR for review?
Zitat von Nir Lisker : I'm not really sure what you mean. If you pull from the remote that the PR is on and checkout the remote branch, is it not good enough for a review? yeah, that's what I meant - without having been too clear - with fork-the-fork :) What I had hoped for was some hidden eclipse magic to directly access a PR as branch (from jfx) - something like the Pull requests tab in GitHub Desktop. Which under the hood adds a new remote to the fork that created the pr. And that's what I ended up with: add that remote manually and checkout the branch. Thanks for your input! -- Jeanette On Tue, Jul 27, 2021 at 2:16 PM Jeanette Winzenburg wrote: when reviewing a PR with only a few files changed, I simply create a local branch and c the changes (*cough, pretty sure there's a better way, but then that's the most simple ;). With changes to many files (like f.i. https://github.com/openjdk/jfx/pull/569) that still would be doable, but rather cumbersome - so looking for something like "gh pr checkout 569" (not that I ever tried that, just copied from the doc :) inside Eclipse. An alternative might be to fork-the-fork .. ? -- Jeanette
Re: Eclipse: any way to checkout a PR for review?
I'm not really sure what you mean. If you pull from the remote that the PR is on and checkout the remote branch, is it not good enough for a review? On Tue, Jul 27, 2021 at 2:16 PM Jeanette Winzenburg wrote: > > when reviewing a PR with only a few files changed, I simply create a > local branch and c the changes (*cough, pretty sure there's a better > way, but then that's the most simple ;). > > With changes to many files (like f.i. > https://github.com/openjdk/jfx/pull/569) that still would be doable, > but rather cumbersome - so looking for something like "gh pr checkout > 569" (not that I ever tried that, just copied from the doc :) inside > Eclipse. > > An alternative might be to fork-the-fork .. ? > > -- Jeanette > >
Re: Eclipse: any way to checkout a PR for review?
ahh .. yeah, that looks doable - had hoped to get away without installing git and frickle with commandlines ;) thanks Zitat von Kevin Rushforth : I do something like this: git fetch upstream pull/569/head:pr_569 Then you can checkout the "pr_569" branch. I typically will then merge in the current upstream/master to test. If you don't have an "upstream" remote you can instead: git fetch https://github.com/openjdk/jfx pull/569/head:pr_569 -- Kevin On 7/27/2021 4:15 AM, Jeanette Winzenburg wrote: when reviewing a PR with only a few files changed, I simply create a local branch and c the changes (*cough, pretty sure there's a better way, but then that's the most simple ;). With changes to many files (like f.i. https://github.com/openjdk/jfx/pull/569) that still would be doable, but rather cumbersome - so looking for something like "gh pr checkout 569" (not that I ever tried that, just copied from the doc :) inside Eclipse. An alternative might be to fork-the-fork .. ? -- Jeanette
Re: Eclipse: any way to checkout a PR for review?
I do something like this: git fetch upstream pull/569/head:pr_569 Then you can checkout the "pr_569" branch. I typically will then merge in the current upstream/master to test. If you don't have an "upstream" remote you can instead: git fetch https://github.com/openjdk/jfx pull/569/head:pr_569 -- Kevin On 7/27/2021 4:15 AM, Jeanette Winzenburg wrote: when reviewing a PR with only a few files changed, I simply create a local branch and c the changes (*cough, pretty sure there's a better way, but then that's the most simple ;). With changes to many files (like f.i. https://github.com/openjdk/jfx/pull/569) that still would be doable, but rather cumbersome - so looking for something like "gh pr checkout 569" (not that I ever tried that, just copied from the doc :) inside Eclipse. An alternative might be to fork-the-fork .. ? -- Jeanette
