Re: Test drive of Skara feature to automatically resolve JBS issues
Thanks for the cleanup :) Zitat von Kevin Rushforth : I was planning to do that this morning (I was going to do it Friday afternoon, but ran into the JBS maintenance window, and then ran out of time). They actually had turned it on before the below bug was integrated, but there was a configuration error in the Skara bot that prevented it from working, and they haven't implemented the retry logic yet. Thanks. -- Kevin On 12/9/2019 2:56 AM, Jeanette Winzenburg wrote: Zitat von Kevin Rushforth : The plan is to put this into place tomorrow (Friday, Dec 6) and test drive it for a week or two so that the Skara team can get feedback on how it is working for our project (they already use it for the Skara project). hmm .. looks like https://github.com/openjdk/jfx/pull/56 was integrated too early for the magic to shine? (With a fix integrated today everything went fine :) Should I update the corresponding issue manually? -- CU, Jeanette
Re: Test drive of Skara feature to automatically resolve JBS issues
I was planning to do that this morning (I was going to do it Friday afternoon, but ran into the JBS maintenance window, and then ran out of time). They actually had turned it on before the below bug was integrated, but there was a configuration error in the Skara bot that prevented it from working, and they haven't implemented the retry logic yet. Thanks. -- Kevin On 12/9/2019 2:56 AM, Jeanette Winzenburg wrote: Zitat von Kevin Rushforth : The plan is to put this into place tomorrow (Friday, Dec 6) and test drive it for a week or two so that the Skara team can get feedback on how it is working for our project (they already use it for the Skara project). hmm .. looks like https://github.com/openjdk/jfx/pull/56 was integrated too early for the magic to shine? (With a fix integrated today everything went fine :) Should I update the corresponding issue manually? -- CU, Jeanette
Re: Test drive of Skara feature to automatically resolve JBS issues
Zitat von Kevin Rushforth : The plan is to put this into place tomorrow (Friday, Dec 6) and test drive it for a week or two so that the Skara team can get feedback on how it is working for our project (they already use it for the Skara project). hmm .. looks like https://github.com/openjdk/jfx/pull/56 was integrated too early for the magic to shine? (With a fix integrated today everything went fine :) Should I update the corresponding issue manually? -- CU, Jeanette
Test drive of Skara feature to automatically resolve JBS issues
The Skara team is ready for us to test drive the "gitupdater" feature of the Skara bot which will automatically resolve JBS issues as fixed when the associated pull request is integrated. It will also add a comment with the commit message. I note that while it is far enough along for us to test, it isn't completely finished: the Skara bot will not set the fixVersion nor will it create a backport record (this latter isn't a concern yet, but will be in the future). The plan is to put this into place tomorrow (Friday, Dec 6) and test drive it for a week or two so that the Skara team can get feedback on how it is working for our project (they already use it for the Skara project). This means two things: 1. The Reviewers of a PR, as well as the Committer who will integrate (or sponsor) the fix, need to ensure that the JBS bug has the fix version set to the current release, which is openjfx14. 2. Once a fix is integrated, don't update the JBS bugs (other than you can remove the "review-requested" label if present). We want to give the Skara bot a change to do it's magic. Let me know if you have any questions. -- Kevin
