[devel] [PATCH 0/1] Review Request for log: refactor log agent - 2nd increment [#2412] V4

2017-05-18 Thread Vu Minh Nguyen 
Summary: log: refactor log agent - 2nd increment [#2412]
Review request for Ticket(s): 2412
Peer Reviewer(s): LOG Dev
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2412
Base revision: 1867ef71083edfad88dc3a9970549e6d35085bd2
Personal repository: git://git.code.sf.net/u/winhvu/review


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***

revision 744109058ebfd01911e62627dcae3a80bd222902
Author: Vu Minh Nguyen 
Date:   Thu, 18 May 2017 15:13:15 +0200

log: refactor log agent - 2nd increment [#2412]

The major changes are:
1) Replacing C database of client list and stream list to C++.
2) Centralizing databases read/write to one place
3) Remove global log agent control block



Added Files:

 src/log/agent/lga_agent.cc
 src/log/agent/lga_agent.h
 src/log/agent/lga_client.cc
 src/log/agent/lga_client.h
 src/log/agent/lga_common.h
 src/log/agent/lga_stream.cc
 src/log/agent/lga_stream.h
 src/log/apitest/tet_multiple_thread.c


Removed Files:
--
 src/log/agent/lga_api.h
 src/log/agent/lga.h


Complete diffstat:
--
 src/log/Makefile.am   |   16 +-
 src/log/agent/lga.h   |  137 
 src/log/agent/lga_agent.cc| 1450 +
 src/log/agent/lga_agent.h |  407 +
 src/log/agent/lga_api.cc  | 1435 +---
 src/log/agent/lga_api.h   |   70 --
 src/log/agent/lga_client.cc   |  456 +++
 src/log/agent/lga_client.h|  316 +++
 src/log/agent/lga_common.h|   60 ++
 src/log/agent/lga_mds.cc  |  434 +-
 src/log/agent/lga_mds.h   |7 +-
 src/log/agent/lga_state.cc|  509 ++--
 src/log/agent/lga_state.h |   25 +-
 src/log/agent/lga_stream.cc   |  167 
 src/log/agent/lga_stream.h|  182 +
 src/log/agent/lga_util.cc |  770 +
 src/log/agent/lga_util.h  |   31 +-
 src/log/apitest/tet_multiple_thread.c |  317 +++
 18 files changed, 3675 insertions(+), 3114 deletions(-)


Testing Commands:
-
Run `logtest`. New test suited is added to test
if having any deadlock or coredump.


Testing, Expected Results:
--
All tests PASS


Conditions of Submission:
-
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***


Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  n  n
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple times

[devel] [PATCH 0/1] Review Request for log: refactor log agent - 2nd increment [#2412] V4

2017-05-15 Thread Vu Minh Nguyen 
Summary: log: refactor log agent - 2nd increment [#2412]
Review request for Ticket(s): 2412
Peer Reviewer(s): LOG Devs
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2412
Base revision: 8c09ce778f01cd0b202a2b7b9fd51dbc14648674
Personal repository: git://git.code.sf.net/u/winhvu/review


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***

revision ab6cf7db983cc97ad4e4b5e39327bd9c72004d11
Author: Vu Minh Nguyen 
Date:   Mon, 15 May 2017 12:39:12 +0200

log: refactor log agent - 2nd increment [#2412]

The major changes are:
1) Replacing C database of client list and stream list to C++.
2) Centralizing databases read/write to one place
3) Remove global log agent control block



Added Files:

 src/log/agent/lga_agent.cc
 src/log/agent/lga_agent.h
 src/log/agent/lga_client.cc
 src/log/agent/lga_client.h
 src/log/agent/lga_common.h
 src/log/agent/lga_stream.cc
 src/log/agent/lga_stream.h
 src/log/apitest/tet_multiple_thread.c


Removed Files:
--
 src/log/agent/lga_api.h
 src/log/agent/lga.h


Complete diffstat:
--
 src/log/Makefile.am   |   16 +-
 src/log/agent/lga.h   |  137 
 src/log/agent/lga_agent.cc| 1445 +
 src/log/agent/lga_agent.h |  408 ++
 src/log/agent/lga_api.cc  | 1435 +---
 src/log/agent/lga_api.h   |   70 --
 src/log/agent/lga_client.cc   |  439 ++
 src/log/agent/lga_client.h|  305 +++
 src/log/agent/lga_common.h|   68 ++
 src/log/agent/lga_mds.cc  |  428 +-
 src/log/agent/lga_mds.h   |7 +-
 src/log/agent/lga_state.cc|  509 ++--
 src/log/agent/lga_state.h |   25 +-
 src/log/agent/lga_stream.cc   |  147 
 src/log/agent/lga_stream.h|  175 
 src/log/agent/lga_util.cc |  770 +-
 src/log/agent/lga_util.h  |   31 +-
 src/log/apitest/tet_multiple_thread.c |  317 
 18 files changed, 3624 insertions(+), 3108 deletions(-)


Testing Commands:
-
Run `logtest`. One new test suite is introduced
to verify if having any deadlock or coredump.


Testing, Expected Results:
--
All tests PASS


Conditions of Submission:
-
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***


Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  n  n
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.

___ You have extraneous garbage in your review (merge commits etc)

___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.

___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.

___ You have resent this content multiple