Re: [devel] [PATCH 0 of 5] Review Request for AMF SU refactoring #713

2014-04-28 Thread Hans Feldt
Friendly remainder.
/Hans

On 04/22/2014 12:58 PM, Hans Feldt wrote:
 Summary: amfd SU refactoring
 Review request for Trac Ticket(s): 713
 Peer Reviewer(s): AMF developers
 Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
 Affected branch(es): default
 Development branch: IF ANY GIVE THE REPO URL

 
 Impacted area   Impact y/n
 
   Docsn
   Build systemn
   RPM/packaging   n
   Configuration files n
   Startup scripts n
   SAF servicesy
   OpenSAF servicesn
   Core libraries  n
   Samples n
   Tests   n
   Other   n


 Comments (indicate scope for each y above):
 -

 changeset 89d505f5680924bcf384ff6a4130658751184923
 Author:   Hans Feldt hans.fe...@ericsson.com
 Date: Tue, 22 Apr 2014 12:53:56 +0200

   amfd: cleanup SU [#713]

   su_act_state is not used thus can be made a dummy (not removed because 
 of
   EDU usage). The corresponding enum AVD_SU_STATE removed. Checkpointing 
 of
   su_act_state kept for backwards compatibility but reduced to a minimum.

   The use of this- is removed from some setters.

   Some non existing function signatures removed from the header file.

 changeset e81dc53b0733dee2b2bbe4d2ec1e3aa6d9dd9ca8
 Author:   Hans Feldt hans.fe...@ericsson.com
 Date: Tue, 22 Apr 2014 12:53:57 +0200

   amfd: add and use SU method set_pres_state [#713]

 changeset 87d7fb15e249c363b2531f43df18d94fa1fa60fe
 Author:   Hans Feldt hans.fe...@ericsson.com
 Date: Tue, 22 Apr 2014 12:53:57 +0200

   amfd: add and use SU method set_admin_state [#713]

 changeset d2c7b29d6113153841ddaaa3ec4ae70784f89ac3
 Author:   Hans Feldt hans.fe...@ericsson.com
 Date: Tue, 22 Apr 2014 12:53:58 +0200

   amfd: add and use SU methods add_comp/remove_comp [#713]

 changeset 4d6d0708b6923a306b9a5ae44be2ddda2cc016a9
 Author:   Hans Feldt hans.fe...@ericsson.com
 Date: Tue, 22 Apr 2014 12:54:00 +0200

   amfd: add and use SU method no_assignments_of_hastate [#713]


 Complete diffstat:
 --
   osaf/services/saf/amf/amfd/ckpt_dec.cc   |   28 
 +
   osaf/services/saf/amf/amfd/ckpt_updt.cc  |1 -
   osaf/services/saf/amf/amfd/comp.cc   |   11 +
   osaf/services/saf/amf/amfd/include/su.h  |   53 
 ++
   osaf/services/saf/amf/amfd/ndproc.cc |2 +-
   osaf/services/saf/amf/amfd/sg_2n_fsm.cc  |   14 ++--
   osaf/services/saf/amf/amfd/sg_nored_fsm.cc   |   16 +++---
   osaf/services/saf/amf/amfd/sg_npm_fsm.cc |   16 +++---
   osaf/services/saf/amf/amfd/sg_nway_fsm.cc|   22 ++--
   osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc |   16 +++---
   osaf/services/saf/amf/amfd/sgproc.cc |4 +-
   osaf/services/saf/amf/amfd/su.cc |  140 
 +++-
   osaf/services/saf/amf/amfd/util.cc   |1 -
   13 files changed, 135 insertions(+), 189 deletions(-)


 Testing Commands:
 -
   Build and start


 Testing, Expected Results:
 --
   PASTE COMMAND OUTPUTS / TEST RESULTS


 Conditions of Submission:
 -
   HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC


 Arch  Built StartedLinux distro
 ---
 mipsn  n
 mips64  n  n
 x86 n  n
 x86_64  n  n
 powerpc n  n
 powerpc64   n  n


 Reviewer Checklist:
 ---
 [Submitters: make sure that your review doesn't trigger any checkmarks!]


 Your checkin has not passed review because (see checked entries):

 ___ Your RR template is generally incomplete; it has too many blank entries
  that need proper data filled in.

 ___ You have failed to nominate the proper persons for review and push.

 ___ Your patches do not have proper short+long header

 ___ You have grammar/spelling in your header that is unacceptable.

 ___ You have exceeded a sensible line length in your headers/comments/text.

 ___ You have failed to put in a proper Trac Ticket # into your commits.

 ___ You have incorrectly put/left internal data in your comments/files
  (i.e. internal bug tracking tool IDs, product names etc)

 ___ You have not given any evidence of testing beyond basic build tests.
  Demonstrate some level of runtime or other sanity testing.

 ___ You have ^M present in some of your files. These have to be removed.

 ___ You have needlessly changed whitespace or added whitespace crimes
  like trailing spaces, or spaces before tabs.

 ___ You have mixed real technical changes 

[devel] [PATCH 0 of 5] Review Request for AMF SU refactoring #713

2014-04-22 Thread Hans Feldt
Summary: amfd SU refactoring
Review request for Trac Ticket(s): 713
Peer Reviewer(s): AMF developers
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): default
Development branch: IF ANY GIVE THE REPO URL


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each y above):
-

changeset 89d505f5680924bcf384ff6a4130658751184923
Author: Hans Feldt hans.fe...@ericsson.com
Date:   Tue, 22 Apr 2014 12:53:56 +0200

amfd: cleanup SU [#713]

su_act_state is not used thus can be made a dummy (not removed because 
of
EDU usage). The corresponding enum AVD_SU_STATE removed. Checkpointing 
of
su_act_state kept for backwards compatibility but reduced to a minimum.

The use of this- is removed from some setters.

Some non existing function signatures removed from the header file.

changeset e81dc53b0733dee2b2bbe4d2ec1e3aa6d9dd9ca8
Author: Hans Feldt hans.fe...@ericsson.com
Date:   Tue, 22 Apr 2014 12:53:57 +0200

amfd: add and use SU method set_pres_state [#713]

changeset 87d7fb15e249c363b2531f43df18d94fa1fa60fe
Author: Hans Feldt hans.fe...@ericsson.com
Date:   Tue, 22 Apr 2014 12:53:57 +0200

amfd: add and use SU method set_admin_state [#713]

changeset d2c7b29d6113153841ddaaa3ec4ae70784f89ac3
Author: Hans Feldt hans.fe...@ericsson.com
Date:   Tue, 22 Apr 2014 12:53:58 +0200

amfd: add and use SU methods add_comp/remove_comp [#713]

changeset 4d6d0708b6923a306b9a5ae44be2ddda2cc016a9
Author: Hans Feldt hans.fe...@ericsson.com
Date:   Tue, 22 Apr 2014 12:54:00 +0200

amfd: add and use SU method no_assignments_of_hastate [#713]


Complete diffstat:
--
 osaf/services/saf/amf/amfd/ckpt_dec.cc   |   28 +
 osaf/services/saf/amf/amfd/ckpt_updt.cc  |1 -
 osaf/services/saf/amf/amfd/comp.cc   |   11 +
 osaf/services/saf/amf/amfd/include/su.h  |   53 
++
 osaf/services/saf/amf/amfd/ndproc.cc |2 +-
 osaf/services/saf/amf/amfd/sg_2n_fsm.cc  |   14 ++--
 osaf/services/saf/amf/amfd/sg_nored_fsm.cc   |   16 +++---
 osaf/services/saf/amf/amfd/sg_npm_fsm.cc |   16 +++---
 osaf/services/saf/amf/amfd/sg_nway_fsm.cc|   22 ++--
 osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc |   16 +++---
 osaf/services/saf/amf/amfd/sgproc.cc |4 +-
 osaf/services/saf/amf/amfd/su.cc |  140 
+++-
 osaf/services/saf/amf/amfd/util.cc   |1 -
 13 files changed, 135 insertions(+), 189 deletions(-)


Testing Commands:
-
 Build and start


Testing, Expected Results:
--
 PASTE COMMAND OUTPUTS / TEST RESULTS


Conditions of Submission:
-
 HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC


Arch  Built StartedLinux distro
---
mipsn  n
mips64  n  n
x86 n  n
x86_64  n  n
powerpc n  n
powerpc64   n  n


Reviewer Checklist:
---
[Submitters: make sure that your review doesn't trigger any checkmarks!]


Your checkin has not passed review because (see checked entries):

___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.

___ You have failed to nominate the proper persons for review and push.

___ Your patches do not have proper short+long header

___ You have grammar/spelling in your header that is unacceptable.

___ You have exceeded a sensible line length in your headers/comments/text.

___ You have failed to put in a proper Trac Ticket # into your commits.

___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)

___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.

___ You have ^M present in some of your files. These have to be removed.

___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.

___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.

___ You need to refactor your submission into logical chunks; there is
too much content into a single