Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

2016-08-23 Thread A V Mahesh 
Hi Hoang,

Please send the all update patches 1 to 8  & README in single tar,
so that I can commit.

-AVM


On 8/23/2016 12:48 PM, Vo Minh Hoang wrote:
> Dear Mahesh,
>
> I updated README file and sent as attachment to this email.
> I also sent update patches following your comments.
>
> Please help me push these items if there is no further problem.
>
> Thank you and best regards,
> Hoang
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Monday, August 22, 2016 1:53 PM
> To: Hoang Vo 
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than
> 255 bytes [#1574] v5
>
> Hi Hoang,
>
> ACK, Please Update README
>
> Note : tested default functionality , LONG DN functionality not tested in
> full fledged.
>
> -AVM
>
>
> On 8/18/2016 12:48 PM, Hoang Vo wrote:
>> Summary: CKPT: Support DNs longer than 255 bytes {#1574} Review
>> request for Trac Ticket(s): 1574 Peer Reviewer(s):
>> mahesh.va...@oracle.com; anders.wid...@ericsson.com Pull request to:
>> mahesh.va...@oracle.com Affected branch(es): default Development
>> branch: default
>>
>> 
>> Impacted area   Impact y/n
>> 
>>Docsn
>>Build systemn
>>RPM/packaging   n
>>Configuration files n
>>Startup scripts n
>>SAF servicesy
>>OpenSAF servicesn
>>Core libraries  n
>>Samples n
>>Tests   n
>>Other   n
>>
>>
>> Comments (indicate scope for each "y" above):
>> -
>>
>> changeset 05233bdae1fb000fea001964eba1c51ebf3bfd8e
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpd: Add support for extended SaNameT [#1574] v3
>>
>> changeset cecabec5b6be73e731e540fd439e1d0e3534809f
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpnd: Add support for extended SaNameT [#1574] v3
>>
>> changeset 940dc877c94a9539e3da06d89c6480ef7e0ceda0
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpa: Add support for extended SaNameT [#1574] v1
>>
>> changeset 1f74531a36163bdfecd6b27174443d51c11ecf61
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpsv: Add new message to support extended SaNameT [#1574] v3
>>
>> changeset 29df19302186b3275ad06db00dc62f275dea25e1
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpd: Add new mbcsv messages supporting extended SaNameT [#1574] v2
>>
>> changeset 3f72410a7c2bb077647bdd4e46869a31a832f1d8
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpsv: Apply new messages supporting extended SaNameT to CPD, CPND,
> and CPA
>>  [#1574] v4
>>
>> changeset f32a0b3ca1ebf6049d2103e68e91d98bf086c48e
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  ckpt: Add new test cases to verify long DN feature on CPSV [#1574]
> v1
>> changeset 1aa38b707cf2cec14c416631cfc7e5518b25735f
>> Author:  Hoang Vo 
>> Date:Thu, 18 Aug 2016 13:51:56 +0700
>>
>>  cpnd: add support for shm recovery for in-service update without
> restarting
>>  node [#1574] v1
>>
>>
>> Complete diffstat:
>> --
>>osaf/libs/agents/saf/cpa/Makefile.am  |1 +
>>osaf/libs/agents/saf/cpa/cpa_api.c|   48 --
>>osaf/libs/agents/saf/cpa/cpa_db.c |2 +
>>osaf/libs/agents/saf/cpa/cpa_mds.c|4 +-
>>osaf/libs/agents/saf/cpa/cpa_proc.c   |2 +-
>>osaf/libs/common/cpsv/cpsv_evt.c  |  440
> ++---
>>osaf/libs/common/cpsv/include/cpa.h   |1 +
>>osaf/libs/common/cpsv/include/cpa_cb.h|2 +-
>>osaf/libs/common/cpsv/include/cpa_proc.h  |2 +-
>>osaf/libs/common/cpsv/include/cpd.h   |1 +
>>osaf/libs/common/cpsv/include/cpd_cb.h|   17 +-
>>osaf/libs/common/cpsv/include/cpd_imm.h   |4 +-
>>osaf/libs/common/cpsv/include/cpd_mem.h   |   25 +++-
>>osaf/libs/common/cpsv/include/cpd_proc.h  |2 +-
>>osaf/libs/common/cpsv/include/cpnd.h  |1 +
>>osaf/libs/common/cpsv/include/cpnd_cb.h   |5 +-
>>osaf/libs/common/cpsv/include/cpnd_init.h |3 +-
>>osaf/libs/common/cpsv/include/cpsv_evt.h  |   10 +
>>osaf/libs/common/cpsv/include/cpsv_shm.h  |   24 +++-
>>osaf/services/saf/cpsv/cpd/Makefile.am|1 +
>>osaf/services/saf/cpsv/cpd/cpd_amf.c  |7 +-
>>

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

2016-08-23 Thread Vo Minh Hoang 
Dear Mahesh,

I updated README file and sent as attachment to this email.
I also sent update patches following your comments.

Please help me push these items if there is no further problem.

Thank you and best regards,
Hoang

-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com] 
Sent: Monday, August 22, 2016 1:53 PM
To: Hoang Vo 
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than
255 bytes [#1574] v5

Hi Hoang,

ACK, Please Update README

Note : tested default functionality , LONG DN functionality not tested in
full fledged.

-AVM


On 8/18/2016 12:48 PM, Hoang Vo wrote:
> Summary: CKPT: Support DNs longer than 255 bytes {#1574} Review 
> request for Trac Ticket(s): 1574 Peer Reviewer(s): 
> mahesh.va...@oracle.com; anders.wid...@ericsson.com Pull request to: 
> mahesh.va...@oracle.com Affected branch(es): default Development 
> branch: default
>
> 
> Impacted area   Impact y/n
> 
>   Docsn
>   Build systemn
>   RPM/packaging   n
>   Configuration files n
>   Startup scripts n
>   SAF servicesy
>   OpenSAF servicesn
>   Core libraries  n
>   Samples n
>   Tests   n
>   Other   n
>
>
> Comments (indicate scope for each "y" above):
> -
>
> changeset 05233bdae1fb000fea001964eba1c51ebf3bfd8e
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpd: Add support for extended SaNameT [#1574] v3
>
> changeset cecabec5b6be73e731e540fd439e1d0e3534809f
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpnd: Add support for extended SaNameT [#1574] v3
>
> changeset 940dc877c94a9539e3da06d89c6480ef7e0ceda0
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpa: Add support for extended SaNameT [#1574] v1
>
> changeset 1f74531a36163bdfecd6b27174443d51c11ecf61
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpsv: Add new message to support extended SaNameT [#1574] v3
>
> changeset 29df19302186b3275ad06db00dc62f275dea25e1
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpd: Add new mbcsv messages supporting extended SaNameT [#1574] v2
>
> changeset 3f72410a7c2bb077647bdd4e46869a31a832f1d8
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpsv: Apply new messages supporting extended SaNameT to CPD, CPND,
and CPA
>   [#1574] v4
>
> changeset f32a0b3ca1ebf6049d2103e68e91d98bf086c48e
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   ckpt: Add new test cases to verify long DN feature on CPSV [#1574]
v1
>
> changeset 1aa38b707cf2cec14c416631cfc7e5518b25735f
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpnd: add support for shm recovery for in-service update without
restarting
>   node [#1574] v1
>
>
> Complete diffstat:
> --
>   osaf/libs/agents/saf/cpa/Makefile.am  |1 +
>   osaf/libs/agents/saf/cpa/cpa_api.c|   48 --
>   osaf/libs/agents/saf/cpa/cpa_db.c |2 +
>   osaf/libs/agents/saf/cpa/cpa_mds.c|4 +-
>   osaf/libs/agents/saf/cpa/cpa_proc.c   |2 +-
>   osaf/libs/common/cpsv/cpsv_evt.c  |  440
++---
>   osaf/libs/common/cpsv/include/cpa.h   |1 +
>   osaf/libs/common/cpsv/include/cpa_cb.h|2 +-
>   osaf/libs/common/cpsv/include/cpa_proc.h  |2 +-
>   osaf/libs/common/cpsv/include/cpd.h   |1 +
>   osaf/libs/common/cpsv/include/cpd_cb.h|   17 +-
>   osaf/libs/common/cpsv/include/cpd_imm.h   |4 +-
>   osaf/libs/common/cpsv/include/cpd_mem.h   |   25 +++-
>   osaf/libs/common/cpsv/include/cpd_proc.h  |2 +-
>   osaf/libs/common/cpsv/include/cpnd.h  |1 +
>   osaf/libs/common/cpsv/include/cpnd_cb.h   |5 +-
>   osaf/libs/common/cpsv/include/cpnd_init.h |3 +-
>   osaf/libs/common/cpsv/include/cpsv_evt.h  |   10 +
>   osaf/libs/common/cpsv/include/cpsv_shm.h  |   24 +++-
>   osaf/services/saf/cpsv/cpd/Makefile.am|1 +
>   osaf/services/saf/cpsv/cpd/cpd_amf.c  |7 +-
>   osaf/services/saf/cpsv/cpd/cpd_db.c   |   95 +++---
>   osaf/services/saf/cpsv/cpd/cpd_evt.c  |  103 ++-
>   osaf/services/saf/cpsv/cpd/cpd_imm.c  |  268
++
>   osaf/services/saf/cpsv/cpd/cpd_main.c |7 +
>   osaf/services/saf/cpsv/cpd/cpd_mbcsv.c|   31 -
>   osaf/services/saf/cpsv/cpd/cpd_mds.c  |

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

2016-08-22 Thread A V Mahesh 
Hi Hoang,

ACK, Please Update README

Note : tested default functionality , LONG DN functionality not tested
in full fledged.

-AVM


On 8/18/2016 12:48 PM, Hoang Vo wrote:
> Summary: CKPT: Support DNs longer than 255 bytes {#1574}
> Review request for Trac Ticket(s): 1574
> Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
> Pull request to: mahesh.va...@oracle.com
> Affected branch(es): default
> Development branch: default
>
> 
> Impacted area   Impact y/n
> 
>   Docsn
>   Build systemn
>   RPM/packaging   n
>   Configuration files n
>   Startup scripts n
>   SAF servicesy
>   OpenSAF servicesn
>   Core libraries  n
>   Samples n
>   Tests   n
>   Other   n
>
>
> Comments (indicate scope for each "y" above):
> -
>
> changeset 05233bdae1fb000fea001964eba1c51ebf3bfd8e
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpd: Add support for extended SaNameT [#1574] v3
>
> changeset cecabec5b6be73e731e540fd439e1d0e3534809f
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpnd: Add support for extended SaNameT [#1574] v3
>
> changeset 940dc877c94a9539e3da06d89c6480ef7e0ceda0
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpa: Add support for extended SaNameT [#1574] v1
>
> changeset 1f74531a36163bdfecd6b27174443d51c11ecf61
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpsv: Add new message to support extended SaNameT [#1574] v3
>
> changeset 29df19302186b3275ad06db00dc62f275dea25e1
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpd: Add new mbcsv messages supporting extended SaNameT [#1574] v2
>
> changeset 3f72410a7c2bb077647bdd4e46869a31a832f1d8
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and 
> CPA
>   [#1574] v4
>
> changeset f32a0b3ca1ebf6049d2103e68e91d98bf086c48e
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   ckpt: Add new test cases to verify long DN feature on CPSV [#1574] v1
>
> changeset 1aa38b707cf2cec14c416631cfc7e5518b25735f
> Author:   Hoang Vo 
> Date: Thu, 18 Aug 2016 13:51:56 +0700
>
>   cpnd: add support for shm recovery for in-service update without 
> restarting
>   node [#1574] v1
>
>
> Complete diffstat:
> --
>   osaf/libs/agents/saf/cpa/Makefile.am  |1 +
>   osaf/libs/agents/saf/cpa/cpa_api.c|   48 --
>   osaf/libs/agents/saf/cpa/cpa_db.c |2 +
>   osaf/libs/agents/saf/cpa/cpa_mds.c|4 +-
>   osaf/libs/agents/saf/cpa/cpa_proc.c   |2 +-
>   osaf/libs/common/cpsv/cpsv_evt.c  |  440 
> ++---
>   osaf/libs/common/cpsv/include/cpa.h   |1 +
>   osaf/libs/common/cpsv/include/cpa_cb.h|2 +-
>   osaf/libs/common/cpsv/include/cpa_proc.h  |2 +-
>   osaf/libs/common/cpsv/include/cpd.h   |1 +
>   osaf/libs/common/cpsv/include/cpd_cb.h|   17 +-
>   osaf/libs/common/cpsv/include/cpd_imm.h   |4 +-
>   osaf/libs/common/cpsv/include/cpd_mem.h   |   25 +++-
>   osaf/libs/common/cpsv/include/cpd_proc.h  |2 +-
>   osaf/libs/common/cpsv/include/cpnd.h  |1 +
>   osaf/libs/common/cpsv/include/cpnd_cb.h   |5 +-
>   osaf/libs/common/cpsv/include/cpnd_init.h |3 +-
>   osaf/libs/common/cpsv/include/cpsv_evt.h  |   10 +
>   osaf/libs/common/cpsv/include/cpsv_shm.h  |   24 +++-
>   osaf/services/saf/cpsv/cpd/Makefile.am|1 +
>   osaf/services/saf/cpsv/cpd/cpd_amf.c  |7 +-
>   osaf/services/saf/cpsv/cpd/cpd_db.c   |   95 +++---
>   osaf/services/saf/cpsv/cpd/cpd_evt.c  |  103 ++-
>   osaf/services/saf/cpsv/cpd/cpd_imm.c  |  268 
> ++
>   osaf/services/saf/cpsv/cpd/cpd_main.c |7 +
>   osaf/services/saf/cpsv/cpd/cpd_mbcsv.c|   31 -
>   osaf/services/saf/cpsv/cpd/cpd_mds.c  |   84 -
>   osaf/services/saf/cpsv/cpd/cpd_proc.c |  180 
> ++--
>   osaf/services/saf/cpsv/cpd/cpd_red.c  |6 +-
>   osaf/services/saf/cpsv/cpd/cpd_sbevt.c|   57 +++-
>   osaf/services/saf/cpsv/cpnd/Makefile.am   |1 +
>   osaf/services/saf/cpsv/cpnd/cpnd_db.c |6 +-
>   osaf/services/saf/cpsv/cpnd/cpnd_evt.c|   73 ---
>   osaf/services/saf/cpsv/cpnd/cpnd_main.c   |7 +
>   osaf/services/saf/cpsv/cpnd/cpnd_mds.c|   86

[devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

2016-08-18 Thread Hoang Vo 
Summary: CKPT: Support DNs longer than 255 bytes {#1574}
Review request for Trac Ticket(s): 1574
Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
Pull request to: mahesh.va...@oracle.com
Affected branch(es): default
Development branch: default


Impacted area   Impact y/n

 Docsn
 Build systemn
 RPM/packaging   n
 Configuration files n
 Startup scripts n
 SAF servicesy
 OpenSAF servicesn
 Core libraries  n
 Samples n
 Tests   n
 Other   n


Comments (indicate scope for each "y" above):
-

changeset 05233bdae1fb000fea001964eba1c51ebf3bfd8e
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpd: Add support for extended SaNameT [#1574] v3

changeset cecabec5b6be73e731e540fd439e1d0e3534809f
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpnd: Add support for extended SaNameT [#1574] v3

changeset 940dc877c94a9539e3da06d89c6480ef7e0ceda0
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpa: Add support for extended SaNameT [#1574] v1

changeset 1f74531a36163bdfecd6b27174443d51c11ecf61
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpsv: Add new message to support extended SaNameT [#1574] v3

changeset 29df19302186b3275ad06db00dc62f275dea25e1
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpd: Add new mbcsv messages supporting extended SaNameT [#1574] v2

changeset 3f72410a7c2bb077647bdd4e46869a31a832f1d8
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and 
CPA
[#1574] v4

changeset f32a0b3ca1ebf6049d2103e68e91d98bf086c48e
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

ckpt: Add new test cases to verify long DN feature on CPSV [#1574] v1

changeset 1aa38b707cf2cec14c416631cfc7e5518b25735f
Author: Hoang Vo 
Date:   Thu, 18 Aug 2016 13:51:56 +0700

cpnd: add support for shm recovery for in-service update without 
restarting
node [#1574] v1


Complete diffstat:
--
 osaf/libs/agents/saf/cpa/Makefile.am  |1 +
 osaf/libs/agents/saf/cpa/cpa_api.c|   48 --
 osaf/libs/agents/saf/cpa/cpa_db.c |2 +
 osaf/libs/agents/saf/cpa/cpa_mds.c|4 +-
 osaf/libs/agents/saf/cpa/cpa_proc.c   |2 +-
 osaf/libs/common/cpsv/cpsv_evt.c  |  440 
++---
 osaf/libs/common/cpsv/include/cpa.h   |1 +
 osaf/libs/common/cpsv/include/cpa_cb.h|2 +-
 osaf/libs/common/cpsv/include/cpa_proc.h  |2 +-
 osaf/libs/common/cpsv/include/cpd.h   |1 +
 osaf/libs/common/cpsv/include/cpd_cb.h|   17 +-
 osaf/libs/common/cpsv/include/cpd_imm.h   |4 +-
 osaf/libs/common/cpsv/include/cpd_mem.h   |   25 +++-
 osaf/libs/common/cpsv/include/cpd_proc.h  |2 +-
 osaf/libs/common/cpsv/include/cpnd.h  |1 +
 osaf/libs/common/cpsv/include/cpnd_cb.h   |5 +-
 osaf/libs/common/cpsv/include/cpnd_init.h |3 +-
 osaf/libs/common/cpsv/include/cpsv_evt.h  |   10 +
 osaf/libs/common/cpsv/include/cpsv_shm.h  |   24 +++-
 osaf/services/saf/cpsv/cpd/Makefile.am|1 +
 osaf/services/saf/cpsv/cpd/cpd_amf.c  |7 +-
 osaf/services/saf/cpsv/cpd/cpd_db.c   |   95 +++---
 osaf/services/saf/cpsv/cpd/cpd_evt.c  |  103 ++-
 osaf/services/saf/cpsv/cpd/cpd_imm.c  |  268 
++
 osaf/services/saf/cpsv/cpd/cpd_main.c |7 +
 osaf/services/saf/cpsv/cpd/cpd_mbcsv.c|   31 -
 osaf/services/saf/cpsv/cpd/cpd_mds.c  |   84 -
 osaf/services/saf/cpsv/cpd/cpd_proc.c |  180 ++--
 osaf/services/saf/cpsv/cpd/cpd_red.c  |6 +-
 osaf/services/saf/cpsv/cpd/cpd_sbevt.c|   57 +++-
 osaf/services/saf/cpsv/cpnd/Makefile.am   |1 +
 osaf/services/saf/cpsv/cpnd/cpnd_db.c |6 +-
 osaf/services/saf/cpsv/cpnd/cpnd_evt.c|   73 ---
 osaf/services/saf/cpsv/cpnd/cpnd_main.c   |7 +
 osaf/services/saf/cpsv/cpnd/cpnd_mds.c|   86 -
 osaf/services/saf/cpsv/cpnd/cpnd_proc.c   |   84 +---
 osaf/services/saf/cpsv/cpnd/cpnd_res.c|  823 
++
 tests/cpsv/Makefile.am|1 +
 tests/cpsv/test_cpa.c |  180 -
 tests/cpsv/test_cpa_util.c|   16 ++-