Re: [devel] [PATCH 0 of 3] Review Request for imm: add support for configurable OI callback timeout [#16]
Hi Neelakanta,
Find comments inline
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 15 maj 2014 17:14
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 3] Review Request for imm: add support for
configurable OI callback timeout [#16]
Hi zoran,
comments inline.
/Neel.
On Thursday 15 May 2014 08:09 PM, Zoran Milinkovic wrote:
Hi Neelakanta,
Find my answers inline.
Best regards,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 15 maj 2014 11:49
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 3] Review Request for imm: add support for
configurable OI callback timeout [#16]
Hi zoran,
Following are the comments:
1. The patch is not compatible at upgrade.
Eg: If one node having new release and other node having older release, then
following is the errors:
osafimmnd[15258]: ER Illegal IMMND message type:97
osafimmnd[15258]: ER Edu decode Failed
osafimmnd[15258]: ER PROBLEM 2 WITH msg no:1810
osafimmnd[15258]: NO Ccb 2 ABORTED (immcfg_Slot-3_377)
osafimmnd[15258]: WA ccb id 2 missing or terminated
osafimmnd[15258]: WA discardImplementer: Implementer 16 is missing -
ignoring
[Zoran] This is expected behavior. You are testing an application that uses
IMM A.2.14, and new features will not work in earlier IMM versions. If you
set IMM version to a version as the lowest IMM version is in the cluster, I'm
sure that your application will work.
At upgrade, case there may be application using A.2.14, when all nodes are not
yet upgraded fully
[Zoran] I will implement support for 4.5, when #842 is pushed. Then I'll send a
new source code for the review.
And here Ccb2 is applyed in other node with this patch.
[Zoran] This is something I need to talk to Anders when he comes back from
vacation.
will wait for andersBj comments.
I see similar behavior only if I test a cluster with different OpenSAF
versions.
2. The PBE timeout should not be the implementer timeout.
There should be separate variable somewhere either in immnd.conf or in
immpbed which can be set the PBE OI timer.
[Zoran] This is a good point. PBE should be excluded from #16, and should
work as it works today. When I push the code, I'll change a line in
saImmOiImplementerSet (imm_oi_api.c):
if(cl_node-isImmA2e cl_node-oiTimeout) { ... to...
if(cl_node-isImmA2e !cl_node-isPbe cl_node-oiTimeout) {
Here i am talking about at IMMND server side, the timeout should be
DEFAULT_TIMEOUT , until IMMPBE OI explicitly sets the timeout.
if((*i3)-mPbeRestartId) {
LOG_WA(Ccb: %u in critical state when PBE
restarted, (*i3)-mId);
ccbsStuck=1;
-} else if(now - (*i3)-mWaitStartTime =
(DEFAULT_TIMEOUT_SEC + addSecs)){
+} else if(now - (*i3)-mWaitStartTime =
(max_oi_timeout + addSecs)){
[Zoran] This is a very good catch that I didn't see it in the beginning, and
it's a bit tricky to find it. I will change this code in the new code review.
3. If the Implementerset has set timeout to 8. For the second run the
application decides to change it to 10.
The second run timeout is not reflected because, class already has class
implementer.
[Zoran] This works for me.
Can you provide more details how you tested this case ?
I came across this scenario when the following steps are followed:
a. create config class with rt attribute
b. create the object for the above class.
c. implementer which implements SaImmOiRtAttrUpdateCallbackT
In the SaImmOiRtAttrUpdateCallbackT sleep for more than OI
callback timeout.
d. export IMMA_OI_CALLBACK_TIMEOUT=6. date;immlist object_name;date
see timeout as 6 seconds for acessorget
e. export IMMA_OI_CALLBACK_TIMEOUT=8.
adjust timeout to OI callback timeout (in this case more than 8 sec)
date;immlist object_name;date
still, see timeout as 6 seconds for acessorget
[Zoran] This is still an issue for the discussion. It still works for me.
OI callback timeout is linked to OI handle. It's not clear what you meant for
second run... did you use the same OI handle when you changed the timeout ?
Best regards,
Zoran
NACK, until the comments are fixed.
/Neel.
On Thursday 08 May 2014 05:16 PM, Zoran Milinkovic wrote:
Summary: imm: add support for configurable OI callback timeout [#16]
Review request for Trac Ticket(s): 16 Peer Reviewer(s): Neelakanta,
Anders Pull request to: Zoran Affected branch(es): default(4.5)
Development branch: default(4.5)
Impacted area Impact y/n
Docsn
Build systemn
RPM/packaging n
Configuration files n
Startup scripts n
SAF servicesy
OpenSAF servicesn
Core libraries n
Samples
Re: [devel] [PATCH 0 of 3] Review Request for imm: add support for configurable OI callback timeout [#16]
Some comments below.
Zoran Milinkovic wrote:
Hi Neelakanta,
Find my answers inline.
Best regards,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 15 maj 2014 11:49
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 3] Review Request for imm: add support for
configurable OI callback timeout [#16]
Hi zoran,
Following are the comments:
1. The patch is not compatible at upgrade.
Eg: If one node having new release and other node having older release, then
following is the errors:
osafimmnd[15258]: ER Illegal IMMND message type:97
osafimmnd[15258]: ER Edu decode Failed
osafimmnd[15258]: ER PROBLEM 2 WITH msg no:1810
osafimmnd[15258]: NO Ccb 2 ABORTED (immcfg_Slot-3_377)
osafimmnd[15258]: WA ccb id 2 missing or terminated
osafimmnd[15258]: WA discardImplementer: Implementer 16 is missing - ignoring
[Zoran] This is expected behavior. You are testing an application that uses
IMM A.2.14, and new features will not work in earlier IMM versions. If you
set IMM version to a version as the lowest IMM version is in the cluster, I'm
sure that your application will work.
The upgrade needs to be supported by an upgrade flag for 4.5.
This is tracked by ticket #842.
http://sourceforge.net/p/opensaf/tickets/842/
And here Ccb2 is applyed in other node with this patch.
[Zoran] This is something I need to talk to Anders when he comes back from
vacation.
I see similar behavior only if I test a cluster with different OpenSAF
versions.
Yes the reason is that the implementer-set is not done at the old nodes
since they dont
recognize the new implementer-set message. So the old nmodes dont even
know they need
to wait for a reply from that implementer.
2. The PBE timeout should not be the implementer timeout.
There should be separate variable somewhere either in immnd.conf or in
immpbed which can be set the PBE OI timer.
In principle the PBE could use the same mechanism. Only if the PBE
process itself sets the environment variable would it be altered.
But the IMMND server gives special treatment for the PBE anyway.
[Currently the PBE does not define the variable so it should
get the default.]
[Zoran] This is a good point. PBE should be excluded from #16, and should
work as it works today. When I push the code, I'll change a line in
saImmOiImplementerSet (imm_oi_api.c):
if(cl_node-isImmA2e cl_node-oiTimeout) {
... to...
if(cl_node-isImmA2e !cl_node-isPbe cl_node-oiTimeout) {
That should also be ok.
3. If the Implementerset has set timeout to 8. For the second run the
application decides to change it to 10.
The second run timeout is not reflected because, class already has class
implementer.
Not sure what is meant by second run and application here.
The timeout would be linked to the OI and is associated with the OI
handle at the oi-client side.
Thus only if the OI closes its handle and re-initialize a new handle
could it set a new timeout that
reaches the server. The timeout is not linked to the class.
/AndersBj
[Zoran] This works for me.
Can you provide more details how you tested this case ?
NACK, until the comments are fixed.
/Neel.
On Thursday 08 May 2014 05:16 PM, Zoran Milinkovic wrote:
Summary: imm: add support for configurable OI callback timeout [#16]
Review request for Trac Ticket(s): 16 Peer Reviewer(s): Neelakanta,
Anders Pull request to: Zoran Affected branch(es): default(4.5)
Development branch: default(4.5)
Impacted area Impact y/n
Docsn
Build systemn
RPM/packaging n
Configuration files n
Startup scripts n
SAF servicesy
OpenSAF servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset da62b083125842a8e6b1437fdc6224b3f1e6720e
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date:Thu, 08 May 2014 13:40:11 +0200
imm: add support for configurable OI callback timeout [#16]
When an implementer is set, the configurable timeout is sent to IMM
service.
The configurable timeout is used for calculating timeouts for OI
callbacks
and waiting on search replies from RTA update callback.
changeset bcd50a218ba95178ea86735ff322b722bdf577f7
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date:Thu, 08 May 2014 13:27:07 +0200
imm: use IMMA_OI_CALLBACK_TIMEOUT for setting OI callback timeout
[#16]
IMMA uses IMMA_OI_CALLBACK_TIMEOUT for sending OI timeout to IMM service
using implementer set operations.
changeset d11cb26e44f7554d6b22476d874086044d22d624
Author: Zoran Milinkovic
Re: [devel] [PATCH 0 of 3] Review Request for imm: add support for configurable OI callback timeout [#16]
Hi zoran, Following are the comments: 1. The patch is not compatible at upgrade. Eg: If one node having new release and other node having older release, then following is the errors: osafimmnd[15258]: ER Illegal IMMND message type:97 osafimmnd[15258]: ER Edu decode Failed osafimmnd[15258]: ER PROBLEM 2 WITH msg no:1810 osafimmnd[15258]: NO Ccb 2 ABORTED (immcfg_Slot-3_377) osafimmnd[15258]: WA ccb id 2 missing or terminated osafimmnd[15258]: WA discardImplementer: Implementer 16 is missing - ignoring And here Ccb2 is applyed in other node with this patch. 2. The PBE timeout should not be the implementer timeout. There should be separate variable somewhere either in immnd.conf or in immpbed which can be set the PBE OI timer. 3. If the Implementerset has set timeout to 8. For the second run the application decides to change it to 10. The second run timeout is not reflected because, class already has class implementer. NACK, until the comments are fixed. /Neel. On Thursday 08 May 2014 05:16 PM, Zoran Milinkovic wrote: Summary: imm: add support for configurable OI callback timeout [#16] Review request for Trac Ticket(s): 16 Peer Reviewer(s): Neelakanta, Anders Pull request to: Zoran Affected branch(es): default(4.5) Development branch: default(4.5) Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each y above): - changeset da62b083125842a8e6b1437fdc6224b3f1e6720e Author: Zoran Milinkovic zoran.milinko...@ericsson.com Date: Thu, 08 May 2014 13:40:11 +0200 imm: add support for configurable OI callback timeout [#16] When an implementer is set, the configurable timeout is sent to IMM service. The configurable timeout is used for calculating timeouts for OI callbacks and waiting on search replies from RTA update callback. changeset bcd50a218ba95178ea86735ff322b722bdf577f7 Author: Zoran Milinkovic zoran.milinko...@ericsson.com Date: Thu, 08 May 2014 13:27:07 +0200 imm: use IMMA_OI_CALLBACK_TIMEOUT for setting OI callback timeout [#16] IMMA uses IMMA_OI_CALLBACK_TIMEOUT for sending OI timeout to IMM service using implementer set operations. changeset d11cb26e44f7554d6b22476d874086044d22d624 Author: Zoran Milinkovic zoran.milinko...@ericsson.com Date: Thu, 08 May 2014 13:41:57 +0200 immtests: add test cases for OI callback timeout [#16] Test cases cover OI callback timeout and timeout on searching for an object with RTA Complete diffstat: -- osaf/libs/agents/saf/imma/imma_cb.h |1 + osaf/libs/agents/saf/imma/imma_def.h |1 + osaf/libs/agents/saf/imma/imma_oi_api.c | 23 +++- osaf/libs/common/immsv/immsv_evt.c | 56 - osaf/libs/common/immsv/include/immsv_evt.h |4 ++ osaf/libs/common/immsv/include/immsv_evt_model.h |1 + osaf/services/saf/immsv/immd/immd_evt.c |9 - osaf/services/saf/immsv/immnd/ImmModel.cc| 89 +++-- osaf/services/saf/immsv/immnd/ImmModel.hh|6 ++- osaf/services/saf/immsv/immnd/immnd_evt.c| 38 --- osaf/services/saf/immsv/immnd/immnd_init.h |8 ++- tests/immsv/implementer/test_cleanup.c |1 + tests/immsv/implementer/test_saImmOiImplementerSet.c | 287 ++ 13 files changed, 487 insertions(+), 37 deletions(-) Testing Commands: - immoitest Testing, Expected Results: -- immoitest must pass all tests Conditions of Submission: - Ack from Neelakanta and Anders Arch Built StartedLinux distro --- mipsn n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and
Re: [devel] [PATCH 0 of 3] Review Request for imm: add support for configurable OI callback timeout [#16]
Hi Neelakanta,
Find my answers inline.
Best regards,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 15 maj 2014 11:49
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 3] Review Request for imm: add support for
configurable OI callback timeout [#16]
Hi zoran,
Following are the comments:
1. The patch is not compatible at upgrade.
Eg: If one node having new release and other node having older release, then
following is the errors:
osafimmnd[15258]: ER Illegal IMMND message type:97
osafimmnd[15258]: ER Edu decode Failed
osafimmnd[15258]: ER PROBLEM 2 WITH msg no:1810
osafimmnd[15258]: NO Ccb 2 ABORTED (immcfg_Slot-3_377)
osafimmnd[15258]: WA ccb id 2 missing or terminated
osafimmnd[15258]: WA discardImplementer: Implementer 16 is missing - ignoring
[Zoran] This is expected behavior. You are testing an application that uses IMM
A.2.14, and new features will not work in earlier IMM versions. If you set IMM
version to a version as the lowest IMM version is in the cluster, I'm sure that
your application will work.
And here Ccb2 is applyed in other node with this patch.
[Zoran] This is something I need to talk to Anders when he comes back from
vacation.
I see similar behavior only if I test a cluster with different OpenSAF versions.
2. The PBE timeout should not be the implementer timeout.
There should be separate variable somewhere either in immnd.conf or in immpbed
which can be set the PBE OI timer.
[Zoran] This is a good point. PBE should be excluded from #16, and should work
as it works today. When I push the code, I'll change a line in
saImmOiImplementerSet (imm_oi_api.c):
if(cl_node-isImmA2e cl_node-oiTimeout) {
... to...
if(cl_node-isImmA2e !cl_node-isPbe cl_node-oiTimeout) {
3. If the Implementerset has set timeout to 8. For the second run the
application decides to change it to 10.
The second run timeout is not reflected because, class already has class
implementer.
[Zoran] This works for me.
Can you provide more details how you tested this case ?
NACK, until the comments are fixed.
/Neel.
On Thursday 08 May 2014 05:16 PM, Zoran Milinkovic wrote:
Summary: imm: add support for configurable OI callback timeout [#16]
Review request for Trac Ticket(s): 16 Peer Reviewer(s): Neelakanta,
Anders Pull request to: Zoran Affected branch(es): default(4.5)
Development branch: default(4.5)
Impacted area Impact y/n
Docsn
Build systemn
RPM/packaging n
Configuration files n
Startup scripts n
SAF servicesy
OpenSAF servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset da62b083125842a8e6b1437fdc6224b3f1e6720e
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 08 May 2014 13:40:11 +0200
imm: add support for configurable OI callback timeout [#16]
When an implementer is set, the configurable timeout is sent to IMM
service.
The configurable timeout is used for calculating timeouts for OI
callbacks
and waiting on search replies from RTA update callback.
changeset bcd50a218ba95178ea86735ff322b722bdf577f7
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 08 May 2014 13:27:07 +0200
imm: use IMMA_OI_CALLBACK_TIMEOUT for setting OI callback timeout
[#16]
IMMA uses IMMA_OI_CALLBACK_TIMEOUT for sending OI timeout to IMM service
using implementer set operations.
changeset d11cb26e44f7554d6b22476d874086044d22d624
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date: Thu, 08 May 2014 13:41:57 +0200
immtests: add test cases for OI callback timeout [#16]
Test cases cover OI callback timeout and timeout on searching for an
object
with RTA
Complete diffstat:
--
osaf/libs/agents/saf/imma/imma_cb.h |1 +
osaf/libs/agents/saf/imma/imma_def.h |1 +
osaf/libs/agents/saf/imma/imma_oi_api.c | 23 +++-
osaf/libs/common/immsv/immsv_evt.c | 56
-
osaf/libs/common/immsv/include/immsv_evt.h |4 ++
osaf/libs/common/immsv/include/immsv_evt_model.h |1 +
osaf/services/saf/immsv/immd/immd_evt.c |9 -
osaf/services/saf/immsv/immnd/ImmModel.cc| 89
+++--
osaf/services/saf/immsv/immnd/ImmModel.hh|6 ++-
osaf/services/saf/immsv/immnd/immnd_evt.c| 38
---
osaf/services/saf/immsv/immnd/immnd_init.h |8 ++-
Re: [devel] [PATCH 0 of 3] Review Request for imm: add support for configurable OI callback timeout [#16]
Hi zoran,
comments inline.
/Neel.
On Thursday 15 May 2014 08:09 PM, Zoran Milinkovic wrote:
Hi Neelakanta,
Find my answers inline.
Best regards,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 15 maj 2014 11:49
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 3] Review Request for imm: add support for
configurable OI callback timeout [#16]
Hi zoran,
Following are the comments:
1. The patch is not compatible at upgrade.
Eg: If one node having new release and other node having older release, then
following is the errors:
osafimmnd[15258]: ER Illegal IMMND message type:97
osafimmnd[15258]: ER Edu decode Failed
osafimmnd[15258]: ER PROBLEM 2 WITH msg no:1810
osafimmnd[15258]: NO Ccb 2 ABORTED (immcfg_Slot-3_377)
osafimmnd[15258]: WA ccb id 2 missing or terminated
osafimmnd[15258]: WA discardImplementer: Implementer 16 is missing - ignoring
[Zoran] This is expected behavior. You are testing an application that uses
IMM A.2.14, and new features will not work in earlier IMM versions. If you
set IMM version to a version as the lowest IMM version is in the cluster, I'm
sure that your application will work.
At upgrade, case there may be application using A.2.14, when all nodes
are not yet upgraded fully
And here Ccb2 is applyed in other node with this patch.
[Zoran] This is something I need to talk to Anders when he comes back from
vacation.
will wait for andersBj comments.
I see similar behavior only if I test a cluster with different OpenSAF
versions.
2. The PBE timeout should not be the implementer timeout.
There should be separate variable somewhere either in immnd.conf or in
immpbed which can be set the PBE OI timer.
[Zoran] This is a good point. PBE should be excluded from #16, and should
work as it works today. When I push the code, I'll change a line in
saImmOiImplementerSet (imm_oi_api.c):
if(cl_node-isImmA2e cl_node-oiTimeout) {
... to...
if(cl_node-isImmA2e !cl_node-isPbe cl_node-oiTimeout) {
Here i am talking about at IMMND server side, the timeout should be
DEFAULT_TIMEOUT , until IMMPBE OI explicitly sets the timeout.
if((*i3)-mPbeRestartId) {
LOG_WA(Ccb: %u in critical state when PBE
restarted, (*i3)-mId);
ccbsStuck=1;
-} else if(now - (*i3)-mWaitStartTime =
(DEFAULT_TIMEOUT_SEC + addSecs)){
+} else if(now - (*i3)-mWaitStartTime =
(max_oi_timeout + addSecs)){
3. If the Implementerset has set timeout to 8. For the second run the
application decides to change it to 10.
The second run timeout is not reflected because, class already has class
implementer.
[Zoran] This works for me.
Can you provide more details how you tested this case ?
I came across this scenario when the following steps are followed:
a. create config class with rt attribute
b. create the object for the above class.
c. implementer which implements SaImmOiRtAttrUpdateCallbackT
In the SaImmOiRtAttrUpdateCallbackT sleep for more than OI
callback timeout.
d. export IMMA_OI_CALLBACK_TIMEOUT=6. date;immlist object_name;date
see timeout as 6 seconds for acessorget
e. export IMMA_OI_CALLBACK_TIMEOUT=8.
adjust timeout to OI callback timeout (in this case more than 8 sec)
date;immlist object_name;date
still, see timeout as 6 seconds for acessorget
NACK, until the comments are fixed.
/Neel.
On Thursday 08 May 2014 05:16 PM, Zoran Milinkovic wrote:
Summary: imm: add support for configurable OI callback timeout [#16]
Review request for Trac Ticket(s): 16 Peer Reviewer(s): Neelakanta,
Anders Pull request to: Zoran Affected branch(es): default(4.5)
Development branch: default(4.5)
Impacted area Impact y/n
Docsn
Build systemn
RPM/packaging n
Configuration files n
Startup scripts n
SAF servicesy
OpenSAF servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset da62b083125842a8e6b1437fdc6224b3f1e6720e
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date:Thu, 08 May 2014 13:40:11 +0200
imm: add support for configurable OI callback timeout [#16]
When an implementer is set, the configurable timeout is sent to IMM
service.
The configurable timeout is used for calculating timeouts for OI
callbacks
and waiting on search replies from RTA update callback.
changeset bcd50a218ba95178ea86735ff322b722bdf577f7
Author: Zoran Milinkovic zoran.milinko...@ericsson.com
Date:Thu, 08 May 2014 13:27:07 +0200
imm: use IMMA_OI_CALLBACK_TIMEOUT for setting OI
Re: [devel] [PATCH 0 of 3] Review Request for imm: add support for configurable OI callback timeout [#16]
Ack on these patches with the following comments: --- 1) In the imma client you have added: +#define IMMSV_OI_CALLBACK_WAIT_TIME 6 /* Default wait time for OI callback to reply in seconds = 6 sec*/ This default timeout is set in the client if the client has not explicitly defined IMMA_OI_CALLBACK_TIMEOUT. But this is redundant since the default is defined in the server (even before this fix). Another thing is that we want to be able in principle to change the default by changing it in ONE place. The natural place is the original place in the server, possibly at some point replaced by the configuration attribute in the existing SAF imm object mentionend in the ticket. The config attribute would then only control the default value and qould not override explicit client settings. WE dont want different clients getting different defaults depending on when they where compiled. IF the client has not explicitly defined IMMA_OI_CALLBACK_TIMEOUT then the implementer set should use the value 0 for the timeout in the message to the server and let the server do the defaulting according to todays (pre #16 fix) behavior. That is the behavior you still get when sending IMMND_EVT_A2ND_OI_IMPL_SET instead of IMMND_EVT_A2ND_OI_IMPL_SET_2. --- 2) I will update the immsv/README with a description of the new IMMA_OI_CALLBACK_TIMEOUT provided as an additional patch to this ticket. Tested with the new immoitest which is slooower since it is testing the oi-timeout setting mechanism. /AndersBj -Original Message- From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] Sent: den 8 maj 2014 13:46 To: reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 0 of 3] Review Request for imm: add support for configurable OI callback timeout [#16] Summary: imm: add support for configurable OI callback timeout [#16] Review request for Trac Ticket(s): 16 Peer Reviewer(s): Neelakanta, Anders Pull request to: Zoran Affected branch(es): default(4.5) Development branch: default(4.5) Impacted area Impact y/n Docsn Build systemn RPM/packaging n Configuration files n Startup scripts n SAF servicesy OpenSAF servicesn Core libraries n Samples n Tests n Other n Comments (indicate scope for each y above): - changeset da62b083125842a8e6b1437fdc6224b3f1e6720e Author: Zoran Milinkovic zoran.milinko...@ericsson.com Date: Thu, 08 May 2014 13:40:11 +0200 imm: add support for configurable OI callback timeout [#16] When an implementer is set, the configurable timeout is sent to IMM service. The configurable timeout is used for calculating timeouts for OI callbacks and waiting on search replies from RTA update callback. changeset bcd50a218ba95178ea86735ff322b722bdf577f7 Author: Zoran Milinkovic zoran.milinko...@ericsson.com Date: Thu, 08 May 2014 13:27:07 +0200 imm: use IMMA_OI_CALLBACK_TIMEOUT for setting OI callback timeout [#16] IMMA uses IMMA_OI_CALLBACK_TIMEOUT for sending OI timeout to IMM service using implementer set operations. changeset d11cb26e44f7554d6b22476d874086044d22d624 Author: Zoran Milinkovic zoran.milinko...@ericsson.com Date: Thu, 08 May 2014 13:41:57 +0200 immtests: add test cases for OI callback timeout [#16] Test cases cover OI callback timeout and timeout on searching for an object with RTA Complete diffstat: -- osaf/libs/agents/saf/imma/imma_cb.h |1 + osaf/libs/agents/saf/imma/imma_def.h |1 + osaf/libs/agents/saf/imma/imma_oi_api.c | 23 +++- osaf/libs/common/immsv/immsv_evt.c | 56 - osaf/libs/common/immsv/include/immsv_evt.h |4 ++ osaf/libs/common/immsv/include/immsv_evt_model.h |1 + osaf/services/saf/immsv/immd/immd_evt.c |9 - osaf/services/saf/immsv/immnd/ImmModel.cc| 89 +++-- osaf/services/saf/immsv/immnd/ImmModel.hh|6 ++- osaf/services/saf/immsv/immnd/immnd_evt.c| 38 --- osaf/services/saf/immsv/immnd/immnd_init.h |8 ++- tests/immsv/implementer/test_cleanup.c |1 + tests/immsv/implementer/test_saImmOiImplementerSet.c | 287 ++ 13 files changed, 487 insertions(+), 37 deletions(-) Testing Commands: - immoitest Testing, Expected Results: -- immoitest
