Coverity Scan: Analysis completed for openssl/openssl
Your request for analysis of openssl/openssl has been completed successfully. The results are available at https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoN-2BQSVjTtaSz8wS4wOr7HlekBtV1P4YRtWclMVkCdvAA-3D-3DbuB8_MulOTlHne1IxTRELXXnGni8d68xSVF-2BUCe3a7Ux-2BjeGfxS5FDf4gqISt4DWxo92CuNWlJpis8xXgqGsv4W6yWF0mePikTRwywZIypSKRCuQ96aCVXayA5-2FGNN6juPb9GohznW4Q500pGkbW6xDnj3PXS7g2i6EDjIagCm78FF0syfyQtey7JZ4r9040RgCqVYGxv0oFw0MuJHZni1ssu3KnanIZ07Y7kJn9lsJUMjbw-3D Build ID: 470018 Analysis Summary: New defects found: 0 Defects eliminated: 0
[openssl/openssl] c34e78: x509_lu.c and x509_vfy.c: improve coding style, co...
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: c34e78766f9f89831d7ed684e411091bf7bfd3e7 https://github.com/openssl/openssl/commit/c34e78766f9f89831d7ed684e411091bf7bfd3e7 Author: Dr. David von Oheimb Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M crypto/x509/x509_lu.c M crypto/x509/x509_vfy.c M doc/man3/X509_STORE_CTX_new.pod M doc/man3/X509_STORE_add_cert.pod M doc/man3/X509_STORE_get0_param.pod M doc/man3/X509_STORE_new.pod M doc/man3/X509_STORE_set_verify_cb_func.pod M include/openssl/x509_vfy.h.in Log Message: --- x509_lu.c and x509_vfy.c: improve coding style, comments, and related doc Reviewed-by: Tomas Mraz Reviewed-by: Hugo Landau Reviewed-by: David von Oheimb (Merged from https://github.com/openssl/openssl/pull/18840)
[openssl/openssl] c34e78: x509_lu.c and x509_vfy.c: improve coding style, co...
Branch: refs/heads/master Home: https://github.openssl.org/openssl/openssl Commit: c34e78766f9f89831d7ed684e411091bf7bfd3e7 https://github.openssl.org/openssl/openssl/commit/c34e78766f9f89831d7ed684e411091bf7bfd3e7 Author: Dr. David von Oheimb Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M crypto/x509/x509_lu.c M crypto/x509/x509_vfy.c M doc/man3/X509_STORE_CTX_new.pod M doc/man3/X509_STORE_add_cert.pod M doc/man3/X509_STORE_get0_param.pod M doc/man3/X509_STORE_new.pod M doc/man3/X509_STORE_set_verify_cb_func.pod M include/openssl/x509_vfy.h.in Log Message: --- x509_lu.c and x509_vfy.c: improve coding style, comments, and related doc Reviewed-by: Tomas Mraz Reviewed-by: Hugo Landau Reviewed-by: David von Oheimb (Merged from https://github.com/openssl/openssl/pull/18840)
[openssl/openssl] affc07: s390x: Optimize kmac
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: affc070aabc930aeaba50f0dd6b3e0b7a2ddc399 https://github.com/openssl/openssl/commit/affc070aabc930aeaba50f0dd6b3e0b7a2ddc399 Author: Juergen Christ Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M providers/implementations/digests/sha3_prov.c Log Message: --- s390x: Optimize kmac Use hardware acceleration for kmac on s390x. Since klmd does not support kmac, perform padding of the last block by hand and use kimd. Yields a performance improvement of between 2x and 3x. Signed-off-by: Juergen Christ Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/18863)
[openssl/openssl] 625849: Fix visual glitch in non-verbose test output
Branch: refs/heads/openssl-3.0 Home: https://github.com/openssl/openssl Commit: 625849ef3834d66d59559648420e4506cb1f3671 https://github.com/openssl/openssl/commit/625849ef3834d66d59559648420e4506cb1f3671 Author: Bernd Edlinger Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M test/recipes/80-test_cmp_http.t Log Message: --- Fix visual glitch in non-verbose test output This fixes a glitch in the non-verbose test output $ make test [...] 80-test_ciphername.t ok 80-test_cmp_http.t .. 5/? 80-test_cmp_http.t .. ok 611 80-test_cms.t ... ok 80-test_cmsapi.t ok Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/18401) (cherry picked from commit 128d1c3c0a12fe68175a460e06daf1e0d940f681) Commit: 497893dfe05d63c24624c3743fc162e2c759f822 https://github.com/openssl/openssl/commit/497893dfe05d63c24624c3743fc162e2c759f822 Author: Dr. David von Oheimb Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M test/recipes/80-test_cmp_http.t Log Message: --- 80-test_cmp_http.t: fix adaption of plan on 'certstatus' aspect of Mock server Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz Reviewed-by: David von Oheimb (Merged from https://github.com/openssl/openssl/pull/18858) (cherry picked from commit 7a86cb69830bf0a8845cd17e606f612109c7564b) Compare: https://github.com/openssl/openssl/compare/bac5b7405b08...497893dfe05d
[openssl/openssl] affc07: s390x: Optimize kmac
Branch: refs/heads/master Home: https://github.openssl.org/openssl/openssl Commit: affc070aabc930aeaba50f0dd6b3e0b7a2ddc399 https://github.openssl.org/openssl/openssl/commit/affc070aabc930aeaba50f0dd6b3e0b7a2ddc399 Author: Juergen Christ Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M providers/implementations/digests/sha3_prov.c Log Message: --- s390x: Optimize kmac Use hardware acceleration for kmac on s390x. Since klmd does not support kmac, perform padding of the last block by hand and use kimd. Yields a performance improvement of between 2x and 3x. Signed-off-by: Juergen Christ Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/18863)
[openssl/openssl] 497893: 80-test_cmp_http.t: fix adaption of plan on 'certs...
Branch: refs/heads/openssl-3.0 Home: https://github.openssl.org/openssl/openssl Commit: 497893dfe05d63c24624c3743fc162e2c759f822 https://github.openssl.org/openssl/openssl/commit/497893dfe05d63c24624c3743fc162e2c759f822 Author: Dr. David von Oheimb Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M test/recipes/80-test_cmp_http.t Log Message: --- 80-test_cmp_http.t: fix adaption of plan on 'certstatus' aspect of Mock server Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz Reviewed-by: David von Oheimb (Merged from https://github.com/openssl/openssl/pull/18858) (cherry picked from commit 7a86cb69830bf0a8845cd17e606f612109c7564b)
[openssl/openssl] 625849: Fix visual glitch in non-verbose test output
Branch: refs/heads/openssl-3.0 Home: https://github.openssl.org/openssl/openssl Commit: 625849ef3834d66d59559648420e4506cb1f3671 https://github.openssl.org/openssl/openssl/commit/625849ef3834d66d59559648420e4506cb1f3671 Author: Bernd Edlinger Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M test/recipes/80-test_cmp_http.t Log Message: --- Fix visual glitch in non-verbose test output This fixes a glitch in the non-verbose test output $ make test [...] 80-test_ciphername.t ok 80-test_cmp_http.t .. 5/? 80-test_cmp_http.t .. ok 611 80-test_cms.t ... ok 80-test_cmsapi.t ok Reviewed-by: Tomas Mraz Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/18401) (cherry picked from commit 128d1c3c0a12fe68175a460e06daf1e0d940f681)
[openssl/openssl] 7a86cb: 80-test_cmp_http.t: fix adaption of plan on 'certs...
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: 7a86cb69830bf0a8845cd17e606f612109c7564b https://github.com/openssl/openssl/commit/7a86cb69830bf0a8845cd17e606f612109c7564b Author: Dr. David von Oheimb Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M test/recipes/80-test_cmp_http.t Log Message: --- 80-test_cmp_http.t: fix adaption of plan on 'certstatus' aspect of Mock server Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz Reviewed-by: David von Oheimb (Merged from https://github.com/openssl/openssl/pull/18858)
[openssl/openssl] 7a86cb: 80-test_cmp_http.t: fix adaption of plan on 'certs...
Branch: refs/heads/master Home: https://github.openssl.org/openssl/openssl Commit: 7a86cb69830bf0a8845cd17e606f612109c7564b https://github.openssl.org/openssl/openssl/commit/7a86cb69830bf0a8845cd17e606f612109c7564b Author: Dr. David von Oheimb Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M test/recipes/80-test_cmp_http.t Log Message: --- 80-test_cmp_http.t: fix adaption of plan on 'certstatus' aspect of Mock server Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz Reviewed-by: David von Oheimb (Merged from https://github.com/openssl/openssl/pull/18858)
[openssl/openssl] bac5b7: Fix UWP builds by defining VirtualLock
Branch: refs/heads/openssl-3.0 Home: https://github.com/openssl/openssl Commit: bac5b7405b085d3926fdca80f221fa462dbe27e5 https://github.com/openssl/openssl/commit/bac5b7405b085d3926fdca80f221fa462dbe27e5 Author: Charles Milette Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M crypto/mem_sec.c Log Message: --- Fix UWP builds by defining VirtualLock Reviewed-by: Tomas Mraz Reviewed-by: Hugo Landau (Merged from https://github.com/openssl/openssl/pull/18311) (cherry picked from commit ff1efe6e261598c3f71727b796767a8e716bcbe2)
[openssl/openssl] ff1efe: Fix UWP builds by defining VirtualLock
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: ff1efe6e261598c3f71727b796767a8e716bcbe2 https://github.com/openssl/openssl/commit/ff1efe6e261598c3f71727b796767a8e716bcbe2 Author: Charles Milette Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M crypto/mem_sec.c Log Message: --- Fix UWP builds by defining VirtualLock Reviewed-by: Tomas Mraz Reviewed-by: Hugo Landau (Merged from https://github.com/openssl/openssl/pull/18311)
[openssl/openssl] bac5b7: Fix UWP builds by defining VirtualLock
Branch: refs/heads/openssl-3.0 Home: https://github.openssl.org/openssl/openssl Commit: bac5b7405b085d3926fdca80f221fa462dbe27e5 https://github.openssl.org/openssl/openssl/commit/bac5b7405b085d3926fdca80f221fa462dbe27e5 Author: Charles Milette Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M crypto/mem_sec.c Log Message: --- Fix UWP builds by defining VirtualLock Reviewed-by: Tomas Mraz Reviewed-by: Hugo Landau (Merged from https://github.com/openssl/openssl/pull/18311) (cherry picked from commit ff1efe6e261598c3f71727b796767a8e716bcbe2)
[openssl/openssl] 9c90a0: Configurations/10-main.conf: In the VC-common targ...
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: 9c90a0737b809048b56dfaa9e64b0a35d6609271 https://github.com/openssl/openssl/commit/9c90a0737b809048b56dfaa9e64b0a35d6609271 Author: Richard Levitte Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M Configurations/10-main.conf Log Message: --- Configurations/10-main.conf: In the VC-common target, unquote $(CC) Some of the VC-common attributes have values that use `$(CC)`, wrapped with quotes. However, `Configurations/windows-makefile.tmpl` already quotes the `CC` value, like this: CC="{- $config{CC} -}" The interaction between that makefile variable and the attributes using `$(CC)` wrapped with quotes is a command line with the quotes doubled. For example, the value of `$(CPP)` becomes `""cl""`. Strangely enough, this appears to be tolerated, at least on some versions of Windows. However, this has been reported not to be the case. This is fixed by removing the quotes in `Configurations/10-main.conf`, making `Configurations/windows-makefile.tmpl` responsible for proper quoting. Fixes #18823 Reviewed-by: Hugo Landau Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/18861) (cherry picked from commit c04b8819161de007cee831dd9e58dde52268da18)
[openssl/openssl] ff1efe: Fix UWP builds by defining VirtualLock
Branch: refs/heads/master Home: https://github.openssl.org/openssl/openssl Commit: ff1efe6e261598c3f71727b796767a8e716bcbe2 https://github.openssl.org/openssl/openssl/commit/ff1efe6e261598c3f71727b796767a8e716bcbe2 Author: Charles Milette Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M crypto/mem_sec.c Log Message: --- Fix UWP builds by defining VirtualLock Reviewed-by: Tomas Mraz Reviewed-by: Hugo Landau (Merged from https://github.com/openssl/openssl/pull/18311)
[openssl/openssl] c04b88: Configurations/10-main.conf: In the VC-common targ...
Branch: refs/heads/openssl-3.0 Home: https://github.com/openssl/openssl Commit: c04b8819161de007cee831dd9e58dde52268da18 https://github.com/openssl/openssl/commit/c04b8819161de007cee831dd9e58dde52268da18 Author: Richard Levitte Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M Configurations/10-main.conf Log Message: --- Configurations/10-main.conf: In the VC-common target, unquote $(CC) Some of the VC-common attributes have values that use `$(CC)`, wrapped with quotes. However, `Configurations/windows-makefile.tmpl` already quotes the `CC` value, like this: CC="{- $config{CC} -}" The interaction between that makefile variable and the attributes using `$(CC)` wrapped with quotes is a command line with the quotes doubled. For example, the value of `$(CPP)` becomes `""cl""`. Strangely enough, this appears to be tolerated, at least on some versions of Windows. However, this has been reported not to be the case. This is fixed by removing the quotes in `Configurations/10-main.conf`, making `Configurations/windows-makefile.tmpl` responsible for proper quoting. Fixes #18823 Reviewed-by: Hugo Landau Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/18861)
[openssl/openssl] 9c90a0: Configurations/10-main.conf: In the VC-common targ...
Branch: refs/heads/master Home: https://github.openssl.org/openssl/openssl Commit: 9c90a0737b809048b56dfaa9e64b0a35d6609271 https://github.openssl.org/openssl/openssl/commit/9c90a0737b809048b56dfaa9e64b0a35d6609271 Author: Richard Levitte Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M Configurations/10-main.conf Log Message: --- Configurations/10-main.conf: In the VC-common target, unquote $(CC) Some of the VC-common attributes have values that use `$(CC)`, wrapped with quotes. However, `Configurations/windows-makefile.tmpl` already quotes the `CC` value, like this: CC="{- $config{CC} -}" The interaction between that makefile variable and the attributes using `$(CC)` wrapped with quotes is a command line with the quotes doubled. For example, the value of `$(CPP)` becomes `""cl""`. Strangely enough, this appears to be tolerated, at least on some versions of Windows. However, this has been reported not to be the case. This is fixed by removing the quotes in `Configurations/10-main.conf`, making `Configurations/windows-makefile.tmpl` responsible for proper quoting. Fixes #18823 Reviewed-by: Hugo Landau Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/18861) (cherry picked from commit c04b8819161de007cee831dd9e58dde52268da18)
[openssl/openssl] c04b88: Configurations/10-main.conf: In the VC-common targ...
Branch: refs/heads/openssl-3.0 Home: https://github.openssl.org/openssl/openssl Commit: c04b8819161de007cee831dd9e58dde52268da18 https://github.openssl.org/openssl/openssl/commit/c04b8819161de007cee831dd9e58dde52268da18 Author: Richard Levitte Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M Configurations/10-main.conf Log Message: --- Configurations/10-main.conf: In the VC-common target, unquote $(CC) Some of the VC-common attributes have values that use `$(CC)`, wrapped with quotes. However, `Configurations/windows-makefile.tmpl` already quotes the `CC` value, like this: CC="{- $config{CC} -}" The interaction between that makefile variable and the attributes using `$(CC)` wrapped with quotes is a command line with the quotes doubled. For example, the value of `$(CPP)` becomes `""cl""`. Strangely enough, this appears to be tolerated, at least on some versions of Windows. However, this has been reported not to be the case. This is fixed by removing the quotes in `Configurations/10-main.conf`, making `Configurations/windows-makefile.tmpl` responsible for proper quoting. Fixes #18823 Reviewed-by: Hugo Landau Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/18861)
[openssl/openssl] 48e35b: s390x: Fix GCM setup
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: 48e35b99bd0071207cfe39da22eb2502db5c09dc https://github.com/openssl/openssl/commit/48e35b99bd0071207cfe39da22eb2502db5c09dc Author: Juergen Christ Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M crypto/modes/gcm128.c Log Message: --- s390x: Fix GCM setup Rework of GCM code did not include s390x causing NULL pointer dereferences on GCM operations other than AES-GCM on platforms that support kma. Fix this by a proper setup of the function pointers. Fixes: 92c9086e5c2b ("Use separate function to get GCM functions") Signed-off-by: Juergen Christ Reviewed-by: Paul Dale Reviewed-by: Hugo Landau (Merged from https://github.com/openssl/openssl/pull/18862)
[openssl/openssl] 48e35b: s390x: Fix GCM setup
Branch: refs/heads/master Home: https://github.openssl.org/openssl/openssl Commit: 48e35b99bd0071207cfe39da22eb2502db5c09dc https://github.openssl.org/openssl/openssl/commit/48e35b99bd0071207cfe39da22eb2502db5c09dc Author: Juergen Christ Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M crypto/modes/gcm128.c Log Message: --- s390x: Fix GCM setup Rework of GCM code did not include s390x causing NULL pointer dereferences on GCM operations other than AES-GCM on platforms that support kma. Fix this by a proper setup of the function pointers. Fixes: 92c9086e5c2b ("Use separate function to get GCM functions") Signed-off-by: Juergen Christ Reviewed-by: Paul Dale Reviewed-by: Hugo Landau (Merged from https://github.com/openssl/openssl/pull/18862)
[openssl/openssl] e544f3: Fix error in LHASH documentation
Branch: refs/heads/OpenSSL_1_1_1-stable Home: https://github.com/openssl/openssl Commit: e544f3ec8354db9e187ac5883cc20cb96e679a25 https://github.com/openssl/openssl/commit/e544f3ec8354db9e187ac5883cc20cb96e679a25 Author: Pauli Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M doc/man3/OPENSSL_LH_COMPFUNC.pod Log Message: --- Fix error in LHASH documentation Reviewed-by: Hugo Landau Reviewed-by: Shane Lontis (Merged from https://github.com/openssl/openssl/pull/18859) (cherry picked from commit 316fad64c1e541a530910a13160d48b7545ac1e0)
[openssl/openssl] ea66c8: Fix error in LHASH documentation
Branch: refs/heads/openssl-3.0 Home: https://github.com/openssl/openssl Commit: ea66c8d85a7104b9da9169e4130bd739215ea12d https://github.com/openssl/openssl/commit/ea66c8d85a7104b9da9169e4130bd739215ea12d Author: Pauli Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M doc/man3/OPENSSL_LH_COMPFUNC.pod Log Message: --- Fix error in LHASH documentation Reviewed-by: Hugo Landau Reviewed-by: Shane Lontis (Merged from https://github.com/openssl/openssl/pull/18859) (cherry picked from commit 316fad64c1e541a530910a13160d48b7545ac1e0)
[openssl/openssl] 316fad: Fix error in LHASH documentation
Branch: refs/heads/master Home: https://github.com/openssl/openssl Commit: 316fad64c1e541a530910a13160d48b7545ac1e0 https://github.com/openssl/openssl/commit/316fad64c1e541a530910a13160d48b7545ac1e0 Author: Pauli Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M doc/man3/OPENSSL_LH_COMPFUNC.pod Log Message: --- Fix error in LHASH documentation Reviewed-by: Hugo Landau Reviewed-by: Shane Lontis (Merged from https://github.com/openssl/openssl/pull/18859)
[openssl/openssl] e544f3: Fix error in LHASH documentation
Branch: refs/heads/OpenSSL_1_1_1-stable Home: https://github.openssl.org/openssl/openssl Commit: e544f3ec8354db9e187ac5883cc20cb96e679a25 https://github.openssl.org/openssl/openssl/commit/e544f3ec8354db9e187ac5883cc20cb96e679a25 Author: Pauli Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M doc/man3/OPENSSL_LH_COMPFUNC.pod Log Message: --- Fix error in LHASH documentation Reviewed-by: Hugo Landau Reviewed-by: Shane Lontis (Merged from https://github.com/openssl/openssl/pull/18859) (cherry picked from commit 316fad64c1e541a530910a13160d48b7545ac1e0)
[openssl/openssl] ea66c8: Fix error in LHASH documentation
Branch: refs/heads/openssl-3.0 Home: https://github.openssl.org/openssl/openssl Commit: ea66c8d85a7104b9da9169e4130bd739215ea12d https://github.openssl.org/openssl/openssl/commit/ea66c8d85a7104b9da9169e4130bd739215ea12d Author: Pauli Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M doc/man3/OPENSSL_LH_COMPFUNC.pod Log Message: --- Fix error in LHASH documentation Reviewed-by: Hugo Landau Reviewed-by: Shane Lontis (Merged from https://github.com/openssl/openssl/pull/18859) (cherry picked from commit 316fad64c1e541a530910a13160d48b7545ac1e0)
[openssl/openssl] 316fad: Fix error in LHASH documentation
Branch: refs/heads/master Home: https://github.openssl.org/openssl/openssl Commit: 316fad64c1e541a530910a13160d48b7545ac1e0 https://github.openssl.org/openssl/openssl/commit/316fad64c1e541a530910a13160d48b7545ac1e0 Author: Pauli Date: 2022-07-26 (Tue, 26 Jul 2022) Changed paths: M doc/man3/OPENSSL_LH_COMPFUNC.pod Log Message: --- Fix error in LHASH documentation Reviewed-by: Hugo Landau Reviewed-by: Shane Lontis (Merged from https://github.com/openssl/openssl/pull/18859)