Re: [openssl-project] External contributors and the next release
Am 07.03.2018 um 02:20 schrieb Salz, Rich: > > I think we should make sure to set aside time to review as many of the > non-project pull requests as possible. I think it is important to > show a commitment to the larger community. > > > > One way to do this is to say that we will extend the BETA date by a > week, and in that week no new code from the team, only third-party > existing pull requests will be considered > > Will there be an official announcement of the prolongation and/or an update to https://www.openssl.org/policies/releasestrat.html? Matthias ___ openssl-project mailing list openssl-project@openssl.org https://mta.openssl.org/mailman/listinfo/openssl-project
Re: [openssl-project] External contributors and the next release
> If you are blocked on review please drop a note (like the one you just > did) to the group. > Some of us review the specifically blocked things when such notes are > sent. > I will try hard to complete the documentation for the RAND_DRBG api until saturday. And I would be happy if #5461 and #5462 would make it into the beta release. I also agree that it is a good idea to look through the outstanding third party pull requests. Matthias ___ openssl-project mailing list openssl-project@openssl.org https://mta.openssl.org/mailman/listinfo/openssl-project
Re: [openssl-project] External contributors and the next release
In message <51cf9902-32af-4d08-82ec-6bca04af5...@akamai.com> on Wed, 7 Mar 2018 01:20:41 +, "Salz, Rich" said: rsalz> I think we should make sure to set aside time to review as many rsalz> of the non-project pull requests as possible. I think it is rsalz> important to show a commitment to the larger community. I agree. rsalz> One way to do this is to say that we will extend the BETA date rsalz> by a week, and in that week no new code from the team, only rsalz> third-party existing pull requests will be considered I like this idea. +1 -- Richard Levitte levi...@openssl.org OpenSSL Project http://www.openssl.org/~levitte/ ___ openssl-project mailing list openssl-project@openssl.org https://mta.openssl.org/mailman/listinfo/openssl-project
Re: [openssl-project] External contributors and the next release
> On Mar 6, 2018, at 11:40 PM, Benjamin Kaduk wrote: > >> One way to do this is to say that we will extend the BETA date by a week, >> and in that week no new code from the team, only third-party existing pull >> requests will be considered > > I'm open to extending the date, though am interested to see what we > can do if everybody chips in this week. (Though, I myself will only > be able to start on Friday, as my next couple days are fully > booked.) I would like to see my OCSP enhancement go through. Matt mostly finished reviewing it, and I addressed the various style issues. I won't be adding anything new, but would like to not have the pending PR excluded from consideration. And yes, reviewing more PRs makes sense. -- Viktor. ___ openssl-project mailing list openssl-project@openssl.org https://mta.openssl.org/mailman/listinfo/openssl-project
Re: [openssl-project] External contributors and the next release
On Wed, Mar 07, 2018 at 03:01:03PM +1000, Tim Hudson wrote: > If you are blocked on review please drop a note (like the one you just did) > to the group. > Some of us review the specifically blocked things when such notes are sent. > > #3082 is already closed and merged - did you mean another PR? Yup, I meant #3802, sorry. (tmshort is my team lead at work) > #3958 approved (in case Richard doesn't get back to it) > #1130 approved > #3958 approved Thanks! -Ben > Tim. > > > > On Wed, Mar 7, 2018 at 2:40 PM, Benjamin Kaduk wrote: > > > On Wed, Mar 07, 2018 at 01:20:41AM +, Salz, Rich wrote: > > > I think we should make sure to set aside time to review as many of the > > non-project pull requests as possible. I think it is important to show a > > commitment to the larger community. > > > > I agree. I started looking at this last week, when we had something > > like 170 open issues+pull requests for the 1.1.1 milestone. We > > still have 165, and that excludes a couple things that I would like > > to see get in but are not part of the milestone (like #3082 and > > #1130). I also have several changes open myself that are small and > > could easily go in, though none of them are especially critical. > > (Richard, could you reconfirm on #3958, though, please?) > > > > > One way to do this is to say that we will extend the BETA date by a > > week, and in that week no new code from the team, only third-party existing > > pull requests will be considered > > > > I'm open to extending the date, though am interested to see what we > > can do if everybody chips in this week. (Though, I myself will only > > be able to start on Friday, as my next couple days are fully > > booked.) > > > > -Ben > > ___ > > openssl-project mailing list > > openssl-project@openssl.org > > https://mta.openssl.org/mailman/listinfo/openssl-project > > > ___ > openssl-project mailing list > openssl-project@openssl.org > https://mta.openssl.org/mailman/listinfo/openssl-project ___ openssl-project mailing list openssl-project@openssl.org https://mta.openssl.org/mailman/listinfo/openssl-project
Re: [openssl-project] External contributors and the next release
If you are blocked on review please drop a note (like the one you just did) to the group. Some of us review the specifically blocked things when such notes are sent. #3082 is already closed and merged - did you mean another PR? #3958 approved (in case Richard doesn't get back to it) #1130 approved #3958 approved Tim. On Wed, Mar 7, 2018 at 2:40 PM, Benjamin Kaduk wrote: > On Wed, Mar 07, 2018 at 01:20:41AM +, Salz, Rich wrote: > > I think we should make sure to set aside time to review as many of the > non-project pull requests as possible. I think it is important to show a > commitment to the larger community. > > I agree. I started looking at this last week, when we had something > like 170 open issues+pull requests for the 1.1.1 milestone. We > still have 165, and that excludes a couple things that I would like > to see get in but are not part of the milestone (like #3082 and > #1130). I also have several changes open myself that are small and > could easily go in, though none of them are especially critical. > (Richard, could you reconfirm on #3958, though, please?) > > > One way to do this is to say that we will extend the BETA date by a > week, and in that week no new code from the team, only third-party existing > pull requests will be considered > > I'm open to extending the date, though am interested to see what we > can do if everybody chips in this week. (Though, I myself will only > be able to start on Friday, as my next couple days are fully > booked.) > > -Ben > ___ > openssl-project mailing list > openssl-project@openssl.org > https://mta.openssl.org/mailman/listinfo/openssl-project > ___ openssl-project mailing list openssl-project@openssl.org https://mta.openssl.org/mailman/listinfo/openssl-project
Re: [openssl-project] External contributors and the next release
On Wed, Mar 07, 2018 at 01:20:41AM +, Salz, Rich wrote: > I think we should make sure to set aside time to review as many of the > non-project pull requests as possible. I think it is important to show a > commitment to the larger community. I agree. I started looking at this last week, when we had something like 170 open issues+pull requests for the 1.1.1 milestone. We still have 165, and that excludes a couple things that I would like to see get in but are not part of the milestone (like #3082 and #1130). I also have several changes open myself that are small and could easily go in, though none of them are especially critical. (Richard, could you reconfirm on #3958, though, please?) > One way to do this is to say that we will extend the BETA date by a week, and > in that week no new code from the team, only third-party existing pull > requests will be considered I'm open to extending the date, though am interested to see what we can do if everybody chips in this week. (Though, I myself will only be able to start on Friday, as my next couple days are fully booked.) -Ben ___ openssl-project mailing list openssl-project@openssl.org https://mta.openssl.org/mailman/listinfo/openssl-project
[openssl-project] External contributors and the next release
I think we should make sure to set aside time to review as many of the non-project pull requests as possible. I think it is important to show a commitment to the larger community. One way to do this is to say that we will extend the BETA date by a week, and in that week no new code from the team, only third-party existing pull requests will be considered ___ openssl-project mailing list openssl-project@openssl.org https://mta.openssl.org/mailman/listinfo/openssl-project