Re: [openstack-dev] [Glance] Cores using -2 votes

2016-09-26 Thread Flavio Percoco 

On 23/09/16 10:12 -0500, Ian Cordasco wrote:

 

-Original Message-
From: Nikhil Komawar <nik.koma...@gmail.com>
Reply: Nikhil Komawar <nik.koma...@gmail.com>
Date: September 23, 2016 at 10:04:51
To: OpenStack Development Mailing List (not for usage questions) 
<openstack-dev@lists.openstack.org>
Cc: Ian Cordasco <sigmaviru...@gmail.com>
Subject:  Re: [openstack-dev] [Glance] Cores using -2 votes


thanks Ian, this is great info.

Just a side question, do you have example for -Workflow , say in cases
when I'd +2ed but to keep a check on process and approve after the
freeze -W'ed it?


So the important thing to keep in mind is that: "Code-Review", "Verified", and 
"Workflow" are all labels. And they all have different values (-2, -1, 0, +1, +2). So you could 
absolutely have a search for

    label:Code-Review=+2, AND label:Workflow=-1,



FWIW, back in the Mitaka cycle I created a dashboard that seemed to work well
for the release. I'll drop the link here in case you guys want to use it:

http://bit.ly/glance-dashboard

This link contains a section with patches "I've" -2'd. 


Hope this helps, let me know if the link still works (it seemed to work here 
and you need to be logged in),
Flavio

--
@flaper87
Flavio Percoco


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Glance] Cores using -2 votes

2016-09-23 Thread Nikhil Komawar 
I empathize with you Erno. I think this is a case of sheer
mis-understanding and probably (I think) the mention of that instance /
situation in this email is only for referential purposes.


There are some critical deadlines one sub-set of people have to met and
there are other priorities other sub-set have. Co-ordination across
continents and low bandwidth conversations that do not necessarily
communicate the /intent/ every time results into such situations.


Let's /all/ move on and not regress on it. We do need improvement in the
process for /sure/ and I've already communicated my intentions with
rosmaita about them. You can expect something later next week as time
permits.



On 9/23/16 12:30 PM, Erno Kuvaja wrote:
> On Fri, Sep 23, 2016 at 3:42 PM, Ian Cordasco  wrote:
>> Hi all,
>>
>> A few weeks ago, there was a controversy in which a patch had been
>> -2'd until other concerns were resolved and then the core who used
>> their -2 powers disappeared and could not lift it after those concerns
>> had been resolved. This lead to a situation where the -2'd patch was
>> abandoned and then resubmitted with a new Change-Id so it could be
>> approved in time for a milestone.
>>
>> In chatting with some folks, it's become apparent that all of us
>> Glance cores need to keep a dashboard around of items that we've -2'd.
>>
>> The basic form of that is:
>>
>> https://review.openstack.org/#/q/reviewer:self+AND+label:code-review-2+AND+(project:openstack/glance+OR+project:openstack/glance_store+OR+project:openstack/python-glanceclient)
>>
>> Or the query in particular is:
>>
>> reviewer:self AND label:code-review-2 AND
>> (project:openstack/glance OR project:openstack/glance_store OR
>> project:openstack/python-glanceclient)
>>
>> That said, this will show any patch you have reviewed that has a -2 on
>> it. (This also ignores specs.)
>>
>> To find what *you* have -2'd, the query is a little bit different:
>>
>> label:code-review-2, AND
>> (project:openstack/glance OR project:openstack/glance_store OR
>> project:openstack/python-glanceclient)
>>
>> For example,
>>
>> label:code-review-2,sigmavirus24 AND (project:openstack/glance OR
>> project:openstack/glance_store OR
>> project:openstack/python-glanceclient)
>>
>> is my query.
>>
>> I think we would all appreciate it if as cores we could keep an eye on
>> our own -2's and keep them up-to-date.
>>
>> I suspect people here will want to ignore anything that was abandoned
>> so you can also do:
>>
>> label:code-review-2, AND -status:abandoned AND
>> (project:openstack/glance OR project:openstack/glance_store OR
>> project:openstack/python-glanceclient)
>>
>> Finally, if you use Gertty, you can use this query to do the same thing:
>>
>> label:Code-Review=-2, AND -status:abandoned AND
>> project:^openstack/.*glance.*
>>
>> Cheers,
>> --
>> Ian Cordasco
>>
>> __
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> Ok, as it's becoming clear that the one wrong assumption did not slip
> from people (as I originally did not want to point it out), lets
> clarify this.
>
> There is difference between "not being able to" as referred in the
> original mailchain and "not willing to before verifying as the issues
> were flagged and their corrections slipped under radar long time
> before". I actually followed up that situation daily basis and got
> online on my holidays to make sure those -2s were not left hanging
> there without reason. That was the cause of the frustration and
> initial e-mail. Yes, it's important to track -2s, it's equally
> important to not assume it's not relevant just because you happen to
> think someone has addressed the reason for it.
>
> No bad feelings,
> Erno "jokke" Kuvaja
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>


-- 

Thanks,
Nikhil



__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Glance] Cores using -2 votes

2016-09-23 Thread Ian Cordasco 
 

-Original Message-
From: Erno Kuvaja <ekuv...@redhat.com>
Reply: OpenStack Development Mailing List (not for usage questions) 
<openstack-dev@lists.openstack.org>
Date: September 23, 2016 at 11:33:46
To: OpenStack Development Mailing List (not for usage questions) 
<openstack-dev@lists.openstack.org>
Subject:  Re: [openstack-dev] [Glance] Cores using -2 votes

> Ok, as it's becoming clear that the one wrong assumption did not slip
> from people (as I originally did not want to point it out), lets
> clarify this.
>  
> There is difference between "not being able to" as referred in the
> original mailchain and "not willing to before verifying as the issues
> were flagged and their corrections slipped under radar long time
> before". I actually followed up that situation daily basis and got
> online on my holidays to make sure those -2s were not left hanging
> there without reason. That was the cause of the frustration and
> initial e-mail. Yes, it's important to track -2s, it's equally
> important to not assume it's not relevant just because you happen to
> think someone has addressed the reason for it.

Hey Erno,

That wasn't apparent from what I saw in those interactions. Thank you for 
clarifying.

To be entirely transparent, the reason I wrote this is because I kept 
forgetting to make these dashboards for myself and Brian asked me this morning 
on IRC to revisit a -2 I had left on a review. Since it was fresh in my mind, I 
thought I'd leave it here. Sorry I didn't include that originally.

--  
Ian Cordasco


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Glance] Cores using -2 votes

2016-09-23 Thread Ian Cordasco 
 

-Original Message-
From: Bashmakov, Alexander <alexander.bashma...@intel.com>
Reply: OpenStack Development Mailing List (not for usage questions) 
<openstack-dev@lists.openstack.org>
Date: September 23, 2016 at 11:08:55
To: OpenStack Development Mailing List (not for usage questions) 
<openstack-dev@lists.openstack.org>
Subject:  Re: [openstack-dev] [Glance] Cores using -2 votes

> These queries might be a good addition to the Glance dashboard in 
> https://github.com/openstack/gerrit-dash-creator  
> under the "Patches I -2'd" section: 
> https://github.com/openstack/gerrit-dash-creator/blob/master/dashboards/glance.dash#L33
>   

Heh, I didn't know that section existed there. I must not have updated my 
dashboard in a long time. I also wasn't aware "self" would work there as the 
Gerrit docs describe using a "group or individual name".

Thanks Alexander!

--  
Ian Cordasco


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Glance] Cores using -2 votes

2016-09-23 Thread Erno Kuvaja 
On Fri, Sep 23, 2016 at 3:42 PM, Ian Cordasco  wrote:
> Hi all,
>
> A few weeks ago, there was a controversy in which a patch had been
> -2'd until other concerns were resolved and then the core who used
> their -2 powers disappeared and could not lift it after those concerns
> had been resolved. This lead to a situation where the -2'd patch was
> abandoned and then resubmitted with a new Change-Id so it could be
> approved in time for a milestone.
>
> In chatting with some folks, it's become apparent that all of us
> Glance cores need to keep a dashboard around of items that we've -2'd.
>
> The basic form of that is:
>
> https://review.openstack.org/#/q/reviewer:self+AND+label:code-review-2+AND+(project:openstack/glance+OR+project:openstack/glance_store+OR+project:openstack/python-glanceclient)
>
> Or the query in particular is:
>
> reviewer:self AND label:code-review-2 AND
> (project:openstack/glance OR project:openstack/glance_store OR
> project:openstack/python-glanceclient)
>
> That said, this will show any patch you have reviewed that has a -2 on
> it. (This also ignores specs.)
>
> To find what *you* have -2'd, the query is a little bit different:
>
> label:code-review-2, AND
> (project:openstack/glance OR project:openstack/glance_store OR
> project:openstack/python-glanceclient)
>
> For example,
>
> label:code-review-2,sigmavirus24 AND (project:openstack/glance OR
> project:openstack/glance_store OR
> project:openstack/python-glanceclient)
>
> is my query.
>
> I think we would all appreciate it if as cores we could keep an eye on
> our own -2's and keep them up-to-date.
>
> I suspect people here will want to ignore anything that was abandoned
> so you can also do:
>
> label:code-review-2, AND -status:abandoned AND
> (project:openstack/glance OR project:openstack/glance_store OR
> project:openstack/python-glanceclient)
>
> Finally, if you use Gertty, you can use this query to do the same thing:
>
> label:Code-Review=-2, AND -status:abandoned AND
> project:^openstack/.*glance.*
>
> Cheers,
> --
> Ian Cordasco
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Ok, as it's becoming clear that the one wrong assumption did not slip
from people (as I originally did not want to point it out), lets
clarify this.

There is difference between "not being able to" as referred in the
original mailchain and "not willing to before verifying as the issues
were flagged and their corrections slipped under radar long time
before". I actually followed up that situation daily basis and got
online on my holidays to make sure those -2s were not left hanging
there without reason. That was the cause of the frustration and
initial e-mail. Yes, it's important to track -2s, it's equally
important to not assume it's not relevant just because you happen to
think someone has addressed the reason for it.

No bad feelings,
Erno "jokke" Kuvaja

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Glance] Cores using -2 votes

2016-09-23 Thread Bashmakov, Alexander 
These queries might be a good addition to the Glance dashboard in 
https://github.com/openstack/gerrit-dash-creator under the "Patches I -2'd" 
section: 
https://github.com/openstack/gerrit-dash-creator/blob/master/dashboards/glance.dash#L33

> -Original Message-
> From: Ian Cordasco [mailto:sigmaviru...@gmail.com]
> Sent: Friday, September 23, 2016 8:12 AM
> To: Nikhil Komawar <nik.koma...@gmail.com>; OpenStack Development
> Mailing List (not for usage questions) <openstack-dev@lists.openstack.org>
> Subject: Re: [openstack-dev] [Glance] Cores using -2 votes
> 
> 
> 
> -Original Message-
> From: Nikhil Komawar <nik.koma...@gmail.com>
> Reply: Nikhil Komawar <nik.koma...@gmail.com>
> Date: September 23, 2016 at 10:04:51
> To: OpenStack Development Mailing List (not for usage questions)
> <openstack-dev@lists.openstack.org>
> Cc: Ian Cordasco <sigmaviru...@gmail.com>
> Subject:  Re: [openstack-dev] [Glance] Cores using -2 votes
> 
> > thanks Ian, this is great info.
> >
> > Just a side question, do you have example for -Workflow , say in cases
> > when I'd +2ed but to keep a check on process and approve after the
> > freeze -W'ed it?
> 
> So the important thing to keep in mind is that: "Code-Review", "Verified",
> and "Workflow" are all labels. And they all have different values (-2, -1, 0, 
> +1,
> +2). So you could absolutely have a search for
> 
>     label:Code-Review=+2, AND label:Workflow=-1, name>
> 
> That could combine with other portions of the queries I wrote in my first
> email. :-)
> 
> Cheers,
> --
> Ian Cordasco
> 
> 
> __
> 
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-
> requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Glance] Cores using -2 votes

2016-09-23 Thread Ian Cordasco 
 

-Original Message-
From: Nikhil Komawar <nik.koma...@gmail.com>
Reply: Nikhil Komawar <nik.koma...@gmail.com>
Date: September 23, 2016 at 10:04:51
To: OpenStack Development Mailing List (not for usage questions) 
<openstack-dev@lists.openstack.org>
Cc: Ian Cordasco <sigmaviru...@gmail.com>
Subject:  Re: [openstack-dev] [Glance] Cores using -2 votes

> thanks Ian, this is great info.
>  
> Just a side question, do you have example for -Workflow , say in cases
> when I'd +2ed but to keep a check on process and approve after the
> freeze -W'ed it?

So the important thing to keep in mind is that: "Code-Review", "Verified", and 
"Workflow" are all labels. And they all have different values (-2, -1, 0, +1, 
+2). So you could absolutely have a search for

    label:Code-Review=+2, AND label:Workflow=-1,

That could combine with other portions of the queries I wrote in my first 
email. :-)

Cheers,
--  
Ian Cordasco


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [Glance] Cores using -2 votes

2016-09-23 Thread Nikhil Komawar 
thanks Ian, this is great info.

Just a side question, do you have example for -Workflow , say in cases
when I'd +2ed but to keep a check on process and approve after the
freeze -W'ed it?

Nonetheless, I have been using the labels and owner/reviewer/project
field to good advantage so would like to acknowledge what you have to
say -- again, this is very effective and I will too encourage folks to
use such a bookmark.

If you need more options for querying, please read up the gerrit docs
https://review.openstack.org/Documentation/user-search.html

On 9/23/16 10:42 AM, Ian Cordasco wrote:
> Hi all,
>
> A few weeks ago, there was a controversy in which a patch had been
> -2'd until other concerns were resolved and then the core who used
> their -2 powers disappeared and could not lift it after those concerns
> had been resolved. This lead to a situation where the -2'd patch was
> abandoned and then resubmitted with a new Change-Id so it could be
> approved in time for a milestone.
>
> In chatting with some folks, it's become apparent that all of us
> Glance cores need to keep a dashboard around of items that we've -2'd.
>
> The basic form of that is:
>
> https://review.openstack.org/#/q/reviewer:self+AND+label:code-review-2+AND+(project:openstack/glance+OR+project:openstack/glance_store+OR+project:openstack/python-glanceclient)
>
> Or the query in particular is:
>
> reviewer:self AND label:code-review-2 AND
> (project:openstack/glance OR project:openstack/glance_store OR
> project:openstack/python-glanceclient)
>
> That said, this will show any patch you have reviewed that has a -2 on
> it. (This also ignores specs.)
>
> To find what *you* have -2'd, the query is a little bit different:
>
> label:code-review-2, AND
> (project:openstack/glance OR project:openstack/glance_store OR
> project:openstack/python-glanceclient)
>
> For example,
>
> label:code-review-2,sigmavirus24 AND (project:openstack/glance OR
> project:openstack/glance_store OR
> project:openstack/python-glanceclient)
>
> is my query.
>
> I think we would all appreciate it if as cores we could keep an eye on
> our own -2's and keep them up-to-date.
>
> I suspect people here will want to ignore anything that was abandoned
> so you can also do:
>
> label:code-review-2, AND -status:abandoned AND
> (project:openstack/glance OR project:openstack/glance_store OR
> project:openstack/python-glanceclient)
>
> Finally, if you use Gertty, you can use this query to do the same thing:
>
> label:Code-Review=-2, AND -status:abandoned AND
> project:^openstack/.*glance.*
>
> Cheers,
> --
> Ian Cordasco
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

-- 

Thanks,
Nikhil


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [Glance] Cores using -2 votes

2016-09-23 Thread Ian Cordasco 
Hi all,

A few weeks ago, there was a controversy in which a patch had been
-2'd until other concerns were resolved and then the core who used
their -2 powers disappeared and could not lift it after those concerns
had been resolved. This lead to a situation where the -2'd patch was
abandoned and then resubmitted with a new Change-Id so it could be
approved in time for a milestone.

In chatting with some folks, it's become apparent that all of us
Glance cores need to keep a dashboard around of items that we've -2'd.

The basic form of that is:

https://review.openstack.org/#/q/reviewer:self+AND+label:code-review-2+AND+(project:openstack/glance+OR+project:openstack/glance_store+OR+project:openstack/python-glanceclient)

Or the query in particular is:

    reviewer:self AND label:code-review-2 AND
(project:openstack/glance OR project:openstack/glance_store OR
project:openstack/python-glanceclient)

That said, this will show any patch you have reviewed that has a -2 on
it. (This also ignores specs.)

To find what *you* have -2'd, the query is a little bit different:

    label:code-review-2, AND
(project:openstack/glance OR project:openstack/glance_store OR
project:openstack/python-glanceclient)

For example,

    label:code-review-2,sigmavirus24 AND (project:openstack/glance OR
project:openstack/glance_store OR
project:openstack/python-glanceclient)

is my query.

I think we would all appreciate it if as cores we could keep an eye on
our own -2's and keep them up-to-date.

I suspect people here will want to ignore anything that was abandoned
so you can also do:

    label:code-review-2, AND -status:abandoned AND
(project:openstack/glance OR project:openstack/glance_store OR
project:openstack/python-glanceclient)

Finally, if you use Gertty, you can use this query to do the same thing:

    label:Code-Review=-2, AND -status:abandoned AND
project:^openstack/.*glance.*

Cheers,
--
Ian Cordasco

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev