Re: [openstack-dev] [Horizon] dashboard-app split in horizon

2015-05-29 Thread Tripp, Travis S
Hi all,

I just added my 2 cents to a couple of these patches, but in my opinion all of 
the existing patches in gerrit for angular tests that were written as part of 
the launch instance effort should be finalized and merged prior to any further 
reorganization patches going through.

Creating a nice phased chain of patches is nice for seeing the steps, but as we 
saw earlier this week with a breakage, even with smaller steps the 
reorganization is making a lot of changes that require a lot of verification. I 
would be a lot more comfortable if we could get the outstanding test patches 
into the system.  I would like to see the tests passing at each stage of the 
reorganization to help avoid corner case breakages. Can we make a concerted 
effort to review those and get them in prior to more reorganization?

I realize file globbing, etc will make the listing of patches easier to do, but 
maybe the outstanding test patches should get a chain of dependencies to avoid 
merge conflicts themselves?

Thanks,
Travis

From: Richard Jones r1chardj0...@gmail.commailto:r1chardj0...@gmail.com
Reply-To: OpenStack List 
openstack-dev@lists.openstack.orgmailto:openstack-dev@lists.openstack.org
Date: Thursday, May 28, 2015 at 12:55 AM
To: OpenStack List 
openstack-dev@lists.openstack.orgmailto:openstack-dev@lists.openstack.org
Subject: Re: [openstack-dev] [Horizon] dashboard-app split in horizon

I have now submitted the patch to do the html shenanigans as a new step in the 
current ngReorg pipeline (inserted because it should fix a test failure popping 
up in the dashboard-app move final step).

https://review.openstack.org/#/c/186295/

Ryan's API reorg should probably depend on this patch also as that should fix 
*its* test failures also.

And before anyone says anything, no I'm not particularly thrilled about the new 
horizon/test/templates/base.html but frankly I'm not sure how else to make it 
work. We could probably cull the JS from that file though. I'm pretty sure none 
of the django unit tests exercise JS, and I believe Selenium works off a 
different interface (but I've run out of time today to investigate).


 Richard


On Thu, 28 May 2015 at 02:15 Thai Q Tran 
tqt...@us.ibm.commailto:tqt...@us.ibm.com wrote:
Yes Rob, you are correct. ToastService was something Cindy wrote to replace 
horizon.alert (aka messages). We can't remove it because legacy still uses it.

-Rob Cresswell (rcresswe) rcres...@cisco.commailto:rcres...@cisco.com 
wrote: -
To: OpenStack Development Mailing List (not for usage questions) 
openstack-dev@lists.openstack.orgmailto:openstack-dev@lists.openstack.org
From: Rob Cresswell (rcresswe) rcres...@cisco.commailto:rcres...@cisco.com
Date: 05/26/2015 11:29PM

Subject: Re: [openstack-dev] [Horizon] dashboard-app split in horizon

Went through the files myself and I concur. Most of these files define pieces 
specific to our implementation of the dashboard, so should be moved.

I’m not entirely sure on where _messages should sit. As we move forward, won’t 
that file just end up as a toast element and nothing more? Maybe I’m 
misinterpreting it, I’m not familiar with toastService.

Rob


From: Richard Jones r1chardj0...@gmail.commailto:r1chardj0...@gmail.com
Reply-To: OpenStack Development Mailing List (not for usage questions) 
openstack-dev@lists.openstack.orgmailto:openstack-dev@lists.openstack.org
Date: Tuesday, 26 May 2015 01:35
To: OpenStack Development Mailing List (not for usage questions) 
openstack-dev@lists.openstack.orgmailto:openstack-dev@lists.openstack.org
Cc: Johanson, Tyr H t...@hp.commailto:t...@hp.com
Subject: Re: [openstack-dev] [Horizon] dashboard-app split in horizon

As a follow-up to this [in the misguided hope that anyone will actually read 
this conversation with myself ;-)] I've started looking at the base.html split. 
At the summit last week, we agreed to:

1. move base.html over from the framework to the dashboard, and
2. move the _conf.html and _scripts.html over as well, since they configure the 
application (dashboard).

Upon starting the work it occurs to me that all of the other files referenced 
by base.html should also move. So, here's the complete list of base.html 
components and whether they should move over in my opinion:

- horizon/_custom_meta.html
  Yep, is an empty file in horizon, intended as an extension point in 
dashboard. The empty file (plus an added comment) should move.
  - horizon/_stylesheets.html
  Is just a dummy in horizon anyway, should move.
- horizon/_conf.html
  Yep, should move.
- horizon/client_side/_script_loader.html
  Looks to be a framework component not intended for override, so we should 
leave it there.
- horizon/_custom_head_js.html
  Yep, is an empty file in horizon, intended as an extension point in 
dashboard. Move, with a comment added.
- horizon/_header.html
  There is a basic implementation in framework but the real (used) 
implementation is in dashboard, so should move.
- horizon/_messages.html

Re: [openstack-dev] [Horizon] dashboard-app split in horizon

2015-05-28 Thread Richard Jones
I have now submitted the patch to do the html shenanigans as a new step in
the current ngReorg pipeline (inserted because it should fix a test failure
popping up in the dashboard-app move final step).

https://review.openstack.org/#/c/186295/

Ryan's API reorg should probably depend on this patch also as that should
fix *its* test failures also.

And before anyone says anything, no I'm not particularly thrilled about the
new horizon/test/templates/base.html but frankly I'm not sure how else to
make it work. We could probably cull the JS from that file though. I'm
pretty sure none of the django unit tests exercise JS, and I believe
Selenium works off a different interface (but I've run out of time today to
investigate).


 Richard


On Thu, 28 May 2015 at 02:15 Thai Q Tran tqt...@us.ibm.com wrote:

 Yes Rob, you are correct. ToastService was something Cindy wrote to
 replace horizon.alert (aka messages). We can't remove it because legacy
 still uses it.

 -Rob Cresswell (rcresswe) rcres...@cisco.com wrote: -
 To: OpenStack Development Mailing List (not for usage questions) 
 openstack-dev@lists.openstack.org
 From: Rob Cresswell (rcresswe) rcres...@cisco.com
 Date: 05/26/2015 11:29PM

 Subject: Re: [openstack-dev] [Horizon] dashboard-app split in horizon

 Went through the files myself and I concur. Most of these files define
 pieces specific to our implementation of the dashboard, so should be moved.

  I’m not entirely sure on where _messages should sit. As we move forward,
 won’t that file just end up as a toast element and nothing more? Maybe
 I’m misinterpreting it, I’m not familiar with toastService.

  Rob


   From: Richard Jones r1chardj0...@gmail.com
 Reply-To: OpenStack Development Mailing List (not for usage questions) 
 openstack-dev@lists.openstack.org
 Date: Tuesday, 26 May 2015 01:35
 To: OpenStack Development Mailing List (not for usage questions) 
 openstack-dev@lists.openstack.org
 Cc: Johanson, Tyr H t...@hp.com
 Subject: Re: [openstack-dev] [Horizon] dashboard-app split in horizon

   As a follow-up to this [in the misguided hope that anyone will actually
 read this conversation with myself ;-)] I've started looking at the
 base.html split. At the summit last week, we agreed to:

  1. move base.html over from the framework to the dashboard, and
 2. move the _conf.html and _scripts.html over as well, since they
 configure the application (dashboard).

  Upon starting the work it occurs to me that all of the other files
 referenced by base.html should also move. So, here's the complete list of
 base.html components and whether they should move over in my opinion:

  - horizon/_custom_meta.html
   Yep, is an empty file in horizon, intended as an extension point in
 dashboard. The empty file (plus an added comment) should move.
   - horizon/_stylesheets.html
   Is just a dummy in horizon anyway, should move.
 - horizon/_conf.html
   Yep, should move.
 - horizon/client_side/_script_loader.html
   Looks to be a framework component not intended for override, so we
 should leave it there.
 - horizon/_custom_head_js.html
Yep, is an empty file in horizon, intended as an extension point in
 dashboard. Move, with a comment added.
  - horizon/_header.html
   There is a basic implementation in framework but the real (used)
 implementation is in dashboard, so should move.
 - horizon/_messages.html
   This is a framework component, so I think should stay there. I'm not
 sure whether anyone would ever wish to override this. Also the bulk of it
 is probably going to be replaced by the toast implementation anyway...
 hmm...
 - horizon/common/_sidebar.html
   This is an overridable component that I think should move.
 - horizon/common/_page_header.html
   This is an overridable component that I think should move.
 - horizon/_scripts.html
Yep, should move.

  Thoughts, anyone who has read this far?


  Richard


 On Sat, 23 May 2015 at 11:46 Richard Jones r1chardj0...@gmail.com wrote:

  As part of the ongoing Horizon project code reorganisation, we today
 agreed to clean up the Horizon-the-Framework and OpenStack Dashboard
 separation issue by doing a couple of things:

  1. nuke (the recently-created) horizon dashboard-app by moving the
 angular app over to dashboard and the other contents to appropriate places
 (mostly under the heading of tech-debt :)
 2. move base.html, _conf.html and _scripts.html from horizon over to
 dashboard.

  Thanks to Cindy, Sean and Thai for the pair (er triple?) programming
 keeping me honest today.

  The first step is done and captured in several linked patches based off
 your leaf patch ngReorg - Create dashboard-app 
 https://review.openstack.org/#/c/184597/ (yes, I am nuking the thing
 created by your patch).

  I've not done the second step, but might find some time since I have 6
 hours to waste in LAX tomorrow.


   Richard


 __
 OpenStack Development Mailing List

Re: [openstack-dev] [Horizon] dashboard-app split in horizon

2015-05-27 Thread Thai Q Tran
Yes Rob, you are correct. ToastService was something Cindy wrote to replace horizon.alert (aka messages). We can't remove it because legacy still uses it.-"Rob Cresswell (rcresswe)" rcres...@cisco.com wrote: -To: "OpenStack Development Mailing List (not for usage questions)" openstack-dev@lists.openstack.orgFrom: "Rob Cresswell (rcresswe)" rcres...@cisco.comDate: 05/26/2015 11:29PMSubject: Re: [openstack-dev] [Horizon] dashboard-app split in horizon
Went through the files myself and I concur. Most of these files define pieces specific to our implementation of the dashboard, so should be moved.


Im not entirely sure on where _messages should sit. As we move forward, wont that file just end up as a toast element and nothing more? Maybe Im misinterpreting it, Im not familiar with toastService.


Rob


From: Richard Jones r1chardj0...@gmail.com
Reply-To: "OpenStack Development Mailing List (not for usage questions)" openstack-dev@lists.openstack.org
Date: Tuesday, 26 May 2015 01:35
To: "OpenStack Development Mailing List (not for usage questions)" openstack-dev@lists.openstack.org
Cc: "Johanson, Tyr H" t...@hp.com
Subject: Re: [openstack-dev] [Horizon] dashboard-app split in horizon

As a follow-up to this [in the misguided hope that anyone will actually read this conversation with myself ;-)] I've started looking at the base.html split. At the summit last week, we agreed to:


1. move base.html over from the framework to the dashboard, and
2. move the _conf.html and _scripts.html over as well, since they configure the application (dashboard).


Upon starting the work it occurs to me that all of the other files referenced by base.html should also move. So, here's the complete list of base.html components and whether they should move over in my opinion:


- horizon/_custom_meta.html
 Yep, is an empty file in horizon, intended as an extension point in dashboard. The empty file (plus an added comment) should move.
 - horizon/_stylesheets.html
 Is just a dummy in horizon anyway, should move.
- horizon/_conf.html
 Yep, should move.
- horizon/client_side/_script_loader.html
 Looks to be a framework component not intended for override, so we should leave it there.
- horizon/_custom_head_js.html

 Yep, is an empty file in horizon, intended as an extension point in dashboard. Move, with a comment added.

- horizon/_header.html
 There is a basic implementation in framework but the real (used) implementation is in dashboard, so should move.
- horizon/_messages.html
 This is a framework component, so I think should stay there. I'm not sure whether anyone would ever wish to override this. Also the bulk of it is probably going to be replaced by the toast implementation anyway... hmm...
- horizon/common/_sidebar.html
 This is an overridable component that I think should move.
-horizon/common/_page_header.html
 This is an overridable component that I think should move.
-horizon/_scripts.html

 Yep, should move.Thoughts, anyone who has read this far?
  Richard


On Sat, 23 May 2015 at 11:46 Richard Jones r1chardj0...@gmail.com wrote:


As part of the ongoing Horizon project code reorganisation, we today agreed to clean up the Horizon-the-Framework and OpenStack Dashboard separation issue by doing a couple of things:


1. nuke (the recently-created) horizon dashboard-app by moving the angular app over to dashboard and the other contents to appropriate places (mostly under the heading of "tech-debt" :)
2. move base.html, _conf.html and _scripts.html from horizon over to dashboard.


Thanks to Cindy, Sean and Thai for the pair (er triple?) programming keeping me honest today.


The first step is done and captured in several linked patches based off your leaf patch "ngReorg - Create dashboard-app" https://review.openstack.org/#/c/184597/ (yes, I am nuking
 the thing created by your patch).


I've not done the second step, but might find some time since I have 6 hours to waste in LAX tomorrow.


  Richard
__OpenStack Development Mailing List (not for usage questions)Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribehttp://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] dashboard-app split in horizon

2015-05-27 Thread Rob Cresswell (rcresswe)
Went through the files myself and I concur. Most of these files define pieces 
specific to our implementation of the dashboard, so should be moved.

I’m not entirely sure on where _messages should sit. As we move forward, won’t 
that file just end up as a toast element and nothing more? Maybe I’m 
misinterpreting it, I’m not familiar with toastService.

Rob


From: Richard Jones r1chardj0...@gmail.commailto:r1chardj0...@gmail.com
Reply-To: OpenStack Development Mailing List (not for usage questions) 
openstack-dev@lists.openstack.orgmailto:openstack-dev@lists.openstack.org
Date: Tuesday, 26 May 2015 01:35
To: OpenStack Development Mailing List (not for usage questions) 
openstack-dev@lists.openstack.orgmailto:openstack-dev@lists.openstack.org
Cc: Johanson, Tyr H t...@hp.commailto:t...@hp.com
Subject: Re: [openstack-dev] [Horizon] dashboard-app split in horizon

As a follow-up to this [in the misguided hope that anyone will actually read 
this conversation with myself ;-)] I've started looking at the base.html split. 
At the summit last week, we agreed to:

1. move base.html over from the framework to the dashboard, and
2. move the _conf.html and _scripts.html over as well, since they configure the 
application (dashboard).

Upon starting the work it occurs to me that all of the other files referenced 
by base.html should also move. So, here's the complete list of base.html 
components and whether they should move over in my opinion:

- horizon/_custom_meta.html
  Yep, is an empty file in horizon, intended as an extension point in 
dashboard. The empty file (plus an added comment) should move.
  - horizon/_stylesheets.html
  Is just a dummy in horizon anyway, should move.
- horizon/_conf.html
  Yep, should move.
- horizon/client_side/_script_loader.html
  Looks to be a framework component not intended for override, so we should 
leave it there.
- horizon/_custom_head_js.html
  Yep, is an empty file in horizon, intended as an extension point in 
dashboard. Move, with a comment added.
- horizon/_header.html
  There is a basic implementation in framework but the real (used) 
implementation is in dashboard, so should move.
- horizon/_messages.html
  This is a framework component, so I think should stay there. I'm not sure 
whether anyone would ever wish to override this. Also the bulk of it is 
probably going to be replaced by the toast implementation anyway... hmm...
- horizon/common/_sidebar.html
  This is an overridable component that I think should move.
- horizon/common/_page_header.html
  This is an overridable component that I think should move.
- horizon/_scripts.html
  Yep, should move.

Thoughts, anyone who has read this far?


Richard


On Sat, 23 May 2015 at 11:46 Richard Jones 
r1chardj0...@gmail.commailto:r1chardj0...@gmail.com wrote:
As part of the ongoing Horizon project code reorganisation, we today agreed to 
clean up the Horizon-the-Framework and OpenStack Dashboard separation issue by 
doing a couple of things:

1. nuke (the recently-created) horizon dashboard-app by moving the angular app 
over to dashboard and the other contents to appropriate places (mostly under 
the heading of tech-debt :)
2. move base.html, _conf.html and _scripts.html from horizon over to dashboard.

Thanks to Cindy, Sean and Thai for the pair (er triple?) programming keeping me 
honest today.

The first step is done and captured in several linked patches based off your 
leaf patch ngReorg - Create dashboard-app 
https://review.openstack.org/#/c/184597/ (yes, I am nuking the thing created 
by your patch).

I've not done the second step, but might find some time since I have 6 hours to 
waste in LAX tomorrow.


 Richard

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] dashboard-app split in horizon

2015-05-26 Thread David Lyle
On Mon, May 25, 2015 at 5:35 PM, Richard Jones r1chardj0...@gmail.com
wrote:

 As a follow-up to this [in the misguided hope that anyone will actually
 read this conversation with myself ;-)] I've started looking at the
 base.html split. At the summit last week, we agreed to:

 1. move base.html over from the framework to the dashboard, and
 2. move the _conf.html and _scripts.html over as well, since they
 configure the application (dashboard).

 Upon starting the work it occurs to me that all of the other files
 referenced by base.html should also move. So, here's the complete list of
 base.html components and whether they should move over in my opinion:

 - horizon/_custom_meta.html
   Yep, is an empty file in horizon, intended as an extension point in
 dashboard. The empty file (plus an added comment) should move.
   - horizon/_stylesheets.html
   Is just a dummy in horizon anyway, should move.
 - horizon/_conf.html
   Yep, should move.
 - horizon/client_side/_script_loader.html
   Looks to be a framework component not intended for override, so we
 should leave it there.
 - horizon/_custom_head_js.html
   Yep, is an empty file in horizon, intended as an extension point in
 dashboard. Move, with a comment added.
 - horizon/_header.html
   There is a basic implementation in framework but the real (used)
 implementation is in dashboard, so should move.
 - horizon/_messages.html
   This is a framework component, so I think should stay there. I'm not
 sure whether anyone would ever wish to override this. Also the bulk of it
 is probably going to be replaced by the toast implementation anyway...
 hmm...
 - horizon/common/_sidebar.html
   This is an overridable component that I think should move.
 - horizon/common/_page_header.html
   This is an overridable component that I think should move.
 - horizon/_scripts.html
   Yep, should move.

 Thoughts, anyone who has read this far?


 Richard


 On Sat, 23 May 2015 at 11:46 Richard Jones r1chardj0...@gmail.com wrote:

 As part of the ongoing Horizon project code reorganisation, we today
 agreed to clean up the Horizon-the-Framework and OpenStack Dashboard
 separation issue by doing a couple of things:

 1. nuke (the recently-created) horizon dashboard-app by moving the
 angular app over to dashboard and the other contents to appropriate places
 (mostly under the heading of tech-debt :)
 2. move base.html, _conf.html and _scripts.html from horizon over to
 dashboard.

 Thanks to Cindy, Sean and Thai for the pair (er triple?) programming
 keeping me honest today.

 The first step is done and captured in several linked patches based off
 your leaf patch ngReorg - Create dashboard-app 
 https://review.openstack.org/#/c/184597/ (yes, I am nuking the thing
 created by your patch).

 I've not done the second step, but might find some time since I have 6
 hours to waste in LAX tomorrow.


  Richard


 __
 OpenStack Development Mailing List (not for usage questions)
 Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
 http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


This all sounds reasonable to me. We have better extension mechanisms than
in the past so direct reuse of the horizon toolkit part is not necessary
and we have little interest in maintaining the horizon toolkit as a
generally reusable toolkit now. Moving the application pieces into
openstack_dashboard (the actual application) makes sense.

David
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] dashboard-app split in horizon

2015-05-26 Thread Thai Q Tran
Looks/sounds good, I started down this path a while ago and it never gained traction, so glad to see that it is finally moving along.-Richard Jones r1chardj0...@gmail.com wrote: -To: "OpenStack Development Mailing List (not for usage questions)" openstack-dev@lists.openstack.orgFrom: Richard Jones r1chardj0...@gmail.comDate: 05/25/2015 05:38PMCc: "Johanson, Tyr H" t...@hp.comSubject: Re: [openstack-dev] [Horizon] dashboard-app split in horizonAs a follow-up to this [in the misguided hope that anyone will actually read this conversation with myself ;-)] I've started looking at the base.html split. At the summit last week, we agreed to:1. move base.html over from the framework to the dashboard, and2. move the _conf.html and _scripts.html over as well, since they configure the application (dashboard).Upon starting the work it occurs to me that all of the other files referenced by base.html should also move. So, here's the complete list of base.html components and whether they should move over in my opinion:- horizon/_custom_meta.html Yep, is an empty file in horizon, intended as an extension point in dashboard. The empty file (plus an added comment) should move. - horizon/_stylesheets.html Is just a dummy in horizon anyway, should move.- horizon/_conf.html Yep, should move.- horizon/client_side/_script_loader.html Looks to be a framework component not intended for override, so we should leave it there.- horizon/_custom_head_js.html Yep, is an empty file in horizon, intended as an extension point in dashboard. Move, with a comment added.- horizon/_header.html There is a basic implementation in framework but the real (used) implementation is in dashboard, so should move.- horizon/_messages.html This is a framework component, so I think should stay there. I'm not sure whether anyone would ever wish to override this. Also the bulk of it is probably going to be replaced by the toast implementation anyway... hmm...- horizon/common/_sidebar.html This is an overridable component that I think should move.-horizon/common/_page_header.html This is an overridable component that I think should move.-horizon/_scripts.html Yep, should move.Thoughts, anyone who has read this far?  RichardOn Sat, 23 May 2015 at 11:46 Richard Jones r1chardj0...@gmail.com wrote:As part of the ongoing Horizon project code reorganisation, we today agreed to clean up the Horizon-the-Framework and OpenStack Dashboard separation issue by doing a couple of things:1. nuke (the recently-created) horizon dashboard-app by moving the angular app over to dashboard and the other contents to appropriate places (mostly under the heading of "tech-debt" :)2. move base.html, _conf.html and _scripts.html from horizon over to dashboard.Thanks to Cindy, Sean and Thai for the pair (er triple?) programming keeping me honest today.The first step is done and captured in several linked patches based off your leaf patch "ngReorg - Create dashboard-app" https://review.openstack.org/#/c/184597/ (yes, I am nuking the thing created by your patch).I've not done the second step, but might find some time since I have 6 hours to waste in LAX tomorrow.  Richard
__OpenStack Development Mailing List (not for usage questions)Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribehttp://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


Re: [openstack-dev] [Horizon] dashboard-app split in horizon

2015-05-25 Thread Richard Jones
As a follow-up to this [in the misguided hope that anyone will actually
read this conversation with myself ;-)] I've started looking at the
base.html split. At the summit last week, we agreed to:

1. move base.html over from the framework to the dashboard, and
2. move the _conf.html and _scripts.html over as well, since they configure
the application (dashboard).

Upon starting the work it occurs to me that all of the other files
referenced by base.html should also move. So, here's the complete list of
base.html components and whether they should move over in my opinion:

- horizon/_custom_meta.html
  Yep, is an empty file in horizon, intended as an extension point in
dashboard. The empty file (plus an added comment) should move.
  - horizon/_stylesheets.html
  Is just a dummy in horizon anyway, should move.
- horizon/_conf.html
  Yep, should move.
- horizon/client_side/_script_loader.html
  Looks to be a framework component not intended for override, so we should
leave it there.
- horizon/_custom_head_js.html
  Yep, is an empty file in horizon, intended as an extension point in
dashboard. Move, with a comment added.
- horizon/_header.html
  There is a basic implementation in framework but the real (used)
implementation is in dashboard, so should move.
- horizon/_messages.html
  This is a framework component, so I think should stay there. I'm not sure
whether anyone would ever wish to override this. Also the bulk of it is
probably going to be replaced by the toast implementation anyway... hmm...
- horizon/common/_sidebar.html
  This is an overridable component that I think should move.
- horizon/common/_page_header.html
  This is an overridable component that I think should move.
- horizon/_scripts.html
  Yep, should move.

Thoughts, anyone who has read this far?


Richard


On Sat, 23 May 2015 at 11:46 Richard Jones r1chardj0...@gmail.com wrote:

 As part of the ongoing Horizon project code reorganisation, we today
 agreed to clean up the Horizon-the-Framework and OpenStack Dashboard
 separation issue by doing a couple of things:

 1. nuke (the recently-created) horizon dashboard-app by moving the angular
 app over to dashboard and the other contents to appropriate places (mostly
 under the heading of tech-debt :)
 2. move base.html, _conf.html and _scripts.html from horizon over to
 dashboard.

 Thanks to Cindy, Sean and Thai for the pair (er triple?) programming
 keeping me honest today.

 The first step is done and captured in several linked patches based off
 your leaf patch ngReorg - Create dashboard-app 
 https://review.openstack.org/#/c/184597/ (yes, I am nuking the thing
 created by your patch).

 I've not done the second step, but might find some time since I have 6
 hours to waste in LAX tomorrow.


  Richard


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


[openstack-dev] [Horizon] dashboard-app split in horizon

2015-05-22 Thread Richard Jones
As part of the ongoing Horizon project code reorganisation, we today agreed
to clean up the Horizon-the-Framework and OpenStack Dashboard separation
issue by doing a couple of things:

1. nuke (the recently-created) horizon dashboard-app by moving the angular
app over to dashboard and the other contents to appropriate places (mostly
under the heading of tech-debt :)
2. move base.html, _conf.html and _scripts.html from horizon over to
dashboard.

Thanks to Cindy, Sean and Thai for the pair (er triple?) programming
keeping me honest today.

The first step is done and captured in several linked patches based off
your leaf patch ngReorg - Create dashboard-app 
https://review.openstack.org/#/c/184597/ (yes, I am nuking the thing
created by your patch).

I've not done the second step, but might find some time since I have 6
hours to waste in LAX tomorrow.


 Richard
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev