Re: [openstack-dev] [Ironic] review days
I wanted to take a moment first to thank all the reviewers who have been getting up early // staying late to join in these review sessions -- I believe they've been tremendously helpful in unblocking a lot of work over the last two weeks. Thanks!! I also want to remind folks that we have another one scheduled at the usual time tomorrow [*] and that this will be the last review jam before the sprint next week and the close of Icehouse-3. Cheers, Devananda * http://www.timeanddate.com/worldclock/fixedtime.html?iso=20140227T1600 ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Ironic] review days
8am PST mostly works for me (except Wednesdays ), so +1 to that. - romcheg On Feb 13, 2014, at 09:44 , Ghe Rivero ghe.riv...@gmail.com wrote: What time would work for you? How about Thursdays at 8am PST? Works for me! Ghe Rivero ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev signature.asc Description: Message signed with OpenPGP using GPGMail ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Ironic] review days
Hi again! I promise this will be a much shorter email than my last one ... :) I'd like to propose that we find regular day/time to have a recurring code jam. Here's what it looks like in my head: - we get at least three core reviewers together - as many non-core folks as show up are welcome, too - we tune out all distractions for a few hours - we pick a patch and all review it If the author is present, we iterate with the author, and review each revision they submit while we're all together. If the author is not present and there are only minor issues, we fix them up in a follow-on patch and land both at once. If neither of those are possible, we -1 it and move on. I think we could make very quick progress in our review queue this way. In particular, I want us to plow through the bug fixes that have been in Fix Proposed status for a while ... What do ya'll think of this idea? Useful or a doomed to fail? What time would work for you? How about Thursdays at 8am PST? Cheers, Devananda ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Ironic] review days
I think that's a nice idea. During the last two days using this approach we managed to find several problems in an important patch which is now waiting to be merged. I bet it would take much longer, if we didn't do that. How about picking a particular time every day for performing this kind of collaboration? - Roman On Feb 12, 2014, at 23:14 , Devananda van der Veen devananda@gmail.com wrote: Hi again! I promise this will be a much shorter email than my last one ... :) I'd like to propose that we find regular day/time to have a recurring code jam. Here's what it looks like in my head: - we get at least three core reviewers together - as many non-core folks as show up are welcome, too - we tune out all distractions for a few hours - we pick a patch and all review it If the author is present, we iterate with the author, and review each revision they submit while we're all together. If the author is not present and there are only minor issues, we fix them up in a follow-on patch and land both at once. If neither of those are possible, we -1 it and move on. I think we could make very quick progress in our review queue this way. In particular, I want us to plow through the bug fixes that have been in Fix Proposed status for a while ... What do ya'll think of this idea? Useful or a doomed to fail? What time would work for you? How about Thursdays at 8am PST? Cheers, Devananda ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev signature.asc Description: Message signed with OpenPGP using GPGMail ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Ironic] review days
Hi All, I like the idea! I'm comfortable to reserve about 3 hours for this, Thursdays 8am (4pm GMT +0) sounds good. I assume we'll pick and merge as much patches as possible during that time, and if the last one doesn't fit to the time - we're increasing the time until the patch merged (in reasonable limit). Makes sense? Best regards, Max Lobur, Python Developer, Mirantis, Inc. Mobile: +38 (093) 665 14 28 Skype: max_lobur 38, Lenina ave. Kharkov, Ukraine www.mirantis.com www.mirantis.ru On Wed, Feb 12, 2014 at 11:14 PM, Devananda van der Veen devananda@gmail.com wrote: Hi again! I promise this will be a much shorter email than my last one ... :) I'd like to propose that we find regular day/time to have a recurring code jam. Here's what it looks like in my head: - we get at least three core reviewers together - as many non-core folks as show up are welcome, too - we tune out all distractions for a few hours - we pick a patch and all review it If the author is present, we iterate with the author, and review each revision they submit while we're all together. If the author is not present and there are only minor issues, we fix them up in a follow-on patch and land both at once. If neither of those are possible, we -1 it and move on. I think we could make very quick progress in our review queue this way. In particular, I want us to plow through the bug fixes that have been in Fix Proposed status for a while ... What do ya'll think of this idea? Useful or a doomed to fail? What time would work for you? How about Thursdays at 8am PST? Cheers, Devananda ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Ironic] review days
+1 What time would work for you? How about Thursdays at 8am PST? Works for me ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Ironic] review days
Also, I think 3 hours might be too much, maybe to have 2 sessions of 2 hours. It might be hard to concentrate on review for 3 hours in a line.. Best regards, Max Lobur, Python Developer, Mirantis, Inc. Mobile: +38 (093) 665 14 28 Skype: max_lobur 38, Lenina ave. Kharkov, Ukraine www.mirantis.com www.mirantis.ru On Wed, Feb 12, 2014 at 11:32 PM, Maksym Lobur mlo...@mirantis.com wrote: Hi All, I like the idea! I'm comfortable to reserve about 3 hours for this, Thursdays 8am (4pm GMT +0) sounds good. I assume we'll pick and merge as much patches as possible during that time, and if the last one doesn't fit to the time - we're increasing the time until the patch merged (in reasonable limit). Makes sense? Best regards, Max Lobur, Python Developer, Mirantis, Inc. Mobile: +38 (093) 665 14 28 Skype: max_lobur 38, Lenina ave. Kharkov, Ukraine www.mirantis.com www.mirantis.ru On Wed, Feb 12, 2014 at 11:14 PM, Devananda van der Veen devananda@gmail.com wrote: Hi again! I promise this will be a much shorter email than my last one ... :) I'd like to propose that we find regular day/time to have a recurring code jam. Here's what it looks like in my head: - we get at least three core reviewers together - as many non-core folks as show up are welcome, too - we tune out all distractions for a few hours - we pick a patch and all review it If the author is present, we iterate with the author, and review each revision they submit while we're all together. If the author is not present and there are only minor issues, we fix them up in a follow-on patch and land both at once. If neither of those are possible, we -1 it and move on. I think we could make very quick progress in our review queue this way. In particular, I want us to plow through the bug fixes that have been in Fix Proposed status for a while ... What do ya'll think of this idea? Useful or a doomed to fail? What time would work for you? How about Thursdays at 8am PST? Cheers, Devananda ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Ironic] review days
Since there are two core-subteams located in different time zones I propose making two sessions: - One in the morning in Europe. Let's say at 10 GMT - One in the morning in the US at a convenient time. This approach might be useful for the submitters located in different time zones. - Roman On Feb 13, 2014, at 00:18 , Maksym Lobur mlo...@mirantis.com wrote: Also, I think 3 hours might be too much, maybe to have 2 sessions of 2 hours. It might be hard to concentrate on review for 3 hours in a line.. Best regards, Max Lobur, Python Developer, Mirantis, Inc. Mobile: +38 (093) 665 14 28 Skype: max_lobur 38, Lenina ave. Kharkov, Ukraine www.mirantis.com www.mirantis.ru On Wed, Feb 12, 2014 at 11:32 PM, Maksym Lobur mlo...@mirantis.com wrote: Hi All, I like the idea! I'm comfortable to reserve about 3 hours for this, Thursdays 8am (4pm GMT +0) sounds good. I assume we'll pick and merge as much patches as possible during that time, and if the last one doesn't fit to the time - we're increasing the time until the patch merged (in reasonable limit). Makes sense? Best regards, Max Lobur, Python Developer, Mirantis, Inc. Mobile: +38 (093) 665 14 28 Skype: max_lobur 38, Lenina ave. Kharkov, Ukraine www.mirantis.com www.mirantis.ru On Wed, Feb 12, 2014 at 11:14 PM, Devananda van der Veen devananda@gmail.com wrote: Hi again! I promise this will be a much shorter email than my last one ... :) I'd like to propose that we find regular day/time to have a recurring code jam. Here's what it looks like in my head: - we get at least three core reviewers together - as many non-core folks as show up are welcome, too - we tune out all distractions for a few hours - we pick a patch and all review it If the author is present, we iterate with the author, and review each revision they submit while we're all together. If the author is not present and there are only minor issues, we fix them up in a follow-on patch and land both at once. If neither of those are possible, we -1 it and move on. I think we could make very quick progress in our review queue this way. In particular, I want us to plow through the bug fixes that have been in Fix Proposed status for a while ... What do ya'll think of this idea? Useful or a doomed to fail? What time would work for you? How about Thursdays at 8am PST? Cheers, Devananda ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev signature.asc Description: Message signed with OpenPGP using GPGMail ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Ironic] review days
Roman: *Since there are two core-subteams located in different time zones I propose making two sessions:* *- One in the morning in Europe. Let's say at 10 GMT* *- One in the morning in the US at a convenient time.* I like this but it might be confusing to the devs, at least initially. I would vote to moving the initial meeting from 8 to say 8:30 on Thursdays. I say lets talk about split review days in the next meeting? Chris On Wed, Feb 12, 2014 at 2:35 PM, Roman Prykhodchenko rprikhodche...@mirantis.com wrote: Since there are two core-subteams located in different time zones I propose making two sessions: - One in the morning in Europe. Let's say at 10 GMT - One in the morning in the US at a convenient time. This approach might be useful for the submitters located in different time zones. - Roman On Feb 13, 2014, at 00:18 , Maksym Lobur mlo...@mirantis.com wrote: Also, I think 3 hours might be too much, maybe to have 2 sessions of 2 hours. It might be hard to concentrate on review for 3 hours in a line.. Best regards, Max Lobur, Python Developer, Mirantis, Inc. Mobile: +38 (093) 665 14 28 Skype: max_lobur 38, Lenina ave. Kharkov, Ukraine www.mirantis.com www.mirantis.ru On Wed, Feb 12, 2014 at 11:32 PM, Maksym Lobur mlo...@mirantis.comwrote: Hi All, I like the idea! I'm comfortable to reserve about 3 hours for this, Thursdays 8am (4pm GMT +0) sounds good. I assume we'll pick and merge as much patches as possible during that time, and if the last one doesn't fit to the time - we're increasing the time until the patch merged (in reasonable limit). Makes sense? Best regards, Max Lobur, Python Developer, Mirantis, Inc. Mobile: +38 (093) 665 14 28 Skype: max_lobur 38, Lenina ave. Kharkov, Ukraine www.mirantis.com www.mirantis.ru On Wed, Feb 12, 2014 at 11:14 PM, Devananda van der Veen devananda@gmail.com wrote: Hi again! I promise this will be a much shorter email than my last one ... :) I'd like to propose that we find regular day/time to have a recurring code jam. Here's what it looks like in my head: - we get at least three core reviewers together - as many non-core folks as show up are welcome, too - we tune out all distractions for a few hours - we pick a patch and all review it If the author is present, we iterate with the author, and review each revision they submit while we're all together. If the author is not present and there are only minor issues, we fix them up in a follow-on patch and land both at once. If neither of those are possible, we -1 it and move on. I think we could make very quick progress in our review queue this way. In particular, I want us to plow through the bug fixes that have been in Fix Proposed status for a while ... What do ya'll think of this idea? Useful or a doomed to fail? What time would work for you? How about Thursdays at 8am PST? Cheers, Devananda ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Ironic] review days
On Wed, Feb 12, 2014 at 2:18 PM, Maksym Lobur mlo...@mirantis.com wrote: Also, I think 3 hours might be too much I'm happy to start with 2 hours and see how it goes. On Wed, Feb 12, 2014 at 2:35 PM, Roman Prykhodchenko rprikhodche...@mirantis.com wrote: Since there are two core-subteams located in different time zones I propose making two sessions: - One in the morning in Europe. Let's say at 10 GMT - One in the morning in the US at a convenient time. We don't exactly have two teams split by timezone... we have core members in GMT -8 +0 +2 +12, +/- 1hr for DST Regardless of that, I would rather not split this up. Without some overlap between US and EU, it may be hard to land much during these code jams. If only two cores are present, neither one of them can land a new patch without +2'ing their own work, which we shouldn't do. The point of this is to be able to rapidly iterate on fixing bugs, and a lot of the important bug fixes have been proposed by core team members already, so we need minimum of 3 cores present. -Deva ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
