Re: [openstack-dev] [kolla][osprofiler][keystone][neutron][nova] osprofiler in paste deploy files
- Mail original - > De: "Lance Bragstad" > À: "OpenStack Development Mailing List (not for usage questions)" > > Envoyé: Mardi 30 Mai 2017 16:33:17 > Objet: Re: [openstack-dev] [kolla][osprofiler][keystone][neutron][nova] > osprofiler in paste deploy files > > On Mon, May 29, 2017 at 4:08 AM, Matthieu Simonin > wrote: > > > Hello, > > > > I'd like to have more insight on OSProfiler support in paste-deploy files > > as it seems not similar across projects. > > As a result, the way you can enable it on Kolla side differs. Here are > > some examples: > > > > a) Nova paste.ini already contains OSProfiler middleware[1]. > > > > b) Keystone paste.ini doesn't contain OSProfiler but the file is exposed > > in Kolla-ansible. > > Thus it can be overwritten[2] by providing an alternate paste file using a > > node_custom_config directory. > > > > I'm looking through keystone's sample paste file we keep in the project and > we do have osprofiler in our v2 and v3 pipelines [0] [1]. It looks like it > has been in keystone's sample paste file since Mitaka [2] My bad, Kolla is maintaining a copy (without osprofiler) of the file which will replace the one shipped with Keystone (with osprofiler). > > > [0] > https://github.com/openstack/keystone/blob/58d7eaca41f83a52e100cbae9afe7d3faf1b9693/etc/keystone-paste.ini#L43-L44 > [1] > https://github.com/openstack/keystone/blob/58d7eaca41f83a52e100cbae9afe7d3faf1b9693/etc/keystone-paste.ini#L68 > [2] > https://github.com/openstack/keystone/commit/639e36adbfa0f58ce2c3f31856b4343e9197aa0e > > > > > > c) Neutron paste.ini doesn't contain OSProfiler middleware[3]. For > > devstack, a hook can reconfigure the file at deploy time[4]. > > For Kolla, it seems that the only solution right now is to rebuild the > > whole docker image. > > > > As a user of Kolla and OSprofiler a) is the most convenient thing. > > > > Regarding b) and c), is it a deliberate choice to ship the paste deploy > > files without OSProfiler middleware? > > > > Do you think we could converge ? ideally having a) for every API services ? > > > > Best, > > > > Matt > > > > [1]: https://github.com/openstack/nova/blob/0d31fb303e07b7ed9f55b9c823b43e > > 6db5153ee6/etc/nova/api-paste.ini#L29-L37 > > [2]: https://github.com/openstack/kolla-ansible/blob/ > > fe61612ec6db469cccf2d2b4f0bd404ad4ced112/ansible/roles/ > > keystone/tasks/config.yml#L119 > > [3]: https://github.com/openstack/neutron/blob/ > > e4557a7793fbf3461bfae36ead41ee4d349920ab/neutron/tests/ > > contrib/hooks/osprofiler > > [4]: https://github.com/openstack/neutron/blob/ > > e4557a7793fbf3461bfae36ead41ee4d349920ab/etc/api-paste.ini#L6-L9 > > > > __ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [kolla][osprofiler][keystone][neutron][nova] osprofiler in paste deploy files
On Mon, May 29, 2017 at 4:08 AM, Matthieu Simonin wrote: > Hello, > > I'd like to have more insight on OSProfiler support in paste-deploy files > as it seems not similar across projects. > As a result, the way you can enable it on Kolla side differs. Here are > some examples: > > a) Nova paste.ini already contains OSProfiler middleware[1]. > > b) Keystone paste.ini doesn't contain OSProfiler but the file is exposed > in Kolla-ansible. > Thus it can be overwritten[2] by providing an alternate paste file using a > node_custom_config directory. > I'm looking through keystone's sample paste file we keep in the project and we do have osprofiler in our v2 and v3 pipelines [0] [1]. It looks like it has been in keystone's sample paste file since Mitaka [2] [0] https://github.com/openstack/keystone/blob/58d7eaca41f83a52e100cbae9afe7d3faf1b9693/etc/keystone-paste.ini#L43-L44 [1] https://github.com/openstack/keystone/blob/58d7eaca41f83a52e100cbae9afe7d3faf1b9693/etc/keystone-paste.ini#L68 [2] https://github.com/openstack/keystone/commit/639e36adbfa0f58ce2c3f31856b4343e9197aa0e > > c) Neutron paste.ini doesn't contain OSProfiler middleware[3]. For > devstack, a hook can reconfigure the file at deploy time[4]. > For Kolla, it seems that the only solution right now is to rebuild the > whole docker image. > > As a user of Kolla and OSprofiler a) is the most convenient thing. > > Regarding b) and c), is it a deliberate choice to ship the paste deploy > files without OSProfiler middleware? > > Do you think we could converge ? ideally having a) for every API services ? > > Best, > > Matt > > [1]: https://github.com/openstack/nova/blob/0d31fb303e07b7ed9f55b9c823b43e > 6db5153ee6/etc/nova/api-paste.ini#L29-L37 > [2]: https://github.com/openstack/kolla-ansible/blob/ > fe61612ec6db469cccf2d2b4f0bd404ad4ced112/ansible/roles/ > keystone/tasks/config.yml#L119 > [3]: https://github.com/openstack/neutron/blob/ > e4557a7793fbf3461bfae36ead41ee4d349920ab/neutron/tests/ > contrib/hooks/osprofiler > [4]: https://github.com/openstack/neutron/blob/ > e4557a7793fbf3461bfae36ead41ee4d349920ab/etc/api-paste.ini#L6-L9 > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [kolla][osprofiler][keystone][neutron][nova] osprofiler in paste deploy files
- Mail original - > De: "Eduardo Gonzalez" > À: "OpenStack Development Mailing List (not for usage questions)" > > Envoyé: Lundi 29 Mai 2017 11:53:53 > Objet: Re: [openstack-dev] [kolla][osprofiler][keystone][neutron][nova] > osprofiler in paste deploy files > > Hi Matt, > > A), As far I can see most services with Osprofile implemented have it > enabled by default at paste-ini files except Neutron and maybe a couple > more. > > B), kolla's custom keystone-paste-ini file will probably be "removed" for > Pike release, using keystone defaults with osprofile enabled. We will add > other method to customize paste-ini, ofc. Is there any reference on a (future) method to customize paste-ini files ? This would be a really helpful feature (and not only for OSProfiler). > > C), For now in kolla, neutron paste-ini cannot be customized by regular > methods, a quick but no good solution would be exec into container, modify > the file and restart container, or modify kolla-ansible playbooks to allow > copying your custom api-paste.ini. > > Agree that option A is the best method. > > FYI, at this moment there is a change under review to implement osprofile > in kolla-ansible. [0] Thanks for pointing me this. It seems a complementary feature to fully enable OSProfiler in Kolla. In my opinion, making sure the various api-paste files enable OSProfiler is something that goes first. Best, Matt > > [0] https://review.openstack.org/#/c/455628/ > > Regards, Eduardo > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [kolla][osprofiler][keystone][neutron][nova] osprofiler in paste deploy files
Hi Matt, A), As far I can see most services with Osprofile implemented have it enabled by default at paste-ini files except Neutron and maybe a couple more. B), kolla's custom keystone-paste-ini file will probably be "removed" for Pike release, using keystone defaults with osprofile enabled. We will add other method to customize paste-ini, ofc. C), For now in kolla, neutron paste-ini cannot be customized by regular methods, a quick but no good solution would be exec into container, modify the file and restart container, or modify kolla-ansible playbooks to allow copying your custom api-paste.ini. Agree that option A is the best method. FYI, at this moment there is a change under review to implement osprofile in kolla-ansible. [0] [0] https://review.openstack.org/#/c/455628/ Regards, Eduardo __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [kolla][osprofiler][keystone][neutron][nova] osprofiler in paste deploy files
Hello, I'd like to have more insight on OSProfiler support in paste-deploy files as it seems not similar across projects. As a result, the way you can enable it on Kolla side differs. Here are some examples: a) Nova paste.ini already contains OSProfiler middleware[1]. b) Keystone paste.ini doesn't contain OSProfiler but the file is exposed in Kolla-ansible. Thus it can be overwritten[2] by providing an alternate paste file using a node_custom_config directory. c) Neutron paste.ini doesn't contain OSProfiler middleware[3]. For devstack, a hook can reconfigure the file at deploy time[4]. For Kolla, it seems that the only solution right now is to rebuild the whole docker image. As a user of Kolla and OSprofiler a) is the most convenient thing. Regarding b) and c), is it a deliberate choice to ship the paste deploy files without OSProfiler middleware? Do you think we could converge ? ideally having a) for every API services ? Best, Matt [1]: https://github.com/openstack/nova/blob/0d31fb303e07b7ed9f55b9c823b43e6db5153ee6/etc/nova/api-paste.ini#L29-L37 [2]: https://github.com/openstack/kolla-ansible/blob/fe61612ec6db469cccf2d2b4f0bd404ad4ced112/ansible/roles/keystone/tasks/config.yml#L119 [3]: https://github.com/openstack/neutron/blob/e4557a7793fbf3461bfae36ead41ee4d349920ab/neutron/tests/contrib/hooks/osprofiler [4]: https://github.com/openstack/neutron/blob/e4557a7793fbf3461bfae36ead41ee4d349920ab/etc/api-paste.ini#L6-L9 __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
