Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment
After thinking about this for a while, I came to think, that we also need a jslinter job for murano-dashboard. Horizon is currently adopting eslint as a one tool for the job (meant to replace jscs and jshint afaiu), so we could adopt this as part of the blueprint, I filed. -- Kirill Zaitsev Murano team Software Engineer Mirantis, Inc On 15 Jun 2015 at 02:27:06, Kirill Zaitsev (kzait...@mirantis.com) wrote: Since there were no objections, and as a follow-up I’ve created a BP for that in murano: https://blueprints.launchpad.net/murano/+spec/add-shellcheck-jobs -- Kirill Zaitsev Murano team Software Engineer Mirantis, Inc On 10 Jun 2015 at 18:07:19, Filip Blaha (filip.bl...@hp.com) wrote: Thanks for comment and suggestion! there is also shutil2 framework for unit testing over shell scripts. We shall consider it whether it could bring us value for the effort. I personally have no strong opinion about that. Little contradiction to my previous mail:-) Regards Filip On 06/10/2015 03:34 PM, Jeremy Stanley wrote: On 2015-06-10 13:48:26 +0200 (+0200), Filip Blaha wrote: +1, nice idea. Shell script are not easy to review - large files, not covered by unit tests. Any automatic tool could be beneficial. It's worth noting that just because your shell scripts don't have their own validation tests doesn't mean they can't. For example see the test-features.sh and test-functions.sh scripts in the https://git.openstack.org/cgit/openstack-infra/devstack-gate/ repo, making sure we maintain a contract on things like branch fallback logic which is easy to subtly break if not tested. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment
Since there were no objections, and as a follow-up I’ve created a BP for that in murano: https://blueprints.launchpad.net/murano/+spec/add-shellcheck-jobs -- Kirill Zaitsev Murano team Software Engineer Mirantis, Inc On 10 Jun 2015 at 18:07:19, Filip Blaha (filip.bl...@hp.com) wrote: Thanks for comment and suggestion! there is also shutil2 framework for unit testing over shell scripts. We shall consider it whether it could bring us value for the effort. I personally have no strong opinion about that. Little contradiction to my previous mail:-) Regards Filip On 06/10/2015 03:34 PM, Jeremy Stanley wrote: On 2015-06-10 13:48:26 +0200 (+0200), Filip Blaha wrote: +1, nice idea. Shell script are not easy to review - large files, not covered by unit tests. Any automatic tool could be beneficial. It's worth noting that just because your shell scripts don't have their own validation tests doesn't mean they can't. For example see the test-features.sh and test-functions.sh scripts in the https://git.openstack.org/cgit/openstack-infra/devstack-gate/ repo, making sure we maintain a contract on things like branch fallback logic which is easy to subtly break if not tested. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment
Hi Kirill, +1 from my side, shellcheck + bashate can help to increase quality of CI scripts. On Wed, Jun 10, 2015 at 2:19 PM, Igor Yozhikov iyozhi...@mirantis.com wrote: Hi, I'm using shellcheck during automation scripts writing as linter and I believe that incorporation of this tool for additional verification in CI is good idea. Thanks, Igor Yozhikov Senior Deployment Engineer at Mirantis http://www.mirantis.com skype: igor.yozhikov cellular: +7 901 5331200 slack: iyozhikov On Tue, Jun 9, 2015 at 11:52 PM, Dean Troyer dtro...@gmail.com wrote: On Tue, Jun 9, 2015 at 2:58 PM, Kirill Zaitsev kzait...@mirantis.com wrote: What would you say about adding a job to murano-deployment, that would launch shellcheck http://www.shellcheck.net/about.html against all .sh files? We looked at shellcheck when the idea for bashate was brewing, frankly the Haskell runtime requirement was a bit of a sticking point for DevStack, I've no idea what that situation is these days. dt -- Dean Troyer dtro...@gmail.com __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Serg Melikyan, Senior Software Engineer at Mirantis, Inc. http://mirantis.com | smelik...@mirantis.com +7 (495) 640-4904, 0261 +7 (903) 156-0836 __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment
Hi, I'm using shellcheck during automation scripts writing as linter and I believe that incorporation of this tool for additional verification in CI is good idea. Thanks, Igor Yozhikov Senior Deployment Engineer at Mirantis http://www.mirantis.com skype: igor.yozhikov cellular: +7 901 5331200 slack: iyozhikov On Tue, Jun 9, 2015 at 11:52 PM, Dean Troyer dtro...@gmail.com wrote: On Tue, Jun 9, 2015 at 2:58 PM, Kirill Zaitsev kzait...@mirantis.com wrote: What would you say about adding a job to murano-deployment, that would launch shellcheck http://www.shellcheck.net/about.html against all .sh files? We looked at shellcheck when the idea for bashate was brewing, frankly the Haskell runtime requirement was a bit of a sticking point for DevStack, I've no idea what that situation is these days. dt -- Dean Troyer dtro...@gmail.com __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment
+1, nice idea. Shell script are not easy to review - large files, not covered by unit tests. Any automatic tool could be beneficial. Regards Filip On 06/09/2015 09:58 PM, Kirill Zaitsev wrote: Folks, I’ve got another proposal, mainly to the guys, who deal with CI and test jobs daily. What would you say about adding a job to murano-deployment, that would launch shellcheck http://www.shellcheck.net/about.html against all .sh files? I use it, when reviewing .sh scripts (well, actually my vim does it for me =P) and although It has some excessive checks I find it quite useful. We could also add a similar job to murano-apps, since they use shell scripts quite often. Any objections to this idea? -- Kirill Zaitsev Murano team Software Engineer Mirantis, Inc __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment
On 2015-06-10 13:48:26 +0200 (+0200), Filip Blaha wrote: +1, nice idea. Shell script are not easy to review - large files, not covered by unit tests. Any automatic tool could be beneficial. It's worth noting that just because your shell scripts don't have their own validation tests doesn't mean they can't. For example see the test-features.sh and test-functions.sh scripts in the https://git.openstack.org/cgit/openstack-infra/devstack-gate/ repo, making sure we maintain a contract on things like branch fallback logic which is easy to subtly break if not tested. -- Jeremy Stanley __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment
Thanks for comment and suggestion! there is also shutil2 framework for unit testing over shell scripts. We shall consider it whether it could bring us value for the effort. I personally have no strong opinion about that. Little contradiction to my previous mail:-) Regards Filip On 06/10/2015 03:34 PM, Jeremy Stanley wrote: On 2015-06-10 13:48:26 +0200 (+0200), Filip Blaha wrote: +1, nice idea. Shell script are not easy to review - large files, not covered by unit tests. Any automatic tool could be beneficial. It's worth noting that just because your shell scripts don't have their own validation tests doesn't mean they can't. For example see the test-features.sh and test-functions.sh scripts in the https://git.openstack.org/cgit/openstack-infra/devstack-gate/ repo, making sure we maintain a contract on things like branch fallback logic which is easy to subtly break if not tested. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment
On 2015-06-09 22:58:15 +0300 (+0300), Kirill Zaitsev wrote: [...] What would you say about adding a job to murano-deployment, that would launch shellcheck http://www.shellcheck.net/about.html against all .sh files? [...] Ooh, that looks neat. Note we also already use http://git.openstack.org/cgit/openstack-dev/bashate/ to do this for DevStack and a lot of the Infra repos. Might be worthwhile to get the rules from one implemented in the other or vice versa. -- Jeremy Stanley __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment
On 2015-06-09 20:40:48 + (+), Jeremy Stanley wrote: On 2015-06-09 22:58:15 +0300 (+0300), Kirill Zaitsev wrote: [...] What would you say about adding a job to murano-deployment, that would launch shellcheck http://www.shellcheck.net/about.html against all .sh files? [...] Ooh, that looks neat. Note we also already use http://git.openstack.org/cgit/openstack-dev/bashate/ to do this for DevStack and a lot of the Infra repos. Might be worthwhile to get the rules from one implemented in the other or vice versa. Er, actually since shellcheck is a static analysis tool and bashate is a style checker, they seem entirely complimentary. Wouldn't make sense to try to incorporate one into the other, but would potentially be useful to run both on proposed changes. Also, since shellcheck (0.3.3) is available in Ubuntu trusty-backports it would be entirely reasonable to install for such a CI job. -- Jeremy Stanley __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment
Folks, I’ve got another proposal, mainly to the guys, who deal with CI and test jobs daily. What would you say about adding a job to murano-deployment, that would launch shellcheck http://www.shellcheck.net/about.html against all .sh files? I use it, when reviewing .sh scripts (well, actually my vim does it for me =P) and although It has some excessive checks I find it quite useful. We could also add a similar job to murano-apps, since they use shell scripts quite often. Any objections to this idea? -- Kirill Zaitsev Murano team Software Engineer Mirantis, Inc__ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [murano] shellcheck all .sh scripts in murano-deployment
On Tue, Jun 9, 2015 at 2:58 PM, Kirill Zaitsev kzait...@mirantis.com wrote: What would you say about adding a job to murano-deployment, that would launch shellcheck http://www.shellcheck.net/about.html against all .sh files? We looked at shellcheck when the idea for bashate was brewing, frankly the Haskell runtime requirement was a bit of a sticking point for DevStack, I've no idea what that situation is these days. dt -- Dean Troyer dtro...@gmail.com __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
