Re: [openstack-dev] [telemetry][heat] Removal of Aodh combination alarms

2017-02-28 Thread Thomas Herve 
On Tue, Feb 28, 2017 at 7:54 AM, Sergey Kraynev  wrote:
> Zane,
> as I understand, all related code was removed. Probably we may to remove our
> Hidden resource too.

We can't remove our hidden resources, because it breaks stacks that
reference them (to the point that you can't delete them).

> If we want to have hidden resource, then probably as you mentioned will be
> enough to raise Exceptions and execute nothing for handle_delete.

We don't want to, we have to :). One trick I'd like to check is simply
have an alias to Heat::None. It may be good enough.

-- 
Thomas

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [telemetry][heat] Removal of Aodh combination alarms

2017-02-27 Thread Sergey Kraynev 
Zane,
as I understand, all related code was removed. Probably we may to remove
our Hidden resource too.

If we want to have hidden resource, then probably as you mentioned will be
enough to raise Exceptions and execute nothing for handle_delete.

On 28 February 2017 at 01:36, Zane Bitter  wrote:

> On 24/02/17 06:15, Julien Danjou wrote:
>
>> Hey,
>>
>> We're about to remove the code for the deprecated combination alarm.
>>
>>   https://review.openstack.org/#/c/429405/
>>
>> I checked and as far as I can tell that should not break Heat gate, but
>> I'd prefer to be sure. So, Heat developers if you have some code relying
>> on it, let us know before we press the big +A button.
>>
>
> Looks like it merged and there was no breakage, so that's good.
>
> How should we handle the (hidden) resource type in Heat?
>
> http://git.openstack.org/cgit/openstack/heat/tree/heat/engin
> e/resources/openstack/aodh/alarm.py#n227
>
> Make handle_delete() return without doing anything, and raise an exception
> in all other handle_*() methods?
>
> - ZB
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Regards,
Sergey.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [telemetry][heat] Removal of Aodh combination alarms

2017-02-27 Thread Zane Bitter 

On 24/02/17 06:15, Julien Danjou wrote:

Hey,

We're about to remove the code for the deprecated combination alarm.

  https://review.openstack.org/#/c/429405/

I checked and as far as I can tell that should not break Heat gate, but
I'd prefer to be sure. So, Heat developers if you have some code relying
on it, let us know before we press the big +A button.


Looks like it merged and there was no breakage, so that's good.

How should we handle the (hidden) resource type in Heat?

http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resources/openstack/aodh/alarm.py#n227

Make handle_delete() return without doing anything, and raise an 
exception in all other handle_*() methods?


- ZB

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [telemetry][heat] Removal of Aodh combination alarms

2017-02-24 Thread gordon chung 


On 24/02/17 06:15 AM, Julien Danjou wrote:
> Hey,
>
> We're about to remove the code for the deprecated combination alarm.
>
>   https://review.openstack.org/#/c/429405/
>
> I checked and as far as I can tell that should not break Heat gate, but
> I'd prefer to be sure. So, Heat developers if you have some code relying
> on it, let us know before we press the big +A button.
>

i mentioned this on patch, but it seems my dependent patch passes in 
heat: https://review.openstack.org/#/c/437192/

-- 
gord

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [telemetry][heat] Removal of Aodh combination alarms

2017-02-24 Thread Julien Danjou 
Hey,

We're about to remove the code for the deprecated combination alarm.

  https://review.openstack.org/#/c/429405/

I checked and as far as I can tell that should not break Heat gate, but
I'd prefer to be sure. So, Heat developers if you have some code relying
on it, let us know before we press the big +A button.

Cheers,
-- 
Julien Danjou
# Free Software hacker
# https://julien.danjou.info


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev