Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Paul Belanger]

On Wed, Oct 14, 2015 at 10:51:36AM +0200, Thierry Carrez wrote:
> Zaro wrote:
> > We want to let everyone know that there is a big UI change in Gerrit
> > 2.11.  The change screen (CS), which is the main view for a patchset,
> > has been completely replaced with a new change screen (CS2).  While
> > Gerrit 2.8 contains both old CS and CS2, I believe everyone in
> > Openstack land is really just using the old CS.  CS2 really wasn't
> > ready in 2.8 and really should never be used in that version.  The CS2
> > has come a long way since then and many other big projects have moved
> > to using Gerrit 2.11 so it's not a concern any longer.  If you would
> > like a preview of Gerrit 2.11 and maybe help us test it, head over to
> > http://review-dev.openstack.org.  If you are very opposed to CS2 then
> > you may like Gertty (https://pypi.python.org/pypi/gertty) instead.  If
> > neither option works for you then maybe you can help us create a new
> > alternative :)
> > 
> > We are soliciting feedback so please let us know what you think.
> 
> It looks quite good to me.
> 
> My main issue with CS2 is how greedy it is in horizontal space, mostly
> due to the waste of space in the "Related changes" panel. If there are
> related changes, the owner/reviewer/voting panel is cramped in the
> middle, while "related changes" has a lot of empty space on the right.
> Is there a way to turn that panel off (move it to a dropdown like the
> patchsets view), or make it use half the width, or push it under
> ChangeID, or...
> 
Agreed. Currently lock my browser to 950x979 (i3wm) and agree that CS2 is pretty
greedy with horizontal spaces. Switching to 1910 x 998 obviously fixes it.  Not
a show stopper but first round of impressions.  Like other, as time continues,
I'll likely become more adjusted to the change.

> I also find the CS2 vote results area a lot less clear than the table we
> had in CS, but that may be because I'm used to it now.
> 
> -- 
> Thierry Carrez (ttx)
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Jeremy Stanley]

On 2015-10-21 10:18:31 -0400 (-0400), Anita Kuno wrote:
[...]
> If folks are willing to help build Gerrit v3, that is wonderful.
> If you would like to talk to Khai on how to get started
> contributing to Gerrit, I'm going out on a limb here and will
> guess he will be supportive of your efforts.

In fact, we even have a work session[*] 9:00am local in the Kinkei
Room on Thursday the 29th to discuss these (and related) topics.
People interested in helping us with our Gerrit implementation
and/or contributing to upstream Gerrit development are welcome!

[*] http://mitakadesignsummit.sched.org/event/c4170a605301dbf9bfa19b9e6a651a87

-- 
Jeremy Stanley

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Anita Kuno]

On 10/21/2015 08:37 AM, Markus Zoeller wrote:
> "Daniel P. Berrange" <berra...@redhat.com> wrote on 10/21/2015 11:29:50 
> AM:
> 
>> From: "Daniel P. Berrange" <berra...@redhat.com>
>> To: "OpenStack Development Mailing List (not for usage questions)" 
>> <openstack-dev@lists.openstack.org>
>> Date: 10/21/2015 11:42 AM
>> Subject: Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11
>>
>> On Tue, Oct 13, 2015 at 05:08:29PM -0700, Zaro wrote:
>>> Hello All,
>>>
>>> The openstack-infra team would like to upgrade from our Gerrit 2.8 to
>>> Gerrit 2.11.  We are proposing to do the upgrade shortly after the
>>> Mitaka summit.  The main motivation behind the upgrade is to allow us
>>> to take advantage of some of the new REST api, ssh commands, and
>>> stream events features.  Also we wanted to stay closer to upstream so
>>> it will be easier to pick up more recent features and fixes.
>>
>> Looking at the release notes I see my most wanted new feature, keyword
>> tagging of changes, is available
>>
>> [quote]
>> Hashtags.
>>
>> Hashtags can be added to changes. The hashtags are stored in git notes 
> and
>> are indexed in the secondary index.
>>
>> This feature requires the notedb to be enabled.
>> [/quote]
>>
>> It is listed as an experimental feature, but I'd really love to see this
>> enabled if at all practical.
>>
>> Regards,
>> Daniel
> 
> +1
> 
> A mockup from the Gerrit folks: http://i.imgur.com/T1azkvk.png
> 
> Regards, Markus Zoeller (markus_z)
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 

My reading of the gerrit group thread for design of Gerrit v3 is that
notedb is slated for v3.
https://groups.google.com/forum/#!topic/repo-discuss/Zz8sEbsO36s

Currently we are running 2.8 and working on upgrading to 2.11.

If folks are willing to help build Gerrit v3, that is wonderful. If you
would like to talk to Khai on how to get started contributing to Gerrit,
I'm going out on a limb here and will guess he will be supportive of
your efforts.

Thanks,
Anita.

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Markus Zoeller]

"Daniel P. Berrange" <berra...@redhat.com> wrote on 10/21/2015 11:29:50 
AM:

> From: "Daniel P. Berrange" <berra...@redhat.com>
> To: "OpenStack Development Mailing List (not for usage questions)" 
> <openstack-dev@lists.openstack.org>
> Date: 10/21/2015 11:42 AM
> Subject: Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11
> 
> On Tue, Oct 13, 2015 at 05:08:29PM -0700, Zaro wrote:
> > Hello All,
> > 
> > The openstack-infra team would like to upgrade from our Gerrit 2.8 to
> > Gerrit 2.11.  We are proposing to do the upgrade shortly after the
> > Mitaka summit.  The main motivation behind the upgrade is to allow us
> > to take advantage of some of the new REST api, ssh commands, and
> > stream events features.  Also we wanted to stay closer to upstream so
> > it will be easier to pick up more recent features and fixes.
> 
> Looking at the release notes I see my most wanted new feature, keyword
> tagging of changes, is available
> 
> [quote]
> Hashtags.
> 
> Hashtags can be added to changes. The hashtags are stored in git notes 
and
> are indexed in the secondary index.
> 
> This feature requires the notedb to be enabled.
> [/quote]
> 
> It is listed as an experimental feature, but I'd really love to see this
> enabled if at all practical.
> 
> Regards,
> Daniel

+1

A mockup from the Gerrit folks: http://i.imgur.com/T1azkvk.png

Regards, Markus Zoeller (markus_z)


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Daniel P. Berrange]

On Tue, Oct 13, 2015 at 05:08:29PM -0700, Zaro wrote:
> Hello All,
> 
> The openstack-infra team would like to upgrade from our Gerrit 2.8 to
> Gerrit 2.11.  We are proposing to do the upgrade shortly after the
> Mitaka summit.  The main motivation behind the upgrade is to allow us
> to take advantage of some of the new REST api, ssh commands, and
> stream events features.  Also we wanted to stay closer to upstream so
> it will be easier to pick up more recent features and fixes.

Looking at the release notes I see my most wanted new feature, keyword
tagging of changes, is available

[quote]
Hashtags.

Hashtags can be added to changes. The hashtags are stored in git notes and
are indexed in the secondary index.

This feature requires the notedb to be enabled.
[/quote]

It is listed as an experimental feature, but I'd really love to see this
enabled if at all practical.

Regards,
Daniel
-- 
|: http://berrange.com  -o-http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org  -o- http://virt-manager.org :|
|: http://autobuild.org   -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org   -o-   http://live.gnome.org/gtk-vnc :|

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Markus Zoeller]

Alexis Lee <lx...@hpe.com> wrote on 10/20/2015 03:13:20 PM:

> From: Alexis Lee <lx...@hpe.com>
> To: "OpenStack Development Mailing List (not for usage questions)" 
> <openstack-dev@lists.openstack.org>
> Date: 10/20/2015 03:19 PM
> Subject: Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11
> 
> Markus Zoeller said on Fri, Oct 16, 2015 at 03:33:37PM +0200:
> > > >Would it be possible to create a "prio" label to help sorting out 
> > stuff?
> 
> +1 to this!
> [...]
> 
> Alexis (lxsli)

To avoid a hijacking of this thread, here the new one where we
can discuss this:
http://lists.openstack.org/pipermail/openstack-dev/2015-October/077517.html

Regards, Markus Zoeller (markus_z)


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Alexis Lee]

Markus Zoeller said on Fri, Oct 16, 2015 at 03:33:37PM +0200:
> > >Would it be possible to create a "prio" label to help sorting out 
> stuff?

+1 to this!

> > I guess topics could be used but those are overwritten on every new
> > PS.
> 
> The topics survive a new patch set, as far as I observed it. Nova used
> this approach in Kilo too [1] but I didn't find such a thing for Liberty
> and I don't know how well this worked. When I think a second time about
> my idea above, I'm unclear which impact that would have on the general
> review process and this thread is probably not the right one to discuss
> this. I have to think more about this. 

Topics only survive if you use the "git review -d NN" workflow,
which creates a branch for you named after the current topic. You'll see
a lot of topics like "master" and "(detached" where people have
forgotten to set the topic. It's also easy to trample topics when
uploading patch series.


Alexis (lxsli)
-- 
Nova developer, Hewlett-Packard Limited.
Registered Office: Cain Road, Bracknell, Berkshire RG12 1HN.
Registered Number: 00690597 England
VAT number: GB 314 1496 79

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Flavio Percoco]

On 15/10/15 17:42 +0200, Markus Zoeller wrote:

Zaro wrote:

We are soliciting feedback so please let us know what you think.


For spotting possible trivial bug fixes the new query option "delta"
will be useful. For example: "status:open delta:<100"

Would it be possible to create a "prio" label to help sorting out stuff?
If I understand [1] correctly, we could have something like like:

   [label "Prio"]
   function = NoOp
   value = 0 Undecided
   value = 1 critical
   value = 2 high
   value = 3 trivialfix

For example, this would allow to create a query with

   "status:open label:Prio=3"

to get all reviews for trivial bug fixes.

Nevertheless, I'm looking forward to the upgrade.



+1

In glance we're currently grouping blueprints, bugs and random
patches. It'd be AWESOME, to have a way to tag priorities on patches.

I guess topics could be used but those are overwritten on every new
PS.

Flavio


References:
[1]
https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_custom

Regards,
Markus Zoeller (markus_z)


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


--
@flaper87
Flavio Percoco


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Markus Zoeller]

On 10/15/2015 11:36 PM, Flavio Percoco wrote:
> >On 15/10/15 17:42 +0200, Markus Zoeller wrote:
> >For spotting possible trivial bug fixes the new query option "delta"
> >will be useful. For example: "status:open delta:<100"
> >
> >Would it be possible to create a "prio" label to help sorting out 
stuff?
> >If I understand [1] correctly, we could have something like like:
> >
> >[label "Prio"]
> >function = NoOp
> >value = 0 Undecided
> >value = 1 critical
> >value = 2 high
> >value = 3 trivialfix
> >
> >For example, this would allow to create a query with
> >
> >"status:open label:Prio=3"
> >
> >to get all reviews for trivial bug fixes.
> 
> +1
> 
> In glance we're currently grouping blueprints, bugs and random
> patches. It'd be AWESOME, to have a way to tag priorities on patches.
> 
> I guess topics could be used but those are overwritten on every new
> PS.

The topics survive a new patch set, as far as I observed it. Nova used
this approach in Kilo too [1] but I didn't find such a thing for Liberty
and I don't know how well this worked. When I think a second time about
my idea above, I'm unclear which impact that would have on the general
review process and this thread is probably not the right one to discuss
this. I have to think more about this. 

[1] 
https://github.com/stackforge/gerrit-dash-creator/blob/master/dashboards/nova-kilo-priorities.dash


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Sean Dague]

On 10/14/2015 08:22 PM, Ian Wienand wrote:
> On 10/14/2015 11:08 AM, Zaro wrote:
>> We are soliciting feedback so please let us know what you think.
> 
> Since you asked :)
> 
> Mostly it's just different which is fine.  Two things I noticed when
> playing around, shown in [1]
> 
> When reviewing, the order "-1 0 +1" is kind of counter-intuitive to
> the usual dialog layout of the "most positive" thing on the left;
> e.g. [OK] [Cancel] dialogs.  I just found it odd to interact with.
> 
> Maybe people default themselves to -1 though :)
> 
> The colours for +1/-1 seem to be missing.  You've got to think a lot
> more to parse the +1/-1 rather than just glance at the colours.

Oh, -1 color is a site local change to the css IIRC. I think I made that
in in paris. It's something we could do for the new change screen as
well. The css selector is weird, but seems to work fine:

/* css attribute selector to make -1s show up red in new screen */
[title="This patch needs further work before it can be merged"] {
color: red;
}

-Sean

-- 
Sean Dague
http://dague.net

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Markus Zoeller]

Zaro wrote:
> We are soliciting feedback so please let us know what you think.

For spotting possible trivial bug fixes the new query option "delta"
will be useful. For example: "status:open delta:<100"

Would it be possible to create a "prio" label to help sorting out stuff?
If I understand [1] correctly, we could have something like like:

[label "Prio"]
function = NoOp
value = 0 Undecided
value = 1 critical
value = 2 high
value = 3 trivialfix

For example, this would allow to create a query with 

"status:open label:Prio=3" 

to get all reviews for trivial bug fixes.

Nevertheless, I'm looking forward to the upgrade.

References:
[1] 
https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_custom

Regards,
Markus Zoeller (markus_z)


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[John Dickinson]

I would love to see this!

It would really help review priorities and could easily be worked into review 
dashboards.

--John



On 15 Oct 2015, at 8:42, Markus Zoeller wrote:

> Zaro wrote:
>> We are soliciting feedback so please let us know what you think.
>
> For spotting possible trivial bug fixes the new query option "delta"
> will be useful. For example: "status:open delta:<100"
>
> Would it be possible to create a "prio" label to help sorting out stuff?
> If I understand [1] correctly, we could have something like like:
>
>  [label "Prio"]
>  function = NoOp
>  value = 0 Undecided
>  value = 1 critical
>  value = 2 high
>  value = 3 trivialfix
>
> For example, this would allow to create a query with
>
>  "status:open label:Prio=3"
>
> to get all reviews for trivial bug fixes.
>
> Nevertheless, I'm looking forward to the upgrade.
>
> References:
> [1]
> https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_custom
>
> Regards,
> Markus Zoeller (markus_z)
>
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


signature.asc
Description: OpenPGP digital signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Yuriy Taraday]

On Wed, Oct 14, 2015 at 3:08 AM Zaro  wrote:

> Hello All,
>
> The openstack-infra team would like to upgrade from our Gerrit 2.8 to
> Gerrit 2.11.  We are proposing to do the upgrade shortly after the
> Mitaka summit.  The main motivation behind the upgrade is to allow us
> to take advantage of some of the new REST api, ssh commands, and
> stream events features.  Also we wanted to stay closer to upstream so
> it will be easier to pick up more recent features and fixes.
>
> We want to let everyone know that there is a big UI change in Gerrit
> 2.11.  The change screen (CS), which is the main view for a patchset,
> has been completely replaced with a new change screen (CS2).  While
> Gerrit 2.8 contains both old CS and CS2, I believe everyone in
> Openstack land is really just using the old CS.  CS2 really wasn't
> ready in 2.8 and really should never be used in that version.  The CS2
> has come a long way since then and many other big projects have moved
> to using Gerrit 2.11 so it's not a concern any longer.  If you would
> like a preview of Gerrit 2.11 and maybe help us test it, head over to
> http://review-dev.openstack.org.  If you are very opposed to CS2 then
> you may like Gertty (https://pypi.python.org/pypi/gertty) instead.  If
> neither option works for you then maybe you can help us create a new
> alternative :)
>
> We are soliciting feedback so please let us know what you think.
>

I think that's great news!
I've been using CS2 since it became an option and it even (mostly) worked
fine for me, so I've been waiting for so long for this upgrade.

Where should I direct issues I find in review-dev.openstack.org? I've found
two so far:
- "Unified diff" button in diff view (next to navigation arrows) always
leads to Internal Server Error;
- cgit links in change screen have "%2F" in URL instead of "/" which leads
to Apache's Not Found instead of cgit's one.
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Zaro]

Thanks for the suggestion Markus.  I think the path for those types of
suggestions would be thru a spec:
http://specs.openstack.org/openstack-infra/infra-specs/


Thanks for reporting these Yuriy.  I've created a checklist[1] to
track things to verify before we actually do anything.  I think at
this point, the etherpad might be the most appropriate place to track
these types of issues.
>
> Where should I direct issues I find in review-dev.openstack.org? I've found
> two so far:
> - "Unified diff" button in diff view (next to navigation arrows) always
> leads to Internal Server Error;

Known issue, fixed here: https://gerrit-review.googlesource.com/#/c/71500/

> - cgit links in change screen have "%2F" in URL instead of "/" which leads
> to Apache's Not Found instead of cgit's one.

I believe the fix for this is to just disable the gitweb.urlEncode
configuration: 
https://gerrit-review.googlesource.com/Documentation/config-gerrit.html
Will try it out shortly.


[1] https://etherpad.openstack.org/p/test-gerrit-2.11

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Thierry Carrez]

Zaro wrote:
> We want to let everyone know that there is a big UI change in Gerrit
> 2.11.  The change screen (CS), which is the main view for a patchset,
> has been completely replaced with a new change screen (CS2).  While
> Gerrit 2.8 contains both old CS and CS2, I believe everyone in
> Openstack land is really just using the old CS.  CS2 really wasn't
> ready in 2.8 and really should never be used in that version.  The CS2
> has come a long way since then and many other big projects have moved
> to using Gerrit 2.11 so it's not a concern any longer.  If you would
> like a preview of Gerrit 2.11 and maybe help us test it, head over to
> http://review-dev.openstack.org.  If you are very opposed to CS2 then
> you may like Gertty (https://pypi.python.org/pypi/gertty) instead.  If
> neither option works for you then maybe you can help us create a new
> alternative :)
> 
> We are soliciting feedback so please let us know what you think.

It looks quite good to me.

My main issue with CS2 is how greedy it is in horizontal space, mostly
due to the waste of space in the "Related changes" panel. If there are
related changes, the owner/reviewer/voting panel is cramped in the
middle, while "related changes" has a lot of empty space on the right.
Is there a way to turn that panel off (move it to a dropdown like the
patchsets view), or make it use half the width, or push it under
ChangeID, or...

I also find the CS2 vote results area a lot less clear than the table we
had in CS, but that may be because I'm used to it now.

-- 
Thierry Carrez (ttx)

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Sean Dague]

On 10/13/2015 08:08 PM, Zaro wrote:
> Hello All,
> 
> The openstack-infra team would like to upgrade from our Gerrit 2.8 to
> Gerrit 2.11.  We are proposing to do the upgrade shortly after the
> Mitaka summit.  The main motivation behind the upgrade is to allow us
> to take advantage of some of the new REST api, ssh commands, and
> stream events features.  Also we wanted to stay closer to upstream so
> it will be easier to pick up more recent features and fixes.
> 
> We want to let everyone know that there is a big UI change in Gerrit
> 2.11.  The change screen (CS), which is the main view for a patchset,
> has been completely replaced with a new change screen (CS2).  While
> Gerrit 2.8 contains both old CS and CS2, I believe everyone in
> Openstack land is really just using the old CS.  CS2 really wasn't
> ready in 2.8 and really should never be used in that version.  The CS2
> has come a long way since then and many other big projects have moved
> to using Gerrit 2.11 so it's not a concern any longer.  If you would
> like a preview of Gerrit 2.11 and maybe help us test it, head over to
> http://review-dev.openstack.org.  If you are very opposed to CS2 then
> you may like Gertty (https://pypi.python.org/pypi/gertty) instead.  If
> neither option works for you then maybe you can help us create a new
> alternative :)
> 
> We are soliciting feedback so please let us know what you think.
> 
> Thanks You.

+1 very excited to get new gerrit out there.

-Sean

-- 
Sean Dague
http://dague.net

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Flavio Percoco]

On 13/10/15 17:08 -0700, Zaro wrote:

Hello All,

The openstack-infra team would like to upgrade from our Gerrit 2.8 to
Gerrit 2.11.  We are proposing to do the upgrade shortly after the
Mitaka summit.  The main motivation behind the upgrade is to allow us
to take advantage of some of the new REST api, ssh commands, and
stream events features.  Also we wanted to stay closer to upstream so
it will be easier to pick up more recent features and fixes.

We want to let everyone know that there is a big UI change in Gerrit
2.11.  The change screen (CS), which is the main view for a patchset,
has been completely replaced with a new change screen (CS2).  While
Gerrit 2.8 contains both old CS and CS2, I believe everyone in
Openstack land is really just using the old CS.  CS2 really wasn't
ready in 2.8 and really should never be used in that version.  The CS2
has come a long way since then and many other big projects have moved
to using Gerrit 2.11 so it's not a concern any longer.  If you would
like a preview of Gerrit 2.11 and maybe help us test it, head over to
http://review-dev.openstack.org.  If you are very opposed to CS2 then
you may like Gertty (https://pypi.python.org/pypi/gertty) instead.  If
neither option works for you then maybe you can help us create a new
alternative :)

We are soliciting feedback so please let us know what you think.


+1, excited to see our gerrit moving forward!

Flavio

P.S: /me has been using CS2 for a while now.

--
@flaper87
Flavio Percoco


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Ian Wienand]

On 10/14/2015 11:08 AM, Zaro wrote:

We are soliciting feedback so please let us know what you think.


Since you asked :)

Mostly it's just different which is fine.  Two things I noticed when
playing around, shown in [1]

When reviewing, the order "-1 0 +1" is kind of counter-intuitive to
the usual dialog layout of the "most positive" thing on the left;
e.g. [OK] [Cancel] dialogs.  I just found it odd to interact with.

Maybe people default themselves to -1 though :)

The colours for +1/-1 seem to be missing.  You've got to think a lot
more to parse the +1/-1 rather than just glance at the colours.

-i

[1] http://imgur.com/QWXOMen

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Tony Breeds]

On Tue, Oct 13, 2015 at 05:08:29PM -0700, Zaro wrote:
> Hello All,
> 
> The openstack-infra team would like to upgrade from our Gerrit 2.8 to
> Gerrit 2.11.  We are proposing to do the upgrade shortly after the
> Mitaka summit.  The main motivation behind the upgrade is to allow us
> to take advantage of some of the new REST api, ssh commands, and
> stream events features.  Also we wanted to stay closer to upstream so
> it will be easier to pick up more recent features and fixes.

Yeah really looking forward to 2.11!
 
> We want to let everyone know that there is a big UI change in Gerrit
> 2.11.  The change screen (CS), which is the main view for a patchset,
> has been completely replaced with a new change screen (CS2).  While
> Gerrit 2.8 contains both old CS and CS2, I believe everyone in
> Openstack land is really just using the old CS.  CS2 really wasn't

Just clarifying because -ENOTENOUGHCOFFEE

So in the Gerrit UI under (https://review.openstack.org/)
Settings -> Preferences -> Change view,  I have 3 options
 * Server Default (Old Screen)
 * Old Screen
 * New screen

I assume that 'Old Screen' == CS and 'New Screen' == CS2.

Yours Tony.


pgpc_CJE2kc7i.pgp
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Anita Kuno]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 10/14/2015 07:07 PM, Tony Breeds wrote:
> On Tue, Oct 13, 2015 at 05:08:29PM -0700, Zaro wrote:
>> Hello All,
>> 
>> The openstack-infra team would like to upgrade from our Gerrit
>> 2.8 to Gerrit 2.11.  We are proposing to do the upgrade shortly
>> after the Mitaka summit.  The main motivation behind the upgrade
>> is to allow us to take advantage of some of the new REST api, ssh
>> commands, and stream events features.  Also we wanted to stay
>> closer to upstream so it will be easier to pick up more recent
>> features and fixes.
> 
> Yeah really looking forward to 2.11!
> 
>> We want to let everyone know that there is a big UI change in
>> Gerrit 2.11.  The change screen (CS), which is the main view for
>> a patchset, has been completely replaced with a new change screen
>> (CS2).  While Gerrit 2.8 contains both old CS and CS2, I believe
>> everyone in Openstack land is really just using the old CS.  CS2
>> really wasn't
> 
> Just clarifying because -ENOTENOUGHCOFFEE
> 
> So in the Gerrit UI under (https://review.openstack.org/) Settings
> -> Preferences -> Change view,  I have 3 options * Server Default
> (Old Screen) * Old Screen * New screen
> 
> I assume that 'Old Screen' == CS and 'New Screen' == CS2.

Correct, though Khai made the point 2.8 new screen isn't the same as
2.11 new screen. 2.11 new screen can be found at
review-dev.openstack.org (sign in like you would sign into review.o.o).

Thanks,
Anita.

> 
> Yours Tony.
> 
> 
> 
> __

>
> 
OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
> openstack-dev-requ...@lists.openstack.org?subject:unsubscribe 
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 

-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJWHuZOAAoJELmKyZugNFU0AVsH/13q3HQlpD5CQNl6slNZRvXl
ajhuOUphFwQ8Tv7KTw1Z5G9HQL6mUd/M2HGGvRHAPJKtDczeI6i6zw4E+s9eTezu
QmB5wMN6GkNuz3AvzGif/xkUCjphiw4X/rgkXoKHPjxVg/1AqqSLouy4l8KFSFE4
UVl5/pcSXLHNzChYOH0VdsPgW0TE0UjV3yZ6J9fAaV64xNjG7cODetWcWeixcGO6
2g7Of7/4oAqfUWYGVLfMs53uU3BQy7FPlGyEBmuTKlYeZlEVRw8si/L4BtIaQYhW
lbDn1Lsup8HzzpaccWxIqcaX8QehCdPuHibui9xpQj5VVTAhM8U5/UcJr4y2luw=
=fQOk
-END PGP SIGNATURE-

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Ihar Hrachyshka]

> On 14 Oct 2015, at 02:08, Zaro  wrote:
> 
> Hello All,
> 
> The openstack-infra team would like to upgrade from our Gerrit 2.8 to
> Gerrit 2.11.  We are proposing to do the upgrade shortly after the
> Mitaka summit.  The main motivation behind the upgrade is to allow us
> to take advantage of some of the new REST api, ssh commands, and
> stream events features.  Also we wanted to stay closer to upstream so
> it will be easier to pick up more recent features and fixes.
> 
> We want to let everyone know that there is a big UI change in Gerrit
> 2.11.  The change screen (CS), which is the main view for a patchset,
> has been completely replaced with a new change screen (CS2).  While
> Gerrit 2.8 contains both old CS and CS2, I believe everyone in
> Openstack land is really just using the old CS.  CS2 really wasn't
> ready in 2.8 and really should never be used in that version.  The CS2
> has come a long way since then and many other big projects have moved
> to using Gerrit 2.11 so it's not a concern any longer.  If you would
> like a preview of Gerrit 2.11 and maybe help us test it, head over to
> http://review-dev.openstack.org.  If you are very opposed to CS2 then
> you may like Gertty (https://pypi.python.org/pypi/gertty) instead.  If
> neither option works for you then maybe you can help us create a new
> alternative :)
> 
> We are soliciting feedback so please let us know what you think.

I had a chance to use the new gerrit UI on gerrithub and on internally in my 
company, and I need to admit that it breaks my keyboard based flow, and I 
haven’t found a way to behave it the old way.

Specifically, I use [ and ] keys to switch between files in the same patchset. 
It’s especially useful when comparing mostly identical patchsets, or reviewing 
backports. Now, with the new UI, it does not work for me, so I need to reach to 
my mouse to switch between files. Also ‘r’ did not work for me, I expect other 
shortcuts being affected too. It could be a local configuration issue, but the 
fact that I experience it on two independent setups suggests that it’s an 
upstream issue.

Another problem with the new UI I have is that sometimes it does not show full 
header of the page (with the links to file list, diff modes, etc.) when I’m in 
patch review mode, and I need to reload the page to see it. That could be a 
browser issue, but I checked it for both Safari and Chrome - fails the same way.

Ihar


signature.asc
Description: Message signed with OpenPGP using GPGMail
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Dean Troyer]

On Wed, Oct 14, 2015 at 3:51 AM, Thierry Carrez 
wrote:

> My main issue with CS2 is how greedy it is in horizontal space, mostly
> due to the waste of space in the "Related changes" panel. If there are
> related changes, the owner/reviewer/voting panel is cramped in the
> middle, while "related changes" has a lot of empty space on the right.
> Is there a way to turn that panel off (move it to a dropdown like the
> patchsets view), or make it use half the width, or push it under
> ChangeID, or...
>

I'm going to concur with ttx here.  That 'Related changes' section can have
at least 4 horizontal sub-tabs (see
https://review-dev.openstack.org/#/c/5294/) and just really seems out of
place where it is. If it is possible to make it another component in the
vertical stack of sections I think it would look a lot better in
less-than-full-screen-width browsers.  In reviews where it is not displayed
the (formerly center) column actually looks a lot better.

Also, did I miss where it indicates order in a series of stacked reviews?
I didn't see one in the test set yet.

The rest of the changes fall into the 'change is hard' category for me and
I'll forget the current screen in a month and life will go on.

Thanks for keeping us up to date guys!

dt

-- 

Dean Troyer
dtro...@gmail.com
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [infra] Upgrade to Gerrit 2.11

[Sean Dague]

On 10/14/2015 07:57 AM, Ihar Hrachyshka wrote:
>> On 14 Oct 2015, at 02:08, Zaro  wrote:
>>
>> Hello All,
>>
>> The openstack-infra team would like to upgrade from our Gerrit 2.8 to
>> Gerrit 2.11.  We are proposing to do the upgrade shortly after the
>> Mitaka summit.  The main motivation behind the upgrade is to allow us
>> to take advantage of some of the new REST api, ssh commands, and
>> stream events features.  Also we wanted to stay closer to upstream so
>> it will be easier to pick up more recent features and fixes.
>>
>> We want to let everyone know that there is a big UI change in Gerrit
>> 2.11.  The change screen (CS), which is the main view for a patchset,
>> has been completely replaced with a new change screen (CS2).  While
>> Gerrit 2.8 contains both old CS and CS2, I believe everyone in
>> Openstack land is really just using the old CS.  CS2 really wasn't
>> ready in 2.8 and really should never be used in that version.  The CS2
>> has come a long way since then and many other big projects have moved
>> to using Gerrit 2.11 so it's not a concern any longer.  If you would
>> like a preview of Gerrit 2.11 and maybe help us test it, head over to
>> http://review-dev.openstack.org.  If you are very opposed to CS2 then
>> you may like Gertty (https://pypi.python.org/pypi/gertty) instead.  If
>> neither option works for you then maybe you can help us create a new
>> alternative :)
>>
>> We are soliciting feedback so please let us know what you think.
> 
> I had a chance to use the new gerrit UI on gerrithub and on internally in my 
> company, and I need to admit that it breaks my keyboard based flow, and I 
> haven’t found a way to behave it the old way.
> 
> Specifically, I use [ and ] keys to switch between files in the same 
> patchset. It’s especially useful when comparing mostly identical patchsets, 
> or reviewing backports. Now, with the new UI, it does not work for me, so I 
> need to reach to my mouse to switch between files. Also ‘r’ did not work for 
> me, I expect other shortcuts being affected too. It could be a local 
> configuration issue, but the fact that I experience it on two independent 
> setups suggests that it’s an upstream issue.

On review-dev [ and ] still work for me (as well as the other keyboard
short cuts).

The one shortcut change between CS1 and CS2 that trips me up flipping
back and forth is 'r' used to be review, now it's toggle the review flag
on  file. Now it's 'a' to review and leave comments.

> Another problem with the new UI I have is that sometimes it does not show 
> full header of the page (with the links to file list, diff modes, etc.) when 
> I’m in patch review mode, and I need to reload the page to see it. That could 
> be a browser issue, but I checked it for both Safari and Chrome - fails the 
> same way.
> 
> Ihar
> 
> 
> 
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 


-- 
Sean Dague
http://dague.net

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev