Re: [openstack-dev] [ironic] Remove in-tree policy and config?

2018-01-24 Thread Loo, Ruby 
Thanks for bringing it up John. I totally forgot about that. Not only are the 
samples in the docs, there is a link in those docs so that the sample can be 
downloaded as a file. Also, for a patch that modifies the configs, you can see 
the rendered file(s) via the generated docs. PROFIT! :)

+1.

--ruby

Now to deal with the "" in our config file... grumble, 
grumble...

From: Jim Rollenhagen <j...@jimrollenhagen.com>
Reply-To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Date: Monday, January 22, 2018 at 3:55 PM
To: "OpenStack Development Mailing List (not for usage questions)" 
<openstack-dev@lists.openstack.org>
Subject: Re: [openstack-dev] [ironic] Remove in-tree policy and config?

Huge +1, I didn't realize this was in docs now. We can finally stop doing it 
manually \o/


// jim

On Mon, Jan 22, 2018 at 7:45 AM, John Garbutt 
<j...@johngarbutt.com<mailto:j...@johngarbutt.com>> wrote:
Hi,

While I was looking at the traits work, I noticed we still have policy and 
config in tree for ironic and ironic inspector:

http://git.openstack.org/cgit/openstack/ironic/tree/etc/ironic/policy.json.sample
http://git.openstack.org/cgit/openstack/ironic/tree/etc/ironic/ironic.conf.sample
http://git.openstack.org/cgit/openstack/ironic/tree/etc/ironic/policy.json

And in a similar way:
http://git.openstack.org/cgit/openstack/ironic-inspector/tree/policy.yaml.sample
http://git.openstack.org/cgit/openstack/ironic-inspector/tree/example.conf

There is an argument that says we shouldn't force operators to build a full 
environment to generate these, but this has been somewhat superseded by us 
having good docs:

https://docs.openstack.org/ironic/latest/configuration/sample-config.html
https://docs.openstack.org/ironic/latest/configuration/sample-policy.html
https://docs.openstack.org/ironic-inspector/latest/configuration/sample-config.html
https://docs.openstack.org/ironic-inspector/latest/configuration/sample-policy.html

It could look something like this (but with the tests working...):
https://review.openstack.org/#/c/536349

What do you all think?

Thanks,
johnthetubaguy

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: 
openstack-dev-requ...@lists.openstack.org?subject:unsubscribe<http://openstack-dev-requ...@lists.openstack.org?subject:unsubscribe>
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] Remove in-tree policy and config?

2018-01-22 Thread Jim Rollenhagen 
Huge +1, I didn't realize this was in docs now. We can finally stop doing
it manually \o/


// jim

On Mon, Jan 22, 2018 at 7:45 AM, John Garbutt  wrote:

> Hi,
>
> While I was looking at the traits work, I noticed we still have policy and
> config in tree for ironic and ironic inspector:
>
> http://git.openstack.org/cgit/openstack/ironic/tree/etc/
> ironic/policy.json.sample
> http://git.openstack.org/cgit/openstack/ironic/tree/etc/
> ironic/ironic.conf.sample
> http://git.openstack.org/cgit/openstack/ironic/tree/etc/ironic/policy.json
>
> And in a similar way:
> http://git.openstack.org/cgit/openstack/ironic-inspector/
> tree/policy.yaml.sample
> http://git.openstack.org/cgit/openstack/ironic-inspector/tree/example.conf
>
> There is an argument that says we shouldn't force operators to build a
> full environment to generate these, but this has been somewhat superseded
> by us having good docs:
>
> https://docs.openstack.org/ironic/latest/configuration/sample-config.html
> https://docs.openstack.org/ironic/latest/configuration/sample-policy.html
> https://docs.openstack.org/ironic-inspector/latest/
> configuration/sample-config.html
> https://docs.openstack.org/ironic-inspector/latest/
> configuration/sample-policy.html
>
> It could look something like this (but with the tests working...):
> https://review.openstack.org/#/c/536349
>
> What do you all think?
>
> Thanks,
> johnthetubaguy
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] Remove in-tree policy and config?

2018-01-22 Thread Pavlo Shchelokovskyy 
John,

+1.

The sample file in etc/ironic/ in our repo is actually (almost) always out
of sync with the one in the docs - the docs one is re-generated on each
commit with new/changed stuff from third-party libs, the version in
etc/ironic is only updated manually when someone remembers it (as people
usually tend to limit the changes to this file in their commit to relevant
ones).

Cheers,

On Mon, Jan 22, 2018 at 2:45 PM, John Garbutt  wrote:

> Hi,
>
> While I was looking at the traits work, I noticed we still have policy and
> config in tree for ironic and ironic inspector:
>
> http://git.openstack.org/cgit/openstack/ironic/tree/etc/
> ironic/policy.json.sample
> http://git.openstack.org/cgit/openstack/ironic/tree/etc/
> ironic/ironic.conf.sample
> http://git.openstack.org/cgit/openstack/ironic/tree/etc/ironic/policy.json
>
> And in a similar way:
> http://git.openstack.org/cgit/openstack/ironic-inspector/
> tree/policy.yaml.sample
> http://git.openstack.org/cgit/openstack/ironic-inspector/tree/example.conf
>
> There is an argument that says we shouldn't force operators to build a
> full environment to generate these, but this has been somewhat superseded
> by us having good docs:
>
> https://docs.openstack.org/ironic/latest/configuration/sample-config.html
> https://docs.openstack.org/ironic/latest/configuration/sample-policy.html
> https://docs.openstack.org/ironic-inspector/latest/
> configuration/sample-config.html
> https://docs.openstack.org/ironic-inspector/latest/
> configuration/sample-policy.html
>
> It could look something like this (but with the tests working...):
> https://review.openstack.org/#/c/536349
>
> What do you all think?
>
> Thanks,
> johnthetubaguy
>
> __
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>


-- 
Dr. Pavlo Shchelokovskyy
Senior Software Engineer
Mirantis Inc
www.mirantis.com
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [ironic] Remove in-tree policy and config?

2018-01-22 Thread Dmitry Tantsur 

+1

I would really hate to not have a place to reference people to, but the 
documentation now provides such place. Keeping the examples up-to-date is quite 
annoying, I'm all for dropping them.


On 01/22/2018 01:45 PM, John Garbutt wrote:

Hi,

While I was looking at the traits work, I noticed we still have policy and 
config in tree for ironic and ironic inspector:


http://git.openstack.org/cgit/openstack/ironic/tree/etc/ironic/policy.json.sample
http://git.openstack.org/cgit/openstack/ironic/tree/etc/ironic/ironic.conf.sample
http://git.openstack.org/cgit/openstack/ironic/tree/etc/ironic/policy.json

And in a similar way:
http://git.openstack.org/cgit/openstack/ironic-inspector/tree/policy.yaml.sample
http://git.openstack.org/cgit/openstack/ironic-inspector/tree/example.conf

There is an argument that says we shouldn't force operators to build a full 
environment to generate these, but this has been somewhat superseded by us 
having good docs:


https://docs.openstack.org/ironic/latest/configuration/sample-config.html
https://docs.openstack.org/ironic/latest/configuration/sample-policy.html
https://docs.openstack.org/ironic-inspector/latest/configuration/sample-config.html
https://docs.openstack.org/ironic-inspector/latest/configuration/sample-policy.html

It could look something like this (but with the tests working...):
https://review.openstack.org/#/c/536349

What do you all think?

Thanks,
johnthetubaguy


__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev