Re: [Openvpn-devel] [PATCH applied] Re: t_client.sh: Allow to skip tests
Hi, On Mon, Mar 11, 2024 at 12:44:20PM +0100, Frank Lichtenheld wrote: > On Fri, Mar 08, 2024 at 12:51:33PM +0100, Gert Doering wrote: > [...] > > Your patch has been applied to the master branch. > > Could we please cherry-pick this to release/2.6 as well? > > Would make it much easier to use this capability in our buildbot > infrastructure and the patch only affects tests anyway. I did toy with the idea, but was afraid it wouldn't work as so much of the new unit test infra is only in master - the t_client patch is trivial, but ntlm_support + mock_msg. Turns out this went smoothly, so here we go... gert@gentoo ~/openvpn-26.git $ tests/ntlm_support gert@gentoo ~/openvpn-26.git $ echo $? 0 (openssl build) > > commit 0c7cf0694ee6f878168330e9a084c255c51a9e8b > > Author: Frank Lichtenheld > > Date: Fri Mar 8 11:28:18 2024 +0100 > > > > t_client.sh: Allow to skip tests commit bbc77d1719d2d5b33e58abac5eba8b8e409561ab (HEAD -> release/2.6, vweb1/release/2.6) Author: Frank Lichtenheld Date: Fri Mar 8 11:28:18 2024 +0100 t_client.sh: Allow to skip tests (cherry picked from commit 0c7cf0694ee6f878168330e9a084c255c51a9e8b) gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XS] Change in openvpn[master]: Avoid SIGUR1 to SIGHUP when the configuration is read from stdin
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/533?usp=email ) Change subject: Avoid SIGUR1 to SIGHUP when the configuration is read from stdin .. Patch Set 1: (1 comment) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/533/comment/8488b519_2420d9dd : PS1, Line 11: "close_context usr1 to hup" logic, the OpenVPN process will fail as tries Please add a short explanation of when this logic might be hit. It is completely unclear to me from the code how you might hit this (especially since both HUP and USR1 are blocked during init_instance). Something with management? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/533?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icfc179490d6821e22d14817941fb0bad667c713f Gerrit-Change-Number: 533 Gerrit-PatchSet: 1 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Mon, 11 Mar 2024 15:09:52 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [S] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email ) Change subject: Http-proxy: fix bug preventing proxy credentials caching .. Patch Set 5: (4 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/523/comment/0095e7d0_7032f979 : PS5, Line 21: http_proxy_options and also a getter method to retrieve The man page for --auth-nocache still says it has no effect on --http-proxy. This needs to be updated. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/10c5ad5e_1e39dee3 : PS5, Line 3126: if (ce->http_proxy_options) This needs to be moved one level up. E.g. when using "--proto tcp4-client" currently --auth-nocache is ignored, since proto is already PROTO_TCP_CLIENT. There should be no issue with always setting this independently of ce->proto. File src/openvpn/proxy.h: http://gerrit.openvpn.net/c/openvpn/+/523/comment/2c3993c2_e1173cce : PS5, Line 61: bool nocache; Please update "show_http_proxy_options" in options.c to show value of nocache. File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/663d790d_11843add : PS5, Line 669: if (p->up.nocache) wouldn't it be better to move this clearing into get_user_pass_http? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 5 Gerrit-Owner: its_Giaan Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Comment-Date: Mon, 11 Mar 2024 14:45:37 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [S] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching
Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/523?usp=email ) Change subject: Http-proxy: fix bug preventing proxy credentials caching .. Patch Set 5: Code-Review-2 (1 comment) Patchset: PS5: Tried to test this change but my tests failed to produce the desired behavior. Should figure out the problem before merging. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 5 Gerrit-Owner: its_Giaan Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Comment-Date: Mon, 11 Mar 2024 12:29:43 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH applied] Re: t_client.sh: Allow to skip tests
On Fri, Mar 08, 2024 at 12:51:33PM +0100, Gert Doering wrote: [...] > Your patch has been applied to the master branch. Could we please cherry-pick this to release/2.6 as well? Would make it much easier to use this capability in our buildbot infrastructure and the patch only affects tests anyway. > commit 0c7cf0694ee6f878168330e9a084c255c51a9e8b > Author: Frank Lichtenheld > Date: Fri Mar 8 11:28:18 2024 +0100 > > t_client.sh: Allow to skip tests > > Signed-off-by: Frank Lichtenheld > Acked-by: Gert Doering > Message-Id: <20240308102818.9249-1-g...@greenie.muc.de> > URL: > https://www.mail-archive.com/search?l=mid=20240308102818.9249-1-g...@greenie.muc.de > Signed-off-by: Gert Doering > > > -- > kind regards, > > Gert Doering > -- Frank Lichtenheld ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
