Re: [Openvpn-devel] [PATCH] Fix various spelling mistakes
Am 23.01.19 um 21:17 schrieb jonat...@reliablehosting.com: > From: Jonathan Tooker > > New patch, omitted changes to copyrights/licenses & changelog. > --- Thanks! Acked-By: Arne Schwabe signature.asc Description: OpenPGP digital signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH] Fix various spelling mistakes
From: Jonathan Tooker New patch, omitted changes to copyrights/licenses & changelog. --- Changes.rst | 6 +++--- INSTALL | 2 +- TODO.IPv6 | 6 +++--- configure.ac | 2 +- distro/rpm/openvpn.init.d.rhel| 2 +- distro/rpm/openvpn.init.d.suse| 4 ++-- doc/keying-material-exporter.txt | 2 +- doc/openvpn.8 | 14 +++--- m4/pkg.m4 | 2 +- sample/sample-config-files/client.conf| 2 +- sample/sample-keys/openssl.cnf| 4 ++-- src/openvpn/buffer.c | 2 +- src/openvpn/console.h | 6 +++--- src/openvpn/crypto.h | 2 +- src/openvpn/crypto_backend.h | 2 +- src/openvpn/fragment.c| 2 +- src/openvpn/init.c| 18 +- src/openvpn/mss.c | 2 +- src/openvpn/options.c | 14 +++--- src/openvpn/packet_id.h | 2 +- src/openvpn/route.c | 2 +- src/openvpn/run_command.c | 4 ++-- src/openvpn/socket.c | 12 ++-- src/openvpn/socket.h | 2 +- src/openvpn/ssl.c | 2 +- src/openvpn/ssl_verify_backend.h | 2 +- src/openvpn/tun.c | 8 src/openvpn/win32.c | 2 +- src/openvpn/win32.h | 2 +- src/openvpnmsica/msica_op.h | 2 +- src/plugins/auth-pam/README.auth-pam | 4 ++-- src/plugins/auth-pam/utils.h | 6 +++--- src/tapctl/tap.c | 2 +- tests/t_client.sh.in | 2 +- tests/unit_tests/openvpn/test_tls_crypt.c | 2 +- 35 files changed, 75 insertions(+), 75 deletions(-) diff --git a/Changes.rst b/Changes.rst index a7429b11..00dd6ed8 100644 --- a/Changes.rst +++ b/Changes.rst @@ -26,7 +26,7 @@ Seamless client IP/port floating the new format. When a data packet arrives, the server identifies peer by peer-id. If peer's ip/port has changed, server assumes that client has floated, verifies HMAC and updates ip/port in internal structs. -This allows the connection to be immediatly restored, instead of requiring +This allows the connection to be immediately restored, instead of requiring a TLS handshake before the server accepts packets from the new client ip/port. @@ -223,7 +223,7 @@ User-visible Changes of a field get _$N appended to it's field name, starting at N=1. For the example above, that would result in e.g. X509_0_OU=one, X509_0_OU_1=two. Note that this breaks setups that rely on the fact that OpenVPN would - previously (incorrectly) only export the last occurence of a field. + previously (incorrectly) only export the last occurrence of a field. - ``proto udp`` and ``proto tcp`` now use both IPv4 and IPv6. The new options ``proto udp4`` and ``proto tcp4`` use IPv4 only. @@ -371,7 +371,7 @@ Security - CVE-2017-7521: Fix post-authentication remote-triggerable memory leaks A client could cause a server to leak a few bytes each time it connects to the - server. That can eventuall cause the server to run out of memory, and thereby + server. That can eventually cause the server to run out of memory, and thereby causing the server process to terminate. Discovered and reported to the OpenVPN security team by Guido Vranken. (OpenSSL builds only.) diff --git a/INSTALL b/INSTALL index 0f12a636..d0c7dfa6 100644 --- a/INSTALL +++ b/INSTALL @@ -200,7 +200,7 @@ OPTIONS for ./configure: --enable-strict-options enable strict options check between peers (debugging option) [default=no] --enable-selinuxenable SELinux support [default=no] - --enable-systemdenable systemd suppport [default=no] + --enable-systemdenable systemd support [default=no] ENVIRONMENT for ./configure: diff --git a/TODO.IPv6 b/TODO.IPv6 index 24bf865a..465eaa66 100644 --- a/TODO.IPv6 +++ b/TODO.IPv6 @@ -21,7 +21,7 @@ TODO for IPv6 payload support 4.) do "ifconfig tun0 inet6 unplumb" or "ifconfig tun0 destroy" for Solaris, *BSD, ... at program termination time, to clean up leftovers -(unless tunnel persistance is desired). +(unless tunnel persistence is desired). For Solaris, only the "ipv6 tun0" is affected, for the *BSDs all tun0 stay around. @@ -47,7 +47,7 @@ tun0: flags=8051 mtu 1500 4b.) verify this - on FreeBSD, tun0 is auto-destroyed if created by opening /dev/tun (and lingers if created by "ifconfig tun0 create") - -> use for persistant tunnels on not-linux? + -> use for persistent tunnels on not-linux? * 2012-06-10 tun interface behaviour is
Re: [Openvpn-devel] [PATCH] Fix various spelling mistakes
Hi, On Tue, Jan 22, 2019 at 09:31:03PM -0600, Jonathan Tooker wrote: > Fork @ github: https://github.com/JDTX/openvpn > (76ab12606155f51aaaf376a46f4a52a459af105c) > > From: Jonathan Tooker > Date: Tue, 22 Jan 2019 18:27:39 -0600 > Subject: [PATCH] Fix various spelling mistakes > > Fix spelling mistakes in code/headers/manpages/etc. While I'm always happy to receive spelling/documentation fixes, *this* patch got mangled by your mail client and git refuses to apply it - your mail client removed leading blanks in *some* lines, so pieces like this: > diff --git a/distro/rpm/openvpn.init.d.suse b/distro/rpm/openvpn.init.d.suse > index 270024e8..1b4bcf06 100644 > --- a/distro/rpm/openvpn.init.d.suse > +++ b/distro/rpm/openvpn.init.d.suse > @@ -72,7 +72,7 @@ > #- removed sourcing "network" > #- removed network checking. it seemed not to > work with SuSE. > #- added sourcing "rc.status", comments and > "rc_reset" command > -#- removed "succes; echo" and "failure; echo" > lines > +# - removed "success; echo" and "failure; echo" > lines ... are no longer a valid patch. Can you please re-send with "git send-email", which normally gets things right even though everything out there is intent on massacring mails these days? thanks, gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH] Fix various spelling mistakes
Am 23.01.19 um 04:31 schrieb Jonathan Tooker: > Fork @ github: https://github.com/JDTX/openvpn > (76ab12606155f51aaaf376a46f4a52a459af105c) > > From: Jonathan Tooker > Date: Tue, 22 Jan 2019 18:27:39 -0600 > Subject: [PATCH] Fix various spelling mistakes > I have gone through all of the correction and they are all correct and some of them are my fault. Acked-By: Arne Schwabe Arne signature.asc Description: OpenPGP digital signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Re: [Openvpn-devel] [PATCH] Fix various spelling mistakes
Am 23.01.19 um 06:15 schrieb Jonathan Tooker:
> Looks like I missed that and a few others! I fixed some more spelling
> errors across other things. Follow up patch/commit below. If I just need
> to re-make the original patch let me know.
>
> From: Jonathan Tooker
> Date: Tue, 22 Jan 2019 23:10:33 -0600
> Subject: [PATCH] Another set of spelling fixes
>
> ---
> COPYING | 6 +-
> ChangeLog| 140 +++
> Changes.rst | 6 +-
> INSTALL | 2 +-
> TODO.IPv6| 6 +-
> configure.ac | 2 +-
> m4/pkg.m4| 2 +-
> src/openvpn/console.h| 2 +-
> src/openvpn/ssl_verify_backend.h | 2 +-
> 9 files changed, 84 insertions(+), 84 deletions(-)
>
> diff --git a/COPYING b/COPYING
> index 9c21c177..54cc9f24 100644
> --- a/COPYING
> +++ b/COPYING
> @@ -157,7 +157,7 @@ OpenSSL License:
> * The implementation was written so as to conform with Netscapes SSL.
> *
> * This library is free for commercial and non-commercial use as long as
> - * the following conditions are aheared to. The following conditions
> + * the following conditions are adhered to. The following conditions
> * apply to all code found in this distribution, be it the RC4, RSA,
> * lhash, DES, etc., code; not just the SSL code. The SSL documentation
> * included with this distribution is covered by the same copyright terms
> @@ -182,7 +182,7 @@ OpenSSL License:
> *must display the following acknowledgement:
> *"This product includes cryptographic software written by
> * Eric Young (e...@cryptsoft.com)"
> - *The word 'cryptographic' can be left out if the rouines from the
> library
> + *The word 'cryptographic' can be left out if the routines from the
> library
> *being used are not cryptographic related :-).
> * 4. If you include any Windows specific code (or a derivative thereof)
> from
> *the apps directory (application code) you must include an
> acknowledgement:
> @@ -200,7 +200,7 @@ OpenSSL License:
> * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> * SUCH DAMAGE.
> *
> - * The licence and distribution terms for any publically available version or
> + * The licence and distribution terms for any publicly available version or
> * derivative of this code cannot be changed. i.e. this code cannot simply
> be
> * copied and put under another distribution licence
> * [including the GNU Public Licence.]
Yes there are spelling mistakes in the license but changing someone
else's license is an absolute nogo, no matter how wrong it is spelt.
Even the current OpenSSL version (1.1.1a) has the text with the spelling
mistakes in it.
[Changelog entries]
I am not sure about the changelog. Changes.rst can be spell checked but
Changelog also doubles as a list of the git commit, so I feel it should
be the same as the commits.
> diff --git a/src/openvpn/console.h b/src/openvpn/console.h
> index 62beacae..f9481684 100644
> --- a/src/openvpn/console.h
> +++ b/src/openvpn/console.h
> @@ -35,7 +35,7 @@ struct _query_user {
> char *prompt; /**< Prompt to present to the user */
> size_t prompt_len;/**< Length of the prompt string */
> char *response; /**< The user's response */
> -size_t response_len; /**< Length the of the user reposone */
> +size_t response_len; /**< Length the of the user response */
> bool echo;/**< True: The user should see what is being
> typed, otherwise mask it */
> };
>
> diff --git a/src/openvpn/ssl_verify_backend.h
> b/src/openvpn/ssl_verify_backend.h
> index f4cc2c54..d6b31bfa 100644
> --- a/src/openvpn/ssl_verify_backend.h
> +++ b/src/openvpn/ssl_verify_backend.h
> @@ -176,7 +176,7 @@ void x509_setenv(struct env_set *es, int cert_depth,
> openvpn_x509_cert_t *cert);
> *
> * The tracked attributes are stored in ll_head.
> *
> - * @param ll_head The x509_track to store tracked atttributes in
> + * @param ll_head The x509_track to store tracked attributes in
> * @param name Name of the attribute to track
> * @param msglevel Message level for errors
> * @param gcGarbage collection arena for temp data
> --
> 2.20.1.windows.1
>
>
>
> On 1/22/2019 9:51 PM, Simon Matter wrote:
>> Hi,
>>
>>> diff --git a/src/openvpn/console.h b/src/openvpn/console.h
>>> index 0ffd6683..62beacae 100644
>>> --- a/src/openvpn/console.h
>>> +++ b/src/openvpn/console.h
>>> @@ -33,9 +33,9 @@
>>> */
>>> struct _query_user {
>>> char *prompt; /**< Prompt to present to the user */
>>> -size_t prompt_len;/**< Lenght of the prompt string */
>>> +size_t prompt_len;/**< Length of the prompt string */
>>> char *response; /**< The user's response */
>>> -size_t
Re: [Openvpn-devel] [PATCH] Fix various spelling mistakes
Looks like I missed that and a few others! I fixed some more spelling
errors across other things. Follow up patch/commit below. If I just need
to re-make the original patch let me know.
From: Jonathan Tooker
Date: Tue, 22 Jan 2019 23:10:33 -0600
Subject: [PATCH] Another set of spelling fixes
---
COPYING | 6 +-
ChangeLog| 140 +++
Changes.rst | 6 +-
INSTALL | 2 +-
TODO.IPv6| 6 +-
configure.ac | 2 +-
m4/pkg.m4| 2 +-
src/openvpn/console.h| 2 +-
src/openvpn/ssl_verify_backend.h | 2 +-
9 files changed, 84 insertions(+), 84 deletions(-)
diff --git a/COPYING b/COPYING
index 9c21c177..54cc9f24 100644
--- a/COPYING
+++ b/COPYING
@@ -157,7 +157,7 @@ OpenSSL License:
* The implementation was written so as to conform with Netscapes SSL.
*
* This library is free for commercial and non-commercial use as long as
- * the following conditions are aheared to. The following conditions
+ * the following conditions are adhered to. The following conditions
* apply to all code found in this distribution, be it the RC4, RSA,
* lhash, DES, etc., code; not just the SSL code. The SSL documentation
* included with this distribution is covered by the same copyright terms
@@ -182,7 +182,7 @@ OpenSSL License:
*must display the following acknowledgement:
*"This product includes cryptographic software written by
* Eric Young (e...@cryptsoft.com)"
- *The word 'cryptographic' can be left out if the rouines from the library
+ *The word 'cryptographic' can be left out if the routines from the library
*being used are not cryptographic related :-).
* 4. If you include any Windows specific code (or a derivative thereof) from
*the apps directory (application code) you must include an
acknowledgement:
@@ -200,7 +200,7 @@ OpenSSL License:
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
- * The licence and distribution terms for any publically available version or
+ * The licence and distribution terms for any publicly available version or
* derivative of this code cannot be changed. i.e. this code cannot simply be
* copied and put under another distribution licence
* [including the GNU Public Licence.]
diff --git a/ChangeLog b/ChangeLog
index 1c06c7f1..077d7063 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -128,7 +128,7 @@ Gert Doering (10):
Heiko Hund (4):
put argv_* functions into own file, add unit tests
- Remove unused and unecessary argv interfaces
+ Remove unused and unnecessary argv interfaces
remove unused system_str from struct argv
Factor out %sc handling from argv_printf()
@@ -230,7 +230,7 @@ Arne Schwabe (100):
Split the PROTO_UDP_xx options into AF_INET/AF_INET6 and
PROTO_TCP/PROTO_UDP part.
Fix two instances of asserting AF_INET
Fix assertion when SIGUSR1 is received while getaddrinfo is successful
- Split link_socket_init_phase1 and link_socket_init_phase2 into smaller
more managable/readable functions. No functional changes
+ Split link_socket_init_phase1 and link_socket_init_phase2 into smaller
more manageable/readable functions. No functional changes
Change proto_remote() function to return a constant string
Remove the ip-remote-hint option.
change the type of 'remote' to addrinfo*, and rename to 'remote_list'.
@@ -252,7 +252,7 @@ Arne Schwabe (100):
Add gateway and device to android control messages
Clean up of socket code.
Fix assert when using port-share
- Work around Solaris getaddrinfo() returing ai_protocol=0
+ Work around Solaris getaddrinfo() returning ai_protocol=0
Fix man page and OSCP script: tls_serial_{n} is decimal
Remove ENABLE_BUFFER_LIST
Fix server routes not working in topology subnet with --server [v3]
@@ -335,7 +335,7 @@ David Sommerseth (44):
autoconf: Fix typo
t_client.sh: Check for fping/fping6 availability
t_client.sh: Write errors to stderr and document requirements
- t_client.sh: Add prepare/cleanup possibilties for each test case
+ t_client.sh: Add prepare/cleanup possibilities for each test case
Fix file checks when --chroot is being used
Adjusted autotools files to build more cleanly on newer
autoconf/automake versions
Improve error reporting on file access to --client-config-dir and
--ccd-exclusive
@@ -382,7 +382,7 @@ Dorian Harmans (1):
Add CHACHA20-POLY1305 ciphersuite IANA name translations.
Felix Janda (1):
- Use OPENVPN_ETH_P_* so that is unecessary
+ Use OPENVPN_ETH_P_* so that is unnecessary
Fish (1):
Add lz4 support to MSVC.
@@ -531,7 +531,7 @@ Holger Kummert (1):
Del ipv6 addr on close of linux tun interface
Hubert Kario
Re: [Openvpn-devel] [PATCH] Fix various spelling mistakes
Hi,
> diff --git a/src/openvpn/console.h b/src/openvpn/console.h
> index 0ffd6683..62beacae 100644
> --- a/src/openvpn/console.h
> +++ b/src/openvpn/console.h
> @@ -33,9 +33,9 @@
> */
> struct _query_user {
> char *prompt; /**< Prompt to present to the user */
> -size_t prompt_len;/**< Lenght of the prompt string */
> +size_t prompt_len;/**< Length of the prompt string */
> char *response; /**< The user's response */
> -size_t response_len; /**< Lenght the of the user reposone */
> +size_t response_len; /**< Length the of the user reposone */
response
Regards,
Simon
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH] Fix various spelling mistakes
Fork @ github: https://github.com/JDTX/openvpn (76ab12606155f51aaaf376a46f4a52a459af105c) From: Jonathan Tooker Date: Tue, 22 Jan 2019 18:27:39 -0600 Subject: [PATCH] Fix various spelling mistakes Fix spelling mistakes in code/headers/manpages/etc. --- distro/rpm/openvpn.init.d.rhel| 2 +- distro/rpm/openvpn.init.d.suse| 4 ++-- doc/keying-material-exporter.txt | 2 +- doc/openvpn.8 | 14 +++--- sample/sample-config-files/client.conf| 2 +- sample/sample-keys/openssl.cnf| 4 ++-- src/openvpn/buffer.c | 2 +- src/openvpn/console.h | 6 +++--- src/openvpn/crypto.h | 2 +- src/openvpn/crypto_backend.h | 2 +- src/openvpn/fragment.c| 2 +- src/openvpn/init.c| 18 +- src/openvpn/mss.c | 2 +- src/openvpn/options.c | 14 +++--- src/openvpn/packet_id.h | 2 +- src/openvpn/route.c | 2 +- src/openvpn/run_command.c | 4 ++-- src/openvpn/socket.c | 12 ++-- src/openvpn/socket.h | 2 +- src/openvpn/ssl.c | 2 +- src/openvpn/tun.c | 8 src/openvpn/win32.c | 2 +- src/openvpn/win32.h | 2 +- src/openvpnmsica/msica_op.h | 2 +- src/plugins/auth-pam/README.auth-pam | 4 ++-- src/plugins/auth-pam/utils.h | 6 +++--- src/tapctl/tap.c | 2 +- tests/t_client.sh.in | 2 +- tests/unit_tests/openvpn/test_tls_crypt.c | 2 +- 29 files changed, 65 insertions(+), 65 deletions(-) diff --git a/distro/rpm/openvpn.init.d.rhel b/distro/rpm/openvpn.init.d.rhel index bfde2216..04125ca6 100755 --- a/distro/rpm/openvpn.init.d.rhel +++ b/distro/rpm/openvpn.init.d.rhel @@ -113,7 +113,7 @@ case "$1" in # From a security perspective, I think it makes # sense to remove this, and have users who need - # it explictly enable in their --up scripts or + # it explicitly enable in their --up scripts or # firewall setups. #echo 1 > /proc/sys/net/ipv4/ip_forward diff --git a/distro/rpm/openvpn.init.d.suse b/distro/rpm/openvpn.init.d.suse index 270024e8..1b4bcf06 100644 --- a/distro/rpm/openvpn.init.d.suse +++ b/distro/rpm/openvpn.init.d.suse @@ -72,7 +72,7 @@ #- removed sourcing "network" #- removed network checking. it seemed not to work with SuSE. #- added sourcing "rc.status", comments and "rc_reset" command -#- removed "succes; echo" and "failure; echo" lines +# - removed "success; echo" and "failure; echo" lines #- added "rc_status" lines at the end of each section #- changed "service" to "/etc/init.d/" in "In addition to start/stop" # section above. @@ -126,7 +126,7 @@ case "$1" in # From a security perspective, I think it makes # sense to remove this, and have users who need - # it explictly enable in their --up scripts or + # it explicitly enable in their --up scripts or # firewall setups. #echo 1 > /proc/sys/net/ipv4/ip_forward diff --git a/doc/keying-material-exporter.txt b/doc/keying-material-exporter.txt index 4187d828..4c1addc8 100644 --- a/doc/keying-material-exporter.txt +++ b/doc/keying-material-exporter.txt @@ -48,7 +48,7 @@ to application layer using well-defined mechanism. [DerivedAAABindingKey][DerivedAAABindingKey] [AuthenticateBindingKeys] Client ---> Server - [Confidental channel] + [Confidential channel] TLS Message flow for a full handshake diff --git a/doc/openvpn.8 b/doc/openvpn.8 index 7abcaf1e..e5c0626a 100644 --- a/doc/openvpn.8 +++ b/doc/openvpn.8 @@ -696,7 +696,7 @@ are used. If the .B ipv6only -keyword is present OpenVPN will bind only to IPv6 (as oposed +keyword is present OpenVPN will bind only to IPv6 (as opposed to IPv6 and IPv4) when a IPv6 socket is opened. .\"* @@ -2221,7 +2221,7 @@ that is parsed on the command line even though the daemonization point occurs later. If one of the .B \-\-log -options is present, it will supercede syslog +options is present, it will supersede syslog redirection. The optional @@ -2332,7 +2332,7 @@ If already exists it will be truncated. This option takes effect immediately when it
