[Openvpn-devel] [XL] Change in openvpn[release/2.6]: CMake: backport CMake buildsystem from master to release/2.6
Attention is currently required from: d12fk. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email ) Change subject: CMake: backport CMake buildsystem from master to release/2.6 .. Patch Set 3: (2 comments) Patchset: PS3: Will fix typo on submission File README.cmake.md: http://gerrit.openvpn.net/c/openvpn/+/315/comment/9117bb79_89326983 : PS2, Line 33: Enviroment > environment Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/315?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I6de18261d5dc7f8561612184059656c73f33a5f2 Gerrit-Change-Number: 315 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: d12fk Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: d12fk Gerrit-Comment-Date: Tue, 26 Sep 2023 09:49:28 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XL] Change in openvpn[release/2.6]: CMake: backport CMake buildsystem from master to release/2.6
Attention is currently required from: d12fk, flichtenheld. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email ) Change subject: CMake: backport CMake buildsystem from master to release/2.6 .. Patch Set 2: Code-Review+2 (1 comment) File README.cmake.md: http://gerrit.openvpn.net/c/openvpn/+/315/comment/f39fcf5a_d00bbdc2 : PS2, Line 33: Enviroment environment -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/315?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I6de18261d5dc7f8561612184059656c73f33a5f2 Gerrit-Change-Number: 315 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: d12fk Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Attention: d12fk Gerrit-Comment-Date: Mon, 25 Sep 2023 09:50:56 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XL] Change in openvpn[release/2.6]: CMake: backport CMake buildsystem from master to release/2.6
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email ) Change subject: CMake: backport CMake buildsystem from master to release/2.6 .. Patch Set 1: (5 comments) Patchset: PS1: Will put all the documentation/comment requests into a separate patch to make it easier to merge both in master and release/2.6 File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/315/comment/2fac3714_15b4e724 : PS1, Line 294: # TODO remove later when msvc-config.h is removed and we can always include config.h > This comment seems to be outdated, since we got rid of config-msvc. […] Acknowledged File README.cmake.md: http://gerrit.openvpn.net/c/openvpn/+/315/comment/9825cfee_238d23c0 : PS1, Line 27: can them install with a package manager of your choice (e.g. > *install them Acknowledged File contrib/cmake/git-version.py: http://gerrit.openvpn.net/c/openvpn/+/315/comment/7e42230e_d6445805 : PS1, Line 23: # > A comment what this does and why would be cool, but then maybe in master or > both here and there Acknowledged File contrib/cmake/parse-version.m4.py: http://gerrit.openvpn.net/c/openvpn/+/315/comment/abb2f492_3f01938f : PS1, Line 23: # > A comment what this does and why would be cool, but then maybe in master or > both here and there Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/315?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I6de18261d5dc7f8561612184059656c73f33a5f2 Gerrit-Change-Number: 315 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: d12fk Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Comment-Date: Tue, 19 Sep 2023 11:37:17 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: d12fk Comment-In-Reply-To: stipa Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XL] Change in openvpn[release/2.6]: CMake: backport CMake buildsystem from master to release/2.6
Attention is currently required from: flichtenheld. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email ) Change subject: CMake: backport CMake buildsystem from master to release/2.6 .. Patch Set 1: Code-Review+2 (3 comments) File README.cmake.md: http://gerrit.openvpn.net/c/openvpn/+/315/comment/1db29f03_003dbb6b : PS1, Line 27: can them install with a package manager of your choice (e.g. *install them File contrib/cmake/git-version.py: http://gerrit.openvpn.net/c/openvpn/+/315/comment/7da55e9b_6b13084e : PS1, Line 23: # A comment what this does and why would be cool, but then maybe in master or both here and there File contrib/cmake/parse-version.m4.py: http://gerrit.openvpn.net/c/openvpn/+/315/comment/df755f5f_7c8d4861 : PS1, Line 23: # A comment what this does and why would be cool, but then maybe in master or both here and there -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/315?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I6de18261d5dc7f8561612184059656c73f33a5f2 Gerrit-Change-Number: 315 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: d12fk Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 18 Sep 2023 22:20:36 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XL] Change in openvpn[release/2.6]: CMake: backport CMake buildsystem from master to release/2.6
Attention is currently required from: flichtenheld. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email ) Change subject: CMake: backport CMake buildsystem from master to release/2.6 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/315?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I6de18261d5dc7f8561612184059656c73f33a5f2 Gerrit-Change-Number: 315 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 24 Jul 2023 12:52:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [XL] Change in openvpn[release/2.6]: CMake: backport CMake buildsystem from master to release/2.6
Attention is currently required from: flichtenheld. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/315?usp=email ) Change subject: CMake: backport CMake buildsystem from master to release/2.6 .. Patch Set 1: (1 comment) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/315/comment/a88d6de4_30bc577d : PS1, Line 294: # TODO remove later when msvc-config.h is removed and we can always include config.h This comment seems to be outdated, since we got rid of config-msvc.h -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/315?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I6de18261d5dc7f8561612184059656c73f33a5f2 Gerrit-Change-Number: 315 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-CC: openvpn-devel Gerrit-CC: stipa Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 24 Jul 2023 12:48:53 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
