Re: [Openvpn-devel] build revolution lost t_client test?

[David Sommerseth]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 27/05/12 22:27, Gert Doering wrote:
> Hi,
> 
> working on the test server, I noticed that t_client.sh was no
> longer run from "make check", and that it lost "read t_client.rc
> from build dir" (which is needed when building different clients
> from a common source dir, and wanting to run t_client with
> different option sets).
> 
> The attached patch restores lost functionality, and adds one extra 
> feature, optionally waiting longer for OpenVPN startup (if the
> server has a high RTT, 10 seconds is not always enough).
> 
> David, this has been tested on FreeBSD 7.4 (so far) and is
> essential for the buildbot client tests :-) - more platform tests
> will follow as soon as I have all the server stanzas up and
> running.
> 
> gert

Applied to master branch and pushed out to -testing and -stable trees.


commit 47c990009c79fe2a96206c54e0240cb2dd8cdf02
Author: Gert Doering 
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Sun May 27 23:19:11 2012 +0300

repair t_client.sh test after build system revolution

Signed-off-by: Gert Doering 
Acked-by: David Sommerseth 
Message-Id: 20120527202737.gv1...@greenie.muc.de
URL: http://article.gmane.org/gmane.network.openvpn.devel/6616
Signed-off-by: David Sommerseth 


This patch was preferred over the patch from Alon, due to:

- - Both solves the same issue, with minor differences
- - This patch has an informative commit message
- - The alternative doesn't provide any arguments why that approach is
  better; in fact, the commit message is completely lacking.
- - The alternative reduces the information in an error message which
  can be helpful for the user running this test.


kind regards,

David Sommerseth
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/Im7AACgkQDC186MBRfrp/ogCbB9GIgwl6c+aU3mjC9xZNn5n6
UPMAoKSxjgbYJOSGHBNHsIKdAwVnOiar
=ZOom
-END PGP SIGNATURE-

Re: [Openvpn-devel] build revolution lost t_client test?

[Gert Doering]

Hi,

On Mon, May 28, 2012 at 03:08:11PM +0300, Samuli Seppänen wrote:
> I don't really care what the make target is called. It could even be an
> entirely different target. Buildslaves could easily run "make check"
> followed by "make root-check", "make connection-test" or whatever. If
> nobody outside the core project is supposed to run the connectivity
> tests, I think separating them from "make check" would make sense.

Nobody who hasn't set up a t_client.rc beforehand will be bothered by
the client connectivity tests anyway - "make check" will tell him 
"rc file hasn't been set up, skipping test", and that's all of it.

So while I can see some purity of argument here - in the end, it's 
wasting human life time on discussions again, and the time could be 
better spent on what's sorely missing right now: automated tests
(unit tests, client system tests, server system tests).

gert
-- 
USENET is *not* the non-clickable part of WWW!
   //www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025g...@net.informatik.tu-muenchen.de


pgpnm4m_DwVf5.pgp
Description: PGP signature

Re: [Openvpn-devel] build revolution lost t_client test?

[Samuli Seppänen]

Il 28.05.2012 10:52, Gert Doering ha scritto:
> Hi
>
> On Sun, May 27, 2012 at 11:36:57PM +0300, Alon Bar-Lev wrote:
>> t_client.sh requires root/sudo privileges.
>> "make check" should not assume any special privilege.
>> Because of this it is removed from "make check".
>> You can still run this by hand or we can add special target such as
>> "make root-check" or similar.
> There was agreement by the developers to *have* this, and no explicit
> agreement to *remove* it - you got an ACK for the patch, but I'm fairly
> sure that it was not made clear that you removed t_client.sh functionality
> while moving stuff around, because otherwise you would have seen NAKs.

It seems 34cb91 removed this functionality without explicitly mention
anything about it. It was a massive patch that moved stuff around, which
is why this change went unnoticed. Somebody please apply Gert's patch or
provide an alternative patch, I'd need to setup connectivity tests for
my buildslaves, too.

I don't really care what the make target is called. It could even be an
entirely different target. Buildslaves could easily run "make check"
followed by "make root-check", "make connection-test" or whatever. If
nobody outside the core project is supposed to run the connectivity
tests, I think separating them from "make check" would make sense.

-- 
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock

Re: [Openvpn-devel] build revolution lost t_client test?

[Gert Doering]

Hi

On Sun, May 27, 2012 at 11:36:57PM +0300, Alon Bar-Lev wrote:
> t_client.sh requires root/sudo privileges.
> "make check" should not assume any special privilege.
> Because of this it is removed from "make check".
> You can still run this by hand or we can add special target such as
> "make root-check" or similar.

There was agreement by the developers to *have* this, and no explicit
agreement to *remove* it - you got an ACK for the patch, but I'm fairly
sure that it was not made clear that you removed t_client.sh functionality
while moving stuff around, because otherwise you would have seen NAKs.

If someone wants to run it as non-root, RUN_SUDO can be defined in 
t_client.rc, and for someone having no provileges at all, you can just
leave off t_client.rc, and it will skip these tests with no adverse
effects.

gert
-- 
USENET is *not* the non-clickable part of WWW!
   //www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025g...@net.informatik.tu-muenchen.de


pgpMZ5BLhKpM9.pgp
Description: PGP signature

Re: [Openvpn-devel] build revolution lost t_client test?

[Alon Bar-Lev]

t_client.sh requires root/sudo privileges.
"make check" should not assume any special privilege.
Because of this it is removed from "make check".
You can still run this by hand or we can add special target such as
"make root-check" or similar.

On Sun, May 27, 2012 at 11:27 PM, Gert Doering  wrote:
> Hi,
>
> working on the test server, I noticed that t_client.sh was no longer run
> from "make check", and that it lost "read t_client.rc from build dir"
> (which is needed when building different clients from a common source
> dir, and wanting to run t_client with different option sets).
>
> The attached patch restores lost functionality, and adds one extra
> feature, optionally waiting longer for OpenVPN startup (if the server
> has a high RTT, 10 seconds is not always enough).
>
> David, this has been tested on FreeBSD 7.4 (so far) and is essential
> for the buildbot client tests :-) - more platform tests will follow
> as soon as I have all the server stanzas up and running.
>
> gert
> --
> USENET is *not* the non-clickable part of WWW!
>                                                           //www.muc.de/~gert/
> Gert Doering - Munich, Germany                             g...@greenie.muc.de
> fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de
>
> --
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> ___
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
>