Re: [OpenWrt-Devel] Interesting issue with hnetd-nossl

2016-06-24 Thread Juliusz Chroboczek 
> Installing the "ip" package fixes the issue -- perhaps there is a bug in
> the busybox ip command that gets triggered by hnetd-nossl, perhaps
> something else.

This is now https://dev.openwrt.org/ticket/22671

-- Juliusz
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] OpenWrt & TR-069 F2F Meeting Agenda

2016-06-24 Thread Eric Schultz 
All,

I was hoping the meeting attendees, and the community, could provide
some feedback  about the agenda of the in-person OpenWrt & TR-069
Meeting. I've created an initial agenda but I'm sure I've missed things
or topics we need to discuss. If you'd like to provide feedback
(especially if you're attending) please leave comments on the linked
Google Docs. In particular, we need:

* Suggestions for OPEN meeting slots
* Session leaders for meeting slots marked as OPEN
* Suggestions for improvements to meeting topics, tweaks, etc.

The time slots I've proposed are pretty flexible and a rough estimate.
I'm sure some sessions will go long and some will be shorter. Once we
get there, we may see some need for adjustments as well.

Anyways, the Google Doc is at
https://docs.google.com/document/d/1IhAd3NLes3r3llV3mep6-YAhIzRElell_f97C-2pIPw/edit?usp=sharing

--
Of note to the broader community, I'll be writing up a short summary of
the topics discussed and any conclusions of the participants at the
meeting. I intend to email these lists on Tuesday evening so folks can
have a chance to give feedback. I think the summary will be rather
limited simply due to time but we'll try to manage. The meeting
attendees will review any feedback received the next morning.
Additionally, I'll send a wrap-up summary on Wednesday evening. If there
are any other online documents or notes that are shared during the
event, I'll make sure to post links to them to the lists.

Thanks,

Eric

-- 
Eric Schultz, Community Manager, prpl Foundation
http://www.prplfoundation.org
eschu...@prplfoundation.org 
cell: 920-539-0404
skype: ericschultzwi
@EricPrpl

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH] libnetfilter_queue: fix checksum computation

2016-06-24 Thread Alin Nastac 
There are 2 issues fixed by this patch:
  - UDP checksum is computed incorrectly, the used pseudo IP header
contains transport protocol 6 iso 17
  - on big endian arches the UDP/TCP checksum is incorrectly
computed when payload length is odd

Signed-off-by: Alin Nastac 
---
 .../patches/100-checksum_computation.patch | 117 +
 1 file changed, 117 insertions(+)
 create mode 100644 
package/libs/libnetfilter-queue/patches/100-checksum_computation.patch

diff --git 
a/package/libs/libnetfilter-queue/patches/100-checksum_computation.patch 
b/package/libs/libnetfilter-queue/patches/100-checksum_computation.patch
new file mode 100644
index 000..5d170f3
--- /dev/null
+++ b/package/libs/libnetfilter-queue/patches/100-checksum_computation.patch
@@ -0,0 +1,117 @@
+diff -Nru libnetfilter_queue-1.0.2.orig/src/extra/checksum.c 
libnetfilter_queue-1.0.2/src/extra/checksum.c
+--- libnetfilter_queue-1.0.2.orig/src/extra/checksum.c 2012-08-06 
14:50:10.596973900 +0200
 libnetfilter_queue-1.0.2/src/extra/checksum.c  2016-06-23 
17:06:50.266905883 +0200
+@@ -11,6 +11,7 @@
+ 
+ #include 
+ #include 
++#include 
+ #include 
+ #include 
+ #include 
+@@ -26,8 +27,13 @@
+   sum += *buf++;
+   size -= sizeof(uint16_t);
+   }
+-  if (size)
+-  sum += *(uint8_t *)buf;
++  if (size) {
++#if __BYTE_ORDER == __BIG_ENDIAN
++  sum += (uint16_t)*(uint8_t *)buf << 8;
++#else
++  sum += (uint16_t)*(uint8_t *)buf;
++#endif
++  }
+ 
+   sum = (sum >> 16) + (sum & 0x);
+   sum += (sum >>16);
+@@ -35,7 +41,7 @@
+   return (uint16_t)(~sum);
+ }
+ 
+-uint16_t checksum_tcpudp_ipv4(struct iphdr *iph)
++uint16_t checksum_tcpudp_ipv4(struct iphdr *iph, uint16_t protocol_id)
+ {
+   uint32_t sum = 0;
+   uint32_t iph_len = iph->ihl*4;
+@@ -46,13 +52,13 @@
+   sum += (iph->saddr) & 0x;
+   sum += (iph->daddr >> 16) & 0x;
+   sum += (iph->daddr) & 0x;
+-  sum += htons(IPPROTO_TCP);
++  sum += htons(protocol_id);
+   sum += htons(len);
+ 
+   return checksum(sum, (uint16_t *)payload, len);
+ }
+ 
+-uint16_t checksum_tcpudp_ipv6(struct ip6_hdr *ip6h, void *transport_hdr)
++uint16_t checksum_tcpudp_ipv6(struct ip6_hdr *ip6h, void *transport_hdr, 
uint16_t protocol_id)
+ {
+   uint32_t sum = 0;
+   uint32_t hdr_len = (uint32_t *)transport_hdr - (uint32_t *)ip6h;
+@@ -68,7 +74,7 @@
+   sum += (ip6h->ip6_dst.s6_addr16[i] >> 16) & 0x;
+   sum += (ip6h->ip6_dst.s6_addr16[i]) & 0x;
+   }
+-  sum += htons(IPPROTO_TCP);
++  sum += htons(protocol_id);
+   sum += htons(ip6h->ip6_plen);
+ 
+   return checksum(sum, (uint16_t *)payload, len);
+diff -Nru libnetfilter_queue-1.0.2.orig/src/extra/tcp.c 
libnetfilter_queue-1.0.2/src/extra/tcp.c
+--- libnetfilter_queue-1.0.2.orig/src/extra/tcp.c  2012-08-20 
19:36:17.985866277 +0200
 libnetfilter_queue-1.0.2/src/extra/tcp.c   2016-06-23 17:04:52.911859011 
+0200
+@@ -91,7 +91,7 @@
+ {
+   /* checksum field in header needs to be zero for calculation. */
+   tcph->check = 0;
+-  tcph->check = checksum_tcpudp_ipv4(iph);
++  tcph->check = checksum_tcpudp_ipv4(iph, IPPROTO_TCP);
+ }
+ EXPORT_SYMBOL(nfq_tcp_compute_checksum_ipv4);
+ 
+@@ -105,7 +105,7 @@
+ {
+   /* checksum field in header needs to be zero for calculation. */
+   tcph->check = 0;
+-  tcph->check = checksum_tcpudp_ipv6(ip6h, tcph);
++  tcph->check = checksum_tcpudp_ipv6(ip6h, tcph, IPPROTO_TCP);
+ }
+ EXPORT_SYMBOL(nfq_tcp_compute_checksum_ipv6);
+ 
+diff -Nru libnetfilter_queue-1.0.2.orig/src/extra/udp.c 
libnetfilter_queue-1.0.2/src/extra/udp.c
+--- libnetfilter_queue-1.0.2.orig/src/extra/udp.c  2012-08-20 
19:36:17.985866277 +0200
 libnetfilter_queue-1.0.2/src/extra/udp.c   2016-06-23 17:04:52.922859297 
+0200
+@@ -91,7 +91,7 @@
+ {
+   /* checksum field in header needs to be zero for calculation. */
+   udph->check = 0;
+-  udph->check = checksum_tcpudp_ipv4(iph);
++  udph->check = checksum_tcpudp_ipv4(iph, IPPROTO_UDP);
+ }
+ EXPORT_SYMBOL(nfq_udp_compute_checksum_ipv4);
+ 
+@@ -110,7 +110,7 @@
+ {
+   /* checksum field in header needs to be zero for calculation. */
+   udph->check = 0;
+-  udph->check = checksum_tcpudp_ipv6(ip6h, udph);
++  udph->check = checksum_tcpudp_ipv6(ip6h, udph, IPPROTO_UDP);
+ }
+ EXPORT_SYMBOL(nfq_udp_compute_checksum_ipv6);
+ 
+diff -Nru libnetfilter_queue-1.0.2.orig/src/internal.h 
libnetfilter_queue-1.0.2/src/internal.h
+--- libnetfilter_queue-1.0.2.orig/src/internal.h   2012-08-06 
14:50:10.596973900 +0200
 libnetfilter_queue-1.0.2/src/internal.h2016-06-23 17:04:52.930859505 
+0200
+@@ -13,8 +13,8 @@
+ struct ip6_hdr;
+ 
+ uint16_t checksum(uint32_t sum, uint16_t *buf, int size);
+-uint16_t checksum_tcpudp_ipv4(struct iphdr *iph);
+-uint16_t checksum_tcpudp_ipv6(struct ip6_hdr *ip6h, void *transp

Re: [OpenWrt-Devel] svn revisions and github repository

2016-06-24 Thread Zoltan HERPAI 

Hi,

On Fri, 24 Jun 2016, Bruno Randolf wrote:


On 22/06/16 23:50, Павел Плетенев wrote:

Hello all!
Thank you for the great OS!
I'm trying to build Chaos Calmer from source for BlackSwift board
(AR9331 dev board). 
Patches for it can be applied only for revision 49007. I'm trying to

apply RT_PREEMT patch for openwrt in that embedded system and I wish to
publish my work somehow. My idea was to fork your github repository at
needed revision and start hacking on that.


Please follow this approach - the github repo is being heavily updated for 
the last few days, but please make a fork, do your changes, and send a 
pull request. ar71xx is done, so no major changes are expected now on that 
target.



So at first I tried googling  github repository
(github.com/openwrt/openwrt ) for
r49007 without any luck. Then I found official openwrt git repository
"git.openwrt.org/15.05/openwrt.git
" and this commit
.
I'm using it currently for hacking. That commit hash isn't present in
github repository. 
The questions are: How are github repository and the one stated above

correlate? Are there any docs about this? How can I publish changes made
in git.openwrt.org  repository?

Hi! I think the do not correlate because they are different imports of
the SVN repository.


There will be some further rework around the github, git, and svn trees - 
the hashes as mentioned won't match.



BWT: I added support for the BlackSwift to 15.05 in
c08d85662b48fff4ac26cdc00c7b22006248cabd (or SVN r46674).

BTW2: The BlackSwift is not really available any more, is it?


I let you guys discuss this. :)

Thanks,
Zoltan H___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] svn revisions and github repository

2016-06-24 Thread Bruno Randolf 
On 22/06/16 23:50, Павел Плетенев wrote:
> Hello all!
> Thank you for the great OS!
> I'm trying to build Chaos Calmer from source for BlackSwift board
> (AR9331 dev board). 
> Patches for it can be applied only for revision 49007. I'm trying to
> apply RT_PREEMT patch for openwrt in that embedded system and I wish to
> publish my work somehow. My idea was to fork your github repository at
> needed revision and start hacking on that.
> 
> So at first I tried googling  github repository
> (github.com/openwrt/openwrt ) for
> r49007 without any luck. Then I found official openwrt git repository
> "git.openwrt.org/15.05/openwrt.git
> " and this commit
> .
> I'm using it currently for hacking. That commit hash isn't present in
> github repository. 
> The questions are: How are github repository and the one stated above
> correlate? Are there any docs about this? How can I publish changes made
> in git.openwrt.org  repository?

Hi! I think the do not correlate because they are different imports of
the SVN repository.

BWT: I added support for the BlackSwift to 15.05 in
c08d85662b48fff4ac26cdc00c7b22006248cabd (or SVN r46674).

BTW2: The BlackSwift is not really available any more, is it?

Greetings,
bruno
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel