Re: [OpenWrt-Devel] [PATCH] pinctrl/lantiq: split xway_mfp into dedicated tables
Hi Martin, The get_maintainer.pl helps to find the correct mailing list, it searches the MAINTAINERS file. ./scripts/get_maintainer.pl -f drivers/pinctrl/pinctrl-xway.c Linus Walleij <linus.wall...@linaro.org> (maintainer:PIN CONTROL SUBSYSTEM) linux-g...@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM) linux-ker...@vger.kernel.org (open list) You should probably not send it to linux-ker...@vger.kernel.org. In addition you should send it to blo...@openwrt.org as he is the main author. I assume John is ok if you also send his patch 0012-pinctrl-lantiq-fix-up-pinmux.patch upstream. When you use git send-mail it should preserve the author name. Can you please also add me in cc as well, thanks. You changed the compatible string, this is considered ABI in the Linux kernel and should stay compatible with older versions, so that you can use an older DTS file with a recent kernel. Could you only add the new names in of_device_id xway_match and not remove the old ones, so that both will work. I send some patches to add basic support for the xrx300 upstream and it is included in Linux 4.4, it boots. ;-) Hauke On 11/16/2015 11:20 AM, Martin Schiller wrote: > Hi, > > ok, I will split this patch into 2 patches: > > [1/2] pinctrl/lantiq: split xway_mfp into dedicated tables > [2/2] pinctrl/lantiq: adapt device-trees to new tables > > Would that be ok? > > To get the pinctrl patch upstream, we also have to send the > 0012-pinctrl-lantiq-fix-up-pinmux.patch upstream. > Should I do this in a patch series as well? > > To whom should this patch be sent? (maintainer/mailing-list?) > > Martin > > -Ursprüngliche Nachricht- > Von: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] Im > Auftrag von John Crispin > Gesendet: Montag, 16. November 2015 10:50 > An: openwrt-devel@lists.openwrt.org > Betreff: Re: [OpenWrt-Devel] [PATCH] pinctrl/lantiq: split xway_mfp into > dedicated tables > > Hi, > > the dts and kernel changes should be in separate patches. > > also please send the pinctrl patch upstream. > > John > > On 16/11/2015 10:42, Martin Schiller wrote: >> This patch splits the inadequate "pinctrl-xway" and "pinctrl-xr9" settings >> into dedicated "pinctrl-ase", "pinctrl-danube", "pinctrl-xrx100" and >> "pinctrl-xrx200" configuration tables. >> >> Based on the newest Lantiq Hardware Description it turend out, that there are >> some differences in the GPIO alternative functions of the Danube, xRX100 and >> xRX200 families, which makes it impossible to use only one xway_mfp table. >> >> This patch is also the first step to add support for the xRX300 family. >> >> Signed-off-by: Martin Schiller <mschil...@tdt.de> >> --- >> target/linux/lantiq/dts/BTHOMEHUBV2B.dts |2 +- >> target/linux/lantiq/dts/BTHOMEHUBV3A.dts |2 +- >> target/linux/lantiq/dts/EASY50712.dts |2 +- >> target/linux/lantiq/dts/EASY50810.dts |2 +- >> target/linux/lantiq/dts/EASY80920.dtsi |2 +- >> target/linux/lantiq/dts/GR7000.dts |2 +- >> target/linux/lantiq/dts/P2601HNFX.dts |2 +- >> target/linux/lantiq/dts/P2812HNUFX.dtsi|2 +- >> target/linux/lantiq/dts/VGV7519.dtsi |2 +- >> target/linux/lantiq/dts/ar9.dtsi |2 +- >> target/linux/lantiq/dts/danube.dtsi|2 +- >> target/linux/lantiq/dts/vr9.dtsi |2 +- >> .../patches-4.1/0150-lantiq-pinctrl-xway.patch | 1059 >> +++- >> 13 files changed, 1061 insertions(+), 22 deletions(-) >> >> diff --git a/target/linux/lantiq/dts/BTHOMEHUBV2B.dts >> b/target/linux/lantiq/dts/BTHOMEHUBV2B.dts >> index 9b3180c..e2d713e 100644 >> --- a/target/linux/lantiq/dts/BTHOMEHUBV2B.dts >> +++ b/target/linux/lantiq/dts/BTHOMEHUBV2B.dts >> @@ -102,7 +102,7 @@ >> }; >> >> gpio: pinmux@E100B10 { >> -compatible = "lantiq,pinctrl-xway"; >> +compatible = "lantiq,pinctrl-danube"; >> pinctrl-names = "default"; >> pinctrl-0 = <_default>; >> >> diff --git a/target/linux/lantiq/dts/BTHOMEHUBV3A.dts >> b/target/linux/lantiq/dts/BTHOMEHUBV3A.dts >> index 1ae9840..9383498 100644 >> --- a/target/linux/lantiq/dts/BTHOMEHUBV3A.dts >> +++ b/target/linux/lantiq/dts/BTHOMEHUBV3A.dts >> @@ -79,7 +79,7 @@ >> }; >> >> gpio: pinmux@E100B10 { >> -compatible = "lantiq,pinctrl-xr9"; >> +compatible = "lantiq,pinctrl-xrx100"; >> pin
[OpenWrt-Devel] [PATCH] pinctrl/lantiq: split xway_mfp into dedicated tables
This patch splits the inadequate "pinctrl-xway" and "pinctrl-xr9" settings into dedicated "pinctrl-ase", "pinctrl-danube", "pinctrl-xrx100" and "pinctrl-xrx200" configuration tables. Based on the newest Lantiq Hardware Description it turend out, that there are some differences in the GPIO alternative functions of the Danube, xRX100 and xRX200 families, which makes it impossible to use only one xway_mfp table. This patch is also the first step to add support for the xRX300 family. Signed-off-by: Martin Schiller--- target/linux/lantiq/dts/BTHOMEHUBV2B.dts |2 +- target/linux/lantiq/dts/BTHOMEHUBV3A.dts |2 +- target/linux/lantiq/dts/EASY50712.dts |2 +- target/linux/lantiq/dts/EASY50810.dts |2 +- target/linux/lantiq/dts/EASY80920.dtsi |2 +- target/linux/lantiq/dts/GR7000.dts |2 +- target/linux/lantiq/dts/P2601HNFX.dts |2 +- target/linux/lantiq/dts/P2812HNUFX.dtsi|2 +- target/linux/lantiq/dts/VGV7519.dtsi |2 +- target/linux/lantiq/dts/ar9.dtsi |2 +- target/linux/lantiq/dts/danube.dtsi|2 +- target/linux/lantiq/dts/vr9.dtsi |2 +- .../patches-4.1/0150-lantiq-pinctrl-xway.patch | 1059 +++- 13 files changed, 1061 insertions(+), 22 deletions(-) diff --git a/target/linux/lantiq/dts/BTHOMEHUBV2B.dts b/target/linux/lantiq/dts/BTHOMEHUBV2B.dts index 9b3180c..e2d713e 100644 --- a/target/linux/lantiq/dts/BTHOMEHUBV2B.dts +++ b/target/linux/lantiq/dts/BTHOMEHUBV2B.dts @@ -102,7 +102,7 @@ }; gpio: pinmux@E100B10 { - compatible = "lantiq,pinctrl-xway"; + compatible = "lantiq,pinctrl-danube"; pinctrl-names = "default"; pinctrl-0 = <_default>; diff --git a/target/linux/lantiq/dts/BTHOMEHUBV3A.dts b/target/linux/lantiq/dts/BTHOMEHUBV3A.dts index 1ae9840..9383498 100644 --- a/target/linux/lantiq/dts/BTHOMEHUBV3A.dts +++ b/target/linux/lantiq/dts/BTHOMEHUBV3A.dts @@ -79,7 +79,7 @@ }; gpio: pinmux@E100B10 { - compatible = "lantiq,pinctrl-xr9"; + compatible = "lantiq,pinctrl-xrx100"; pinctrl-names = "default"; pinctrl-0 = <_default>; diff --git a/target/linux/lantiq/dts/EASY50712.dts b/target/linux/lantiq/dts/EASY50712.dts index e44267a..e0d5ed1 100644 --- a/target/linux/lantiq/dts/EASY50712.dts +++ b/target/linux/lantiq/dts/EASY50712.dts @@ -51,7 +51,7 @@ }; gpio: pinmux@E100B10 { - compatible = "lantiq,pinctrl-xway"; + compatible = "lantiq,pinctrl-danube"; pinctrl-names = "default"; pinctrl-0 = <_default>; diff --git a/target/linux/lantiq/dts/EASY50810.dts b/target/linux/lantiq/dts/EASY50810.dts index 5f4b733..73f31ea 100644 --- a/target/linux/lantiq/dts/EASY50810.dts +++ b/target/linux/lantiq/dts/EASY50810.dts @@ -51,7 +51,7 @@ }; gpio: pinmux@E100B10 { - compatible = "lantiq,pinctrl-xr9"; + compatible = "lantiq,pinctrl-xrx100"; pinctrl-names = "default"; pinctrl-0 = <_default>; diff --git a/target/linux/lantiq/dts/EASY80920.dtsi b/target/linux/lantiq/dts/EASY80920.dtsi index 4013610..0600d36 100644 --- a/target/linux/lantiq/dts/EASY80920.dtsi +++ b/target/linux/lantiq/dts/EASY80920.dtsi @@ -71,7 +71,7 @@ }; gpio: pinmux@E100B10 { - compatible = "lantiq,pinctrl-xr9"; + compatible = "lantiq,pinctrl-xrx200"; pinctrl-names = "default"; pinctrl-0 = <_default>; diff --git a/target/linux/lantiq/dts/GR7000.dts b/target/linux/lantiq/dts/GR7000.dts index fcc27eb..bc95f1f 100644 --- a/target/linux/lantiq/dts/GR7000.dts +++ b/target/linux/lantiq/dts/GR7000.dts @@ -42,7 +42,7 @@ }; gpio: pinmux@E100B10 { - compatible = "lantiq,pinctrl-xr9"; + compatible = "lantiq,pinctrl-xrx100"; pinctrl-names = "default"; pinctrl-0 = <_default>; diff --git a/target/linux/lantiq/dts/P2601HNFX.dts b/target/linux/lantiq/dts/P2601HNFX.dts index bb9193e..c22c547 100644 --- a/target/linux/lantiq/dts/P2601HNFX.dts +++ b/target/linux/lantiq/dts/P2601HNFX.dts @@ -50,7 +50,7 @@ }; gpio: pinmux@E100B10 { - compatible = "lantiq,pinctrl-xr9"; + compatible = "lantiq,pinctrl-xrx100"; pinctrl-names = "default"; pinctrl-0 =
Re: [OpenWrt-Devel] [PATCH] pinctrl/lantiq: split xway_mfp into dedicated tables
Hi, ok, I will split this patch into 2 patches: [1/2] pinctrl/lantiq: split xway_mfp into dedicated tables [2/2] pinctrl/lantiq: adapt device-trees to new tables Would that be ok? To get the pinctrl patch upstream, we also have to send the 0012-pinctrl-lantiq-fix-up-pinmux.patch upstream. Should I do this in a patch series as well? To whom should this patch be sent? (maintainer/mailing-list?) Martin -Ursprüngliche Nachricht- Von: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] Im Auftrag von John Crispin Gesendet: Montag, 16. November 2015 10:50 An: openwrt-devel@lists.openwrt.org Betreff: Re: [OpenWrt-Devel] [PATCH] pinctrl/lantiq: split xway_mfp into dedicated tables Hi, the dts and kernel changes should be in separate patches. also please send the pinctrl patch upstream. John On 16/11/2015 10:42, Martin Schiller wrote: > This patch splits the inadequate "pinctrl-xway" and "pinctrl-xr9" settings > into dedicated "pinctrl-ase", "pinctrl-danube", "pinctrl-xrx100" and > "pinctrl-xrx200" configuration tables. > > Based on the newest Lantiq Hardware Description it turend out, that there are > some differences in the GPIO alternative functions of the Danube, xRX100 and > xRX200 families, which makes it impossible to use only one xway_mfp table. > > This patch is also the first step to add support for the xRX300 family. > > Signed-off-by: Martin Schiller <mschil...@tdt.de> > --- > target/linux/lantiq/dts/BTHOMEHUBV2B.dts |2 +- > target/linux/lantiq/dts/BTHOMEHUBV3A.dts |2 +- > target/linux/lantiq/dts/EASY50712.dts |2 +- > target/linux/lantiq/dts/EASY50810.dts |2 +- > target/linux/lantiq/dts/EASY80920.dtsi |2 +- > target/linux/lantiq/dts/GR7000.dts |2 +- > target/linux/lantiq/dts/P2601HNFX.dts |2 +- > target/linux/lantiq/dts/P2812HNUFX.dtsi|2 +- > target/linux/lantiq/dts/VGV7519.dtsi |2 +- > target/linux/lantiq/dts/ar9.dtsi |2 +- > target/linux/lantiq/dts/danube.dtsi|2 +- > target/linux/lantiq/dts/vr9.dtsi |2 +- > .../patches-4.1/0150-lantiq-pinctrl-xway.patch | 1059 > +++- > 13 files changed, 1061 insertions(+), 22 deletions(-) > > diff --git a/target/linux/lantiq/dts/BTHOMEHUBV2B.dts > b/target/linux/lantiq/dts/BTHOMEHUBV2B.dts > index 9b3180c..e2d713e 100644 > --- a/target/linux/lantiq/dts/BTHOMEHUBV2B.dts > +++ b/target/linux/lantiq/dts/BTHOMEHUBV2B.dts > @@ -102,7 +102,7 @@ > }; > > gpio: pinmux@E100B10 { > -compatible = "lantiq,pinctrl-xway"; > +compatible = "lantiq,pinctrl-danube"; > pinctrl-names = "default"; > pinctrl-0 = <_default>; > > diff --git a/target/linux/lantiq/dts/BTHOMEHUBV3A.dts > b/target/linux/lantiq/dts/BTHOMEHUBV3A.dts > index 1ae9840..9383498 100644 > --- a/target/linux/lantiq/dts/BTHOMEHUBV3A.dts > +++ b/target/linux/lantiq/dts/BTHOMEHUBV3A.dts > @@ -79,7 +79,7 @@ > }; > > gpio: pinmux@E100B10 { > -compatible = "lantiq,pinctrl-xr9"; > +compatible = "lantiq,pinctrl-xrx100"; > pinctrl-names = "default"; > pinctrl-0 = <_default>; > > diff --git a/target/linux/lantiq/dts/EASY50712.dts > b/target/linux/lantiq/dts/EASY50712.dts > index e44267a..e0d5ed1 100644 > --- a/target/linux/lantiq/dts/EASY50712.dts > +++ b/target/linux/lantiq/dts/EASY50712.dts > @@ -51,7 +51,7 @@ > }; > > gpio: pinmux@E100B10 { > -compatible = "lantiq,pinctrl-xway"; > +compatible = "lantiq,pinctrl-danube"; > pinctrl-names = "default"; > pinctrl-0 = <_default>; > > diff --git a/target/linux/lantiq/dts/EASY50810.dts > b/target/linux/lantiq/dts/EASY50810.dts > index 5f4b733..73f31ea 100644 > --- a/target/linux/lantiq/dts/EASY50810.dts > +++ b/target/linux/lantiq/dts/EASY50810.dts > @@ -51,7 +51,7 @@ > }; > > gpio: pinmux@E100B10 { > -compatible = "lantiq,pinctrl-xr9"; > +compatible = "lantiq,pinctrl-xrx100"; > pinctrl-names = "default"; > pinctrl-0 = <_default>; > > diff --git a/target/linux/lantiq/dts/EASY80920.dtsi > b/target/linux/lantiq/dts/EASY80920.dtsi > index 4013610..0600d36 100644 > --- a/target/linux/lantiq/dts/EASY80920.dtsi > +++ b/target/linux/lantiq/dts/EASY80920.dtsi > @@ -71,7 +71,7 @@ > }; > > gpio: pinmux@E100B10 { > -compatible = "lantiq,pinctrl-xr9"; > +compatible = "lantiq,pinctrl-xrx200"; > pinctrl-names = "default"; > pinctrl-0 = <_default>; > > diff --git a/t
Re: [OpenWrt-Devel] [PATCH] pinctrl/lantiq: split xway_mfp into dedicated tables
Hi, the dts and kernel changes should be in separate patches. also please send the pinctrl patch upstream. John On 16/11/2015 10:42, Martin Schiller wrote: > This patch splits the inadequate "pinctrl-xway" and "pinctrl-xr9" settings > into dedicated "pinctrl-ase", "pinctrl-danube", "pinctrl-xrx100" and > "pinctrl-xrx200" configuration tables. > > Based on the newest Lantiq Hardware Description it turend out, that there are > some differences in the GPIO alternative functions of the Danube, xRX100 and > xRX200 families, which makes it impossible to use only one xway_mfp table. > > This patch is also the first step to add support for the xRX300 family. > > Signed-off-by: Martin Schiller> --- > target/linux/lantiq/dts/BTHOMEHUBV2B.dts |2 +- > target/linux/lantiq/dts/BTHOMEHUBV3A.dts |2 +- > target/linux/lantiq/dts/EASY50712.dts |2 +- > target/linux/lantiq/dts/EASY50810.dts |2 +- > target/linux/lantiq/dts/EASY80920.dtsi |2 +- > target/linux/lantiq/dts/GR7000.dts |2 +- > target/linux/lantiq/dts/P2601HNFX.dts |2 +- > target/linux/lantiq/dts/P2812HNUFX.dtsi|2 +- > target/linux/lantiq/dts/VGV7519.dtsi |2 +- > target/linux/lantiq/dts/ar9.dtsi |2 +- > target/linux/lantiq/dts/danube.dtsi|2 +- > target/linux/lantiq/dts/vr9.dtsi |2 +- > .../patches-4.1/0150-lantiq-pinctrl-xway.patch | 1059 > +++- > 13 files changed, 1061 insertions(+), 22 deletions(-) > > diff --git a/target/linux/lantiq/dts/BTHOMEHUBV2B.dts > b/target/linux/lantiq/dts/BTHOMEHUBV2B.dts > index 9b3180c..e2d713e 100644 > --- a/target/linux/lantiq/dts/BTHOMEHUBV2B.dts > +++ b/target/linux/lantiq/dts/BTHOMEHUBV2B.dts > @@ -102,7 +102,7 @@ > }; > > gpio: pinmux@E100B10 { > - compatible = "lantiq,pinctrl-xway"; > + compatible = "lantiq,pinctrl-danube"; > pinctrl-names = "default"; > pinctrl-0 = <_default>; > > diff --git a/target/linux/lantiq/dts/BTHOMEHUBV3A.dts > b/target/linux/lantiq/dts/BTHOMEHUBV3A.dts > index 1ae9840..9383498 100644 > --- a/target/linux/lantiq/dts/BTHOMEHUBV3A.dts > +++ b/target/linux/lantiq/dts/BTHOMEHUBV3A.dts > @@ -79,7 +79,7 @@ > }; > > gpio: pinmux@E100B10 { > - compatible = "lantiq,pinctrl-xr9"; > + compatible = "lantiq,pinctrl-xrx100"; > pinctrl-names = "default"; > pinctrl-0 = <_default>; > > diff --git a/target/linux/lantiq/dts/EASY50712.dts > b/target/linux/lantiq/dts/EASY50712.dts > index e44267a..e0d5ed1 100644 > --- a/target/linux/lantiq/dts/EASY50712.dts > +++ b/target/linux/lantiq/dts/EASY50712.dts > @@ -51,7 +51,7 @@ > }; > > gpio: pinmux@E100B10 { > - compatible = "lantiq,pinctrl-xway"; > + compatible = "lantiq,pinctrl-danube"; > pinctrl-names = "default"; > pinctrl-0 = <_default>; > > diff --git a/target/linux/lantiq/dts/EASY50810.dts > b/target/linux/lantiq/dts/EASY50810.dts > index 5f4b733..73f31ea 100644 > --- a/target/linux/lantiq/dts/EASY50810.dts > +++ b/target/linux/lantiq/dts/EASY50810.dts > @@ -51,7 +51,7 @@ > }; > > gpio: pinmux@E100B10 { > - compatible = "lantiq,pinctrl-xr9"; > + compatible = "lantiq,pinctrl-xrx100"; > pinctrl-names = "default"; > pinctrl-0 = <_default>; > > diff --git a/target/linux/lantiq/dts/EASY80920.dtsi > b/target/linux/lantiq/dts/EASY80920.dtsi > index 4013610..0600d36 100644 > --- a/target/linux/lantiq/dts/EASY80920.dtsi > +++ b/target/linux/lantiq/dts/EASY80920.dtsi > @@ -71,7 +71,7 @@ > }; > > gpio: pinmux@E100B10 { > - compatible = "lantiq,pinctrl-xr9"; > + compatible = "lantiq,pinctrl-xrx200"; > pinctrl-names = "default"; > pinctrl-0 = <_default>; > > diff --git a/target/linux/lantiq/dts/GR7000.dts > b/target/linux/lantiq/dts/GR7000.dts > index fcc27eb..bc95f1f 100644 > --- a/target/linux/lantiq/dts/GR7000.dts > +++ b/target/linux/lantiq/dts/GR7000.dts > @@ -42,7 +42,7 @@ > }; > > gpio: pinmux@E100B10 { > - compatible = "lantiq,pinctrl-xr9"; > + compatible = "lantiq,pinctrl-xrx100"; > pinctrl-names = "default"; > pinctrl-0 = <_default>; > > diff --git a/target/linux/lantiq/dts/P2601HNFX.dts > b/target/linux/lantiq/dts/P2601HNFX.dts > index bb9193e..c22c547 100644 > --- a/target/linux/lantiq/dts/P2601HNFX.dts >
Re: [OpenWrt-Devel] [PATCH] pinctrl/lantiq: split xway_mfp into dedicated tables
Hi, On 11/16/2015 at 9:28 PM, Hauke Mehrtens wrote: > Hi Martin, > > The get_maintainer.pl helps to find the correct mailing list, it > searches the MAINTAINERS file. > > ./scripts/get_maintainer.pl -f drivers/pinctrl/pinctrl-xway.c > Linus Walleij(maintainer:PIN CONTROL > SUBSYSTEM) > linux-g...@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM) > linux-ker...@vger.kernel.org (open list) Thanks, John already told me to use the get_maintainer.pl script. > You should probably not send it to linux-ker...@vger.kernel.org. > In addition you should send it to blo...@openwrt.org as he is the main > author. > > I assume John is ok if you also send his patch > 0012-pinctrl-lantiq-fix-up-pinmux.patch upstream. When you use git > send-mail it should preserve the author name. I think we have to review this patch again, because it changes more than that what is stated in the comment. Maybe we have to split it up in several parts to get it upstream? > Can you please also add me in cc as well, thanks. Ok. > You changed the compatible string, this is considered ABI in the Linux > kernel and should stay compatible with older versions, so that you can > use an older DTS file with a recent kernel. Could you only add the new > names in of_device_id xway_match and not remove the old ones, so that > both will work. So I will leave the old stuff (pinctrl-xway and pinctrl-xr9), mark them as deprecated and add the new ones (pinctrl-danube, pinctrl-xrx100 and pinctrl-xrx200). Of course, the Documentation will also be updated. > > I send some patches to add basic support for the xrx300 upstream and it > is included in Linux 4.4, it boots. ;-) Ah, nice work! I want to use the USIF UART of the xRX200, so it was also on my todo list to adapt the Lantiq UGW PMU Patches to the free world. ;-) But maybe you overlooked some little details: The PMU_ASC0 should be removed from the "generic xway clocks" section. Instead, the PMU_ASC1 should go there because it is available on every XWAY SoC (even on the Amazon-SE). Also, the quotation marks should be removed from the second parameter of the clkdev_add_pmu("1da.usif", "NULL", 1, 0, PMU_USIF) calls. Looking forward to meet again on the next Summit, Martin ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel