Re: [PATCH 2/3] realtek: enable gpio-restart driver in target
Hi, On 2021/11/13 6:15, Sander Vanheule wrote: As made clear by Paul Fertser, gpio-restart isn't actually used unless _machine_restart() is also removed. Although I don't mind adding the correct nodes to the DTS already (maybe others disagree). Adding the driver already would only have the effect (benefit?) of grabbing the relevant GPIO, and preventing users from using it accidentally. I definitely think this driver should definitely be enabled, but do we wait with enabling it until we can remove _machine_restart? Or can this already be merged as some sort of preparatory patch? IMO, I think that there is no problem because the gpio-restart exists as a clear specification of this device, and even if the driver is enabled at the moment, it only does not work and does not interfere with others. Regards, Hiroshi ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH 2/3] realtek: enable gpio-restart driver in target
Hi, On Sun, 2021-10-03 at 15:53 +0900, INAGAKI Hiroshi wrote: > On Panasonic Switch-M8eG PN28080K, a GPIO pin on PCA9539 chip is used > for for hard-reset of the system. To use this, enable gpio-restart > driver and built-in to the kernel. > > Signed-off-by: INAGAKI Hiroshi As made clear by Paul Fertser, gpio-restart isn't actually used unless _machine_restart() is also removed. Although I don't mind adding the correct nodes to the DTS already (maybe others disagree). Adding the driver already would only have the effect (benefit?) of grabbing the relevant GPIO, and preventing users from using it accidentally. I definitely think this driver should definitely be enabled, but do we wait with enabling it until we can remove _machine_restart? Or can this already be merged as some sort of preparatory patch? Best, Sander ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH 2/3] realtek: enable gpio-restart driver in target
On Panasonic Switch-M8eG PN28080K, a GPIO pin on PCA9539 chip is used for for hard-reset of the system. To use this, enable gpio-restart driver and built-in to the kernel. Signed-off-by: INAGAKI Hiroshi --- target/linux/realtek/config-5.10 | 1 + target/linux/realtek/config-5.4 | 1 + 2 files changed, 2 insertions(+) diff --git a/target/linux/realtek/config-5.10 b/target/linux/realtek/config-5.10 index 810bacbefa..5a847a2bb1 100644 --- a/target/linux/realtek/config-5.10 +++ b/target/linux/realtek/config-5.10 @@ -158,6 +158,7 @@ CONFIG_PHYLIB=y CONFIG_PHYLINK=y CONFIG_PINCTRL=y CONFIG_POWER_RESET=y +CONFIG_POWER_RESET_GPIO_RESTART=y CONFIG_POWER_RESET_SYSCON=y CONFIG_RATIONAL=y CONFIG_REALTEK_PHY=y diff --git a/target/linux/realtek/config-5.4 b/target/linux/realtek/config-5.4 index 8a353dfc32..34e4b9028b 100644 --- a/target/linux/realtek/config-5.4 +++ b/target/linux/realtek/config-5.4 @@ -159,6 +159,7 @@ CONFIG_PHYLIB=y CONFIG_PHYLINK=y CONFIG_PINCTRL=y CONFIG_POWER_RESET=y +CONFIG_POWER_RESET_GPIO_RESTART=y CONFIG_POWER_RESET_SYSCON=y CONFIG_PSB6970_PHY=y CONFIG_REALTEK_PHY=y -- 2.33.0.windows.2 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
