[orientdb] Code review questions

[Shahim Essaid]

Hi,

What is the best way to ask questions if I'm reviewing some code and I 
think I see a problem, or I need some clarification? I know GitHub has a 
commenting feature for pull requests and on blame views but there is no way 
to simply place comments on arbitrary lines in current files.  I also 
looked for an issue label like "code review" or something similar and I 
didn't notice one.

Examples of what I'm talking about are:

1. Why is there no checkSecurity here: 

https://github.com/orientechnologies/orientdb/blob/b431805894b2599c3c7b4f066d31800ca504b389/core/src/main/java/com/orientechnologies/orient/core/db/document/ODatabaseDocumentTx.java#L1348

as seen for the similar method here:

https://github.com/orientechnologies/orientdb/blob/b431805894b2599c3c7b4f066d31800ca504b389/core/src/main/java/com/orientechnologies/orient/core/db/document/ODatabaseDocumentTx.java#L1365

2. Database listeners are sometimes called for onBeforeTxBegin before the 
actual transaction object is set for the database. Is this intentional? 
Examples:

https://github.com/orientechnologies/orientdb/blob/b431805894b2599c3c7b4f066d31800ca504b389/core/src/main/java/com/orientechnologies/orient/core/db/document/ODatabaseDocumentTx.java#L1736

https://github.com/orientechnologies/orientdb/blob/b431805894b2599c3c7b4f066d31800ca504b389/core/src/main/java/com/orientechnologies/orient/core/db/document/ODatabaseDocumentTx.java#L2284

3. DRY

https://github.com/orientechnologies/orientdb/blob/b431805894b2599c3c7b4f066d31800ca504b389/core/src/main/java/com/orientechnologies/orient/core/db/document/ODatabaseDocumentTx.java#L2341

can simply be  this.freeze(false);

I'm starting to study some of the code and I'm sure I'll have many similar 
questions. Should these be issues? One issue per file? Which label should I 
use?

Best,
Shahim

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"OrientDB" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to orient-database+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[orientdb] Re: orientDB picturs

[Oleksandr Gubchenko]

Hello,

what do you mean pictures? If you need to install OrientDB follow this 
guide: http://orientdb.com/docs/last/Tutorial-Installation.html
What is your operating system?
You can also start from this Udemy course for complete beginners which will 
show you also installation process at the very 
beginning: https://www.udemy.com/orientdb-getting-started/

Oleksandr.

Il giorno venerdì 14 ottobre 2016 18:27:40 UTC+2, Hosain Yaghobi ha scritto:
>
>
> Hi!
>
> i start with orientDB.
> befor use !
>  
> i need to get the picturs screenshut about  orientedDB  environment. 
> instalation  and use .
>
> pleaze send  to me if you have.
>
> thanks.
>

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"OrientDB" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to orient-database+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[orientdb] orientDB picturs

[Hosain Yaghobi]

Hi!

i start with orientDB.
befor use !
 
i need to get the picturs screenshut about  orientedDB  environment. 
instalation  and use .

pleaze send  to me if you have.

thanks.

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"OrientDB" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to orient-database+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [orientdb] Re: Can't remove embedded list item from 3 levels down

[borov333]

Bug submitted.


On Thursday, October 13, 2016 at 9:51:57 AM UTC-7, Luigi Dell'Aquila wrote:
>
> Yes, please
>
> Thanks
>
> Luigi
>
> 2016-10-13 18:23 GMT+02:00 :
>
>> Thanks Luigi. Shall it be filed as a bug?
>>
>>
>>
>> On Wednesday, October 12, 2016 at 11:58:33 PM UTC-7, Luigi Dell'Aquila 
>> wrote:
>>>
>>> Hi guys,
>>>
>>> Ok, it's correct, it "kind of" works because of some internal corner 
>>> cases, but it's definitely a dirty work around :-D 
>>> Anyway, I'll fix the main problem in next days
>>>
>>> Thanks
>>>
>>> Luigi
>>>
>>> 2016-10-13 7:37 GMT+02:00 :
>>>
 Hi Oleksandr,

 Interesting, I think it is similar or related to that issue of 5703. 
 When I wrapped the whole string into `` characters it worked, or kind of 
 worked. Check this out:

 orientdb {db=Tetraop}> update #25:0 remove 
 `settings.leads.TempLead.overrideProperties[0]`
 Updated record(s) '1' in 0.001000 sec(s).

 orientdb {db=Tetraop}> select settings.leads.TempLead.overrideProperties 
 from #25:0

 +++

 |#   |settings|

 +++

 |0   |[PropertyOverride{customValues:[1]}]|

 +++

 It appears as it removed the record, but when I did a select, the 
 record is still there. That's false positive

 orientdb {db=Tetraop}> update #25:0 remove 
 `settings.leads.TempLead.overrideProperties` = 
 settings.leads.TempLead.overrideProperties[0]
 Updated record(s) '1' in 0.002000 sec(s). 

 orientdb {db=Tetraop}> select settings.leads.TempLead.overrideProperties 
 from #25:0   +++

 |#   |settings|

 +++

 |0   |[]  |

 +++

 Now it removed the record and the list is empty. This behavior raises 3 
 questions:

1. Why do we need to use `` if this issues seemed to be fixed in 
the issue 5703
2. Is the first way a legit way to remove list items? If so, why 
did it give false positive?
3. What is the right and bullet proof way to remove embedded list 
items?


 For your previous request, this is how I did the insert:

 update #25:0 add settings.leads.TempLead.overrideProperties = 
 {"@type":"d", "@class":"PropertyOverride", 
 "standardProperty":"utilityCompany", "customProperty":"utilityProvider"}

 Thanks for looking into this.




 On Wednesday, October 12, 2016 at 9:21:25 AM UTC-7, Oleksandr Gubchenko 
 wrote:
>
> Is this issue similar to your case? Can you confirm?
> https://github.com/orientechnologies/orientdb/issues/5703
>
> Il giorno mercoledì 12 ottobre 2016 18:16:28 UTC+2, Oleksandr 
> Gubchenko ha scritto:
>>
>> Can you add an insert that you are using to originally create the 
>> #25:0 ?
>>
>> Thanks.
>>
>> Il giorno mercoledì 12 ottobre 2016 17:47:25 UTC+2, boro...@gmail.com 
>> ha scritto:
>>>
>>> Hi Michela, here are the schemas starting from the most inner class 
>>> and up all the way to account. 
>>>
>>> // Property Override
>>> create class PropertyOverride extends V
>>> create property PropertyOverride.standardProperty STRING (NOTNULL 
>>> TRUE)
>>> create property PropertyOverride.customProperty STRING (NOTNULL TRUE)
>>> create property PropertyOverride.customValues EMBEDDEDMAP STRING 
>>> (NOTNULL TRUE)
>>>
>>> // Class Override
>>> create class LeadClass extends V
>>> create property LeadClass.template STRING (NOTNULL TRUE)
>>> create property LeadClass.booleanTrue STRING (NOTNULL TRUE, COLLATE 
>>> "ci")
>>> create property LeadClass.booleanFalse STRING (NOTNULL TRUE, COLLATE 
>>> "ci")
>>> create property LeadClass.dateFormat STRING (NOTNULL TRUE, COLLATE 
>>> "ci")
>>> create property LeadClass.timestampFormat STRING (NOTNULL TRUE, 
>>> COLLATE "ci")
>>> create property LeadClass.overrideProperties EMBEDDEDLIST 
>>> PropertyOverride (NOTNULL TRUE)
>>>
>>> // Account Settings
>>> create class AccountSettings extends V
>>> create property AccountSettings.leads EMBEDDEDMAP LeadClass
>>>
>>> // Account
>>> create class Account extends V
>>> create property Account.id INTEGER (DEFAULT 
>>> "sequence('accountId').next()", READONLY TRUE)
>>> create property Account.created DATETIME (DEFAULT "sysdate()", 
>>> READONLY TRUE)
>>> create property Account.active BOOLEAN (NOTNULL TRUE, DEFAULT FALSE)
>>> create property Account.company STRING (NOTNULL TRUE, MANDATORY 
>>> TRUE, MIN 2, MAX 50, COLLATE "ci")
>>> create property Account.settings EMBEDDED AccountSettings
>>>
>>> The #25:0 

[orientdb] Re: OrientDB and Rexster

[Nigel Brown]

There seem to be mistakes on that linked page - that was what I was 
originally following. Assuming OrientDB 2.2, rexster 2.5.0 does not seem to 
work, 2.6.0 does.

There is a typo

  orientgraph
  url-to-your-db

should be more like

  
com.tinkerpop.blueprints.pgm.impls.orientdb.OrientGraph
  url-to-your-db


With the above changes I got my plug-in/graph working.

One pain point for us was that you are not allowed periods (.) in property 
names. Another is that there is no regex query in the Gremlin API. This was 
something we used from Titan and non standard. We will probably be able to 
query OrientDB directly for some of our cases, but some are in the middle 
of a pipeline and that will be harder.

'And a bonus question, what is the status of Tinkerpop3?'

This seems to have gone very quiet. Some say it should have been out last 
December, but it wasn't.

-- 

--- 
You received this message because you are subscribed to the Google Groups 
"OrientDB" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to orient-database+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.