Re: [osg-users] Importance Of Node Path List In Database Pager
Hi Ryan, On Wed, Aug 5, 2009 at 10:36 PM, Kawicki, Ryan H wrote: > I was just curious to see if anything was committed to the 2.9.x / 2.10 > baselines for this. I know that you stated that you already had code in > place to fix this issue. Thanks. I thought I had code in place, but when I reviewed the code it wasn't there, so my guess is that I probably didn't write it but thought about it and implemented something simpler to address the particular problem in hand. There is no RefNodePath recorded by DatabasePager::DatabaseRequest right now, so we still have to write this. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Importance Of Node Path List In Database Pager
Robert, I was just curious to see if anything was committed to the 2.9.x / 2.10 baselines for this. I know that you stated that you already had code in place to fix this issue. Thanks. Ryan H. Kawicki The Boeing Company Training Systems & Services Software Engineer -Original Message- From: Kawicki, Ryan H Sent: Friday, July 24, 2009 10:44 AM To: OpenSceneGraph Users Subject: [osg-users] FW: Importance Of Node Path List In Database Pager > Have you implemented a fix yet? If not I'll try to get to it while I'm still > around this week/early next week. Unfortunately, we have not come up with a fix. If you like, I could come up with a solution and submit it, but I would hate to duplicate work if you already have it on disk somewhere. I will be out most of next week and would not be able to get to it until sometime the following week. Thanks for the continue support. Ryan H. Kawicki The Boeing Company Training Systems & Services Software Engineer -Original Message- From: Robert Osfield [mailto:robert.osfi...@gmail.com] Sent: Friday, July 24, 2009 9:20 AM To: OpenSceneGraph Users Subject: Re: [osg-users] Importance Of Node Path List In Database Pager Hi Ryan, On Fri, Jul 24, 2009 at 3:01 PM, Kawicki, Ryan H wrote: > Would it be possible to store this information as a DatabaseRequest attribute? Curious, I thought I had already made such a change to DatabasePager - to move the NodePath acquisition to the DatabaseRequest set up, but now reviewing it this code isn't in svn/trunk. Weird. Perhaps I thought about implementing it and then got distracted or perhaps I did the experiment but not checked it in. Such a change would be appropriate - adding a RedNodePath to DatabaseRequest and set it inside the DatabasePager::requestNodeFile(). Unfortunately such a change would break the ABI for 2.8.x so would have to be merged with just the svn/trunk and the 2.9.x/2.10 series. >The node path should be computed during the cull traversal. The problem here >is that there is the possibility for a parent iterator to become invalidated >when this operation traverses up the scene graph. > > Sorry about the confusion on the line number. I am referencing OSG 2.8.1. Thanks, I now understand the issue at hand. One I have previous thought about, but alas wrapped up this work... Have you implemented a fix yet? If not I'll try to get to it while I'm still around this week/early next week. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Importance Of Node Path List In Database Pager
Hi Ryan, On Fri, Jul 24, 2009 at 3:01 PM, Kawicki, Ryan H wrote: > Would it be possible to store this information as a DatabaseRequest attribute? Curious, I thought I had already made such a change to DatabasePager - to move the NodePath acquisition to the DatabaseRequest set up, but now reviewing it this code isn't in svn/trunk. Weird. Perhaps I thought about implementing it and then got distracted or perhaps I did the experiment but not checked it in. Such a change would be appropriate - adding a RedNodePath to DatabaseRequest and set it inside the DatabasePager::requestNodeFile(). Unfortunately such a change would break the ABI for 2.8.x so would have to be merged with just the svn/trunk and the 2.9.x/2.10 series. >The node path should be computed during the cull traversal. The problem here >is that there is the possibility for a parent iterator to become invalidated >when this operation traverses up the scene graph. > > Sorry about the confusion on the line number. I am referencing OSG 2.8.1. Thanks, I now understand the issue at hand. One I have previous thought about, but alas wrapped up this work... Have you implemented a fix yet? If not I'll try to get to it while I'm still around this week/early next week. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Importance Of Node Path List In Database Pager
Would it be possible to store this information as a DatabaseRequest attribute? The node path should be computed during the cull traversal. The problem here is that there is the possibility for a parent iterator to become invalidated when this operation traverses up the scene graph. Sorry about the confusion on the line number. I am referencing OSG 2.8.1. Ryan H. Kawicki The Boeing Company Training Systems & Services Software Engineer -Original Message- From: Robert Osfield [mailto:robert.osfi...@gmail.com] Sent: Friday, July 24, 2009 5:59 AM To: OpenSceneGraph Users Subject: Re: [osg-users] Importance Of Node Path List In Database Pager Hi Ryan, On Tue, Jul 21, 2009 at 4:11 PM, Kawicki, Ryan H wrote: > I am curious as to what the importance of the node path list is for > the database pager. More importantly, why does the > FindCompileableGLObjectsVisitor need to have a complete path from the > group to be loaded all the way to the root camera node? It's so the NodeVisitor had be set up with the full parental path so it works as it it came from the root, rather than just the local subgraph. Having the full parent path in the NodeVisitor is used by the osgTerrain::TerrainTile to enable it find it's enclosing osgTerrain::Terrain from the parental node path, the Terrain provide hints to TerrainTechnique that builds the final terrain geometry such as sample density. Without pushing the full parent node path we'd have to delay the compute of the terrain geometry to after the new subgraph had been added into the scene graph - something which would break frame. > It looks not to > serve any importance and there is the possibility that an iterator can > be invalidated on the parent list when ascending to the root. The > lines I am looking at are around 588 of DatabasePager.cpp. Thanks. A line number is no use to me or others with specific information which version of the OSG your are talking about. Please provide this and a small code fragment of the area of concern. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] Importance Of Node Path List In Database Pager
Hi Ryan, On Tue, Jul 21, 2009 at 4:11 PM, Kawicki, Ryan H wrote: > I am curious as to what the importance of the node path list is for the > database pager. More importantly, why does the > FindCompileableGLObjectsVisitor need to have a complete path from the > group to be loaded all the way to the root camera node? It's so the NodeVisitor had be set up with the full parental path so it works as it it came from the root, rather than just the local subgraph. Having the full parent path in the NodeVisitor is used by the osgTerrain::TerrainTile to enable it find it's enclosing osgTerrain::Terrain from the parental node path, the Terrain provide hints to TerrainTechnique that builds the final terrain geometry such as sample density. Without pushing the full parent node path we'd have to delay the compute of the terrain geometry to after the new subgraph had been added into the scene graph - something which would break frame. > It looks not to > serve any importance and there is the possibility that an iterator can > be invalidated on the parent list when ascending to the root. The lines > I am looking at are around 588 of DatabasePager.cpp. Thanks. A line number is no use to me or others with specific information which version of the OSG your are talking about. Please provide this and a small code fragment of the area of concern. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
[osg-users] Importance Of Node Path List In Database Pager
I am curious as to what the importance of the node path list is for the database pager. More importantly, why does the FindCompileableGLObjectsVisitor need to have a complete path from the group to be loaded all the way to the root camera node? It looks not to serve any importance and there is the possibility that an iterator can be invalidated on the parent list when ascending to the root. The lines I am looking at are around 588 of DatabasePager.cpp. Thanks. Ryan H. Kawicki The Boeing Company Training Systems & Services Software Engineer ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
