[osg-users] OpenGL ES 2.0 on windows

2013-07-30 Thread Sergey Kurdakov
Hi Robert,

working with OpenGL ES 2.0 with Angle ( I also checked ATI OpenGL ES SDK )
with osg 3.2
I have a warning Detected OpenGL error invalid enumerant on this line in
State.cpp

 glGetIntegerv(GL_MAX_TEXTURE_COORDS,_glMaxTextureCoords);

( in following part of  code in function void
State::initializeExtensionProcs()  )

 if ( osg::getGLVersionNumber() = 2.0 ||
osg::isGLExtensionSupported(_contextID,GL_ARB_vertex_shader) ||
OSG_GLES2_FEATURES)
{

glGetIntegerv(GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS,_glMaxTextureUnits);
glGetIntegerv(GL_MAX_TEXTURE_COORDS,_glMaxTextureCoords);
}



I asked Angle project list that maybe they are wrong here ( but still ATI
ES SDK also lacks GL_MAX_TEXTURE_COORDS ) and they responded they are not,
the  GL_MAX_TEXTURE_COORDS is underfined for OpenGL ES 2.0


So, possibly here there should be a code like

if ( osg::getGLVersionNumber() = 2.0 ||
osg::isGLExtensionSupported(_contextID,GL_ARB_vertex_shader) ||
OSG_GLES2_FEATURES)
{

glGetIntegerv(GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS,_glMaxTextureUnits);
if(OSG_GLES2_FEATURES)
{
_glMaxTextureCoords = _glMaxTextureUnits;
}
else
glGetIntegerv(GL_MAX_TEXTURE_COORDS,_glMaxTextureCoords);
}

?

Best regards
Sergey
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] OpenGL ES 2.0 on windows

2013-07-30 Thread Robert Osfield
Hi Sergey,

You suggested change looks reasonable.  Curious that others including
myself haven't spotted this error so I can only presume that quite a
few GLES implementations do indeed included support for
GL_MAX_TEXTURE_COORDS.  Once you have the code working cleanly could
you post the modified file to osg-submissions.

Thanks,
Robert.

On 31 July 2013 04:18, Sergey Kurdakov sergey.fo...@gmail.com wrote:
 Hi Robert,

 working with OpenGL ES 2.0 with Angle ( I also checked ATI OpenGL ES SDK )
 with osg 3.2
 I have a warning Detected OpenGL error invalid enumerant on this line in
 State.cpp

  glGetIntegerv(GL_MAX_TEXTURE_COORDS,_glMaxTextureCoords);

 ( in following part of  code in function void
 State::initializeExtensionProcs()  )

  if ( osg::getGLVersionNumber() = 2.0 ||
 osg::isGLExtensionSupported(_contextID,GL_ARB_vertex_shader) ||
 OSG_GLES2_FEATURES)
 {

 glGetIntegerv(GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS,_glMaxTextureUnits);
 glGetIntegerv(GL_MAX_TEXTURE_COORDS,_glMaxTextureCoords);
 }



 I asked Angle project list that maybe they are wrong here ( but still ATI ES
 SDK also lacks GL_MAX_TEXTURE_COORDS ) and they responded they are not, the
 GL_MAX_TEXTURE_COORDS is underfined for OpenGL ES 2.0


 So, possibly here there should be a code like

 if ( osg::getGLVersionNumber() = 2.0 ||
 osg::isGLExtensionSupported(_contextID,GL_ARB_vertex_shader) ||
 OSG_GLES2_FEATURES)
 {

 glGetIntegerv(GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS,_glMaxTextureUnits);
 if(OSG_GLES2_FEATURES)
 {
 _glMaxTextureCoords = _glMaxTextureUnits;
 }
 else
 glGetIntegerv(GL_MAX_TEXTURE_COORDS,_glMaxTextureCoords);
 }

 ?

 Best regards
 Sergey





 ___
 osg-users mailing list
 osg-users@lists.openscenegraph.org
 http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


[osg-users] OpenGL ES 2.0 on windows

2013-07-30 Thread Sergey Kurdakov
Hi Robert,

Once you have the code working cleanly could
you post the modified file to osg-submissions.

ok,

checking now.

Regards
Sergey

On Wed, Jul 31, 2013 at 9:29 AM, Robert Osfield robert.osfi...@gmail.comwrote:

 Hi Sergey,

 You suggested change looks reasonable.  Curious that others including
 myself haven't spotted this error so I can only presume that quite a
 few GLES implementations do indeed included support for
 GL_MAX_TEXTURE_COORDS.  Once you have the code working cleanly could
 you post the modified file to osg-submissions.

 Thanks,
 Robert.


___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org