Re: [osg-users] osgText: two thread-safety issues

2018-07-31 Thread Robert Osfield
Hi Glenn,

Thanks for the note.  When I just back onto OSG maintenance work I'll
have a look into it.  Should be in the next week or two.

Robert.
On Tue, 31 Jul 2018 at 15:54, Glenn Waldron  wrote:
>
> Robert,
> I would like to make you aware of two thread-safety issues in osgText:
>
> Font::getGlyph() is thread-safe, but it returns a shared Glyph object that 
> also needs protection.  Glyph::getOrCreateTextureInfo, getTextureInfo, and 
> setTextureInfo can fail when creating Text objects from different threads.
>
> Font::getCachedStateSets() returns a container that can be modified by the 
> Text::createStateSet() method. This container also needs mutex protection.
>
> Glenn Waldron
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


[osg-users] osgText: two thread-safety issues

2018-07-31 Thread Glenn Waldron
Robert,
I would like to make you aware of two thread-safety issues in osgText:

Font::getGlyph() is thread-safe, but it returns a shared Glyph object that
also needs protection.  Glyph::getOrCreateTextureInfo, getTextureInfo, and
setTextureInfo can fail when creating Text objects from different threads.

Font::getCachedStateSets() returns a container that can be modified by the
Text::createStateSet() method. This container also needs mutex protection.

Glenn Waldron
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org