Re: [ovs-dev] [PATCH 1/2] dpctl: Stop showing the dpctl/help command.

[Ben Pfaff]

On Fri, Mar 15, 2019 at 05:06:01PM +0300, Ilya Maximets wrote:
> 'dpctl/help' command is not registered and could not be called.
> However, 'dpctl/list-commands' prints it as available.
> 
> CC: Ben Pfaff 
> Fixes: 337c45285445 ("dpctl: Fix jump through wild pointer in "dpctl/help".")
> Signed-off-by: Ilya Maximets 

Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 1/2] dpctl: Stop showing the dpctl/help command.

[Ilya Maximets]

'dpctl/help' command is not registered and could not be called.
However, 'dpctl/list-commands' prints it as available.

CC: Ben Pfaff 
Fixes: 337c45285445 ("dpctl: Fix jump through wild pointer in "dpctl/help".")
Signed-off-by: Ilya Maximets 
---
 lib/dpctl.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/lib/dpctl.c b/lib/dpctl.c
index baf37b8bc..edb753cb4 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -1348,6 +1348,10 @@ dpctl_list_commands(int argc OVS_UNUSED, const char 
*argv[] OVS_UNUSED,
 for (; commands->name; commands++) {
 const struct dpctl_command *c = commands;
 
+if (dpctl_p->is_appctl && !strcmp(c->name, "help")) {
+continue;
+}
+
 ds_put_format(, "  %s%-23s %s\n", dpctl_p->is_appctl ? "dpctl/" : 
"",
   c->name, c->usage);
 }
-- 
2.17.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev