Re: [ovs-dev] [PATCH ovn] pinctrl: Fix up comments about sending RST packets for healthcheck.

[Dumitru Ceara]

On 11/23/23 15:36, Ales Musil wrote:
> 
> 
> On Mon, Nov 20, 2023 at 8:45 PM Dumitru Ceara  > wrote:
> 
> We're sending TCP RST not RST-ACK as the comment suggests.
> 
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409288.html 
> 
> Reported-by: Mark Michelson  >
> Fixes: a35725a7a24b ("pinctrl: send RST instead of RST_ACK bit for
> lb hc")
> Signed-off-by: Dumitru Ceara  >
> ---
>  controller/pinctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/controller/pinctrl.c b/controller/pinctrl.c
> index 62cf4da324..1b176490ea 100644
> --- a/controller/pinctrl.c
> +++ b/controller/pinctrl.c
> @@ -7887,7 +7887,7 @@ pinctrl_handle_tcp_svc_check(struct rconn *swconn,
>          svc_mon->n_success++;
>          svc_mon->state = SVC_MON_S_ONLINE;
> 
> -        /* Send RST-ACK packet. */
> +        /* Send RST packet. */
>          svc_monitor_send_tcp_health_check__(swconn, svc_mon, TCP_RST,
>                                              htonl(tcp_ack),
>                                              htonl(0), th->tcp_dst);
> -- 
> 2.39.3
> 
> ___
> dev mailing list
> d...@openvswitch.org 
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> 
> 
> 
> Looks good to me, thanks.
> 
> Acked-by: Ales Musil mailto:amu...@redhat.com>>
> 

Thanks, Ales!  Applied to main and backported down to 22.03.

Regards,
Dumitru


___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] pinctrl: Fix up comments about sending RST packets for healthcheck.

[Ales Musil]

On Mon, Nov 20, 2023 at 8:45 PM Dumitru Ceara  wrote:

> We're sending TCP RST not RST-ACK as the comment suggests.
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409288.html
> Reported-by: Mark Michelson 
> Fixes: a35725a7a24b ("pinctrl: send RST instead of RST_ACK bit for lb hc")
> Signed-off-by: Dumitru Ceara 
> ---
>  controller/pinctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/controller/pinctrl.c b/controller/pinctrl.c
> index 62cf4da324..1b176490ea 100644
> --- a/controller/pinctrl.c
> +++ b/controller/pinctrl.c
> @@ -7887,7 +7887,7 @@ pinctrl_handle_tcp_svc_check(struct rconn *swconn,
>  svc_mon->n_success++;
>  svc_mon->state = SVC_MON_S_ONLINE;
>
> -/* Send RST-ACK packet. */
> +/* Send RST packet. */
>  svc_monitor_send_tcp_health_check__(swconn, svc_mon, TCP_RST,
>  htonl(tcp_ack),
>  htonl(0), th->tcp_dst);
> --
> 2.39.3
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
Looks good to me, thanks.

Acked-by: Ales Musil 

-- 

Ales Musil

Senior Software Engineer - OVN Core

Red Hat EMEA 

amu...@redhat.com

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] pinctrl: Fix up comments about sending RST packets for healthcheck.

[Dumitru Ceara]

We're sending TCP RST not RST-ACK as the comment suggests.

Reported-at: 
https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409288.html
Reported-by: Mark Michelson 
Fixes: a35725a7a24b ("pinctrl: send RST instead of RST_ACK bit for lb hc")
Signed-off-by: Dumitru Ceara 
---
 controller/pinctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/controller/pinctrl.c b/controller/pinctrl.c
index 62cf4da324..1b176490ea 100644
--- a/controller/pinctrl.c
+++ b/controller/pinctrl.c
@@ -7887,7 +7887,7 @@ pinctrl_handle_tcp_svc_check(struct rconn *swconn,
 svc_mon->n_success++;
 svc_mon->state = SVC_MON_S_ONLINE;
 
-/* Send RST-ACK packet. */
+/* Send RST packet. */
 svc_monitor_send_tcp_health_check__(swconn, svc_mon, TCP_RST,
 htonl(tcp_ack),
 htonl(0), th->tcp_dst);
-- 
2.39.3

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev