Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files
On Thu, May 9, 2019 at 10:08 PM Numan Siddique wrote: > > > On Thu, May 9, 2019 at 9:45 PM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > >> > > >> > > From: Numan Siddique >> > > >> > > This patch cleans up the tests folder and removes the non OVN >> > > test files. >> > > >> > > Signed-off-by: Numan Siddique >> >> Tested-by: Lorenzo Bianconi >> > > Thanks Lorenzo for testing it out. I missed adding Tested-by tag in the > next version I posted, which is same as this one > except the subject line to trigger the bot to compile on ovn repo. > > Let's see what the bot says about the tests results. > I pushed this commit to the master of the ovn-org/ovn repo. Thanks Numan > Thanks > Numan > > >> >> > > --- >> > > TODO_SPLIT.rst| 5 +- >> > > tests/MockXenAPI.py | 117 - >> > > tests/aes128.at | 146 - >> > > tests/appctl.py |74 - >> > > tests/auto-attach.at | 7 - >> > > tests/automake.mk | 301 +- >> > > tests/bfd.at | 1102 -- >> > > tests/bridge.at | 105 - >> > > tests/bundle.at | 454 - >> > > tests/cfm.at | 510 - >> > > tests/check-structs.at|56 - >> > > tests/checkpatch.at | 330 - >> > > tests/classifier.at | 308 - >> > > tests/completion.at | 794 -- >> > > tests/daemon-py.at| 252 - >> > > tests/daemon.at | 228 - >> > > tests/dpctl.at|87 - >> > > tests/dpdk/ring_client.c | 200 - >> > > tests/dpif-netdev.at | 422 - >> > > tests/file_name.at| 125 - >> > > tests/flowgen.py | 239 - >> > > tests/fuzz-regression-list.at |23 - >> > > tests/fuzz-regression.at |21 - >> > > .../flow_extract_fuzzer-5112775280951296 | Bin 54 -> 0 bytes >> > > .../flow_extract_fuzzer-5457710546944000 | Bin 227 -> 0 bytes >> > > .../json_parser_fuzzer-4790908707930112 | Bin 43 -> 0 bytes >> > > .../ofp_print_fuzzer-4584019764183040 | Bin 128 -> 0 bytes >> > > .../ofp_print_fuzzer-4730143510626304 | Bin 12 -> 0 bytes >> > > .../ofp_print_fuzzer-4854119633256448 | Bin 48 -> 0 bytes >> > > .../ofp_print_fuzzer-5070973479944192 | Bin 112 -> 0 bytes >> > > .../ofp_print_fuzzer-5072291707748352 | Bin 112 -> 0 bytes >> > > .../ofp_print_fuzzer-5147430386401280 | Bin 128 -> 0 bytes >> > > .../ofp_print_fuzzer-5168455220199424 | Bin 80 -> 0 bytes >> > > .../ofp_print_fuzzer-5190507327127552 | Bin 113 -> 0 bytes >> > > .../ofp_print_fuzzer-5204186701496320 | Bin 80 -> 0 bytes >> > > .../ofp_print_fuzzer-5394482341085184 | Bin 128 -> 0 bytes >> > > .../ofp_print_fuzzer-5395207246839808 | Bin 156 -> 0 bytes >> > > .../ofp_print_fuzzer-564745581120 | Bin 48 -> 0 bytes >> > > .../ofp_print_fuzzer-5674119268925440 | Bin 96 -> 0 bytes >> > > .../ofp_print_fuzzer-5674419757252608 | Bin 112 -> 0 bytes >> > > .../ofp_print_fuzzer-5677588436484096 | Bin 128 -> 0 bytes >> > > .../ofp_print_fuzzer-5706562554298368 | Bin 72 -> 0 bytes >> > > .../ofp_print_fuzzer-5722747668791296 | Bin 120 -> 0 bytes >> > > .../ofp_print_fuzzer-6285128790704128 | Bin 128 -> 0 bytes >> > > .../ofp_print_fuzzer-6470117922701312 | Bin 256 -> 0 bytes >> > > .../ofp_print_fuzzer-6502620041576448 | Bin 128 -> 0 bytes >> > > tests/heap.at |13 - >> > > tests/idltest.ann | 9 - >> > > tests/idltest.ovsschema | 184 - >> > > tests/idltest2.ovsschema | 144 - >> > > tests/interface-reconfigure.at| 1052 -- >> > > tests/json.at | 412 - >> > > tests/jsonrpc-py.at |46 - >> > > tests/jsonrpc.at |29 - >> > > tests/lacp.at | 1013 -- >> > > tests/learn.at| 838 -- >> > > tests/lib.at | 9 - >> > > tests/library.at | 258 - >> > > tests/lockfile.at |54 - >> > > tests/mcast-snooping.at | 218 - >> > > tests/mpls-xlate.at | 209 - >> > > tests/multipath.at| 582 -
Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files
On Thu, May 9, 2019 at 9:45 PM Lorenzo Bianconi wrote: > > > > > > From: Numan Siddique > > > > > > This patch cleans up the tests folder and removes the non OVN > > > test files. > > > > > > Signed-off-by: Numan Siddique > > Tested-by: Lorenzo Bianconi > Thanks Lorenzo for testing it out. I missed adding Tested-by tag in the next version I posted, which is same as this one except the subject line to trigger the bot to compile on ovn repo. Let's see what the bot says about the tests results. Thanks Numan > > > > --- > > > TODO_SPLIT.rst| 5 +- > > > tests/MockXenAPI.py | 117 - > > > tests/aes128.at | 146 - > > > tests/appctl.py |74 - > > > tests/auto-attach.at | 7 - > > > tests/automake.mk | 301 +- > > > tests/bfd.at | 1102 -- > > > tests/bridge.at | 105 - > > > tests/bundle.at | 454 - > > > tests/cfm.at | 510 - > > > tests/check-structs.at|56 - > > > tests/checkpatch.at | 330 - > > > tests/classifier.at | 308 - > > > tests/completion.at | 794 -- > > > tests/daemon-py.at| 252 - > > > tests/daemon.at | 228 - > > > tests/dpctl.at|87 - > > > tests/dpdk/ring_client.c | 200 - > > > tests/dpif-netdev.at | 422 - > > > tests/file_name.at| 125 - > > > tests/flowgen.py | 239 - > > > tests/fuzz-regression-list.at |23 - > > > tests/fuzz-regression.at |21 - > > > .../flow_extract_fuzzer-5112775280951296 | Bin 54 -> 0 bytes > > > .../flow_extract_fuzzer-5457710546944000 | Bin 227 -> 0 bytes > > > .../json_parser_fuzzer-4790908707930112 | Bin 43 -> 0 bytes > > > .../ofp_print_fuzzer-4584019764183040 | Bin 128 -> 0 bytes > > > .../ofp_print_fuzzer-4730143510626304 | Bin 12 -> 0 bytes > > > .../ofp_print_fuzzer-4854119633256448 | Bin 48 -> 0 bytes > > > .../ofp_print_fuzzer-5070973479944192 | Bin 112 -> 0 bytes > > > .../ofp_print_fuzzer-5072291707748352 | Bin 112 -> 0 bytes > > > .../ofp_print_fuzzer-5147430386401280 | Bin 128 -> 0 bytes > > > .../ofp_print_fuzzer-5168455220199424 | Bin 80 -> 0 bytes > > > .../ofp_print_fuzzer-5190507327127552 | Bin 113 -> 0 bytes > > > .../ofp_print_fuzzer-5204186701496320 | Bin 80 -> 0 bytes > > > .../ofp_print_fuzzer-5394482341085184 | Bin 128 -> 0 bytes > > > .../ofp_print_fuzzer-5395207246839808 | Bin 156 -> 0 bytes > > > .../ofp_print_fuzzer-564745581120 | Bin 48 -> 0 bytes > > > .../ofp_print_fuzzer-5674119268925440 | Bin 96 -> 0 bytes > > > .../ofp_print_fuzzer-5674419757252608 | Bin 112 -> 0 bytes > > > .../ofp_print_fuzzer-5677588436484096 | Bin 128 -> 0 bytes > > > .../ofp_print_fuzzer-5706562554298368 | Bin 72 -> 0 bytes > > > .../ofp_print_fuzzer-5722747668791296 | Bin 120 -> 0 bytes > > > .../ofp_print_fuzzer-6285128790704128 | Bin 128 -> 0 bytes > > > .../ofp_print_fuzzer-6470117922701312 | Bin 256 -> 0 bytes > > > .../ofp_print_fuzzer-6502620041576448 | Bin 128 -> 0 bytes > > > tests/heap.at |13 - > > > tests/idltest.ann | 9 - > > > tests/idltest.ovsschema | 184 - > > > tests/idltest2.ovsschema | 144 - > > > tests/interface-reconfigure.at| 1052 -- > > > tests/json.at | 412 - > > > tests/jsonrpc-py.at |46 - > > > tests/jsonrpc.at |29 - > > > tests/lacp.at | 1013 -- > > > tests/learn.at| 838 -- > > > tests/lib.at | 9 - > > > tests/library.at | 258 - > > > tests/lockfile.at |54 - > > > tests/mcast-snooping.at | 218 - > > > tests/mpls-xlate.at | 209 - > > > tests/multipath.at| 582 - > > > tests/netdev-type.at |24 - > > > tests/nsh.at | 823 -- > > > tests/odp.at | 406 - > > > tests/ofp-actions.at | 912 -- > > > tes
Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files
Numan Siddique writes: > On Thu, May 9, 2019 at 8:14 AM Mark Michelson wrote: > > On Wed, May 8, 2019, 20:35 Ben Pfaff wrote: > > On Wed, May 08, 2019 at 04:15:59PM -0400, Aaron Conole wrote: > > Hi Numan, > > > > (also, CC'ing Mark) > > > > 0-day Robot writes: > > > > > Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried > out your patch. > > > Thanks for your contribution. > > > > > > I encountered some error that I wasn't expecting. See the details below. > > > > I think it makes sense to use the 'ovn-org/ovn' bracketed string as a > > way of sending the patch to the OVN github repo for processing. I'm > > glad you proposed something with this patch. > > > > Is there any objection to settling on that? Then I can make the bot "do > > the right thing" :-) > > To me it seems longer than necessary, I'd think "ovn" by itself would be > enough. > > I agree with Ben. The longer the required patch prefix, the less information > can be conveyed in > the first line of the commit message > > Ok. Sounds good to me. > > I will submit the patch with the prefix - "[PATCH][ovn] " You can even shorten it: [PATCH ovn] ... should also work :) It can be made to appear like that with the --subject-prefix argument to git-format-patch: $ git format-patch HEAD~ --subject-prefix="PATCH ovn" > Thanks > Numan ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files
On Thu, May 9, 2019 at 8:14 AM Mark Michelson wrote: > > > On Wed, May 8, 2019, 20:35 Ben Pfaff wrote: > >> On Wed, May 08, 2019 at 04:15:59PM -0400, Aaron Conole wrote: >> > Hi Numan, >> > >> > (also, CC'ing Mark) >> > >> > 0-day Robot writes: >> > >> > > Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried >> out your patch. >> > > Thanks for your contribution. >> > > >> > > I encountered some error that I wasn't expecting. See the details >> below. >> > >> > I think it makes sense to use the 'ovn-org/ovn' bracketed string as a >> > way of sending the patch to the OVN github repo for processing. I'm >> > glad you proposed something with this patch. >> > >> > Is there any objection to settling on that? Then I can make the bot "do >> > the right thing" :-) >> >> To me it seems longer than necessary, I'd think "ovn" by itself would be >> enough. >> > > I agree with Ben. The longer the required patch prefix, the less > information can be conveyed in the first line of the commit message > Ok. Sounds good to me. I will submit the patch with the prefix - "[PATCH][ovn] " Thanks Numan ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files
On Wed, May 8, 2019, 20:35 Ben Pfaff wrote: > On Wed, May 08, 2019 at 04:15:59PM -0400, Aaron Conole wrote: > > Hi Numan, > > > > (also, CC'ing Mark) > > > > 0-day Robot writes: > > > > > Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried > out your patch. > > > Thanks for your contribution. > > > > > > I encountered some error that I wasn't expecting. See the details > below. > > > > I think it makes sense to use the 'ovn-org/ovn' bracketed string as a > > way of sending the patch to the OVN github repo for processing. I'm > > glad you proposed something with this patch. > > > > Is there any objection to settling on that? Then I can make the bot "do > > the right thing" :-) > > To me it seems longer than necessary, I'd think "ovn" by itself would be > enough. > I agree with Ben. The longer the required patch prefix, the less information can be conveyed in the first line of the commit message > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files
On Wed, May 08, 2019 at 04:15:59PM -0400, Aaron Conole wrote: > Hi Numan, > > (also, CC'ing Mark) > > 0-day Robot writes: > > > Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out > > your patch. > > Thanks for your contribution. > > > > I encountered some error that I wasn't expecting. See the details below. > > I think it makes sense to use the 'ovn-org/ovn' bracketed string as a > way of sending the patch to the OVN github repo for processing. I'm > glad you proposed something with this patch. > > Is there any objection to settling on that? Then I can make the bot "do > the right thing" :-) To me it seems longer than necessary, I'd think "ovn" by itself would be enough. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files
Hi Numan, (also, CC'ing Mark) 0-day Robot writes: > Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. I think it makes sense to use the 'ovn-org/ovn' bracketed string as a way of sending the patch to the OVN github repo for processing. I'm glad you proposed something with this patch. Is there any objection to settling on that? Then I can make the bot "do the right thing" :-) > git-am: > fatal: sha1 information is lacking or useless (TODO_SPLIT.rst). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 tests: Remove non OVN test files > The copy of the patch that failed is found in: > > /var/lib/jenkins/jobs/upstream_build_from_pw/workspace/.git/rebase-apply/patch > When you have resolved this problem, run "git am --resolved". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > > > Please check this out. If you feel there has been an error, please > email acon...@bytheb.org > > Thanks, > 0-day Robot > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (TODO_SPLIT.rst). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 tests: Remove non OVN test files The copy of the patch that failed is found in: /var/lib/jenkins/jobs/upstream_build_from_pw/workspace/.git/rebase-apply/patch When you have resolved this problem, run "git am --resolved". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
