Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

[Matteo Croce]

On Thu, Jan 4, 2018 at 11:50 AM, Vishal Deep Ajmera
 wrote:
> Hi Matteo,
>
> Can we also have DPDK version in the logs (VLOG_INFO) when DPDK is 
> initialized ? May be in dpdk_init() function. This will help in identifying 
> the correct DPDK version from the log files while debugging issues.
>
> Warm Regards,
> Vishal Ajmera
>

Sure, makes sense.

Thanks,
-- 
Matteo Croce
per aspera ad upstream
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

[Vishal Deep Ajmera]

Hi Matteo,

Can we also have DPDK version in the logs (VLOG_INFO) when DPDK is initialized 
? May be in dpdk_init() function. This will help in identifying the correct 
DPDK version from the log files while debugging issues.

Warm Regards,
Vishal Ajmera

-Original Message-
From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] 
On Behalf Of Aaron Conole
Sent: Wednesday, January 03, 2018 12:20 AM
To: Matteo Croce <mcr...@redhat.com>
Cc: d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

Matteo Croce <mcr...@redhat.com> writes:

> On Tue, Jan 2, 2018 at 6:08 PM, Aaron Conole <acon...@redhat.com> wrote:
>> Hi Matteo,
>>
>> Matteo Croce <mcr...@redhat.com> writes:
>>
>>> Show DPDK version if Open vSwitch is compiled with DPDK support.
>>> Add a `dpdk_version` column in the datamodel, change ovs-ctl and 
>>> ovs-dev.py to populate the field with the right value.
>>>
>>> Signed-off-by: Matteo Croce <mcr...@redhat.com>
>>> ---
>>
>> Sorry I missed some of the development for this - I think it's better 
>> to have the dpdk version retrieved via an appctl command.  I can't 
>> think of a need for this information to be persistent - if it's for 
>> historical information when debugging, we can put it in with the logs 
>> when dpdk is started.  The user cannot influence DPDK version 
>> dynamically - it is not just read-only, but it's read-only from a 
>> compile time decision.  I might be misunderstanding the point of putting 
>> this in the DB, though?
>
> Hi Aaron,
>
> I was threating dpdk_version the same way as ovs_version.

Ahh, okay.  I had forgotten that ovs_version (and other information) was in the 
db as well.  Sorry for that - next time I'll have coffee before reviewing. :)

> ovs_version is saved into the DB by ovs-ctl and it isn't read-only either.
> What about putting it only in `ovs-vswitchd --version` output and not 
> into the DB?

What about using the datapath_version field?  That field already gets 
populated, and I think it may be okay to modify the return value of 
dpif_netdev_get_datapath_version function when dpdk is enabled.  Just a thought.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

[Aaron Conole]

Matteo Croce  writes:

> On Tue, Jan 2, 2018 at 6:08 PM, Aaron Conole  wrote:
>> Hi Matteo,
>>
>> Matteo Croce  writes:
>>
>>> Show DPDK version if Open vSwitch is compiled with DPDK support.
>>> Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py
>>> to populate the field with the right value.
>>>
>>> Signed-off-by: Matteo Croce 
>>> ---
>>
>> Sorry I missed some of the development for this - I think it's better to
>> have the dpdk version retrieved via an appctl command.  I can't think of
>> a need for this information to be persistent - if it's for historical
>> information when debugging, we can put it in with the logs when dpdk is
>> started.  The user cannot influence DPDK version dynamically - it is not
>> just read-only, but it's read-only from a compile time decision.  I
>> might be misunderstanding the point of putting this in the DB, though?
>
> Hi Aaron,
>
> I was threating dpdk_version the same way as ovs_version.

Ahh, okay.  I had forgotten that ovs_version (and other information) was
in the db as well.  Sorry for that - next time I'll have coffee before
reviewing. :)

> ovs_version is saved into the DB by ovs-ctl and it isn't read-only either.
> What about putting it only in `ovs-vswitchd --version` output and not
> into the DB?

What about using the datapath_version field?  That field already gets
populated, and I think it may be okay to modify the return value of
dpif_netdev_get_datapath_version function when dpdk is enabled.  Just a
thought.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

[Ben Pfaff]

On Tue, Jan 02, 2018 at 06:18:03PM +0100, Matteo Croce wrote:
> On Tue, Jan 2, 2018 at 6:08 PM, Aaron Conole  wrote:
> > Hi Matteo,
> >
> > Matteo Croce  writes:
> >
> >> Show DPDK version if Open vSwitch is compiled with DPDK support.
> >> Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py
> >> to populate the field with the right value.
> >>
> >> Signed-off-by: Matteo Croce 
> >> ---
> >
> > Sorry I missed some of the development for this - I think it's better to
> > have the dpdk version retrieved via an appctl command.  I can't think of
> > a need for this information to be persistent - if it's for historical
> > information when debugging, we can put it in with the logs when dpdk is
> > started.  The user cannot influence DPDK version dynamically - it is not
> > just read-only, but it's read-only from a compile time decision.  I
> > might be misunderstanding the point of putting this in the DB, though?
> 
> Hi Aaron,
> 
> I was threating dpdk_version the same way as ovs_version.
> ovs_version is saved into the DB by ovs-ctl and it isn't read-only either.
> What about putting it only in `ovs-vswitchd --version` output and not
> into the DB?

One reason that ovs_version is in the database is because a controller
might need to know and the controller can't necessarily run
"ovs-vswitchd --version" since it might be on a different host.

I don't know whether a controller needs to know the DPDK version.  I
assumed that it did and that that was the motivation for the commit.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

[Matteo Croce]

On Tue, Jan 2, 2018 at 6:08 PM, Aaron Conole  wrote:
> Hi Matteo,
>
> Matteo Croce  writes:
>
>> Show DPDK version if Open vSwitch is compiled with DPDK support.
>> Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py
>> to populate the field with the right value.
>>
>> Signed-off-by: Matteo Croce 
>> ---
>
> Sorry I missed some of the development for this - I think it's better to
> have the dpdk version retrieved via an appctl command.  I can't think of
> a need for this information to be persistent - if it's for historical
> information when debugging, we can put it in with the logs when dpdk is
> started.  The user cannot influence DPDK version dynamically - it is not
> just read-only, but it's read-only from a compile time decision.  I
> might be misunderstanding the point of putting this in the DB, though?

Hi Aaron,

I was threating dpdk_version the same way as ovs_version.
ovs_version is saved into the DB by ovs-ctl and it isn't read-only either.
What about putting it only in `ovs-vswitchd --version` output and not
into the DB?

-- 
Matteo Croce
per aspera ad upstream
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

[Aaron Conole]

Hi Matteo,

Matteo Croce  writes:

> Show DPDK version if Open vSwitch is compiled with DPDK support.
> Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py
> to populate the field with the right value.
>
> Signed-off-by: Matteo Croce 
> ---

Sorry I missed some of the development for this - I think it's better to
have the dpdk version retrieved via an appctl command.  I can't think of
a need for this information to be persistent - if it's for historical
information when debugging, we can put it in with the logs when dpdk is
started.  The user cannot influence DPDK version dynamically - it is not
just read-only, but it's read-only from a compile time decision.  I
might be misunderstanding the point of putting this in the DB, though?
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

[Matteo Croce]

On Tue, Dec 26, 2017 at 6:38 PM, Ben Pfaff  wrote:
> On Mon, Dec 25, 2017 at 03:31:02PM +0100, Matteo Croce wrote:
>> Show DPDK version if Open vSwitch is compiled with DPDK support.
>> Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py
>> to populate the field with the right value.
>>
>> Signed-off-by: Matteo Croce 
>
> OK, this is better, but why does ovs-vswitchd need a shell helper for
> this?  It should just set the key itself.

On ovs-vswitchd startup?
I think I set dpdk_version the same way ovs_version was set.
I can do it in ovs-vswitchd startup but in that case ovs_version
should be set in ovs-vswitchd too.

Cheers,
-- 
Matteo Croce
per aspera ad upstream
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

[Ben Pfaff]

On Mon, Dec 25, 2017 at 03:31:02PM +0100, Matteo Croce wrote:
> Show DPDK version if Open vSwitch is compiled with DPDK support.
> Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py
> to populate the field with the right value.
> 
> Signed-off-by: Matteo Croce 

OK, this is better, but why does ovs-vswitchd need a shell helper for
this?  It should just set the key itself.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev