[Bug 957804] Review Request: kryo - Object graph serialization framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=957804 Michal Srb changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@redhat.com Assignee|nob...@fedoraproject.org|m...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fKQqpuwT57&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799650] Review Request: python-django-tagging - A generic tagging application for Django projects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799650 Matthias Runge changed: What|Removed |Added Blocks||962956 Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #7 from Matthias Runge --- Package Change Request == Package Name: python-django-tagging New Branches: el6 Owners: mrunge -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ya0JKQXTYx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806562] Review Request: python-django-pagination - Django pagination tools
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=806562 Matthias Runge changed: What|Removed |Added Blocks||962955 Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #11 from Matthias Runge --- Package Change Request == Package Name: python-django-pagination New Branches: el6 Owners: mrunge -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8UXiEVTRsK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959674 Michal Srb changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@redhat.com Assignee|nob...@fedoraproject.org|m...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hoMayU8eO7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920038] Review Request: infomas-asl - Java annotation scanner
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920038 Michal Srb changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Yl7f64u4ux&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920037] Review Request: maven-jsf-plugin - Maven plugin for generating tlds, jsp tag sources and others
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=920037 Michal Srb changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3piSNfJg1f&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816323] Review Request: python-django-contact-form - An extensible contact-form application for Django
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=816323 Matthias Runge changed: What|Removed |Added Blocks||962953 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jmHHwKzi2I&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816323] Review Request: python-django-contact-form - An extensible contact-form application for Django
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=816323 Matthias Runge changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #8 from Matthias Runge --- Package Change Request == Package Name: python-django-contact-form New Branches: el6 Owners: mrunge -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GhvX6NsqK4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962691] Review Request: jenkins-version-number - Version number manipulation library for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=962691 Michal Srb changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=H4CoZr8CS6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qOhGrxpghq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 Parag AN(पराग) changed: What|Removed |Added Blocks||963077 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lJqteAsZed&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963077] Review Request: brise - the official Rime schema repository
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963077 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED Depends On||963074 Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=300qggXwLj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963077] Review Request: brise - the official Rime schema repository
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963077 Parag AN(पराग) changed: What|Removed |Added Blocks||963078 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kIKRZays2m&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963078] Review Request: ibus-rime - Rime Input Method Engine for Linux/IBus
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963078 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED Depends On||963074, 963077 Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3JxQCxrjU5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 Parag AN(पराग) changed: What|Removed |Added Blocks||963078 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P8fmhHxUbo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962691] Review Request: jenkins-version-number - Version number manipulation library for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=962691 Michal Srb changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Michal Srb --- Thanks for the review, I will ask upstream if it would be possible to add license text(s) to the repository. New Package SCM Request === Package Name: jenkins-version-number Short Description: Version number manipulation library for Java Owners: msrb sochotni mizdebsk tradej Branches: f19 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z0kNbK2ICX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963078] Review Request: ibus-rime - Rime Input Method Engine for Linux/IBus
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963078 Peng Wu changed: What|Removed |Added Assignee|nob...@fedoraproject.org|panem...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LrPYvQDmWy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963078] New: Review Request: ibus-rime - Rime Input Method Engine for Linux/IBus
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963078 Bug ID: 963078 Summary: Review Request: ibus-rime - Rime Input Method Engine for Linux/IBus Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: p...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://pwu.fedorapeople.org/rime/ibus-rime.spec SRPM URL: http://pwu.fedorapeople.org/rime/ibus-rime-0.9.9-1.fc18.src.rpm Description: ibus-rime: Rime Input Method Engine for Linux/IBus Fedora Account System Username:pwu -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=frEyrnDI7T&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963077] Review Request: brise - the official Rime schema repository
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963077 Peng Wu changed: What|Removed |Added Assignee|nob...@fedoraproject.org|panem...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D3tIqGiXp0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963077] New: Review Request: brise - the official Rime schema repository
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963077 Bug ID: 963077 Summary: Review Request: brise - the official Rime schema repository Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: p...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://pwu.fedorapeople.org/rime/brise.spec SRPM URL: http://pwu.fedorapeople.org/rime/brise-0.22-1.fc18.src.rpm Description: La brise: the official Rime schema repository. Fedora Account System Username:pwu -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TwMfnPcJ0i&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] Review Request: librime - Rime Input Method Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 Peng Wu changed: What|Removed |Added Assignee|nob...@fedoraproject.org|panem...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vSPx3AS139&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963074] New: Review Request: librime - Rime Input Method Engine
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963074 Bug ID: 963074 Summary: Review Request: librime - Rime Input Method Engine Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: p...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Category: --- Spec URL: http://pwu.fedorapeople.org/rime/librime.spec SRPM URL: http://pwu.fedorapeople.org/rime/librime-0.9.8-1.fc18.src.rpm Description: RIME: Rime Input Method Engine Fedora Account System Username:pwu -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=G6DxWxo2ih&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961819] Review Request: jenkins-task-reactor - Jenkins task-reactor library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961819 Michal Srb changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-05-15 01:44:59 --- Comment #5 from Michal Srb --- Built in Rawhide and F19. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Aejc33RRir&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961786] Review Request: git-ftp - Git powered FTP client written as shell script
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961786 Eduardo Echeverria changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Eduardo Echeverria --- Thanks Yohan New Package SCM Request === Package Name: git-ftp Short Description: Git powered FTP client written as shell script Owners: echevemaster Branches: f17 f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x6GjjDbyHx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871018] Review Request: glassfish-hk2 - Hundred Kilobytes Kernel
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871018 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from gil cattaneo --- New Package SCM Request === Package Name: glassfish-hk2 Short Description: Hundred Kilobytes Kernel Owners: gil Branches: f18 f19 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=na6UDkTXnu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961817] Review Request: jenkins-extras-memory-monitor - Java library for monitoring memory/swap usage
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961817 Michal Srb changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-05-15 01:40:58 --- Comment #5 from Michal Srb --- Built in Rawhide and F19. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B8pHuKC4mg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961394] Review Request: access-modifier-annotation - Java annotation for custom access modifiers
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961394 Michal Srb changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-05-15 01:39:51 --- Comment #5 from Michal Srb --- Built in Rawhide and F19. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ALWUbO7CG4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 871018] Review Request: glassfish-hk2 - Hundred Kilobytes Kernel
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871018 Michal Srb changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Michal Srb --- Everything seems to be in order now, thanks. Approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kxCKdZFM6P&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891170] Review Request: e_dbus - Wrappers around D-Bus for EFL based applications
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891170 --- Comment #3 from Rahul Sundaram --- Done the changes suggested along with a few more. The suggestion to change %make_install is bogus since it expands to the latter and is NOT the same as %makeinstall macro http://sundaram.fedorapeople.org/packages/e_dbus.spec http://sundaram.fedorapeople.org/packages/e_dbus-1.7.6-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lzDt8aUWhg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961786] Review Request: git-ftp - Git powered FTP client written as shell script
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961786 Yohan Graterol changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TW1udYU20l&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961786] Review Request: git-ftp - Git powered FTP client written as shell script
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961786 Yohan Graterol changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=avLwJr0Nww&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961786] Review Request: git-ftp - Git powered FTP client written as shell script
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=961786
--- Comment #1 from Yohan Graterol ---
Hello Eduardo,
I'll do the formal review.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[-]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 51200 bytes in 4 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
= EXTRA items =
Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
---
Checking: git-ftp-0.84-1.fc20.noarch.rpm
git-ftp.noarch: W: no-manual
[Bug 877779] Review Request: openwebbeans - Implementation of the JSR-299 WebBeans
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=89 --- Comment #13 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/openwebbeans.spec SRPM URL: http://gil.fedorapeople.org/openwebbeans-1.1.8-2.fc18.src.rpm - added jpackage-utils references -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pq618gO70T&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 961786] Review Request: git-ftp - Git powered FTP client written as shell script
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=961786 Yohan Graterol changed: What|Removed |Added CC||yohangratero...@gmail.com Assignee|nob...@fedoraproject.org|yohangratero...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=APKv7p9kIQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890769] Review Request: embryo - Small Pawn based virtual machine and compiler.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890769 Rahul Sundaram changed: What|Removed |Added Flags|fedora-review- | Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nyhsrU6xtD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890769] Review Request: embryo - Small Pawn based virtual machine and compiler.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890769 Rahul Sundaram changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review- --- Comment #15 from Rahul Sundaram --- Please fix the license to zlib and GPLv2 and use make_install macro as suggested in IRC. Other than that, I don't see any blockers. As a side note, I proposed this originally but Dan is going to be the primary maintainer and I am doing a review after his changes just in case anyone is confused by that. @Dan, please keep me as co-maintainer. thanks! == APPROVED == -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZwVDVeZUMg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962651] Re-Review Request: bamf - Application matching framework
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=962651
--- Comment #3 from Praveen Kumar ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in bamf-devel
, bamf-daemon
[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated",
"LGPL (v3 or later)", "GPL (v3)". 18 files have unknown license. Detailed
output of licensecheck in /home/daredevil/962651-bamf/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[-]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 245760 bytes in 9 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English la
[Bug 890769] Review Request: embryo - Small Pawn based virtual machine and compiler.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890769 Rahul Sundaram changed: What|Removed |Added Assignee|terje...@phys.ntnu.no |methe...@gmail.com QA Contact|extras...@fedoraproject.org |methe...@gmail.com --- Comment #14 from Rahul Sundaram --- Terje Røsten, I am taking over the review since we need to move forward quickly. Hope you don't mind and thanks for the review so far. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vj7eyUQhct&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916431] Review Request: python-tw2-jqplugins-jqplot - Toscawidgets2 wrapper for the jqPlot jQuery plugin
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916431 --- Comment #12 from Fedora Update System --- python-tw2-jqplugins-jqplot-2.0.3-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xUzNENgvTU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916431] Review Request: python-tw2-jqplugins-jqplot - Toscawidgets2 wrapper for the jqPlot jQuery plugin
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916431 --- Comment #11 from Fedora Update System --- python-tw2-jqplugins-jqplot-2.0.3-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FLLrkbwK1S&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915427] Review Request: python-zc-customdoctests - Use doctest with other languages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915427 --- Comment #14 from Fedora Update System --- python-zc-customdoctests-1.0.1-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aMeaxZmOw6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916436] Review Request: python-narcissus-app - WSGI components for Narcissus, realtime log visualization
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916436 --- Comment #8 from Fedora Update System --- python-tw2-slideymenu-2.2-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lO9wv7ki7w&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915427] Review Request: python-zc-customdoctests - Use doctest with other languages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915427 --- Comment #13 from Fedora Update System --- python-zc-customdoctests-1.0.1-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WF7vjmuGpk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916426] Review Request: python-narcissus-common - Common components for Narcissus, realtime log visualization
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916426 --- Comment #13 from Fedora Update System --- python-narcissus-common-0.9.0.1-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ml7xg9iAJN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916426] Review Request: python-narcissus-common - Common components for Narcissus, realtime log visualization
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916426 --- Comment #12 from Fedora Update System --- python-narcissus-common-0.9.0.1-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZIELQOySmU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916436] Review Request: python-narcissus-app - WSGI components for Narcissus, realtime log visualization
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916436 --- Comment #7 from Fedora Update System --- python-tw2-slideymenu-2.2-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EiYDmZKyus&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854670] Review Request: libjpeg-turbo - A MMX/SSE2 accelerated library for manipulating JPEG image files
Product: Fedora EPEL https://bugzilla.redhat.com/show_bug.cgi?id=854670 Orion Poplawski changed: What|Removed |Added Flags||needinfo?(gsgat...@ncsu.edu ||) --- Comment #9 from Orion Poplawski --- Gary - ping? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Rudh7NxpSd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962651] Re-Review Request: bamf - Application matching framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=962651 --- Comment #2 from Praveen Kumar --- Hi Michel, Thanks for taking this package, I will do a formal review today. I am not changing "Assigned Flag" right now, will do it later. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FOczVQqG4X&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959188] Review Request: perl-Plack-Middleware-Deflater - Compress response body with Gzip or Deflate
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959188 --- Comment #2 from Robin Lee --- Changes: - BuildRequires more Perl modules: parent, Plack::Middleware, Plack::Util, Plack::Util::Accessor, File::Spec, Spiffy, Test::Base::Filter, Test::Builder, Test::Builder::Module - 'frontend' changed to 'front end' Spec URL: http://cheeselee.fedorapeople.org/perl-Plack-Middleware-Deflater.spec SRPM URL: http://cheeselee.fedorapeople.org/perl-Plack-Middleware-Deflater-0.08-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DuKHkxamVD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 955913] Review Request: nsnake - Classic snake game on console
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=955913 --- Comment #11 from Christopher Meng --- (In reply to comment #9) Upstream finally decide to release a new version. Spec URL: http://cicku.me/nsnake.spec SRPM URL: http://cicku.me/nsnake-1.7-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PXsmfUuqFy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917388] Review Request: zopfli - Zlib compatible better compressor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=917388 Rahul Sundaram changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Rahul Sundaram --- I don't think there is any need to rename and converting into a library is tracked upstream and I have no sway in that process one way or the other. Thanks for approving New Package SCM Request === Package Name: zopfli Short Description: Zlib compatible better compressor Owners: sundaram Branches: f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7qeP1jNDls&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960784] Review Request: trac-fedmsg-plugin - Emit fedmsg messages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960784 Ralph Bean changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Ralph Bean --- New Package SCM Request === Package Name: trac-fedmsg-plugin Short Description: Emit fedmsg messages Owners: ralph Branches: f19 f18 f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fwdQmDJs9j&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957918] Review Request: libxmp - A multi-format module playback library
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957918
Paulo Andrade changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||paulo.cesar.pereira.de.andr
||a...@gmail.com
Assignee|nob...@fedoraproject.org|paulo.cesar.pereira.de.andr
||a...@gmail.com
Flags||fedora-review?
--- Comment #1 from Paulo Andrade ---
Hi, the package appears good, and I feel if any issues
arise it is due to a vague possibility of it implementing
some patented algorithm or issues with the public domain
licensed files.
I will try to carefully review all files to make more
specific questions about the possible refactoring and/or
bundling of system libraries in the decoders, unpack, etc,
implementation files, but any early comment by you
(or Claudio :-) is welcome).
[?]: Package complies to the Packaging Guidelines
[!]: Buildroot is not present
Note: Invalid buildroot found:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -u -n)
Unless you plan to package to epel5, you must remove the
BuildRoot tag, and still, would be better to have the
buildroot tag only in the epel5 branch.
[!]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
Please do to a breakdown of the license in the spec. Usually
prefixing the license name as a comment before files in the
%files sections.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios
Generic fedora-review output follows.
---%<---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libxmp-
devel
[?]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later) (with incorrect FSF address)", "Unknown or
generated", "BSD (4 clause)", "MIT/X11 (BSD like)", "LGPL (v2 or later)
(with incorrect FSF address)", "*No copyright* Public domain", "GPL
(unversioned/unknown version)", "LGPL (v2.1 or later)". 424 files have
unknown license. Detailed output of licensecheck in
/home/pcpa/957918-libxmp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[!]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 348160 bytes in 12 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run
[Bug 810336] Review Request: ga - Global Arrays Toolkit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=810336 --- Comment #27 from Fedora Update System --- ga-5.1.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ga-5.1.1-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ReLXrOKdoU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959118] Review Request: fossil - A distributed SCM with bug tracking and wiki
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959118 --- Comment #15 from Fedora Update System --- fossil-1.25-2.20130216000435.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/fossil-1.25-2.20130216000435.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WTTX4YTFTs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959118] Review Request: fossil - A distributed SCM with bug tracking and wiki
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959118 --- Comment #14 from Fedora Update System --- fossil-1.25-2.20130216000435.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/fossil-1.25-2.20130216000435.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TaRACOBB3O&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959118] Review Request: fossil - A distributed SCM with bug tracking and wiki
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959118 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AEZU77SrJX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962581] Review Request: arm-boot-config - ARM boot configuration generator for uboot
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=962581 --- Comment #5 from Brendan Conoboy --- New Package SCM Request === Package Name: arm-boot-config Short Description: ARM boot configuration engine. Owners: blc Branches: f19 InitialCC: dgilmore -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TMtv0Edljj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962581] Review Request: arm-boot-config - ARM boot configuration generator for uboot
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=962581 Peter Robinson changed: What|Removed |Added CC||pbrobin...@gmail.com Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gXo0Z5kT0s&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956147] Review Request: wide-dhcpv6 - DHCPv6 Prefix Delegation client that works on PPP
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956147 --- Comment #14 from David Beveridge --- (In reply to comment #10) > PS: still not sure about SELINUX policies. I need to test this too. I've been running tests in enforcing targeted mode without any problems. root@localhost ~ # sestatus SELinux status: enabled SELinuxfs mount:/sys/fs/selinux SELinux root directory: /etc/selinux Loaded policy name: targeted Current mode: enforcing Mode from config file: enforcing Policy MLS status: enabled Policy deny_unknown status: allowed Max kernel policy version: 28 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tEjqVxtbqa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 956147] Review Request: wide-dhcpv6 - DHCPv6 Prefix Delegation client that works on PPP
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=956147 --- Comment #13 from David Beveridge --- (In reply to comment #10) > > sure the cflags/linker flags make it properly. You can check using this > > script that is not yet integrated into rpmlint: > > https://nohats.ca/checksec.sh > > not done yet > root@localhost ~/rpmbuild/SPECS # ./checksec.sh --file /sbin/dhcp6c RELRO STACK CANARY NXPIE RPATH RUNPATH FILE Full RELRO Canary found NX enabledPIE enabled No RPATH No RUNPATH /sbin/dhcp6c root@localhost ~/rpmbuild/SPECS # ./checksec.sh --file /sbin/dhcp6s RELRO STACK CANARY NXPIE RPATH RUNPATH FILE Full RELRO Canary found NX enabledPIE enabled No RPATH No RUNPATH /sbin/dhcp6s root@localhost ~/rpmbuild/SPECS # ./checksec.sh --file /sbin/dhcp6relay RELRO STACK CANARY NXPIE RPATH RUNPATH FILE Full RELRO Canary found NX enabledPIE enabled No RPATH No RUNPATH /sbin/dhcp6relay -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PVlHqrmXOk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958865] Review Request: edk2 - EFI Development Kit II
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958865 --- Comment #2 from Cole Robinson --- (In reply to comment #1) > > [ ]: Sources contain only permissible code or content. > > I'll address this in a separate comment > I was going to ping someone to see if it's acceptable to even have the fat bits in the tarball. I know for patent encumbered code we don't want it in Fedora in any form. But we can avoid the question entirely, just delete the fat code during the tarball generation step and document it in the spec. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8aqgO2ZYAJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958865] Review Request: edk2 - EFI Development Kit II
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958865
Cole Robinson changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|crobi...@redhat.com
--- Comment #1 from Cole Robinson ---
A few things flagged by fedora-review:
- Package contains BR: python2-devel or python3-devel
See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
needs BuildRequires: python2-devel instead of BR: python
- Large documentation must go in a -doc subpackage.
Note: Documentation size is 1269760 bytes in 21 files.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
Move pdf bits to a edk2-docs or edk2-tools-docs package
[ ]: Sources contain only permissible code or content.
I'll address this in a separate comment
[ ]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in edk2-tools
Like it says, 'Requires: edk2' needs to be fully versioned
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"BSD (4 clause) ISC", "Public domain", "Unknown or generated", "BSD (4
clause)", "MIT/X11 (BSD like)", "BSD (3 clause) ISC", "zlib/libpng",
"ISC", "BSD (2 clause) GPL (v2 or later)", "BSD (3 clause)", "BSD (2
clause)", "*No copyright* Public domain". 7334 files have unknown
The bits being distributed seem to all be BSD, but there's quite a few other
hits.
GPLv2 comes from bundled libfdt. If we eventually ship ovmf we'd need to be
able to build against system library here.
zlib/libpng comes from bundled Python 2.7.2 . (Is that just for a devkit or
would that be included in a future ovmf?)
[!]: Dist tag is present.
Version: should be git
Release: should be 1%{?dist}
[!]: Uses parallel make.
Use make %{?_smp_mflags}
[ ]: SourceX tarball generation or download is documented.
Stick a comment above the Source line describing how you generated it. Example
from virt-manager looks like:
# Generate source with
# git clone git://git.fedorahosted.org/git/virt-manager.git
# cd virt-manager
# git archive --output virt-manager-%{gitcommit}.tar.gz --prefix
virt-manager-%{gitcommit}/ %{gitcommit}
[!]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Note: Arch-ed rpms have a total of 10895360 bytes in /usr/share 10895360
edk2-tools-20130502.g732d199-1.x86_64.rpm
Since this is all python bits I guess edk2-tools should be noarch.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=lMPDBXu4HL&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 750394] Review Request: dmtcp - Checkpoint/Restart functionality for Linux processes
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=750394 --- Comment #41 from Orion Poplawski --- Ping? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zat5KXPq50&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 924263] Review Request: caja-dropbox - Dropbox extension for caja
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924263 --- Comment #4 from Wolfgang Ulbrich --- (In reply to comment #3) > This package contains CC-BY-ND artwork. From the COPYING file in upstream's > tarball: > > "All images included in this package constitute data and are licensed under > the > Creative Commons Attribution-No Derivative Works 3.0 Unported License [1]." > > So you'll want to alter the License field to include this. Thanks for your hint, i will include the CC-BY-ND license > > Also, it appears that the "dropbox.in" script inside the tarball has the > capability to download the proprietary daemon and install it? I'm not sure > this can go into Fedora if that's the case. > > - Ken You're right, this script download and install the main dropbox software which connect the user system with the dropbox cloud. Do you know where I can clarify this point in fedora's infrastructure? Is Tom 'spot' Callaway the right contact for this? Wolfgang -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=H3O0FdwecE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 928196] Review Request: php-pecl-apcu - APC User Cache
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=928196
ben.har...@rackspace.com changed:
What|Removed |Added
CC||ben.har...@rackspace.com
--- Comment #3 from ben.har...@rackspace.com ---
While I am not a package maintainer or reviewer, but I would like help get the
ball rolling.
[ O K ] MUST: rpmlint must be run on every package. The output should be posted
in the review.
$ rpmlint
$ rpmlint php-pecl-apcu.spec php-pecl-apcu-4.0.1-1.remi.src.rpm
apcu-panel-4.0.1-1.fc20.noarch.rpm
php-pecl-apcu.src: W: spelling-error %description -l en_US userland -> user
land, user-land, slanderous
php-pecl-apcu.src: W: spelling-error %description -l en_US opcode -> op code,
op-code, code
php-pecl-apcu.src: W: spelling-error %description -l en_US codebase -> co
debase, co-debase, code base
php-pecl-apcu.src: W: spelling-error %description -l en_US optimizations ->
optimization, optimization's, optimization s
php-pecl-apcu.src: E: unknown-key GPG#00f97f56
apcu-panel.noarch: W: no-documentation
apcu-panel.noarch: E: non-standard-dir-perm /etc/apcu-panel 0750L
2 packages and 1 specfiles checked; 2 errors, 5 warnings.
The non-standard directory appears to required, from the spec file:
%files -n apcu-panel
%defattr(-,root,root,-)
# Need to restrict access, as it contains a clear password
%attr(750,apache,root) %dir %{_sysconfdir}/apcu-panel
I believe the unknown signing key is not important for package review.
[ O K ] MUST: The package must be named according to the Package Naming
Guidelines.
[ O K ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[ O K ] MUST: The package must meet the Packaging Guidelines.
[ O K ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.
[ O K ] MUST: The License field in the package spec file must match the actual
license.
[ O K ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[ O K ] MUST: The spec file must be written in American English.
[ O K ] MUST: The spec file for the package MUST be legible.
[ N/A ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
$ md5sum SOURCES/apcu-4.0.1.tgz ; curl -s -o -
http://pecl.php.net/get/apcu-4.0.1.tgz |md5sum -
994de4335eb2967c006aa9ca185876fa SOURCES/apcu-4.0.1.tgz
994de4335eb2967c006aa9ca185876fa -
[ O K ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[ N/A ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[ O K ] MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[ N/A ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[ N/A ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[ O K ] MUST: Packages must NOT bundle copies of system libraries.
[ N/A ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[ O K ] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory.
[ O K ] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[ O K ] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.
[ O K ] MUST: Each package must consistentl
[Bug 924263] Review Request: caja-dropbox - Dropbox extension for caja
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=924263 --- Comment #3 from Ken Dreyer --- This package contains CC-BY-ND artwork. From the COPYING file in upstream's tarball: "All images included in this package constitute data and are licensed under the Creative Commons Attribution-No Derivative Works 3.0 Unported License [1]." So you'll want to alter the License field to include this. Also, it appears that the "dropbox.in" script inside the tarball has the capability to download the proprietary daemon and install it? I'm not sure this can go into Fedora if that's the case. - Ken -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0FtVR4iec6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822730] Review Request: laptop-mode-tools - Tools for power savings based on battery/AC status
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822730 Claudio changed: What|Removed |Added CC||claudiozu...@gmail.com --- Comment #21 from Claudio --- I've actully tried to fix a few things that had been mentioned in the older posts, let me know. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hhX9h0uUu6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822730] Review Request: laptop-mode-tools - Tools for power savings based on battery/AC status
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822730 --- Comment #20 from Claudio --- Created attachment 747878 --> https://bugzilla.redhat.com/attachment.cgi?id=747878&action=edit 1.63 spec file Spec file updated for 1.63 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oJ2qjHye02&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915006] Review Request: qt5-qtwebkit - Qt5 - QtWebKit components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915006 --- Comment #16 from Rex Dieter --- And, grr, ANGLE actually is used, reading further down on it's project page, makes it clearer why: Portions of the ANGLE shader compiler are used as a shader validator and translator by WebGL implementations across multiple platforms. It is used on Mac OS X, Linux, and in mobile variants of the browsers. Having one shader validator helps to ensure that a consistent set of GLSL ES shaders are accepted across browsers and platforms. The shader translator can be used to translate shaders to other shading languages, and to optionally apply shader modifications to work around bugs or quirks in the native graphics drivers. The translator targets Desktop GLSL, Direct3D HLSL, and even ESSL for native GLES2 platforms. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bJMKVmM12O&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915006] Review Request: qt5-qtwebkit - Qt5 - QtWebKit components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915006 --- Comment #15 from Rex Dieter --- mt19937ar.c copylib request: https://fedorahosted.org/fpc/ticket/291 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UI8mke59LP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 Michael Schwendt changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mschwe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HJ8hq62Zb9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960200] Review Request: libyui-qt - Qt User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960200 Michael Schwendt changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mschwe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VrGUUF5HnT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836708] Review Request: sugar-locosugar - a game for discovering how to use the mouse and keyboard
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836708 Kalpa Welivitigoda changed: What|Removed |Added Flags|needinfo?(callkalpa@gmail.c | |om) | --- Comment #12 from Kalpa Welivitigoda --- Hi Dan, yes I'm interested. I get the following error. $ clear; fedpkg clone sugar-locosugar Cloning into 'sugar-locosugar'... R access for sugar-locosugar DENIED to callkalpa (Or there may be no repository at the given path. Did you spell it correctly?) fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Could not execute clone: Command '['git', 'clone', 'ssh://callka...@pkgs.fedoraproject.org/sugar-locosugar']' returned non-zero exit status 128 I'll look into this and try to get this fixed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Nc13eJP7Oy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915006] Review Request: qt5-qtwebkit - Qt5 - QtWebKit components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915006 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #14 from Rex Dieter --- and, pretty sure we don't need angle. per https://code.google.com/p/angleproject/ The goal of ANGLE is to allow Windows users to seamlessly run WebGL and other OpenGL ES 2.0 content by translating OpenGL ES 2.0 API calls to DirectX 9 API calls. Looks like we're left with just Source/Thirdparty/mt19937ar.c and per http://www.math.sci.hiroshima-u.ac.jp/~m-mat/MT/emt.html is fairly clear to be a copylib. I'll poke fpc about it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TcuZUGXfp3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 Orion Poplawski changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-05-14 14:37:55 --- Comment #11 from Orion Poplawski --- Checked in and built. Thanks all. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L59SVn55wM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915006] Review Request: qt5-qtwebkit - Qt5 - QtWebKit components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915006 --- Comment #13 from Rex Dieter --- As far as licensing is concerned, upstream intentions here is clear: http://qt-project.org/doc/qt-5.0/qtdoc/licensing.html -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hpkQnjeXd3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962813] Review Request: funguloids - Space-Flying-Mushroom-Picking-Simulator game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=962813 Wolfgang Ulbrich changed: What|Removed |Added CC||chat-to...@raveit.de Assignee|nob...@fedoraproject.org|chat-to...@raveit.de Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NLem8472cE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JrLuJL9Baq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zuHMr3Eud8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915006] Review Request: qt5-qtwebkit - Qt5 - QtWebKit components
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915006 --- Comment #12 from Rex Dieter --- Of those, it would appear that only ThirdParty/ANGLE is actively used during the build. Taking a closer look now. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=w9Uwp0LXfg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 Orion Poplawski changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Orion Poplawski --- Thanks. New Package SCM Request === Package Name: python-envisage Short Description: Extensible application framework Owners: orion Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=99dxL9Ufkp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 Rahul Sundaram changed: What|Removed |Added Flags||fedora-review+ --- Comment #8 from Rahul Sundaram --- Depending on whether you need a older EPEL branch, you don't need to define that macro on top but I assume you already know that. I don't see any outstanding blockers. == APPROVED == -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9BEHEjXHhb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810336] Review Request: ga - Global Arrays Toolkit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=810336 --- Comment #26 from Fedora Update System --- ga-5.1.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ga-5.1.1-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VI6qdzwIKC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810336] Review Request: ga - Global Arrays Toolkit
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=810336 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5uqurVJ82O&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915909] Review Request: qt5-qtdeclarative - Qt5 - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915909 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HlytrDUV0P&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915909] Review Request: qt5-qtdeclarative - Qt5 - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915909 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PnUB0csmw1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915909] Review Request: qt5-qtdeclarative - Qt5 - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915909 --- Comment #9 from Rex Dieter --- fyi, before issuing any official builds, need to fix another conflict (with qt-creator this time): file /usr/bin/qmlprofiler from install of qt5-qtdeclarative-devel-5.0.2-2.fc17.x86_64 conflicts with file from package qt-creator-2.4.1-2.fc17.x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ln16fmGrlG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 --- Comment #7 from Orion Poplawski --- * Tue May 14 2013 Orion Poplawski - 4.3.0-3 - Remove shipped egg-info and eggs http://www.cora.nwra.com/~orion/fedora/python-envisage-4.3.0-3.fc18.src.rpm I'll send a message about adding license headers. I've not had much success with python 3 on a lot of these packages. Need to start from the bottom. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kRTYWtUTvs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915909] Review Request: qt5-qtdeclarative - Qt5 - QtDeclarative component
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915909 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #8 from Rex Dieter --- yay, thanks! New Package SCM Request === Package Name: qt5-qtdeclarative Short Description: Qt5 - QtDeclarative components Owners: than rdieter jreznik kkofler ltinkl rnovacek Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=izSan1ejYd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927877] Review Request: naga - Simplified Java NIO asynchronous sockets
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927877 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- jmol-13.0.15-1.fc19, jspecview-2-4.1169svn.fc19, naga-3.0-1.82svn.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0WYEeY7VMY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927879] Review Request: jspecview - JAVA applets for the display of JCAMP-DX and AnIML/CML spectral files
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=927879 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- jmol-13.0.15-1.fc19, jspecview-2-4.1169svn.fc19, naga-3.0-1.82svn.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JquQIctC6R&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916431] Review Request: python-tw2-jqplugins-jqplot - Toscawidgets2 wrapper for the jqPlot jQuery plugin
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916431 --- Comment #10 from Fedora Update System --- python-tw2-jqplugins-jqplot-2.0.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mgi4KB4RbQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952343] Review Request: python-svg-path - SVG path objects and parser
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=952343 --- Comment #13 from Fedora Update System --- python-svg-path-1.0b1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PjMU7NNrdB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916436] Review Request: python-narcissus-app - WSGI components for Narcissus, realtime log visualization
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916436 --- Comment #6 from Fedora Update System --- python-tw2-slideymenu-2.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wg8vtyMkCr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865787] Review Request: xmlstreambuffer - XML Stream Buffer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=865787 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- xmlstreambuffer-1.5.1-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jnPRXYTnB5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916426] Review Request: python-narcissus-common - Common components for Narcissus, realtime log visualization
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916426 --- Comment #11 from Fedora Update System --- python-narcissus-common-0.9.0.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yY4r6d2S12&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915427] Review Request: python-zc-customdoctests - Use doctest with other languages
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=915427 --- Comment #12 from Fedora Update System --- python-zc-customdoctests-1.0.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MYEvbzupNM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 947640] Review Request: snappy - An open-source Gnome media player
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=947640 Antonio Trande changed: What|Removed |Added Alias||snappy-player --- Comment #8 from Antonio Trande --- Waiting for Autotool files inclusion from upstream (https://bugzilla.gnome.org/show_bug.cgi?id=697640) ... Spec URL: http://sagitter.fedorapeople.org/snappy/snappy-player.spec SRPM URL: http://sagitter.fedorapeople.org/snappy/snappy-player-0.3.7-1.fc18.src.rpm - Update to 0.3.7 - Package renamed as 'snappy-player' to avoid conflict with 'snappy' library according to upstream (https://bugzilla.gnome.org/show_bug.cgi?id=697122) - Definited 'realname' macro - Added missing Autotools files in source archive - Removed Explicit Requires - Set the environment variables CLUTTER_GST_CFLAGS/CLUTTER_GST_LIBS - Defined binary name conflict Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5380202 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Xk4vbIjaxH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 915909] Review Request: qt5-qtdeclarative - Qt5 - QtDeclarative component
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915909
Gregor Tätzner changed:
What|Removed |Added
Flags|needinfo?(gre...@freenet.de |
|) |
Flags||fedora-review+
--- Comment #7 from Gregor Tätzner ---
(In reply to comment #4)
> Some comments before posting new spec:
>
> - I don't see anything packaged that actually uses FDL. If you do, can you
> please clarify where it is?
Nay, we don't include any *.qdoc files. Maybe you wanna add a comment so you
won't forget.
(In reply to comment #6)
> ping, any remaining review blockers or fixes you'd like to see?
no further objections from my side...gonna approve this component.
diff -r -Nup qt5-qtdeclarative-5.0.2-1.fc18.src/qt5-qtdeclarative.spec
qt5-qtdeclarative-5.0.2-2.fc18.src/qt5-qtdeclarative.spec
--- qt5-qtdeclarative-5.0.2-1.fc18.src/qt5-qtdeclarative.spec 2013-04-11
18:28:16.0 +0200
+++ qt5-qtdeclarative-5.0.2-2.fc18.src/qt5-qtdeclarative.spec 2013-05-09
16:10:21.0 +0200
@@ -4,9 +4,9 @@
Summary: Qt5 - QtDeclarative component
Name:qt5-%{qt_module}
Version: 5.0.2
-Release: 1%{?dist}
+Release: 2%{?dist}
-# See LGPL_EXCEPTIONS.txt, LICENSE.GPL3, respectively, for exception details
+# See LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt, for details
License: LGPLv2 with exceptions or GPLv3 with exceptions
Url: http://qt-project.org/
Source0:
http://releases.qt-project.org/qt5/%{version}%{?pre:-%{pre}}/submodules/%{qt_module}-opensource-src-%{version}.tar.xz
@@ -38,7 +38,6 @@ Requires: %{name}-devel%{?_isa} = %{vers
%build
-
%{_qt5_qmake}
make %{?_smp_mflags}
@@ -53,7 +52,7 @@ mkdir %{buildroot}%{_bindir}
pushd %{buildroot}%{_qt5_bindir}
for i in * ; do
case "${i}" in
-foobar)
+qmlplugindump)
mv $i ../../../bin/${i}-qt5
ln -s ../../../bin/${i}-qt5 .
ln -s ../../../bin/${i}-qt5 $i
@@ -83,17 +82,19 @@ popd
%postun -p /sbin/ldconfig
%files
+%doc LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt
+%doc dist/changes*
%{_qt5_libdir}/libQt5Qml.so.5*
%{_qt5_libdir}/libQt5Quick.so.5*
%{_qt5_libdir}/libQt5QuickParticles.so.5*
%{_qt5_libdir}/libQt5QuickTest.so.5*
-%{_qt5_bindir}/qml*
-%{_bindir}/qml*
%{_qt5_plugindir}/accessible/libqtaccessiblequick.so
%{_qt5_plugindir}/qmltooling/
%{_qt5_archdatadir}/qml/
%files devel
+%{_bindir}/qml*
+%{_qt5_bindir}/qml*
%{_qt5_headerdir}/Qt*/
%{_qt5_libdir}/libQt5Qml.so
%{_qt5_libdir}/libQt5Qml.prl
@@ -109,6 +110,10 @@ popd
%changelog
+* Fri Apr 12 2013 Rex Dieter 5.0.2-2
+- fix conflicts with qt4-devel
+- include license files, dist/changes*
+
* Thu Apr 11 2013 Rex Dieter 5.0.2-1
- 5.0.2
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=aVLskFkR0g&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
