[Bug 1277407] Review Request: php-latte - Latte: the amazing template engine for PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277407



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/php-latte

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262644] Review Request: python-Pyped - Replace sed/grep/cut/awk by letting you execute Python one-liners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262644



--- Comment #6 from Upstream Release Monitoring 
 ---
uggla's scratch build of python-Pyped-1.4-2.fc22.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11756733

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277379] Review Request: php-nette-tokenizer - Nette Tokenizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277379



--- Comment #6 from Fedora Update System  ---
php-nette-tokenizer-2.2.1-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-958646e79a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277379] Review Request: php-nette-tokenizer - Nette Tokenizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277379



--- Comment #7 from Fedora Update System  ---
php-nette-tokenizer-2.2.1-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-6fb66ce85b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277379] Review Request: php-nette-tokenizer - Nette Tokenizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277379



--- Comment #7 from Fedora Update System  ---
php-nette-tokenizer-2.2.1-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-6fb66ce85b

--- Comment #8 from Fedora Update System  ---
php-nette-tokenizer-2.2.1-1.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-5ad793fe45

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276081] Review Request: texlive-extension - TeX formatting system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276081



--- Comment #7 from Karsten Hopp  ---
rpmlint looks ok now.

The only issue remaining is the last one from comment #5:
Please note that it is impossible to install these texlive-extension packages
on CentOS or in an epel-7 mock chroot as Centos hasn't updated
texlive-kpathsea-lib:

Error: Package: texlive-cyrillic-bin-bin-svn27329.0-1.el7.centos.noarch
(/texlive-cyrillic-bin-bin-svn27329.0-1.el7.centos.noarch)
   Requires: texlive-kpathsea-lib >=
2:2012-38.20130427_r30134.el7.centos
   Available: 2:texlive-kpathsea-lib-2012-32.20130427_r30134.el7.i686
(base)
   texlive-kpathsea-lib = 2:2012-32.20130427_r30134.el7

Manually installing texlive-kpathsea-lib.x86_64 into the mock chroot resulted
in a different error that shows the real issue:
Error: Package: texlive-cyrillic-bin-bin-svn27329.0-1.el7.centos.noarch
(/texlive-cyrillic-bin-bin-svn27329.0-1.el7.centos.noarch)
   Requires: texlive-kpathsea-lib >=
2:2012-32.20130427_r30134.el7.centos
   Installed: 2:texlive-kpathsea-lib-2012-32.20130427_r30134.el7.x86_64
(@base)
   texlive-kpathsea-lib = 2:2012-32.20130427_r30134.el7

in the mock chroot:
# rpm --eval %dist
.el7.centos

So there's a mismatch between the provides of official EPEL packages and the
requirements in mock builds if the packages use %dist in the
Provides:/Requires: fields.

I think we need to waive this issue although it is quite unfortunate. The
package review guidelines only require  that the package builds in mock, not
that it is installable ;-(


comment #2 is now valid for all other subpackages. The 5 mentioned are fixed
now and use the release tag. All others have Release 1%{dist} hardcoded

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #20 from Christian Dersch  ---
Yes, running mock with yum instead of dnf solves the FTBS. Other possibilty
would be teh usage of provided koji builds.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278803] Review Request: godep - Dependency tool for go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278803



--- Comment #4 from Fedora Update System  ---
godep-27-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-6b01d32ceb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278803] Review Request: godep - Dependency tool for go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278803

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #4 from Fedora Update System  ---
godep-27-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-6b01d32ceb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277377] Review Request: php-nette-utils - Nette Utility Classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277377



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/php-nette-utils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310

M. Scherer  changed:

   What|Removed |Added

 CC||msche...@redhat.com
  Flags||needinfo?(sergio.pasra@gmai
   ||l.com)



--- Comment #28 from M. Scherer  ---
Sergio, anything missing ? This is blocking new version of salt, afaik.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1268360] Review Request: rubygem-simple_oauth - Simply builds and verifies OAuth headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268360



--- Comment #1 from Upstream Release Monitoring 
 ---
pvalena's scratch build of rubygem-simple_oauth-0.3.1-1.fc24.src.rpm for
f24-candidate completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11755585

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1156086] Review Request: openmx - Open source package for Material eXplorer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1156086



--- Comment #12 from gil cattaneo  ---
Other issues:
[!]: Package contains no static executables.
 openmx3.7/source/liberi-091216/source/sbt/linear/eri_linfsbt_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/sbt/log/eri_fsbt_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/sbt/log/eri_logfsbt_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/sbt/eri_sbt_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/eri_gtbl_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/eri_interpolate_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/eri_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/eri_ll_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/source/eri_sf_ipa6_openmx.oo
 openmx3.7/source/liberi-091216/test/test/test_pp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262644] Review Request: python-Pyped - Replace sed/grep/cut/awk by letting you execute Python one-liners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262644



--- Comment #5 from René Ribaud  ---
Hello Julien,

>- I guess you intended to use the %sum variable
I used it now.
>- Python3 by default https://fedoraproject.org 
>wiki/Packaging:Python#Avoiding_collisions_between_the_python_2_and_python_3_stacks
Fixed as porposed in the doco. Please tell me if it is fine from your point of
view.
>- Not sure if your patch is useful
Yep otherwise I get an error at build step.
>- To get rid of the E: non-executable-script /usr/lib/python3.4/site-packages 
>pyped.py 644 /usr/bin/env you should remove the shebang from pyped.py. The 
>typical way to do this is to call sed -i '1{\@^#!/usr/bin/env python@d}' 
>%{buildroot}%{python3_sitearch}/pyped.py in %install (the same for python 2). 
>I will wait for this to be fixed before approving the package.
I have just made the required file executable as it should be run by the user.

New packages location :
Spec URL: http://uggla.free.fr/rpmbuild/SPECS/python-Pyped.spec
SRPM URL: http://uggla.free.fr/rpmbuild/SRPMS/python-Pyped-1.4-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1275386] Review Request: openscap-daemon - manages continuous SCAP scans of your infrastructure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1275386



--- Comment #1 from Šimon Lukašík  ---
1) The package should require dbus package as it uses /etc/dbus-1/system.d/
directory.

This is not a blocker, as you already require python-dbus. But still consider
fixing this.

2) First paragraph of description is not really a project description.

However, this is not a blocker.

3) The whole thing is python2.

There is no problem with that, per se. We can accept Python2 packages to
Fedora. So the packaging is alright.

However, atomic in F23+ is build/installed using python3 and you require some
of the atomic parts.
That could will not work on F23, so you need to patch the specfile for f23 and
rawhide.

Please review the specfile of atomic, and consider using same if/else
statements for deciding target python version.

2) rpmlint issues:
> openscap-daemon.noarch: W: invalid-license LGPLv2.1+

Please fix this. The document at
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing advices to use
LGPLv2+ in your case.

Also there are files in `cve_scanner` sub-dir which are LGPLv2+. Note that FSF
address is incorrect in them (not a blocker).

> openscap-daemon.noarch: W: non-conffile-in-etc 
> /etc/dbus-1/system.d/org.oscapd.conf

Use %config(noreplace) %{_sysconfdir}/dbus-1/system.d/ ...

> openscap-daemon.noarch: W: no-manual-page-for-binary oscapd
> openscap-daemon.noarch: W: no-manual-page-for-binary oscapd-cli

This is not a blocker for me. However, perhaps you can file an upstream ticket
for this.

> openscap-daemon.src: W: invalid-url Source0: 
> https://github.com/OpenSCAP/openscap-daemon/releases/download/0.1.0/openscap_daemon-0.1.0.tar.gz
>  HTTP Error 403: Forbidden

Please use valid URL.

---
This is all I have found during the first round. Overall good job!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267189] Review Request: antimony - Computer-aided design CAD tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267189



--- Comment #2 from Antonio Trande  ---
New release:

Spec URL: https://sagitter.fedorapeople.org/antimony/antimony.spec
SRPM URL:
https://sagitter.fedorapeople.org/antimony/antimony-0.9.0-0.2.20151031git5c144c.fc23.src.rpm

- Update to commit #c144cc
- Hardened build on Fedora 22
- Added an appdata file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277379] Review Request: php-nette-tokenizer - Nette Tokenizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277379



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/php-nette-tokenizer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #21 from Christian Dersch  ---
Following line should do it:

mock --clean --init --yum -r fedora-rawhide-x86_64 && fedora-review -v -m
fedora-rawhide-x86_64 -o "--yum " -b 1244797

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270394] Review Request: sharpziplib - Zip, GZip, Tar and BZip2 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270394



--- Comment #16 from Raphael Groner  ---
Spec URL: https://raphgro.fedorapeople.org/review/openra/sharpziplib.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/openra/sharpziplib-0.86.0-0.2.fc23.src.rpm

* Mon Nov 09 2015 Raphael Groner <> - 0.86.0-0.2
- improve License tag
- fix directory ownership

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1266087] Review Request: crossguid - Lightweight cross platform C++ GUID/UUID library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1266087



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/crossguid

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277379] Review Request: php-nette-tokenizer - Nette Tokenizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277379

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #6 from Fedora Update System  ---
php-nette-tokenizer-2.2.1-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-958646e79a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1272652] Review Request: tktable - Table/matrix widget extension to Tcl/Tk

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272652



--- Comment #18 from Fedora Update System  ---
tktable-2.10-7.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1268266] Review Request: python-jinja2-cli - CLI interface to Jinja2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268266



--- Comment #7 from Fedora Update System  ---
python-jinja2-cli-0.5.0-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1272652] Review Request: tktable - Table/matrix widget extension to Tcl/Tk

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272652

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-11-09 16:53:40



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262645] Review Request: python-tortilla - A tiny library for creating wrappers around web APIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262645

Julien Enselme  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Julien Enselme  ---
I think you should add a line break between each changelog entry to make it
more readable.

Apart from that, it looks good. Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274690] Review Request: nordugrid-arc-gangliarc - Ganglia monitoring for ARC services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274690

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-11-09 16:52:56



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277970] Review Request: R-testthat - Unit Testing for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277970

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from gil cattaneo  ---
NON blocking issues:

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 131 files have unknown license.
 Detailed output of licensecheck in
 /home/gil/1277970-R-testthat/licensecheck.txt

  Please, report to upstream and ask to add license headers in those files
where is missing
 
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

[!]: License file installed when any subpackage combination is installed.

 Please, report to upstream and ask to add license file

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text


[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.

[!]: Package does not include license text files separate from upstream.

[!]: Spec use %global instead of %define unless justified.
 Note: %define requiring justification: %define packname testthat

Please, fix before import
approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277376] Review Request: php-nette-neon - Nette NEON: parser and generator for Nette Object Notation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277376



--- Comment #6 from Fedora Update System  ---
php-nette-neon-2.3.3-1.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-4588228af8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277376] Review Request: php-nette-neon - Nette NEON: parser and generator for Nette Object Notation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277376



--- Comment #6 from Fedora Update System  ---
php-nette-neon-2.3.3-1.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-4588228af8

--- Comment #7 from Fedora Update System  ---
php-nette-neon-2.3.3-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-97289108ce

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277376] Review Request: php-nette-neon - Nette NEON: parser and generator for Nette Object Notation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277376

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #5 from Fedora Update System  ---
php-nette-neon-2.3.3-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-e603bea5b9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277376] Review Request: php-nette-neon - Nette NEON: parser and generator for Nette Object Notation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277376



--- Comment #5 from Fedora Update System  ---
php-nette-neon-2.3.3-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-e603bea5b9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277478] Review Request: php-nette-deprecated - APIs and features removed from Nette Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277478
Bug 1277478 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277395] Review Request: php-nette-component-model - Nette Component Model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277395
Bug 1277395 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1273601] Review Request: python-qutepart - Code editor widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1273601



--- Comment #14 from Fedora Update System  ---
python-qutepart-2.2.2-3.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-qutepart'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-85b822e636

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277397] Review Request: php-nette-di - Nette Dependency Injection Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277397
Bug 1277397 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277415] Review Request: php-nette-http - Nette HTTP Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277415
Bug 1277415 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277388] Review Request: php-nette-php-generator - Nette PHP Generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277388
Bug 1277388 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277409] Review Request: php-nette-caching - Nette Caching Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277409
Bug 1277409 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277484] Review Request: php-nette - Nette Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277484
Bug 1277484 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277470] Review Request: php-nette-application - Nette Application MVC Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277470
Bug 1277470 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277437] Review Request: php-nette-robot-loader - Nette RobotLoader: comfortable autoloading

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277437
Bug 1277437 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277434] Review Request: php-nette-mail - Nette Mail: Sending E-mails

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277434
Bug 1277434 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277377] Review Request: php-nette-utils - Nette Utility Classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277377

Remi Collet  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed|2015-11-09 13:02:52 |2015-11-10 01:07:33



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277493] Review Request: php-kdyby-events - Events for Nette Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277493
Bug 1277493 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277413] Review Request: php-nette-reflection - Nette PHP Reflection Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277413
Bug 1277413 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277476] Review Request: php-nette-bootstrap - Nette Bootstrap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277476
Bug 1277476 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277418] Review Request: php-nette-security - Nette Security: Access Control Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277418
Bug 1277418 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277384] Review Request: php-nette-finder - Nette Finder: Files Searching

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277384
Bug 1277384 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277395] Review Request: php-nette-component-model - Nette Component Model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277395
Bug 1277395 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277465] Review Request: php-nette-forms - Nette Forms: greatly facilitates web forms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277465
Bug 1277465 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277474] Review Request: php-nette-database - Nette Database Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277474
Bug 1277474 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277478] Review Request: php-nette-deprecated - APIs and features removed from Nette Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277478
Bug 1277478 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277970] Review Request: R-testthat - Unit Testing for R

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277970

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #2 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Package have the default element marked as %%doc :DESCRIPTION, CITATION
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 131 files have unknown license.
 Detailed output of licensecheck in
 /home/gil/1277970-R-testthat/licensecheck.txt

  Please, report to upstream and ask to add license headers in those files
where is missing
 
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

[!]: License file installed when any subpackage combination is installed.

 Please, report to upstream and ask to add license file

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under 

[Bug 1277966] Review Request: R-crayon - Colored Terminal Output

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277966

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #2 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Package have the default element marked as %%doc :DESCRIPTION
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 50 files have unknown license. Detailed
 output of licensecheck in /home/gil/1277966-R-crayon/licensecheck.txt

  Please, report to upstream and ask to add license headers in those files
where is missing
 
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.
[x]: Package requires R-core.

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: 

[Bug 1277966] Review Request: R-crayon - Colored Terminal Output

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277966

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from gil cattaneo  ---
NON blocking issues:

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 50 files have unknown license. Detailed
 output of licensecheck in /home/gil/1277966-R-crayon/licensecheck.txt

  Please, report to upstream and ask to add license headers in those files
where is missing
 
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.

[!]: Package does not include license text files separate from upstream.

[!]: Spec use %global instead of %define unless justified.
 Note: %define requiring justification: %define packname crayon

Please, fix before import
approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279677] New: Review Request: Git Large File Storage - Allows for large file versioning in Github.com

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279677

Bug ID: 1279677
   Summary: Review Request: Git Large File Storage  - Allows for
large file versioning in Github.com
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: email...@jimgallaher.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://git-lfs.github.com/
SRPM URL: https://packagecloud.io/github/git-lfs/install
Description:

Git Large File Storage (LFS) replaces large files such as audio samples,
videos, datasets, and graphics with text pointers inside Git, while storing the
file contents on a remote server like GitHub.com or GitHub Enterprise.

There is an RPM file available for installing on Fedora.

Fedora Account System Username: email...@jimgallaher.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279223] Review Request: python-h5io - Read and write simple Python objects using HDF5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279223

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
python-h5io-0.1-0.2.gita73bba4.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-h5io'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-41d77a0433

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279225] Review Request: python-jdcal - Julian dates from proleptic Gregorian and Julian calendars

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279225

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
python-jdcal-1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-jdcal'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-83313fb26c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1273601] Review Request: python-qutepart - Code editor widget

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1273601



--- Comment #15 from Fedora Update System  ---
python-qutepart-2.2.2-3.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-qutepart'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-175d04c097

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276837] Review Request: python-pydicom - Read, modify and write DICOM files with python code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276837

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
python-pydicom-1.0.0-0.3.gitf6191c7.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-pydicom'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-2803c1bf3b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #22 from Dave Johansen  ---
(In reply to Antonio Trande from comment #21)
> (In reply to Dave Johansen from comment #20)
> > (In reply to Antonio Trande from comment #19)
> > > - You can use 'nose' for an explicit output of tests.
> > I'm unfamiliar with 'nose'. Where would the change in the spec file be made
> > and what would it be?
> 
> hgsubversion's upstream maintainer uses python-nose for his tests:
> https://pypi.python.org/pypi/nose/1.3.7
> 
> - Edit:
> 
> %check
> nosetests -v
Fixed.

> - Please, define what this package provides with:
> 
> %{?python_provide:%python_provide python2-%{name}}

Since this is a mercurial extension, I'm not sure how useful it is as a
standalone Python package, but I guess it doesn't hurt to add this and so I
did.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277388] Review Request: php-nette-php-generator - Nette PHP Generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277388
Bug 1277388 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277441] Review Request: php-nette-safe-stream - Nette SafeStream: Atomic Operations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277441

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
php-nette-safe-stream-2.3.1-2.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update php-nette-safe-stream'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-674a68bec7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277377] Review Request: php-nette-utils - Nette Utility Classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277377

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #9 from Fedora Update System  ---
php-nette-utils-2.3.6-1.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update php-nette-utils'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-d1520530d8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277476] Review Request: php-nette-bootstrap - Nette Bootstrap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277476
Bug 1277476 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277493] Review Request: php-kdyby-events - Events for Nette Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277493
Bug 1277493 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277409] Review Request: php-nette-caching - Nette Caching Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277409
Bug 1277409 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277465] Review Request: php-nette-forms - Nette Forms: greatly facilitates web forms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277465
Bug 1277465 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277418] Review Request: php-nette-security - Nette Security: Access Control Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277418
Bug 1277418 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277484] Review Request: php-nette - Nette Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277484
Bug 1277484 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277413] Review Request: php-nette-reflection - Nette PHP Reflection Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277413
Bug 1277413 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277441] Review Request: php-nette-safe-stream - Nette SafeStream: Atomic Operations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277441



--- Comment #8 from Fedora Update System  ---
php-nette-safe-stream-2.3.1-2.fc22 has been submitted as an update to Fedora
22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-674a68bec7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277441] Review Request: php-nette-safe-stream - Nette SafeStream: Atomic Operations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277441



--- Comment #7 from Fedora Update System  ---
php-nette-safe-stream-2.3.1-2.el6 has been submitted as an update to Fedora
EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-965b7a0aee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277441] Review Request: php-nette-safe-stream - Nette SafeStream: Atomic Operations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277441

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #7 from Fedora Update System  ---
php-nette-safe-stream-2.3.1-2.el6 has been submitted as an update to Fedora
EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-965b7a0aee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #25 from Christian Dersch  ---
Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec
SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.6-0.5.fc22.src.rpm

Koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11758115

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277395] Review Request: php-nette-component-model - Nette Component Model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277395
Bug 1277395 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277434] Review Request: php-nette-mail - Nette Mail: Sending E-mails

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277434
Bug 1277434 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277413] Review Request: php-nette-reflection - Nette PHP Reflection Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277413
Bug 1277413 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277409] Review Request: php-nette-caching - Nette Caching Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277409
Bug 1277409 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277470] Review Request: php-nette-application - Nette Application MVC Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277470
Bug 1277470 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277376] Review Request: php-nette-neon - Nette NEON: parser and generator for Nette Object Notation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277376



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/php-nette-neon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255857] Review Request: apache-htrace - Tracing framework for java based distributed systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255857



--- Comment #3 from Upstream Release Monitoring 
 ---
gil's scratch build of apache-htrace-4.0.0-1.fc23.src.rpm for rawhide failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11757023

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255857] Review Request: apache-htrace - Tracing framework for java based distributed systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255857



--- Comment #4 from Upstream Release Monitoring 
 ---
gil's scratch build of apache-htrace-4.0.0-1.fc23.src.rpm for rawhide failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11757310

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1268360] Review Request: rubygem-simple_oauth - Simply builds and verifies OAuth headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268360

Pavel Valena  changed:

   What|Removed |Added

 CC||pval...@redhat.com



--- Comment #2 from Pavel Valena  ---
Informal Package Review
===

No issues found. I would approve this package.


Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.


Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -r -n
rubygem-simple_oauth-0.3.1-1.fc24.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Ruby, Shell-api
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1268716] Review Request: cjdns - IP6 VPN with crypto address allocation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268716



--- Comment #13 from Stuart D Gathman  ---
Whatever the decision of Fedora, I will add a flag to the SPEC file so that
uses can easily get the embedded nacl (or not) when desired.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276081] Review Request: texlive-extension - TeX formatting system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276081



--- Comment #13 from Ngo Than  ---
Jon, thanks for you info, i already sent request

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278487] Review Request: nodejs-path-to-regexp - Express style path to RegExp utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278487



--- Comment #5 from Jared Smith  ---
Updated.

Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-path-to-regexp/nodejs-path-to-regexp.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-array-flatten/nodejs-array-flatten-1.1.1-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #23 from Raphael Groner  ---
Created attachment 1091874
  --> https://bugzilla.redhat.com/attachment.cgi?id=1091874=edit
licensecheck.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #32 from Igor Gnatenko  ---
(In reply to Jonathan Underwood from comment #31)
> Igor: I see you've pushedd a build to rawhide. Please can you psuh for F23
> as well. And please do close this bug.

not possible right now, bodhi don't allow me to push other stack (pytools,
etc.) just because bugs in bodhi. I will do it ASAP

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278152] Review Request: nodejs-base64-url - Base64 utilities for url applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278152

Tom Hughes  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Tom Hughes  ---
The comment about 1.2.1 not being tagged yet can be removed, but other than
that it looks fine now, so package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277437] Review Request: php-nette-robot-loader - Nette RobotLoader: comfortable autoloading

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277437
Bug 1277437 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277384] Review Request: php-nette-finder - Nette Finder: Files Searching

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277384
Bug 1277384 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277474] Review Request: php-nette-database - Nette Database Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277474
Bug 1277474 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277493] Review Request: php-kdyby-events - Events for Nette Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277493
Bug 1277493 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277476] Review Request: php-nette-bootstrap - Nette Bootstrap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277476
Bug 1277476 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277388] Review Request: php-nette-php-generator - Nette PHP Generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277388
Bug 1277388 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277478] Review Request: php-nette-deprecated - APIs and features removed from Nette Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277478
Bug 1277478 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #28 from Christian Dersch  ---
Thank you again :) Well this depends on use case, maybe a user just wants to
run the provides examples as binaries.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277484] Review Request: php-nette - Nette Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277484
Bug 1277484 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277397] Review Request: php-nette-di - Nette Dependency Injection Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277397
Bug 1277397 depends on bug 1277377, which changed state.

Bug 1277377 Summary: Review Request: php-nette-utils - Nette Utility Classes
https://bugzilla.redhat.com/show_bug.cgi?id=1277377

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review