[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362490



--- Comment #13 from Remi Collet  ---
Some app offers choice between mysql and mysqli (e.g. phpMyadmin), and so our
package only offers mysqli, no choice.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362490



--- Comment #12 from Remi Collet  ---
> The code doesn't really require the -mysql extension (and no other mysql
> equivalent), I'm just wondering what the Requires: line should look like for
> it to require 'anything functionally equivalent to -mysql' across the
> different release streams (-5.3, -5.4, -5.6 and -7.x).

This doesn't work this way.
'anything functionally equivalent to -mysql' can't exists.


$ grep -rl mysqli_ src
src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

So this part of the code use mysqli extension (http://php.net/mysqli)

=> Requires: php-mysqli


$ grep -rl mysql_ src
./src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php

So this part of the code use the old deprecated mysql extension
(http://php.net/manual/en/book.mysql.php)

=> Requires: php-mysql

Of course, this is a problem, as php-mysql is deprecated for years and doesn't
exists anymore. Best is to drop this part, after checking it is not required.

Some app offers choice between mysql and mysqli (e.g. phpMyadmin), and so our
package only offers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361334] Review Request: rubygem-rails-controller-testing - Extracting `assigns` and `assert_template` from ActionDispatch

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361334

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
rubygem-rails-controller-testing-0.1.1-2.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d27f6ff494

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361891] Review Request: python-windtalker - Super easy-to-use encryption and decryption tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361891

William Moreno  changed:

   What|Removed |Added

  Flags||needinfo?(omarberroteranlkf
   ||@gmail.com)



--- Comment #6 from William Moreno  ---
Reviewer ping ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364194] Review Request: pintail - Build web sites from Mallard sources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364194



--- Comment #6 from William Moreno  ---
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/pintail.spec
SRPM URL:
https://williamjmorenor.fedorapeople.org/rpmdev/pintail-0.3-1git6f2daf7.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #6 from Dave Johansen  ---
(In reply to Antonio Trande from comment #5)
> Hi Dave.
> 
> (In reply to Dave Johansen from comment #4)
> > Sorry for the delay. We moved and I haven't had time to work on this sort of
> > thing.
> > 
> 
> > > [!]: Patches link to upstream bugs/comments/lists or are otherwise
> > >  justified.
> >
> > Fixed.
> 
> I dont see any comment.

Sorry, the file wasn't uploaded before but it's there now.

> > > Generic:
> > > [!]: Avoid bundling fonts in non-fonts packages.
> > >  Note: Package contains font files
> > 
> > This came up during the original review of cppformat and the general
> > consensus was that it wasn't an issue:
> > https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/
> > message/EKVX5GCQUFINUYBRGFD2JQHF2UXUBBVV/
> 
> There is a similar issue in this review:
> https://bugzilla.redhat.com/show_bug.cgi?id=1362265#c16

I'm using the pre-built documentation because it can't be built in Fedora right
now, so unfortunately I can't do that sort of fix.

> > > fmt.x86_64: W: tag-in-description C Provides:
> > > fmt.x86_64: W: tag-in-description C Obsoletes:
> > 
> > Is there something wrong with my Provides/Obsoletes?
> 
> Are under %description section; move them after the BuildRequires: line. 

Fixed.

> > The updated .spec file with the fixes is at:
> > https://daveisfera.fedorapeople.org/fmt_3.0.0/fmt.spec
> 
> Please, include these header files
> 
> %exclude %{_includedir}/fmt/ostream.h
> %exclude %{_includedir}/fmt/posix.h
> %exclude %{_includedir}/fmt/time.h
> 
> I need them for packaging other software.

Are these useful without the .cc files? My initial thought would be that if I'm
going to package the "header only" files that it should be in a separate
package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1363778] Review Request: perl-Test-Timer - Test module to test/ assert response times

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363778

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
perl-Test-Timer-0.13-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7f302ca1ca

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359802] Review Request: golang-github-gosexy-gettext - Gettext support for the Go language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359802



--- Comment #17 from Fedora Update System  ---
golang-github-gosexy-gettext-0-0.2.git305f360.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0eff5c48e4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1353000] Review Request: gns3-server - Graphical Network Simulator 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353000
Bug 1353000 depends on bug 1349576, which changed state.

Bug 1349576 Summary: missing Requires: python3-multidict
https://bugzilla.redhat.com/show_bug.cgi?id=1349576

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359234] Review Request: auter - Prepare and apply updates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359234

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-08-09 20:17:28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359234] Review Request: auter - Prepare and apply updates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359234



--- Comment #15 from Fedora Update System  ---
auter-0.7-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1308367] Review Request: raknet - C++ networking engine for game programmers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308367



--- Comment #15 from mark.ota...@openmailbox.org ---
Actually, SRPM at https://openblox.org/~mark/raknet-4.081-6.fc24.src.rpm. I
forgot to increment the release number, I am sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1308367] Review Request: raknet - C++ networking engine for game programmers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308367

mark.ota...@openmailbox.org changed:

   What|Removed |Added

 CC||mark.ota...@openmailbox.org



--- Comment #14 from mark.ota...@openmailbox.org ---
Renamed to raknet in b722205bf223d7bbde70a54d608d0bf602ac5e14, spec is at
https://git.openblox.org/raknet.git/tree/raknet.spec and SRPM at
https://openblox.org/~mark/raknet-4.081-5.fc24.src.rpm.

FAS username: markotaris

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365320] Review Request: simplenote - Simplenote.com desktop client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365320

Robert Bost  changed:

   What|Removed |Added

 CC||rb...@redhat.com
  Flags||needinfo?(rb...@redhat.com)



--- Comment #2 from Robert Bost  ---
(In reply to Igor Gnatenko from comment #1)
> 
> doesn't seem like true open source.

I'm not sure if I follow what you mean by true open source. Can you clarify
your concerns and I can check on it? Also, if you can help me understand how
that line would lead you to believe its not true open source, I'm happy to
adjust it so its a little clearer.

Turns out, I'm going to need to make some adjustments to the .spec anyways.
Part of the build process requires reaching out to the network to pull down npm
dependencies. This is going to need to be removed since koji does not allow for
network connections created outside of the standard rpmbuild macros during
build.

Also, I neglected to state this in my initial update, but this is my first
package submission. I'm in search of a sponsor as well and will be reaching out
to the devel list soon.


I'll be following up with a revision of my SRPM and .spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359802] Review Request: golang-github-gosexy-gettext - Gettext support for the Go language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359802



--- Comment #16 from Fedora Update System  ---
golang-github-gosexy-gettext-0-0.2.git305f360.fc23 has been pushed to the
Fedora 23 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6abbfaa875

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #35 from Fedora Update System  ---
graphite-api-1.1.3-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-aafa9d322d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362265] Review Request: yara - Malware identification tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362265



--- Comment #19 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/yara

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1363825] Review Request: perl-LWP-UserAgent-DNS-Hosts - Override LWP HTTP/HTTPS request' s host like /etc/hosts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363825



--- Comment #3 from Carl George  ---
I'll hold off on that TODO item, pending clarification of the Perl packaging
guidelines.  Everything else has been fixed, please review.

Spec URL:
https://carlgeorge.fedorapeople.org/perl-LWP-UserAgent-DNS-Hosts/perl-LWP-UserAgent-DNS-Hosts.spec

SRPM URL:
https://carlgeorge.fedorapeople.org/perl-LWP-UserAgent-DNS-Hosts/perl-LWP-UserAgent-DNS-Hosts-0.08-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1353000] Review Request: gns3-server - Graphical Network Simulator 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353000



--- Comment #18 from Athmane Madjoudj  ---
Yes, It's an issue with python3-aiohttp, which should depend on
python3-multidict

See: RHBZ #1349576

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1353000] Review Request: gns3-server - Graphical Network Simulator 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353000



--- Comment #17 from nucleo  ---
Looks like there is missing Requires: python3-multidict.

I have error when running gns3 installed without python3-multidict:

Traceback (most recent call last):
  File "/usr/bin/gns3server", line 5, in 
from pkg_resources import load_entry_point
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 3141,
in 
@_call_aside
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 3127,
in _call_aside
f(*args, **kwargs)
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 3154,
in _initialize_master_working_set
working_set = WorkingSet._build_master()
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 640,
in _build_master
ws.require(__requires__)
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 941,
in require
needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 828,
in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'multidict' distribution was not found
and is required by aiohttp

Installing python3-multidict fixes it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361687] Review Request: python-isort - A Python utility / library to sort Python imports

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361687

Jon Ciesla  changed:

   What|Removed |Added

  Flags|needinfo?(limburgher@gmail. |
   |com)|



--- Comment #9 from Jon Ciesla  ---
Banner day.


SRPM:
https://fedorapeople.org/~limb/review/python-isort/python-isort-4.2.5-4.fc24.src.rpm
SPEC: https://fedorapeople.org/~limb/review/python-isort/python-isort.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361687] Review Request: python-isort - A Python utility / library to sort Python imports

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361687

Randy Barlow  changed:

   What|Removed |Added

  Flags||needinfo?(limburgher@gmail.
   ||com)



--- Comment #8 from Randy Barlow  ---
Hello again Jon,

It's closer, but the isort2 and isort3 executable names are still missing the
-'s. They should be isort-2 and isort-3. Here's what the current spec builds:

$ ls rpms-unpacked/python2-isort-4.2.5-3.fc26.noarch.rpm/usr/bin/ -l
total 4
lrwxrwxrwx. 1 rbarlow rbarlow  18 Aug  9 16:18 isort -> /usr/bin/isort-2.7
lrwxrwxrwx. 1 rbarlow rbarlow  18 Aug  9 16:18 isort2 -> /usr/bin/isort-2.7
-rwxr-xr-x. 1 rbarlow rbarlow 292 Aug  9 16:17 isort-2.7
$ ls rpms-unpacked/python3-isort-4.2.5-3.fc26.noarch.rpm/usr/bin/ -l
total 4
lrwxrwxrwx. 1 rbarlow rbarlow  18 Aug  9 16:18 isort3 -> /usr/bin/isort-3.5
-rwxr-xr-x. 1 rbarlow rbarlow 292 Aug  9 16:17 isort-3.5

All you need to do is to change isort2 to isort-2, and isort3 to isort-3. That
should do the trick!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357064



--- Comment #17 from Raphael Groner  ---
https://lumina-desktop.org/version-1-0-0-released/

Can update on next weekend or so.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361687] Review Request: python-isort - A Python utility / library to sort Python imports

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361687

Jon Ciesla  changed:

   What|Removed |Added

  Flags|needinfo?(limburgher@gmail. |
   |com)|



--- Comment #7 from Jon Ciesla  ---
Ah, I see, like this?

SRPM:
https://fedorapeople.org/~limb/review/python-isort/python-isort-4.2.5-3.fc24.src.rpm
SPEC: https://fedorapeople.org/~limb/review/python-isort/python-isort.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361687] Review Request: python-isort - A Python utility / library to sort Python imports

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361687

Randy Barlow  changed:

   What|Removed |Added

 CC||limburg...@gmail.com
  Flags||needinfo?(limburgher@gmail.
   ||com)



--- Comment #6 from Randy Barlow  ---
Hello Jon!

Thanks for fixing the license. The executable names still do not follow the
Fedora guidelines I cited. I'll be a little more specific. The spec file
currently generates these files:

$ ls rpms-unpacked/python2-isort-4.2.5-2.fc26.noarch.rpm/usr/bin/ -l
total 4
lrwxrwxrwx. 1 rbarlow rbarlow  17 Aug  9 14:57 isort -> /usr/bin/isort2.7
-rwxr-xr-x. 1 rbarlow rbarlow 292 Aug  9 14:55 isort2.7
$ ls rpms-unpacked/python3-isort-4.2.5-2.fc26.noarch.rpm/usr/bin/ -l
total 4
-rwxr-xr-x. 1 rbarlow rbarlow 292 Aug  9 14:55 isort3.5

According to the Python packaging guidelines, it *should* be generating these
files:

/usr/bin/isort -> /usr/bin/isort-2.7
/usr/bin/isort-2 -> /usr/bin/isort-2.7
/usr/bin/isort-2.7
/usr/bin/isort-3 -> /usr/bin/isort-3.5
/usr/bin/isort-3.5

In particular, this spec file is missing the dashes and the -2 and -3 symlinks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1363935] Review Request: python-yara - Python binding for the YARA pattern matching tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363935

Michal Ambroz  changed:

   What|Removed |Added

 Blocks||563471 (FE-SECLAB)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=563471
[Bug 563471] Tracker: Review Requests for Fedora Security Lab related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362265] Review Request: yara - Malware identification tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362265



--- Comment #18 from Michal Ambroz  ---
>Package approved.
Thank you for the review Antonio.

>Just a note: hidden directory /usr/share/doc/yara-doc/html/.buildinfo 
>can be erased, i think.
OK, I will put the directory removal back

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1363935] Review Request: python-yara - Python binding for the YARA pattern matching tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363935

Michal Ambroz  changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com
   Fixed In Version|anto.tra...@gmail.com   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1363935] Review Request: python-yara - Python binding for the YARA pattern matching tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363935

Michal Ambroz  changed:

   What|Removed |Added

  Alias||python-yara



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361334] Review Request: rubygem-rails-controller-testing - Extracting `assigns` and `assert_template` from ActionDispatch

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361334

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361334] Review Request: rubygem-rails-controller-testing - Extracting `assigns` and `assert_template` from ActionDispatch

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361334



--- Comment #9 from Fedora Update System  ---
rubygem-rails-controller-testing-0.1.1-2.fc25 has been submitted as an update
to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d27f6ff494

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1356048] Review Request: rtlsdr-scanner - Frequency scanning GUI for RTL2832 based DVB-T dongles

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1356048



--- Comment #32 from Fedora Update System  ---
rtlsdr-scanner-1.0.22298.18049-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362490



--- Comment #11 from Jeroen van Meeuwen  ---
I've split the server (phabricator) dependencies from the client (arcanist)
dependencies, removed all references to xhprof, and adjusted the dependences as
per Remi's comments.

Spec URL: https://kanarip.fedorapeople.org/phabricator/libphutil.spec
SRPM URL:
https://kanarip.fedorapeople.org/phabricator/libphutil-20160727.git8f8e02d-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Douglas Schilling Landgraf  changed:

   What|Removed |Added

External Bug ID||oVirt gerrit 62164
  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Douglas Schilling Landgraf  ---
Package re-approved.

This package has been in Fedora for long time and current maintainers are
responsive. Unfortunately, it got retired because one of dep. package was
broken. Additionally, VDSM is very important for the oVirt ecosystem. 

* I see some false positive in rpmlint, as example, %dir statement has been
  used and still complains about dir used but not owned.
* rpmlint complains about explicit-lib-dependency but such package doesn't get
installed if removed from spec.
* wrong-script-interpreter even using /usr/bin/env python
* Incorrect spelling-error warning

Additional item, patch sent to upstream:
Please remove deprecated:
  BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)

* My final suggestion, use jenkins job to run fedora-review tool weekly and
keep the eye on it to find improvements needed, deprecated keys, warnings or
errors.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD
 like)", "PSF (v2;)", "*No copyright* GPL (v2 or later)", "GPL (v2)".
 106 files have unknown license. Detailed output of licensecheck in
 /home/fedora/vdsm/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: Package requires other packages for directories it uses.
 Note: No known owner of /rhev, /usr/share/vdsm/storage/sdm,
 /usr/lib64/udev/rules.d, /usr/lib64/udev, /usr/lib64/systemd,
 /etc/vdsm/logrotate, /usr/lib/python2.7/site-packages/sos,
 /usr/lib/python2.7/site-packages/sos/plugins, /etc/libvirt/hooks,
 /usr/share/vdsm/storage/sdm/api, /usr/lib64/systemd/system-preset,
 /etc/systemd/system/libvirtd.service.d, /usr/lib/python2.7/site-
 packages/api
[X]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/libexec/vdsm,
 /usr/libexec/vdsm/hooks/before_vm_destroy, /etc/cron.hourly,
 /usr/libexec/vdsm/hooks/after_vm_start,
 /usr/share/vdsm/storage/sdm/api, /etc/libvirt/hooks,
 /usr/libexec/vdsm/hooks/before_vm_migrate_destination,
 /usr/libexec/vdsm/hooks,
 /usr/libexec/vdsm/hooks/before_vm_migrate_source,
 /usr/libexec/vdsm/hooks/after_nic_hotunplug, /usr/lib64/systemd
 /system-preset, /usr/share/vdsm/storage/sdm,
 /etc/systemd/system/libvirtd.service.d, /usr/lib64/systemd,
 /etc/modprobe.d, /etc/vdsm/logrotate,
 /usr/libexec/vdsm/hooks/after_nic_hotplug,
 /usr/libexec/vdsm/hooks/after_device_destroy,
 /usr/share/polkit-1/rules.d, /rhev, /usr/lib64/udev/rules.d,
 /usr/lib/python2.7/site-packages/vdsm/gluster, /etc/sudoers.d,
 /usr/libexec/vdsm/hooks/before_nic_hotplug, /usr/lib/systemd/system,
 /etc/libvirt/nwfilter, /etc/libvirt, /usr/lib/systemd,
 /usr/libexec/vdsm/hooks/after_device_create,
 /usr/libexec/vdsm/hooks/before_device_migrate_destination,
 /usr/libexec/vdsm/hooks/before_device_create,
 /usr/libexec/vdsm/hooks/before_vm_dehibernate,
 /usr/libexec/vdsm/hooks/after_network_setup, /usr/lib/python2.7/site-
 packages/api, /usr/libexec/vdsm/hooks/after_vm_destroy,
 /usr/lib/python2.7/site-packages/sos, /usr/lib64/udev,
 /usr/lib/python2.7/site-packages/sos/plugins,
 /usr/libexec/vdsm/hooks/before_vm_start,
 /usr/libexec/vdsm/hooks/after_device_migrate_destination
[X]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /etc/modprobe.d(kmod)
[X]: %build honors applicable compiler flags or justifies otherwise.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[X]: Each %files section contains %defattr if rpm < 4.4
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not 

[Bug 1364215] Review Request: nodejs-pad-left - Left pad a string with zeros or a specified string

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364215



--- Comment #3 from Jared Smith  ---
Sorry, I confused "pad-left" with "left-pad".

Issues have been updated in:

Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-pad-left/nodejs-pad-left.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-pad-left/nodejs-pad-left-2.1.0-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364216] Review Request: nodejs-time-stamp - Get a formatted timestamp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364216
Bug 1364216 depends on bug 1364215, which changed state.

Bug 1364215 Summary: Review Request: nodejs-pad-left - Left pad a string with 
zeros or a specified string
https://bugzilla.redhat.com/show_bug.cgi?id=1364215

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|DUPLICATE   |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364215] Review Request: nodejs-pad-left - Left pad a string with zeros or a specified string

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364215

Jared Smith  changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|DUPLICATE   |---
   Keywords||Reopened



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364186] Review Request: nodejs-log-driver - A simple logging framework for logging to stdout

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364186

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 13:16:40



--- Comment #5 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364187] Review Request: nodejs-coveralls - Takes json-cov output into stdin and POSTs to coveralls.io

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364187
Bug 1364187 depends on bug 1364186, which changed state.

Bug 1364186 Summary: Review Request: nodejs-log-driver - A simple logging 
framework for logging to stdout
https://bugzilla.redhat.com/show_bug.cgi?id=1364186

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364213] Review Request: nodejs-es6-map - ECMAScript6 Map polyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364213

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 13:15:09



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364212] Review Request: nodejs-es6-set - ECMAScript6 Set polyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364212

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 13:05:46



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364685] Review Request: nodejs-lazy-cache - Cache requires to be lazy-loaded when needed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364685
Bug 1364685 depends on bug 1364680, which changed state.

Bug 1364680 Summary: Review Request: nodejs-set-getter - Create nested getter 
properties and any intermediary paths
https://bugzilla.redhat.com/show_bug.cgi?id=1364680

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364213] Review Request: nodejs-es6-map - ECMAScript6 Map polyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364213
Bug 1364213 depends on bug 1364212, which changed state.

Bug 1364212 Summary: Review Request: nodejs-es6-set - ECMAScript6 Set polyfill
https://bugzilla.redhat.com/show_bug.cgi?id=1364212

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364689] Review Request: nodejs-has-glob - Returns if an array has a glob pattern

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364689

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 12:57:46



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364680] Review Request: nodejs-set-getter - Create nested getter properties and any intermediary paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364680

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 12:58:46



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364697] Review Request: nodejs-leche - A JavaScript testing utility designed to work with Mocha and Sinon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364697

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 12:57:23



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364690] Review Request: nodejs-matched - Adds array support to node-glob, sync and async

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364690
Bug 1364690 depends on bug 1364689, which changed state.

Bug 1364689 Summary: Review Request: nodejs-has-glob - Returns  if an array has 
a glob pattern
https://bugzilla.redhat.com/show_bug.cgi?id=1364689

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364701] Review Request: nodejs-uc-dot-micro - Micro subset of unicode data files for markdown-it projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364701

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 13:00:19



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364182] Review Request: nodejs-cliui - Easily create complex multi-column command-line-interfaces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364182

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 13:05:30



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364696] Review Request: nodejs-file-entry-cache - Super simple cache for file metadata

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364696

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 12:57:08



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364687] Review Request: nodejs-arr-union - Combines a list of arrays , returning a single array with unique values

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364687

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 12:53:39



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364685] Review Request: nodejs-lazy-cache - Cache requires to be lazy-loaded when needed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364685
Bug 1364685 depends on bug 1364682, which changed state.

Bug 1364682 Summary: Review Request: nodejs-ansi-yellow - The color yellow, in 
ansi
https://bugzilla.redhat.com/show_bug.cgi?id=1364682

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364679] Review Request: nodejs-to-object-path - Create an object path from a list or array of strings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364679

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 12:46:44



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350257] Review Request: petsc - Portable Extensible Toolkit for Scientific Computation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350257



--- Comment #7 from Dave Love  ---
Oh, something else.  PAPI is a mess on el6.  You need to ensure you get v5 for
at least sandybridge+.  This is what I had to do for scorep:

# The messing with linkage paths here and below is due to the mess of  
# the papi package there.  %%_libdir/libpapi.so is papi v4 with a  
# soname of libpapi.so (bz #1300664).  
export LDFLAGS='-Wl,--as-needed -L%{_libdir}/papi-5.1.1/usr/lib'
%global configure_opts --enable-shared --disable-static --disable-silent-rules
%{?el6:--with-papi-header=%{_libdir}/papi-5.1.1%{_includedir}
--with-papi-lib=%{_libdir}/papi-5.1.1/usr/lib}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364676] Review Request: nodejs-try-open - Tries to open a file using fs.openSync, fails gracefully

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364676

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 12:38:09



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364674] Review Request: nodejs-treeify - Converts a JS object into a nice and readable tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364674

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 12:37:48



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364670] Review Request: nodejs-parse-ms - Parse milliseconds into an object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364670

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 12:16:24



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364667] Review Request: nodejs-ignore - Ignore is a manager and filter for .gitignore rules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364667

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 12:13:53



--- Comment #4 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364635] Review Request: nodejs-strip-bom-stream - Strip UTF-8 byte order mark (BOM) from a stream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364635

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 12:12:02



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364535] Review Request: ehcache2 - Java in-process cache

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364535

gil cattaneo  changed:

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|CANTFIX |---
   Keywords||Reopened



--- Comment #5 from gil cattaneo  ---
(In reply to Tom "spot" Callaway from comment #4)
> If you remove all code under the Terracotta Public License, then what
> remains would be Apache 2.0 and fine for inclusion in Fedora.

Spec URL: https://gil.fedorapeople.org/ehcache2.spec
SRPM URL: https://gil.fedorapeople.org/ehcache2-2.9.0-1.fc24.src.rpm

- remove all non-free/buildable contents

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364640] Review Request: nodejs-rechoir - Require any supported file as a node module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364640

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 12:01:13



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364634] Review Request: nodejs-first-chunk-stream - Transform the first chunk in a stream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364634

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 11:57:32



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365589] Review Request: rubygem-activemodel-serializers-xml - XML serialization for Active Model objects and Active Record models

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365589



--- Comment #2 from Jun Aruga  ---
I will review this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364628] Review Request: nodejs-unique-stream - A node.js through stream that emits a unique stream of objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364628

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 11:40:11



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364631] Review Request: nodejs-glob-stream - A wrapper around node-glob to make it streamy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364631
Bug 1364631 depends on bug 1364628, which changed state.

Bug 1364628 Summary: Review Request: nodejs-unique-stream - A node.js through 
stream that emits a unique stream of objects
https://bugzilla.redhat.com/show_bug.cgi?id=1364628

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365589] New: Review Request: rubygem-activemodel-serializers-xml - XML serialization for Active Model objects and Active Record models

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365589

Bug ID: 1365589
   Summary: Review Request: rubygem-activemodel-serializers-xml -
XML serialization for Active Model objects and Active
Record models
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: vondr...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://fedorapeople.org/cgit/vondruch/public_git/rubygem-activemodel-serializers-xml.git/plain/rubygem-activemodel-serializers-xml.spec?id=5b7cb92fecbd4f7ce6476cc829264bbe22f0e705
SRPM URL:
http://people.redhat.com/vondruch/rubygem-activemodel-serializers-xml-1.0.1-1.fc26.src.rpm
Description: XML serialization for your Active Model objects and Active Record
models - extracted from Rails.
Fedora Account System Username: vondruch

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15189736

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1343661] Rebase clufter component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343661

errata-xmlrpc  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364626] Review Request: nodejs-deprecated - Tool for deprecating things

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364626

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-08-09 11:15:24



--- Comment #2 from Jared Smith  ---
In rawhide, closing bug

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364623] Review Request: nodejs-gulplog - Logger for gulp and gulp plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364623
Bug 1364623 depends on bug 1364622, which changed state.

Bug 1364622 Summary: Review Request: nodejs-glogg - Global logging utility
https://bugzilla.redhat.com/show_bug.cgi?id=1364622

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364689] Review Request: nodejs-has-glob - Returns if an array has a glob pattern

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364689



--- Comment #1 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-has-glob

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364680] Review Request: nodejs-set-getter - Create nested getter properties and any intermediary paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364680



--- Comment #1 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-set-getter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364673] Review Request: nodejs-package-license - Checks the filesystem for potential license files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364673



--- Comment #1 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-package-license

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364672] Review Request: nodejs-nopt-usage - This module generates a usage string for nopt options

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364672



--- Comment #1 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-nopt-usage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364667] Review Request: nodejs-ignore - Ignore is a manager and filter for .gitignore rules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364667



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-ignore

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364647] Review Request: nodejs-svgmin - Minify SVG files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364647

Jared Smith  changed:

   What|Removed |Added

 Depends On||1364959



--- Comment #2 from Jared Smith  ---
Good catch... I've fixed this to pull index.js from GitHub instead of from the
NPM tarball.  This introduced a new dependency, nodejs-ware, which itself has a
new dependency (nodejs-wrap-fn).  Those have been submitted for package review.

Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-svgmin/nodejs-svgmin.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-svgmin/nodejs-svgmin-0.1.0-1.fc26.src.rpm


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364959
[Bug 1364959] Review Request: nodejs-ware - Easily create your own
middleware layer
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1344101] Review Request: rubygem-sinatra-cross_origin - Cross Origin Resource Sharing helper for Sinatra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344101

Vít Ondruch  changed:

   What|Removed |Added

 CC||vondr...@redhat.com



--- Comment #5 from Vít Ondruch  ---
(In reply to Jun Aruga from comment #4)
> Still fixed version rubygem-sinatra 1.4.7 is not updated to rawhide

It is actually in Rawhide, available on builders:

```
$ koji wait-repo f26-build --build rubygem-sinatra-1.4.7-1.fc26
Successfully waited 0:02 for rubygem-sinatra-1.4.7-1.fc26 to appear in the
f26-build repo
```

It seems that just the compose is failing for some reasons, hence the official
repositories are not update. Not a showstopper for anything.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1344101] Review Request: rubygem-sinatra-cross_origin - Cross Origin Resource Sharing helper for Sinatra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344101



--- Comment #4 from Jun Aruga  ---
Still fixed version rubygem-sinatra 1.4.7 is not updated to rawhide, though it
is committed to master branch. So, I would wait this review until it is updated
on rawhide.

```
dnf repoquery --disablerepo=* --enablerepo=rawhide rubygem-sinatra
rubygem-sinatra-1:1.4.6-3.fc24.noarch
```

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362490



--- Comment #8 from Remi Collet  ---
1/ XHprof is a dead project (damned because first developed by Facebook, which
forgive it as they use HHVM... and nobody can take ownership because of a
strange CLA). Have been removed from Fedora (BTW various fork exists, but none
are packaged for now)

2/ Mysql

Need code inspection.

If this package really requires "mysql" extension, you have an issue, this is
dead (deprecated for years, removed from PHP 7) and no more available in
Fedora.

> Note that the 'Obsoletes: php-mysql < x.y.z' in the current php-7 package in 
> rawhide does not provide the equivalent nevra for 'php-mysql'.

This is for the update from php-mysql package to php-mysqlnd package (with 5.6
IIRC). Can probably be cleaned, in all case can't be provided.

MySQLi is a different extension.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361334] Review Request: rubygem-rails-controller-testing - Extracting `assigns` and `assert_template` from ActionDispatch

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361334

Jun Aruga  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362490



--- Comment #7 from Remi Collet  ---
Sorry, I missread, I was thinking there is "jsmin"... 
So, not no-free issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361334] Review Request: rubygem-rails-controller-testing - Extracting `assigns` and `assert_template` from ActionDispatch

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361334



--- Comment #7 from Jun Aruga  ---
(In reply to František Dvořák from comment #5)

> > #1. LICENCE file.
> 
> Pull request sent (and merged). It seems it is just a typo in upstream
> gemspec and it's true it will simplify the spec file.
> 
> URL updated, versioned license file is better.

Okay I got it, and checked your new spec file.
It looks good to me. Thanks.

> > #2. Koji URL
> > 
> > Next time not now, it is good habit to put the result of scratch build.
> > https://bugzilla.redhat.com/show_bug.cgi?id=1359224
> > > Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=14979792
> > 
> 
> OK (I usually include the link to the build. :-))

OK :)

> > #3. files
> > 
> > %files
> > %doc %{gem_instdir}/README.md
> > 
> > You may use gem2rpm old version.
> > You do not need to include README.md %files section. as you inlude LICENSE
> > file in it.
> > 
> > Remove below lines from %files, and move to %files doc section.
> > I want to include below files doc RPM file.
> > 
> > %exclude %{gem_instdir}/test/
> > %exclude %{gem_instdir}/Rakefile
> > 
> > The reason is we want to reduce the base RPM's file size.
> > And if it is not ".*" file, want to include doc RPM file.
> > 
> 
> OK. I guess this is quite "gray" area: some reviewers even prefer to include
> README file in the main package. The gem2spec version way may be slightly
> better here because more packages will probably use that way. :-) Updated.

Yeah, some reviewers may prefer to include README file.
It is grey area, as it is not written on "Packaging:Ruby" Guideline.
You can decide it of cource finally.
OK I checked it had updated in the new spec file.
Thanks.

> > #3. Add below lines. near "BuildRequires: rubygems-devel".
> >   You can see the result of latest gem2rpm.
> > 
> > BuildRequires: ruby(release)
> > BuildRequires: ruby
> > 
> 
> Why is that needed? Guideline doesn't mention it (most of my ruby packages
> doesn't have these dependencies).
> 
> Although it's true I haven't checked any other ruby implementations here.

We can build and install without these 2 lines on latest version Fedora.
Because these 2 lines are needed to build, install on older Feodra version like
F22 or F23. Though I do not know exact version for that. I have heard it.
However it is gray area. It is up to you finally.

> > #5. Use latest version gem2rpm
> > 
> > Finally latest gem2rpm is covering above these things.
> > I can suggest you can use master branch of 
> > https://github.com/fedora-ruby/gem2rpm
> > , though it is optional.
> > 
> > Its generated template is the collection of our latest trend for the spec
> > file.
> > 
> 
> Yes, it looks like there are no differences in generated spec-file between
> the version I use (0.11.3) and the master branch.
> 
> I generate the spec file by gem2spec, but edit it heavily after that.

Yes mostly same. There is a little different. But it looks harmless.
https://github.com/fedora-ruby/gem2rpm/issues/87

> Updated package (koji
> http://koji.fedoraproject.org/koji/taskinfo?taskID=15175903):
> 
> Spec URL:
> http://scientific.zcu.cz/fedora/rubygem-rails-controller-testing-0.1.1-2/
> rubygem-rails-controller-testing.spec
> SRPM URL:
> http://scientific.zcu.cz/fedora/rubygem-rails-controller-testing-0.1.1-2/
> rubygem-rails-controller-testing-0.1.1-2.fc25.src.rpm
> 
> %changelog
> * Mon Aug 08 2016 František Dvořák  - 0.1.1-2
> - Pull request to include LICENSE file in the gem
> - Keep the tests in -doc subpackage

I APPROVED your code!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362490



--- Comment #6 from Jeroen van Meeuwen  ---
== Bundling ==

(In reply to Remi Collet from comment #5)
> Of course, I mean : "Non-free software must NOT go in the repo, even in
> .src.rpm"

I understand this to mean vendorized or bundled rather than non-Free, or am I
misunderstanding something? I would like sufficient clarification to
distinguish between needing to repack the upstream sources excluding the
externals/jsonlint/ directory from what is shipped as the Source0 in the SRPM,
or alternatively just not install it with the binary package.

In any case, I agree we need to not ship it in the binary package and instead
use the system php-jsonlint. I'll be working on a patch for it.

I think I might have it sorted for the next .spec/.srpm I include

== Seemingly Superfluous Requirements ==

The requirements could be split up between a set that is at the very core, a
set that is needed for arcanist, the client-side command-line (Bug #1362487)
and a set that is needed for phabricator, the server-side web interface and API
(xhprof, apc|apcu, opcache, etc., Bug #1362491). We can do one worse by also
sub-packaging phabricator-devel (xhprof comes to mind).

Note that, currently, arcanist and phabricator currently list their own sets of
dependencies satisfying the needs of the corresponding parts actually in
libphutil. These would be cleaned up.

== Requiring MySQL ==

I'm not certain what is the recommended route for requiring mysql.

'php-mysql' used to be provided by both the php-mysql as well as the
php-mysqlnd sub-packages, but today unless I clause %{?rhel} out I cannot
require 'php-mysql' in rawhide. I choose 'php-mysqli' which seems to still be
provided by either or both of the packages across platforms. Note that the
'Obsoletes: php-mysql < x.y.z' in the current php-7 package in rawhide does not
provide the equivalent nevra for 'php-mysql'.

== Versioning Scheme ==

Upstream does not use versioning. They maintain a level of compatibility
between days, weeks or months of releases of libphutil, arcanist and
phabricator, but basically only ever move forward with deprecation warnings.

I would like to use the Version to have packages depend on , MM and DD (of
the last commit made to the stable branches of each GIT repository), so that I
can let other packages depend on a dated version greater than some months ago
and before some months ahead.

At Flock however, jsmith re-iterated a packaging requirement that non-versioned
software should have a version of 0, and a release of
0.$x.$date.git$id.%{?dist}, which I believe would void the requires and
provides scenario I'm proposing we use for libphutil, arcanist and phabricator.

However, perhaps we could/should move the git%{git_short_version_hash} over to
the Release tag.

Spec URL: https://kanarip.fedorapeople.org/phabricator/libphutil.spec
SRPM URL:
https://kanarip.fedorapeople.org/phabricator/libphutil-20160727.git8f8e02d-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315495] Review Request: ibus-table-coptic - Unicode Ibus keyboard input for Sahidic Coptic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315495



--- Comment #3 from Parag AN(पराग)  ---
I think correct links for fedora-review tool to work are

SPEC:
http://copr-dist-git.fedorainfracloud.org/cgit/vwbusguy/ibus-coptic/ibus-table-coptic.git/plain/ibus-table-coptic.spec

SRPM:
https://copr-be.cloud.fedoraproject.org/results/vwbusguy/ibus-coptic/fedora-rawhide-x86_64/00166444-ibus-table-coptic/ibus-table-coptic-0.1-5.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1317286] Review Request: hunspell-ie - Interlingue hunspell dictionary

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317286

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Parag AN(पराग)  ---
I would like to review this but can you provide working links?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315495] Review Request: ibus-table-coptic - Unicode Ibus keyboard input for Sahidic Coptic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315495

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362487] Review Request: arcanist - A command line interface to Phabricator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362487



--- Comment #5 from Jeroen van Meeuwen  ---
(In reply to Jeroen van Meeuwen from comment #4)
> Note while working on libphutil, that to have rpmlint and builds from source
> succeed, the Source0 URL will likely just need to be:
> 
> > https://github.com/phacility/arcanist/archive/%{git_full_version_hash}.tar.gz
> 
> Adjust gen-tar.sh to reflect this.
> 

That's wrong, I mean to use --content-disposition option to wget instead and
use the full version hash instead of the short version hash for the trailing
part.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362487] Review Request: arcanist - A command line interface to Phabricator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362487



--- Comment #4 from Jeroen van Meeuwen  ---
Note while working on libphutil, that to have rpmlint and builds from source
succeed, the Source0 URL will likely just need to be:

> https://github.com/phacility/arcanist/archive/%{git_full_version_hash}.tar.gz

Adjust gen-tar.sh to reflect this.

Also note to require phabricator(libphutil) in an attempt to silence rpmlint.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359802] Review Request: golang-github-gosexy-gettext - Gettext support for the Go language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359802

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Neal Gompa  ---
Package was generated through gofed, simplifying the review considerably.

- Conforms to packaging guidelines (gofed generated spec)
- license correct and valid
- only sources installed in all subpackages except go-xgettext, which provides
/usr/bin/go-xgettext

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359802] Review Request: golang-github-gosexy-gettext - Gettext support for the Go language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359802

Zygmunt Krynicki  changed:

   What|Removed |Added

  Flags|needinfo?(m...@zygoon.pl) |



--- Comment #9 from Zygmunt Krynicki  ---
I fixed the missing build dependency on go-flags and started building the
go-xgettext binary in a separate binary package. Built-tested in mock.

Spec file: https://fedorapeople.org/~zyga/golang-github-gosexy-gettext.spec
SRPM:
https://fedorapeople.org/~zyga/golang-github-gosexy-gettext-0-0.2.git305f360.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365399] Review Request: python-aaargh - An astonishingly awesome application argument helper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365399



--- Comment #6 from Dominika Krejčí  ---
Done.

Spec URL: https://dkrejci.fedorapeople.org/python-aaargh/python-aaargh.spec
SRPM URL:
https://dkrejci.fedorapeople.org/python-aaargh/python-aaargh-0.7.1-1.fc24.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15185854

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362265] Review Request: yara - Malware identification tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362265

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #17 from Antonio Trande  ---
Just a note: hidden directory /usr/share/doc/yara-doc/html/.buildinfo can be
erased, i think.

Package approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "GPL (v3 or later)", "Unknown or generated",
 "BSD (4 clause)", "BSD (3 clause)", "BSD (2 clause)". 53 files have
 unknown license. Detailed output of licensecheck in
 /home/sagitter/1362265-yara/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in yara-doc
 , yara-devel , yara-debuginfo
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files 

[Bug 1365399] Review Request: python-aaargh - An astonishingly awesome application argument helper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365399



--- Comment #5 from Igor Gnatenko  ---
you forgot to fix:

> %description -n python2-%{srcname}
> %{desc}

same for python3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 505154] Tracker: Review Requests for Science and Technology related packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=505154
Bug 505154 depends on bug 1176595, which changed state.

Bug 1176595 Summary: Review Request: hypre - High performance matrix 
preconditioners
https://bugzilla.redhat.com/show_bug.cgi?id=1176595

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1176595] Review Request: hypre - High performance matrix preconditioners

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1176595

Dave Love  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-08-09 06:26:57



--- Comment #30 from Dave Love  ---
Seems not to have been linked to the bug in bodhi.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365399] Review Request: python-aaargh - An astonishingly awesome application argument helper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365399



--- Comment #4 from Dominika Krejčí  ---
Modified.

Spec URL: https://dkrejci.fedorapeople.org/python-aaargh/python-aaargh.spec
SRPM URL:
https://dkrejci.fedorapeople.org/python-aaargh/python-aaargh-0.7.1-1.fc24.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15185358

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1350143] Review Request: fmt - Small, safe and fast formating library for C++

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350143



--- Comment #5 from Antonio Trande  ---
Hi Dave.

(In reply to Dave Johansen from comment #4)
> Sorry for the delay. We moved and I haven't had time to work on this sort of
> thing.
> 

> > [!]: Patches link to upstream bugs/comments/lists or are otherwise
> >  justified.
>
> Fixed.

I dont see any comment.

> 
> 
> > Generic:
> > [!]: Avoid bundling fonts in non-fonts packages.
> >  Note: Package contains font files
> 
> This came up during the original review of cppformat and the general
> consensus was that it wasn't an issue:
> https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/
> message/EKVX5GCQUFINUYBRGFD2JQHF2UXUBBVV/

There is a similar issue in this review:
https://bugzilla.redhat.com/show_bug.cgi?id=1362265#c16

> 
> > fmt.x86_64: W: tag-in-description C Provides:
> > fmt.x86_64: W: tag-in-description C Obsoletes:
> 
> Is there something wrong with my Provides/Obsoletes?

Are under %description section; move them after the BuildRequires: line. 

> 
> > fmt-devel.x86_64: W: only-non-binary-in-usr-lib
> 
> I don't understand what this is warning about.

It's a false positive.

> 
> The updated .spec file with the fixes is at:
> https://daveisfera.fedorapeople.org/fmt_3.0.0/fmt.spec

Please, include these header files

%exclude %{_includedir}/fmt/ostream.h
%exclude %{_includedir}/fmt/posix.h
%exclude %{_includedir}/fmt/time.h

I need them for packaging other software.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362626] Review Request: mediawriter - Fedora Media Writer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362626



--- Comment #6 from Martin Bříza  ---
> %if 0%{?fedora} && 0%{?fedora} < 2

Noo, I wanted to avoid this. But since you suggested so, it's there. And the
other stuff, too.

Spec URL: https://mbriza.fedorapeople.org/mediawriter/3/mediawriter.spec
SRPM URL:
https://mbriza.fedorapeople.org/mediawriter/3/mediawriter-0-0.1git0054ae4.fc24.src.rpm

Thank you for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1362626] Review Request: mediawriter - Fedora Media Writer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1362626

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Igor Gnatenko  ---
> #f24/23 Requires: udisks2   
> Requires:   storaged%{?_isa}
* whitespace detected ;)
* you can do something:
%if 0%{?fedora} && 0%{?fedora} < 25
Requires: udisks2%{?_isa}
%else
Requires: storaged%{?_isa}
%endif

> %{_libexecdir}/%{name}
I would prefer to have trailing "/" to be sure that it's directory

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364982] Review Request: nodejs-coffee-coverage - Istanbul and JSCoverage-style instrumentation for CoffeeScript files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364982

Jeroen van Meeuwen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|vanmeeuwen+fedora@kolabsys.
   ||com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364958] Review Request: nodejs-wrap-fn - Support sync, async, and generator functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364958

Jared Smith  changed:

   What|Removed |Added

 Blocks||1364959

Jeroen van Meeuwen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|vanmeeuwen+fedora@kolabsys.
   ||com




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364959
[Bug 1364959] Review Request: nodejs-ware - Easily create your own
middleware layer
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org