[Bug 1372938] Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938



--- Comment #4 from Christopher Atherton  ---
Actually we need libdrm version of at least 2.4.63 ...

New Spec: https://cjatherton.fedorapeople.org/xorg-x11-drv-amdgpu.spec (same)
New SRPM:
https://cjatherton.fedorapeople.org/xorg-x11-drv-amdgpu-1.1.0-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372938] Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938



--- Comment #3 from Christopher Atherton  ---
Thanks for the help!

Fixes applied here ...
New Spec: https://cjatherton.fedorapeople.org/xorg-x11-drv-amdgpu.spec (same)
New SRPM:
https://cjatherton.fedorapeople.org/xorg-x11-drv-amdgpu-1.1.0-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372938] Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938



--- Comment #2 from Neal Gompa  ---
First pass comments:

* "s390s" is not a valid architecture, as far as I know. Shouldn't it be
"s390x"?

* Is there a URL and a URL path for the Source? URL-less sources are
discouraged...

* Is there a reason autoreconf isn't using "-fiv" instead?

* Is there a reason you are using "make %{?_smp_mflags}" instead of
"%make_build"?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372938] Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372938] New: Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938

Bug ID: 1372938
   Summary: Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu
video driver
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: the8lack...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://cjatherton.fedorapeople.org/xorg-x11-drv-amdgpu.spec
SRPM URL:
https://cjatherton.fedorapeople.org/xorg-x11-drv-amdgpu-1.1.0-1.fc24.src.rpm

Description:
This is new basic support for Radeon GPUs.  It is not AMDGPU-PRO and does not
contain any binary blobs.

I drafted this spec using the xorg-x11-drv-intel spec for reference.  It works
on my machine with Sapphire Radeon Rx 480 test hardware.  Kernel 4.7 or later
might be required.

Fedora Account System Username: cjatherton

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #12 from Fedora Update System  ---
python-fadvise-5.0.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d6fcbadcf1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903



--- Comment #16 from Fedora Update System  ---
NetworkManager-sstp-1.2.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-dc25b53d8d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340



--- Comment #11 from Fedora Update System  ---
python-fadvise-5.0.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-19e20103d3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1229903] Review Request: NetworkManager-sstp - NetworkManager VPN plugin for SSTP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1229903

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
NetworkManager-sstp-1.2.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9708701139

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361340

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
python-fadvise-5.0.0-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-25d018f640

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372866



--- Comment #16 from Jason Taylor  ---
here is the latest scratch build (successful)

http://koji.fedoraproject.org/koji/taskinfo?taskID=15490876

I believe the directory ownership is corrected as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366881] Review Request: ispc - C-based SPMD programming language compiler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366881



--- Comment #27 from Fedora Update System  ---
ispc-1.9.1-7.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372866



--- Comment #15 from gil cattaneo  ---
directory /usr/include/hs/ is still unowned.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372866



--- Comment #14 from gil cattaneo  ---
(In reply to Jason Taylor from comment #13)
> Hi gil/ralf thank you for the feedback. Working through a your comments. I
> am 
> reviewing the comment from ralf:
> 
> Remove these 2 lines from your spec:
> export CFLAGS="$RPM_OPT_FLAGS -march=core2"
> export CXXFLAGS="${CFLAGS}"
> 
> In reading through the hyperscan documentation some more it appears that
> hyperscan requires at least core2 instruction set features to compile. 
> 
> This being the case should I add an excludearch for i686?

maybe also for arm and append in the "Depends On" field of
https://bugzilla.redhat.com/show_bug.cgi?id=485251 this bug

> 
> Thanks again for the help!
> 
> 
> [0] https://github.com/01org/hyperscan/issues/20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372866



--- Comment #13 from Jason Taylor  ---
Hi gil/ralf thank you for the feedback. Working through a your comments. I am 
reviewing the comment from ralf:

Remove these 2 lines from your spec:
export CFLAGS="$RPM_OPT_FLAGS -march=core2"
export CXXFLAGS="${CFLAGS}"

In reading through the hyperscan documentation some more it appears that
hyperscan requires at least core2 instruction set features to compile. 

This being the case should I add an excludearch for i686?

Thanks again for the help!


[0] https://github.com/01org/hyperscan/issues/20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1268758] Review Request: rubygem-rubocop - Automatic Ruby code style checking tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268758



--- Comment #2 from Ilya Gradina  ---
New Spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-rubocop.spec
New SRPM:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-rubocop-0.42.0-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372918] Review Request: rubygem-rspectacular -RSpec Support And Matchers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372918

Ilya Gradina  changed:

   What|Removed |Added

 Blocks||1372926




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372926
[Bug 1372926] Review Request: rubygem-ruby-progressbar - Ruby/ProgressBar
is a flexible text progress bar library for Ruby
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372926] Review Request: rubygem-ruby-progressbar - Ruby/ ProgressBar is a flexible text progress bar library for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372926

Ilya Gradina  changed:

   What|Removed |Added

 Depends On||1372918




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372918
[Bug 1372918] Review Request: rubygem-rspectacular -RSpec Support And
Matchers
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372926] Review Request: rubygem-ruby-progressbar - Ruby/ ProgressBar is a flexible text progress bar library for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372926

Ilya Gradina  changed:

   What|Removed |Added

 Blocks||1268758




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1268758
[Bug 1268758] Review Request: rubygem-rubocop - Automatic Ruby code style
checking tool
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1268758] Review Request: rubygem-rubocop - Automatic Ruby code style checking tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268758

Ilya Gradina  changed:

   What|Removed |Added

 Depends On||1372926




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372926
[Bug 1372926] Review Request: rubygem-ruby-progressbar - Ruby/ProgressBar
is a flexible text progress bar library for Ruby
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372926] New: Review Request: rubygem-ruby-progressbar - Ruby/ ProgressBar is a flexible text progress bar library for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372926

Bug ID: 1372926
   Summary: Review Request: rubygem-ruby-progressbar -
Ruby/ProgressBar is a flexible text progress bar
library for Ruby
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ilya.grad...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-ruby-progressbar.spec
SRPM URL:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-ruby-progressbar-1.8.1-1.fc25.src.rpm
Description: Ruby/ProgressBar is a flexible text progress bar library for Ruby
Fedora Account System Username: ilgrad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372918] New: Review Request: rubygem-rspectacular -RSpec Support And Matchers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372918

Bug ID: 1372918
   Summary: Review Request: rubygem-rspectacular -RSpec Support
And Matchers
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ilya.grad...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-rspectacular.spec
SRPM URL:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-rspectacular-0.70.7-1.fc25.src.rpm
Description: RSpec Support And Matchers
Fedora Account System Username: ilgrad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372866



--- Comment #12 from gil cattaneo  ---
Created attachment 1197506
  --> https://bugzilla.redhat.com/attachment.cgi?id=1197506=edit
spec file

Build fails. Task info:Task info:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15487263

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1268703] Review Request: rubygem-powerpack - A few useful extensions to core Ruby classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268703



--- Comment #1 from Ilya Gradina  ---
New SPEC:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-powerpack.spec
New SRPM:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-powerpack-0.1.1-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372866



--- Comment #11 from gil cattaneo  ---
Sorry, mkdir -p %{buildroot}%{_libdir} what is it? Please, remove

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1268703] Review Request: rubygem-powerpack - A few useful extensions to core Ruby classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268703

Ilya Gradina  changed:

   What|Removed |Added

 Blocks||1268758




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1268758
[Bug 1268758] Review Request: rubygem-rubocop - Automatic Ruby code style
checking tool
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1268758] Review Request: rubygem-rubocop - Automatic Ruby code style checking tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268758

Ilya Gradina  changed:

   What|Removed |Added

 Depends On||1268703




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1268703
[Bug 1268703] Review Request: rubygem-powerpack - A few useful extensions
to core Ruby classes
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1268745] Review Request: rubygem-parser - A Ruby parser written in pure Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268745



--- Comment #1 from Ilya Gradina  ---
New Spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-parser.spec
New SRPM:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-parser-2.3.1.2-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372429] Review Request: openjdk-orb - A downstream fork of OpenJDK' s ORB implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372429



--- Comment #7 from gil cattaneo  ---
Thanks for the review!

create new SCM request/s:
https://admin.fedoraproject.org/pkgdb/package/requests/7647
https://admin.fedoraproject.org/pkgdb/package/requests/7648

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372429] Review Request: openjdk-orb - A downstream fork of OpenJDK' s ORB implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372429

Jason Taylor  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372429] Review Request: openjdk-orb - A downstream fork of OpenJDK' s ORB implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372429



--- Comment #6 from gil cattaneo  ---
(In reply to Jason Taylor from comment #5)
> Looks good then, I see you opened a couple of tickets with upstream
> regarding the misc licensing fixes.
> 
> Must and Should components appear to be satisfied. Package approved.
Thanks! Please, set Status field as ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1268744] Review Request: rubygem-ast - A library for working with Abstract Syntax Trees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268744



--- Comment #1 from Ilya Gradina  ---
New Spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-ast.spec
New SRPM:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-ast-2.3.0-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372429] Review Request: openjdk-orb - A downstream fork of OpenJDK' s ORB implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372429

Jason Taylor  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Jason Taylor  ---
Looks good then, I see you opened a couple of tickets with upstream regarding
the misc licensing fixes.

Must and Should components appear to be satisfied. Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1268742] Review Request: rubygem-bacon-colored_output - Colored output for Bacon test framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268742



--- Comment #1 from Ilya Gradina  ---
New Spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-bacon-colored_output.spec
New SRPM:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-bacon-colored_output-1.0.1-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1352408] Review Request: lasem - A library for rendering SVG and Mathml, implementing a DOM like API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352408



--- Comment #16 from Fedora Update System  ---
lasem-0.4.3-4.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372866



--- Comment #10 from gil cattaneo  ---
Build fails. Task info:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15485494

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1126983] Review Request: cereal - Header-only C++11 serialization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1126983

Christoph Junghans  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||jungh...@votca.org
 Resolution|--- |DUPLICATE
Last Closed||2016-09-03 12:14:27



--- Comment #1 from Christoph Junghans  ---


*** This bug has been marked as a duplicate of bug 1372403 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372403] Review Request: cereal - A header-only C++11 serialization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372403

Christoph Junghans  changed:

   What|Removed |Added

 CC||fed...@besser82.io



--- Comment #6 from Christoph Junghans  ---
*** Bug 1126983 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367699] Review Request: python-sphinx-theme-py3doc-enhanced - Theme based on the theme of https:/ /docs.python.org/3/

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367699

Julien Enselme  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-sphinx_py3doc_enhanc |python-sphinx-theme-py3doc-
   |ed_theme - Theme based on   |enhanced - Theme based on
   |the theme of|the theme of
   |https://docs.python.org/3/  |https://docs.python.org/3/



--- Comment #6 from Julien Enselme  ---
* Sat Sep 03 2016 Julien Enselme  - 2.3.2-3
- Change package name to python-sphinx-theme-py3doc-enhanced
- Add provides for python-sphinx_py3doc_enhanced_theme


SRPM:
http://dl.jujens.eu/SRPMS/python-sphinx-theme-py3doc-enhanced-2.3.2-3.fc24.src.rpm
SPEC: http://dl.jujens.eu/SPECS/python-sphinx-theme-py3doc-enhanced.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1264546] Review Request: soletta - A framework for making IoT devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264546



--- Comment #67 from Paulo Andrade  
---
  Hi Gustavo,

  About the changelog, feel free to to how you think is
better.
  For now there isn't much logs in the changelog, but if
you kept that way, soon you could have a really large
changelog :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372866



--- Comment #9 from gil cattaneo  ---
(In reply to Ralf Corsepius from comment #8)
> MUSTFIXES:
> 
> - Package does not honor RPM_OPT_FLAGS:
> Your spec appends Fedora incompatible compilation flags to CFLAGS/CXXFLAGS.
> 
> Remove these 2 lines from your spec:
> export CFLAGS="$RPM_OPT_FLAGS -march=core2"
> export CXXFLAGS="${CFLAGS}"
> 
> - Directory /usr/include/hs/ is unowned.
> Add this directory to *-devel's %files
> 
> - Package ships static libs. 
> This is strongly discouraged in Fedora. Please disable building static libs
> unless there are very strong reasons to ship them.
> 
> - The base package contains files which should be packaged in *-devel,
> instead of the base package.
> %{_libdir}/*.so should go into devel,
> %{_libdir}/*.so.* into 

I agree

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372429] Review Request: openjdk-orb - A downstream fork of OpenJDK' s ORB implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372429



--- Comment #4 from gil cattaneo  ---


(In reply to Jason Taylor from comment #1)
> Hi gil,
> 
> looks like Source0 could be updated to 
> 
> https://github.com/jboss/%{name}/archive/%{name}-%{namedversion}.tar.gz
for me is useless. it should be at the discretion of the packager

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372429] Review Request: openjdk-orb - A downstream fork of OpenJDK' s ORB implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372429



--- Comment #3 from gil cattaneo  ---
(In reply to Jason Taylor from comment #2)
> I don't see a line installing the pom.xml. According to
> https://fedorahosted.org/released/javapackages/doc/ it looks like there
> should be a:
> 
> %mvn_artifact pom.xml

This should be done only when is used an ant build style
all artifacts (pom and jar) are installed with %mvn_install
https://fedorahosted.org/released/javapackages/doc/#ant
https://fedorahosted.org/released/javapackages/doc/#maven
the guideline is not update, now, "%dir %{_javadir}/%{name}" is useless
because is already owned

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372403] Review Request: cereal - A header-only C++11 serialization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372403

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307271] Review Request: vswm - Very Simple Wireless Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307271



--- Comment #10 from Diogo Melo  ---
Hi Giovanni. Thank you for the review. I'm looking into it. I will get back as
soon as possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372403] Review Request: cereal - A header-only C++11 serialization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372403



--- Comment #5 from Christoph Junghans  ---
(In reply to Igor Gnatenko from comment #4)
> (In reply to Christoph Junghans from comment #3)
> > (In reply to Igor Gnatenko from comment #1) 
> > > > %global debug_package %{nil}
> > > BuildArch: noarch
> > Was already there!
> No, spec still has %global debug_package %{nil}
Fixed.

> * %dir %{_datadir}/cmake still not there
Fixed.

New SRPM URL:
https://raw.githubusercontent.com/junghans/fedora-review/master/cereal/cereal-1.2.1-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336552] Review Request: exodusii - Library to store and retrieve transient finite element data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336552



--- Comment #7 from Christoph Junghans  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #6)
> The spec file URL stays the same, but the SRPM should be different due to
> bumped Release field.
Done

New SPRM URL:
https://github.com/junghans/fedora-review/raw/master/exodusii/exodusii-6.02-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368790] Review Request: perl-App-PFT - Hacker friendly static blog generator, command line utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368790



--- Comment #11 from Giovanni  ---
Updates: upgrade of version for sake of README consistency

SRPM:
https://copr-be.cloud.fedoraproject.org/results/dacav/pft/fedora-rawhide-x86_64/00449154-perl-App-PFT/perl-App-PFT-1.0.6-1.fc26.src.rpm

SPEC:
http://copr-dist-git.fedorainfracloud.org/cgit/dacav/pft/perl-App-PFT.git/plain/perl-App-PFT.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367569] Review Request: perl-PFT - Hacker friendly static blog generator, core library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367569



--- Comment #12 from Giovanni  ---
Hi there.

I did a version bump of this package, which has basically the only purpose of
having the README files in sync between upstream and the new spec.

There is no other change except for the version.   

https://github.com/dacav/PFT/commit/bd7d499009fbf5e1dfba479e229db00b6babbeb6

Updated SRPM:
https://copr-be.cloud.fedoraproject.org/results/dacav/pft/fedora-rawhide-x86_64/00449153-perl-PFT/perl-PFT-1.0.4-1.fc26.src.rpm
Updated SPEC:
http://copr-dist-git.fedorainfracloud.org/cgit/dacav/pft/perl-PFT.git/plain/perl-PFT.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361942] Review Request: kf5-akonadi-notes - The Akonadi Notes Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361942

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-09-03 09:35:05



--- Comment #6 from Rex Dieter  ---
imported

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361941] Review Request: kf5-akonadi-mime - The Akonadi Mime Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361941

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-09-03 09:35:30



--- Comment #9 from Rex Dieter  ---
imported

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361940] Review Request: kf5-akonadi-contacts - The Akonadi Contacts Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361940

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-09-03 09:34:35



--- Comment #6 from Rex Dieter  ---
imported

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1268745] Review Request: rubygem-parser - A Ruby parser written in pure Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268745

Ilya Gradina  changed:

   What|Removed |Added

 Blocks||1268758




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1268758
[Bug 1268758] Review Request: rubygem-rubocop - Automatic Ruby code style
checking tool
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1268758] Review Request: rubygem-rubocop - Automatic Ruby code style checking tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268758

Ilya Gradina  changed:

   What|Removed |Added

 Depends On||1268745
  Flags|needinfo?(ilya.gradina@gmai |
   |l.com)  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1268745
[Bug 1268745] Review Request: rubygem-parser - A Ruby parser written in
pure Ruby
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372893] Review Request: python-parquet - Python implementation of the Parquet file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372893

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1372894




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372894
[Bug 1372894] Add parquet plugin
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1372893 (python-parquet)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372893
[Bug 1372893] Review Request: python-parquet - Python implementation of the
Parquet file format
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372893] Review Request: python-parquet - Python implementation of the Parquet file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372893

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1372889 (python-thriftpy),
   ||1372892
   ||(python-backports-csv)
  Alias||python-parquet




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372889
[Bug 1372889] Review Request: python-thriftpy - Pure Python implementation
of Apache Thrift
https://bugzilla.redhat.com/show_bug.cgi?id=1372892
[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3's
csv module for Python 2
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372889] Review Request: python-thriftpy - Pure Python implementation of Apache Thrift

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372889

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1372893 (python-parquet)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372893
[Bug 1372893] Review Request: python-parquet - Python implementation of the
Parquet file format
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372893] New: Review Request: python-parquet - Python implementation of the Parquet file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372893

Bug ID: 1372893
   Summary: Review Request: python-parquet - Python implementation
of the Parquet file format
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-parquet.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-parquet-1.1-1.fc26.src.rpm
Description:
Python implementation of the Parquet file format.

It comes with a script for reading parquet files and outputting the data to
stdout as JSON or TSV (without the overhead of JVM startup).
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3' s csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1372890
  Alias||python-backports-csv




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372890
[Bug 1372890] Provide python3-backports subpkg
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372892] New: Review Request: python-backports-csv - Backport of Python 3's csv module for Python 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372892

Bug ID: 1372892
   Summary: Review Request: python-backports-csv - Backport of
Python 3's csv module for Python 2
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-backports-csv.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-backports-csv-1.0.1-1.fc26.src.rpm
Description:
Backport of Python 3's csv module for Python 2.

The API of the csv module in Python 2 is drastically different from the
csv module in Python 3. This is due, for the most part, to the difference
between str in Python 2 and Python 3.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367699] Review Request: python-sphinx_py3doc_enhanced_theme - Theme based on the theme of https:/ /docs.python.org/3/

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367699



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
Yeah, that sounds good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336552] Review Request: exodusii - Library to store and retrieve transient finite element data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336552



--- Comment #6 from Dominik 'Rathann' Mierzejewski  ---
The spec file URL stays the same, but the SRPM should be different due to
bumped Release field.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336552] Review Request: exodusii - Library to store and retrieve transient finite element data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336552



--- Comment #5 from Dominik 'Rathann' Mierzejewski  ---
After each change during review process, you should increase the Release:
field, describe the changes in %changelog and post a new set of URLs for the
spec file and the SRPM. That way, fedora-review can be run again on the new
files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372888] Review Request: python-toro - Synchronization primitives for Tornado coroutines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372888

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1372886, 1372887




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372886
[Bug 1372886] Rudimentary ceritifi requires in requires.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1372887
[Bug 1372887] Missing Requires: python-backports-ssl_match_hostname
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372888] Review Request: python-toro - Synchronization primitives for Tornado coroutines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372888

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1372889 (python-thriftpy)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372889
[Bug 1372889] Review Request: python-thriftpy - Pure Python implementation
of Apache Thrift
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372889] Review Request: python-thriftpy - Pure Python implementation of Apache Thrift

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372889

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1372888 (python-toro)
  Alias||python-thriftpy




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372888
[Bug 1372888] Review Request: python-toro - Synchronization primitives for
Tornado coroutines
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372889] New: Review Request: python-thriftpy - Pure Python implementation of Apache Thrift

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372889

Bug ID: 1372889
   Summary: Review Request: python-thriftpy - Pure Python
implementation of Apache Thrift
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-thriftpy.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-thriftpy-0.3.9-1.fc26.src.rpm
Description:
ThriftPy is a pure python implementation of Apache Thrift in a pythonic way.

The official thrift python lib is not pythonic at all, it needs a complicated
process of installation, and the generated sdk is very ugly. Everytime the
thrift file changed you have to re-generate the sdk which causes more pain
in development.

ThriftPy helps that, it’s compatible with Apache Thrift so you no longer
need to install ‘thrift’ package, it can import thrift file on the fly so
you no longer need to re-generate the sdk again and again and again.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372454] Review Request: bwrap-oci - Run OCI containers with bubblewrap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372454

Daniel Walsh  changed:

   What|Removed |Added

 CC||dwa...@redhat.com



--- Comment #6 from Daniel Walsh  ---
Good job.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372888] New: Review Request: python-toro - Synchronization primitives for Tornado coroutines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372888

Bug ID: 1372888
   Summary: Review Request: python-toro - Synchronization
primitives for Tornado coroutines
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-toro.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-toro-1.0.1-1.fc26.src.rpm
Description:
Toro provides to Tornado coroutines a set of locking primitives and queues
analogous to those that Gevent provides to Greenlets, or that the standard
library provides to threads.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372888] Review Request: python-toro - Synchronization primitives for Tornado coroutines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372888

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||python-toro



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372881] New: Review Request: nodejs-stream-shift - Returns the next buffer/object in a stream' s readable queue

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372881

Bug ID: 1372881
   Summary: Review Request: nodejs-stream-shift - Returns the next
buffer/object in a stream's readable queue
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://pnemade.fedorapeople.org//nodejs-stream-shift.spec
SRPM URL:
http://pnemade.fedorapeople.org//nodejs-stream-shift-1.0.0-1.fc25.src.rpm

Description:
Returns the next buffer/object in a stream's readable queue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372881] Review Request: nodejs-stream-shift - Returns the next buffer/object in a stream' s readable queue

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372881



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=15479773

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372403] Review Request: cereal - A header-only C++11 serialization library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372403



--- Comment #4 from Igor Gnatenko  ---
(In reply to Christoph Junghans from comment #3)
> (In reply to Igor Gnatenko from comment #1) 
> > > %global debug_package %{nil}
> > BuildArch: noarch
> Was already there!
No, spec still has %global debug_package %{nil}

* %dir %{_datadir}/cmake still not there

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1308985] Review Request: vulkan - Vulkan loader and validation layers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308985

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|ignate...@redhat.com|nob...@fedoraproject.org



--- Comment #15 from Igor Gnatenko  ---
> Source0:  vulkan.tar.xz
> Source1:  glslang.tar.xz
using URLs please

> Group:System Environment/Libraries
> Group:Development/Libraries
> Group:System Environment/Base
not needed

> Requires: %{name} = %{version}-%{release}
missing %{?_isa}

> %doc LICENSE.txt
%license please

> #BuildArch:   noarch
looks like it owns only noarch directories, so you can uncomment this.

sorry, but I don't have enough free time to continue with this Review Request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org