[Bug 1379460] Review Request: kompose - Tool to move from `docker-compose` to Kubernetes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379460

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #9 from Fedora Update System  ---
kompose-0.1.0-0.1.git8227684.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-26445cfcfe

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364194] Review Request: pintail - Build web sites from Mallard sources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364194



--- Comment #14 from Fedora Update System  ---
pintail-0.3-1.20160805git6f2daf7.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-249e1f83f6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364194] Review Request: pintail - Build web sites from Mallard sources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364194



--- Comment #13 from Fedora Update System  ---
pintail-0.3-1.20160805git6f2daf7.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9460866789

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379709] Review Request: python-epi - Tool for looking at the entry point plugins on a system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379709



--- Comment #8 from Fedora Update System  ---
python-epi-0.1-3.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9032512284

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196037] Review Request: google-http-java-client - Google HTTP Client Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196037

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196037] Review Request: google-http-java-client - Google HTTP Client Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196037



--- Comment #11 from gil cattaneo  ---
Thanks for the review!

create new SCM request:
https://admin.fedoraproject.org/pkgdb/package/requests/8065

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from gil cattaneo  ---
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379091] Review Request: python-QtPy - Provides an abstraction layer on top of the various Qt bindings (PyQt5, PyQt4 and PySide) and additional custom QWidgets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379091



--- Comment #15 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-QtPy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104



--- Comment #7 from Jon Ciesla  ---
Upstream answered.

https://github.com/jaraco/skeleton/issues/1

They said no.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196037] Review Request: google-http-java-client - Google HTTP Client Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196037

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Jon Ciesla  ---
- rpmlint checks return:

The package contains no documentation (README, doc, etc). You have to include
documentation files.

Would be nice but may not exist individually for each subpackage.

- package meets naming guidelines
- package meets packaging guidelines
- license ( ASL 2.0 ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 


Very clean.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380671] Review Request: python-jcconv - JapaneseCharacterCONVerter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380671



--- Comment #3 from Mukundan Ragavan  ---


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 6 files have unknown license. Detailed
 output of licensecheck in
 /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1380671-python-
 jcconv/licensecheck.txt

---> Missing license already mentioned to upstream as per changelog.


[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-jcconv , python3-jcconv
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve 

[Bug 1380671] Review Request: python-jcconv - JapaneseCharacterCONVerter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380671

Mukundan Ragavan  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #4 from Mukundan Ragavan  ---
Nothing to complain here.

Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379091] Review Request: python-QtPy - Provides an abstraction layer on top of the various Qt bindings (PyQt5, PyQt4 and PySide) and additional custom QWidgets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379091



--- Comment #14 from Mukundan Ragavan  ---
Thanks for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379091] Review Request: python-QtPy - Provides an abstraction layer on top of the various Qt bindings (PyQt5, PyQt4 and PySide) and additional custom QWidgets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379091

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379091] Review Request: python-QtPy - Provides an abstraction layer on top of the various Qt bindings (PyQt5, PyQt4 and PySide) and additional custom QWidgets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379091



--- Comment #13 from Mukundan Ragavan  ---
(In reply to gil cattaneo from comment #12)
> Remain these problems:
> [!]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "BSD (3 clause)", "Unknown or generated". 24 files have unknown
>  license. Detailed output of licensecheck in /home/gil/1379091-python-
>  QtPy/licensecheck.txt
>   License:MIT and BSD
> 
> License: BSD.
> ./qtpy/_patch/qcombobox.py

Fixed.


> 
> [?]: Package contains no bundled libraries without FPC exception.
> ./qtpy/_patch/qcombobox.py PyQt4 ... ?


This is not a bundled library. This is code that spyder folks adapted from
qt-helpers.

Please see the relevant sources here - 

qtpy; qcombobox.py 

https://github.com/spyder-ide/qtpy/blob/master/qtpy/_patch/qcombobox.py


qt-helpers

https://github.com/glue-viz/qt-helpers/blob/master/qt_helpers.py


So, this should not be an issue.


+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=+=


Spec URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtPy/python-QtPy.spec
SRPM URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtPy/python-QtPy-1.1.2-5.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380140] Review Request: language-detector - Language Detection Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380140

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376207] Review Request: python-fedmsg-atomic-composer - Composes atomic trees when Fedora repositories are updated

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376207



--- Comment #15 from Fedora Update System  ---
python-fedmsg-atomic-composer-2016.2-2.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #35 from l...@us.ibm.com ---
COPR output: https://copr.fedorainfracloud.org/coprs/honclo/TSS2/build/458951

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



--- Comment #16 from Fedora Update System  ---
kf5-kirigami-1.1.0-3.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-aa4b40fb1e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364194] Review Request: pintail - Build web sites from Mallard sources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364194

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #12 from Fedora Update System  ---
pintail-0.3-1.20160805git6f2daf7.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f9c789f707

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379709] Review Request: python-epi - Tool for looking at the entry point plugins on a system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379709



--- Comment #7 from Fedora Update System  ---
python-epi-0.1-3.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8a526e322c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372938] Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938



--- Comment #26 from Fedora Update System  ---
libXfont2-2.0.1-2.fc25, xorg-x11-drivers-7.7-18.fc25,
xorg-x11-drv-amdgpu-1.1.2-3.20160929git97d7386c.fc25,
xorg-x11-drv-armsoc-1.4.0-3.20160929.fc25,
xorg-x11-drv-ati-7.7.1-1.20160928git3fc839ff.fc25,
xorg-x11-drv-dummy-0.3.6-26.fc25, xorg-x11-drv-evdev-2.10.3-2.fc25,
xorg-x11-drv-fbdev-0.4.3-25.fc25, xorg-x11-drv-fbturbo-0.5.1-0.8.20150221.fc25,
xorg-x11-drv-freedreno-1.4.0-3.20160929.fc25,
xorg-x11-drv-geode-2.11.18-2.fc25,
xorg-x11-drv-intel-2.99.917-26.20160929.fc25,
xorg-x11-drv-ivtv-1.2.0-0.22.fc25,
xorg-x11-drv-libinput-0.19.1-2.20160929.fc25,
xorg-x11-drv-nouveau-1.0.13-1.fc25, xorg-x11-drv-omap-0.4.4-3.fc25,
xorg-x11-drv-openchrome-0.5.0-2.fc25, xorg-x11-drv-opentegra-0.7.0-8.fc25,
xorg-x11-drv-qxl-0.1.4-9.20160929gite13d28ee.fc25,
xorg-x11-drv-sisusb-0.9.6-24.fc25,
xorg-x11-drv-synaptics-1.8.99.1-2.20160929git48632211.fc25,
xorg-x11-drv-v4l-0.2.0-47.fc25, xorg-x11-drv-vesa-2.3.2-25.fc25,
xorg-x11-drv-vmware-13.0.2-12.20150211git8f0cf7c.fc25,
xorg-x11-drv-voodoo-1.2.5-25.fc25,
xorg-x11-drv-wacom-0.33.0-2.20160929gitb61d1711.fc25,
xorg-x11-font-utils-7.5-32.fc25, xorg-x11-proto-devel-7.7-20.fc25,
xorg-x11-server-1.19.0-0.1.20160929.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a5c3ebe67a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243



--- Comment #13 from Fedora Update System  ---
execdb-0.0.7-5.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2a012e4d1a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104



--- Comment #6 from gil cattaneo  ---
(In reply to Jon Ciesla from comment #5)
> https://github.com/jaraco/backports.functools_lru_cache/issues/8

we should wait until upstream will not give us an answer?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104



--- Comment #5 from Jon Ciesla  ---
https://github.com/jaraco/backports.functools_lru_cache/issues/8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196037] Review Request: google-http-java-client - Google HTTP Client Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196037

Jon Ciesla  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||limburg...@gmail.com
   Assignee|nob...@fedoraproject.org|limburg...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104



--- Comment #4 from Jon Ciesla  ---
(In reply to gil cattaneo from comment #3)
> have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1196037 ?

Sure!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104



--- Comment #3 from gil cattaneo  ---
have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1196037 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104



--- Comment #2 from gil cattaneo  ---
Issues:
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 7 files have unknown license. Detailed
 output of licensecheck in /home/gil/1380104-python-backports-
 functools_lru_cache/licensecheck.txt
 All source file are without license headers. Please, ask to upstream to
confirm
 the licensing of code and/or content/s, and add license headers


https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[!]: License file installed when any subpackage combination is installed.

[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
https://github.com/jaraco/backports.functools_lru_cache/issues

[!]: Package does not include license text files separate from upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #1 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 7 files have unknown license. Detailed
 output of licensecheck in /home/gil/1380104-python-backports-
 functools_lru_cache/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python3.5/site-
 packages(system-python-libs), /usr/lib/python3.5/site-
 packages/backports(python3-configparser), /usr/lib/python2.7/site-
 packages/backports(python-backports)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
https://github.com/jaraco/backports.functools_lru_cache/issues
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
 -backports-functools_lru_cache , python3-backports-functools_lru_cache
[x]: Package functions as described.
[x]: 

[Bug 1380540] Review Request: votca-xtp - VOTCA excitation and charge properties module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380540



--- Comment #1 from Christoph Junghans  ---
Triggered another rebuild:
Spec URL: http://junghans.github.io/fedora-review/votca-xtp/votca-xtp.spec
SRPM URL:
http://junghans.github.io/fedora-review/votca-xtp/votca-xtp-1.4-0.1rc1.fc26.src.rpm
Review.txt: http://junghans.github.io/fedora-review/votca-xtp/review.txt
Build log: https://travis-ci.org/junghans/fedora-review/builds/164092056
Raw Build log:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/164092057/log.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380826] Review Request: pgadmin4 - Management tool for PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380826



--- Comment #1 from Devrim GÜNDÜZ  ---
For the records, the following packages either needs to be updated or added for
pgadmin4 to work:

Fedora 24:

babel
django-htmlmin
python-dateutil
python-fixtures
python-flask
python-flask-babel
python-flask-gravatar
python-flask-login
python-flask-mail
python-flask-principal
python-flask-security
python-flask-sqlalchemy
python-flask-wtf
python-mimeparse
python-pyrsistent
python-simplejson
python-wsgiref
python-wtforms

EPEL 7:
babel
django-htmlmin
python-beautifulsoup4
python-dateutil
python-fixtures
python-flask
python-flask-babel
python-flask-gravatar
python-flask-login
python-flask-mail
python-flask-principal
python-flask-security
python-flask-sqlalchemy
python-flask-wtf
python-jinja2
python-markupsafe
python-mimeparse
python-pyrsistent
python-simplejson
python-sqlalchemy
python-sqlparse
python-werkzeug
python-wsgiref
python-wtforms
pytz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380420] Review Request: gomtree - Go CLI tool for mtree support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380420



--- Comment #2 from Lokesh Mandvekar  ---
(In reply to Jan Chaloupka from comment #1)
> Change 
> 
> %gobuild -o bin/%{name} %{import_path}
> 
> to
> 
> %gobuild -o bin/%{name} %{import_path}/cmd/gomtree
> 
> Otherwise rpmlint complains about shebang. Otherwise LGTM:

No big deal to me either way, but just curious where you're seeing this in
rpmlint. I don't seem to see this anywhere. I'm on rawhide if it matters. See: 

$ rpmlint SRPMS/gomtree-0-0.1.git8c6b32c.fc26.src.rpm RPMS/* gomtree.spec
gomtree.src: W: spelling-error Summary(en_US) mtree -> tree, m tree
gomtree.src: W: spelling-error %description -l en_US mtree -> tree, m tree
gomtree-devel.noarch: W: spelling-error Summary(en_US) mtree -> tree, m tree
gomtree-devel.noarch: W: spelling-error %description -l en_US mtree -> tree, m
tree
gomtree-devel.noarch: W: spelling-error %description -l en_US github -> git
hub, git-hub, GitHub
gomtree.x86_64: W: spelling-error Summary(en_US) mtree -> tree, m tree
gomtree.x86_64: W: spelling-error %description -l en_US mtree -> tree, m tree
gomtree.x86_64: W: binaryinfo-readelf-failed /usr/bin/gomtree 
gomtree.x86_64: W: no-manual-page-for-binary gomtree
gomtree-unit-test-devel.x86_64: W: spelling-error %description -l en_US github
-> git hub, git-hub, GitHub
gomtree-unit-test-devel.x86_64: W: spelling-error %description -l en_US mtree
-> tree, m tree
4 packages and 1 specfiles checked; 0 errors, 11 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1254799] Review Request: pgbadger - A fast PostgreSQL log analyzer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1254799



--- Comment #2 from Devrim GÜNDÜZ  ---
(In reply to Eduardo Mayorga from comment #1)
> SRPM URL returns 404 Not Found.

Updated to 9.0:

Spec URL: https://devrim.fedorapeople.org/pgbadger/pgbadger.spec
SRPM URL: https://devrim.fedorapeople.org/pgbadger/pgbadger-9.0-1.f24.src.rpm

Thanks!

Regards, Devrim

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380826] Review Request: pgadmin4 - Management tool for PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380826

Devrim GÜNDÜZ  changed:

   What|Removed |Added

 Depends On||1352188




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1352188
[Bug 1352188] FutureFeature: Package PGAdmin4
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380826] New: Review Request: pgadmin4 - Management tool for PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380826

Bug ID: 1380826
   Summary: Review Request: pgadmin4 - Management tool for
PostgreSQL
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: dev...@gunduz.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: 
SRPM URL: 


Spec URL: https://devrim.fedorapeople.org/pgadmin4/pgadmin4.spec
SRPM URL: https://devrim.fedorapeople.org/pgadmin4/pgadmin4-1.0-1.f24.src.rpm
Description: pgAdmin 4 is a rewrite of the popular pgAdmin3 management tool for
the PostgreSQL
(http://www.postgresql.org) database.
pgAdmin 4 is written as a web application in Python, using jQuery and Bootstrap
for the client side processing and UI. On the server side, Flask is being
utilised.

Although developed using web technologies, we intend for pgAdmin 4 to be usable
either on a web server using a browser, or standalone on a workstation. The
runtime/ subdirectory contains a QT based runtime application intended to allow
this - it is essentially a browser and Python interpretor in one package which
will be capable of hosting the Python application and presenting it to the user
as a desktop application.

Fedora Account System Username:devrim

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1254799] Review Request: pgbadger - A fast PostgreSQL log analyzer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1254799

Eduardo Mayorga  changed:

   What|Removed |Added

 CC||e...@mayorgalinux.com



--- Comment #1 from Eduardo Mayorga  ---
SRPM URL returns 404 Not Found.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380105] Review Request: mingw-libdb - MinGW build of The Berkeley DB database library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380105



--- Comment #2 from Neal Gompa  ---
Wow, I got them backwards...

Spec URL: http://kinginuyasha.enanocms.org/downloads/mingw-libdb.spec
SRPM URL:
http://kinginuyasha.enanocms.org/downloads/mingw-libdb-5.3.28-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379091] Review Request: python-QtPy - Provides an abstraction layer on top of the various Qt bindings (PyQt5, PyQt4 and PySide) and additional custom QWidgets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379091



--- Comment #12 from gil cattaneo  ---
Remain these problems:
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 24 files have unknown
 license. Detailed output of licensecheck in /home/gil/1379091-python-
 QtPy/licensecheck.txt
  License:MIT and BSD

License: BSD.
./qtpy/_patch/qcombobox.py

[?]: Package contains no bundled libraries without FPC exception.
./qtpy/_patch/qcombobox.py PyQt4 ... ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373218] Review Request: zstd - Zstd compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373218



--- Comment #10 from Pádraig Brady  ---
Yes I intend to update epel branches also

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310873



--- Comment #16 from Fedora Update System  ---
rubygem-async_sinatra-1.2.1-3.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380178] Review Request: zsh-grml - Configuration files for zsh from the Grml project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380178



--- Comment #3 from Raphael Groner  ---
A better idea is try to get a package for oh-my-zsh:
https://github.com/robbyrussell/oh-my-zsh

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-09-23 10:04:56 |2016-09-30 11:51:44



--- Comment #15 from Fedora Update System  ---
kf5-kirigami-1.1.0-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1329838] Review Request: ghc-uglymemo - A simple (but internally ugly ) memoization function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329838



--- Comment #15 from Fedora Update System  ---
ghc-uglymemo-0.1.0.1-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354113



--- Comment #17 from Fedora Update System  ---
python-pytest-catchlog-1.2.2-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1360587] Review Request: rsyntaxtextarea - A syntax highlighting, code folding text editor for Java Swing applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360587



--- Comment #12 from Fedora Update System  ---
rsyntaxtextarea-2.5.8-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374035] Review Request: pimd - The original PIM-SM multicast routing daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374035



--- Comment #12 from Fedora Update System  ---
pimd-2.3.2-3.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373218] Review Request: zstd - Zstd compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373218

Ken Dreyer (Red Hat)  changed:

   What|Removed |Added

 CC||kdre...@redhat.com



--- Comment #9 from Ken Dreyer (Red Hat)  ---
This package will help Ceph (https://github.com/ceph/ceph/pull/11156). Thanks
for packaging it. I've verified that zstd-1.1.0-1.fc23.src.rpm builds fine in
Mock for EPEL 7, too (are you going to maintain it there)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377762] Review Request: opendht - A lightweight C++11 Distributed Hash Table implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377762



--- Comment #2 from Benjamin Lefoul  ---
Now builds for EPEL7 (since msgpack does too):

http://koji.fedoraproject.org/koji/taskinfo?taskID=15875241

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-QtAwesome

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373782] Review Request: mingw-cmocka - MinGW Lightweight library to simplify and generalize unit tests for C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373782



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/mingw-cmocka

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368790] Review Request: perl-App-PFT - Hacker friendly static blog generator, command line utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368790



--- Comment #15 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-App-PFT

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379094] Review Request: python-flit - Simplified packaging of Python modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379094



--- Comment #14 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-flit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380671] Review Request: python-jcconv - JapaneseCharacterCONVerter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380671

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||nonamed...@gmail.com
   Assignee|nob...@fedoraproject.org|nonamed...@gmail.com



--- Comment #2 from Mukundan Ragavan  ---
taken

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379092] Review Request: python-QtAwesome - FontAwesome icons in PyQt and PySide applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379092



--- Comment #8 from Mukundan Ragavan  ---
Many thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377762] Review Request: opendht - A lightweight C++11 Distributed Hash Table implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377762

Benjamin Lefoul  changed:

   What|Removed |Added

 Whiteboard||Trivial



--- Comment #1 from Benjamin Lefoul  ---
I believe all requirements for "Trivial" whiteboarding are met. Rpmlint may
warn about a few tabs here and there. They will be removed eventually. License
is quite clearly a vanilla GPLv3.

FROM: https://fedoraproject.org/wiki/Package_Review_Process
The "Trivial" status is intended to indicate packages which, as an aid to new
reviewers, are especially uncomplicated and easy to review. A ticket should not
be marked as being trivial unless:

The package is known to build and a link to a scratch build is included.
The ticket explains any rpmlint output which is present.
The spec contains nothing which is unnecessary in modern Fedora (such as
BuildRoot:, a %clean section or %defattr).
The spec is free from excessive or complicated macro usage.
The spec uses only the least complicated scriptlets which are taken
directly from the Packaging:Scriptlets page.
The package contains no daemons.
The package is not especially security sensitive.
The code has undergone a thorough inspection for licensing issues.
Anomalies which would be found by licensecheck should be explained. 

In short, this should be reserved only for those tickets which should be easily
approachable by someone doing their first package review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379091] Review Request: python-QtPy - Provides an abstraction layer on top of the various Qt bindings (PyQt5, PyQt4 and PySide) and additional custom QWidgets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379091



--- Comment #11 from Mukundan Ragavan  ---
(In reply to gil cattaneo from comment #8)
> Maybe you could add %doc CHANGELOG.md README.md for each pythonX sub packages

done.


Spec URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtPy/python-QtPy.spec
SRPM URL:
https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtPy/python-QtPy-1.1.2-4.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380140] Review Request: language-detector - Language Detection Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380140

Mukundan Ragavan  changed:

   What|Removed |Added

 CC||nonamed...@gmail.com
   Assignee|nob...@fedoraproject.org|nonamed...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379091] Review Request: python-QtPy - Provides an abstraction layer on top of the various Qt bindings (PyQt5, PyQt4 and PySide) and additional custom QWidgets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379091



--- Comment #10 from Mukundan Ragavan  ---
(In reply to gil cattaneo from comment #9)
> have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1380140 ?
> thanks in advance

Yes of couse. Taken,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380671] Review Request: python-jcconv - JapaneseCharacterCONVerter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380671



--- Comment #1 from Björn "besser82" Esser  ---
Updated package:

Koji Build:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=15872194


Urls:

  Spec URL:  https://besser82.fedorapeople.org/review/python-jcconv.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/python-jcconv-0.2.3-0.2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380442] Review Request: ripgrep - A search tool that combines the usability of ag with the raw speed of grep

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380442

Benjamin Lefoul  changed:

   What|Removed |Added

 Whiteboard||BuildFails



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380442] Review Request: ripgrep - A search tool that combines the usability of ag with the raw speed of grep

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380442

Benjamin Lefoul  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380442] Review Request: ripgrep - A search tool that combines the usability of ag with the raw speed of grep

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380442

Benjamin Lefoul  changed:

   What|Removed |Added

 CC||benjamin.lef...@nwise.se
   Assignee|nob...@fedoraproject.org|benjamin.lef...@nwise.se



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380671] Review Request: python-jcconv - JapaneseCharacterCONVerter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380671

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1379432 (odoo)
  Alias||python-jcconv




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1379432
[Bug 1379432] Review Request: odoo - Suite of web based open source
business apps
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380671] New: Review Request: python-jcconv - JapaneseCharacterCONVerter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380671

Bug ID: 1380671
   Summary: Review Request: python-jcconv -
JapaneseCharacterCONVerter
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@besser82.io
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description:

  JapaneseCharacterCONVerter - inter-convert hiragana, katakana,
  half-width kana.


Koji Build:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=15871370


Issues:

  no known issues, but some false positives about spelling from rpmlint.


FAS-User:

  besser82


Urls:

  Spec URL:  https://besser82.fedorapeople.org/review/python-jcconv.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/python-jcconv-0.2.3-0.1.fc26.src.rpm


Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432

Björn "besser82" Esser  changed:

   What|Removed |Added

 Depends On||1380671 (python-jcconv)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1380671
[Bug 1380671] Review Request: python-jcconv - JapaneseCharacterCONVerter
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373782] Review Request: mingw-cmocka - MinGW Lightweight library to simplify and generalize unit tests for C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373782

Jakub Hrozek  changed:

   What|Removed |Added

  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373782] Review Request: mingw-cmocka - MinGW Lightweight library to simplify and generalize unit tests for C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373782



--- Comment #7 from Jakub Hrozek  ---
Thank you, the package now looks good to me and fedora-review doesn't complain
anymore (well, it does, but I think the complains are now coming from not
understanding mingw packages). The package also builds in mock.

I haven't tried the functionality to be honest, but I trust you did :)

So I'm approving the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380420] Review Request: gomtree - Go CLI tool for mtree support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380420

Jan Chaloupka  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 QA Contact|extras...@fedoraproject.org |jchal...@redhat.com



--- Comment #1 from Jan Chaloupka  ---
Change 

%gobuild -o bin/%{name} %{import_path}

to

%gobuild -o bin/%{name} %{import_path}/cmd/gomtree

Otherwise rpmlint complains about shebang. Otherwise LGTM:

After the change:

$ rpmlint gomtree-0-0.1.git8c6b32c.fc20.src.rpm
gomtree-0-0.1.git8c6b32c.fc20.x86_64.rpm
gomtree-devel-0-0.1.git8c6b32c.fc20.noarch.rpm
gomtree-unit-test-devel-0-0.1.git8c6b32c.fc20.x86_64.rpm
gomtree.src: W: spelling-error Summary(en_US) mtree -> tree, m tree
gomtree.src: W: spelling-error %description -l en_US mtree -> tree, m tree
gomtree.x86_64: W: spelling-error Summary(en_US) mtree -> tree, m tree
gomtree.x86_64: W: spelling-error %description -l en_US mtree -> tree, m tree
gomtree.x86_64: W: unstripped-binary-or-object /usr/bin/gomtree
gomtree.x86_64: W: no-manual-page-for-binary gomtree
gomtree-devel.noarch: W: spelling-error Summary(en_US) mtree -> tree, m tree
gomtree-devel.noarch: W: spelling-error %description -l en_US mtree -> tree, m
tree
gomtree-devel.noarch: W: spelling-error %description -l en_US github -> git
hub, git-hub, thuggish
gomtree-unit-test-devel.x86_64: W: spelling-error %description -l en_US github
-> git hub, git-hub, thuggish
gomtree-unit-test-devel.x86_64: W: spelling-error %description -l en_US mtree
-> tree, m tree
4 packages and 0 specfiles checked; 0 errors, 11 warnings.

$ gofed lint
W: Incorrect package name gomtree, should be golang-github-vbatts-go-mtree
1 golang specfile checked; 0 errors, 1 warnings.

You can ignore the warning, it is recommendation only.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373782] Review Request: mingw-cmocka - MinGW Lightweight library to simplify and generalize unit tests for C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373782



--- Comment #6 from Nikos Mavrogiannopoulos  ---
I've updated (overwritten) packages to address that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368790] Review Request: perl-App-PFT - Hacker friendly static blog generator, command line utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368790



--- Comment #14 from Parag AN(पराग)  ---
Thanks. Looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1126308] Review Request: datamash - Performs basic numeric, textual and statistical operations in command-line

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1126308

Daiki Ueno  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |WONTFIX
  Flags||fedora-review-
Last Closed||2016-09-30 03:15:59




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368790] Review Request: perl-App-PFT - Hacker friendly static blog generator, command line utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368790



--- Comment #13 from Giovanni  ---
Fixed.

SRPM:
https://copr-be.cloud.fedoraproject.org/results/dacav/pft/fedora-rawhide-x86_64/00459295-perl-App-PFT/perl-App-PFT-1.0.6-2.fc26.src.rpm

SPEC:
http://copr-dist-git.fedorainfracloud.org/cgit/dacav/pft/perl-App-PFT.git/plain/perl-App-PFT.spec?id=c7bfc2d852e70ba5736e0f86d5ff837e3722bedd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org