[Bug 1396790] New: Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790

Bug ID: 1396790
   Summary: Review Request: gnome-shell-extension-freon - GNOME
Shell extension to display system temperature,
voltage, and fan speed
   Product: Fedora
   Version: 24
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: and...@tosk.in
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://gitlab.com/terrycloth/packaging-gnome-shell-extension-freon/raw/master/gnome-shell-extension-freon.spec

SRPM URL:
https://andrew.tosk.in/tmp/gnome-shell-extension-freon-22-1.fc24.src.rpm

Description: Freon is forked from gnome-shell-extension-sensors. Freon is a
GNOME Shell extension for displaying CPU temperature, hard disk or solid state
temperatures, video card temperature (NVIDIA, Catalyst, and Bumblebee
supported), power supply voltage, and fan RPM. You can choose which HDD/SSD or
other devices to include, what temperature units to use, and how often to
refresh the sensors readout, and they will appear in the GNOME Shell top bar.

Fedora Account System Username: terrycloth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382928] Review Request: perl-HTTP-Entity-Parser - PSGI compliant HTTP Entity Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382928



--- Comment #5 from Fedora Update System  ---
perl-HTTP-Entity-Parser-0.18-2.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-030fe5a9b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382928] Review Request: perl-HTTP-Entity-Parser - PSGI compliant HTTP Entity Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382928

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273



--- Comment #14 from Fedora Update System  ---
python-wcsaxes-0.9-3.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-884992496e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Sergio Monteiro Basto  changed:

   What|Removed |Added

 CC||ser...@serjux.com



--- Comment #19 from Sergio Monteiro Basto  ---
Hi,

(In reply to Karel Volný from comment #10) 
> meanwhile, the license got simplified, however still I'm unsure how is it
> treated in Fedora, so I've resent a question to
> le...@lists.fedoraproject.org today

first it accepted by Fedora legal or not ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350884] Review Request: mspgcc - Rebase of GCC for the MSP430 to TI / Red Hat upstream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350884

Till Maas  changed:

   What|Removed |Added

 CC||opensou...@till.name



--- Comment #5 from Till Maas  ---
Hi Brandon, would you please consider unofficially reviewing other review
requests to show that you know the packaging guidelines and link the reviews
here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395396] Review Request: python-sphinx_gallery - Sphinx extension to automatically generate an examples gallery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395396



--- Comment #2 from Orion Poplawski  ---
Spec URL: https://www.cora.nwra.com/~orion/fedora/python-sphinx-gallery.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python-sphinx-gallery-0.1.5-2.fc26.src.rpm

* Sat Nov 19 2016 Orion Poplawski  - 0.1.5-2
- Use github source, ship LICENSE
- Update URL
- Add needed requires

Good catch on all counts.  I went for adding a sphinx requirement as it does
not seem useful without it, although it doesn't appear to directly import
anything from it.  It is listed in requirements.txt.

But now I'm getting some test failures:

+ nosetests-2.7
/usr/lib64/python2.7/site-packages/matplotlib/font_manager.py:279: UserWarning:
Matplotlib is building the font cache using fc-list. This may take a moment.
  warnings.warn('Matplotlib is building the font cache using fc-list. This may
take a moment.')
.../builddir/build/BUILD/sphinx-gallery-0.1.5/sphinx_gallery/gen_rst.py:538:
UserWarning:

/tmp/tmp1xCZ4j/raise.py failed to execute correctly:Traceback (most recent call
last):
  File "/builddir/build/BUILD/sphinx-gallery-0.1.5/sphinx_gallery/gen_rst.py",
line 518, in execute_code_block
exec(code_block, example_globals)
  File "", line 1, in 
NameError: name 'First_test_fail' is not defined


  warnings.warn(fail_example_warning)


+ nosetests-3.5
/usr/lib64/python3.5/site-packages/matplotlib/font_manager.py:279: UserWarning:
Matplotlib is building the font cache using fc-list. This may take a moment.
  warnings.warn('Matplotlib is building the font cache using fc-list. This may
take a moment.')
/usr/lib64/python3.5/site-packages/matplotlib/font_manager.py:279: UserWarning:
Matplotlib is building the font cache using fc-list. This may take a moment.
  warnings.warn('Matplotlib is building the font cache using fc-list. This may
take a moment.')
...EE..S...
==
ERROR: Test that failing examples are only executed until failing block
--
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
self.test(*self.arg)
  File
"/builddir/build/BUILD/sphinx-gallery-0.1.5/sphinx_gallery/tests/test_gen_rst.py",
line 159, in test_fail_example
gallery_conf['examples_dir'], gallery_conf)
  File "/builddir/build/BUILD/sphinx-gallery-0.1.5/sphinx_gallery/gen_rst.py",
line 599, in generate_file_rst
if md5sum_is_current(example_file):
  File "/builddir/build/BUILD/sphinx-gallery-0.1.5/sphinx_gallery/gen_rst.py",
line 290, in md5sum_is_current
src_md5 = get_md5sum(src_file)
  File "/builddir/build/BUILD/sphinx-gallery-0.1.5/sphinx_gallery/gen_rst.py",
line 277, in get_md5sum
src_content = src_data.read()
  File "/usr/lib64/python3.5/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 99:
ordinal not in range(128)

==
ERROR: Test if only examples matching pattern are executed
--
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
self.test(*self.arg)
  File
"/builddir/build/BUILD/sphinx-gallery-0.1.5/sphinx_gallery/tests/test_gen_rst.py",
line 192, in test_pattern_matching
gallery_conf['examples_dir'], gallery_conf)
  File "/builddir/build/BUILD/sphinx-gallery-0.1.5/sphinx_gallery/gen_rst.py",
line 599, in generate_file_rst
if md5sum_is_current(example_file):
  File "/builddir/build/BUILD/sphinx-gallery-0.1.5/sphinx_gallery/gen_rst.py",
line 290, in md5sum_is_current
src_md5 = get_md5sum(src_file)
  File "/builddir/build/BUILD/sphinx-gallery-0.1.5/sphinx_gallery/gen_rst.py",
line 277, in get_md5sum
src_content = src_data.read()
  File "/usr/lib64/python3.5/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 99:
ordinal not in range(128)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #17 from Ryan H. Lewis (rhl)  ---
Ok, I've gone ahead and separated out the devel package, and the rpms are
building

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1277260] Review Request: rofi - A window switcher, run dialog and dmenu replacement

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277260

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2016-11-19 17:16:56



--- Comment #17 from Igor Gnatenko  ---


*** This bug has been marked as a duplicate of bug 1396761 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396761] Review Request: rofi - A window switcher, run dialog and dmenu replacement

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396761



--- Comment #1 from Igor Gnatenko  ---
*** Bug 1277260 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396761] New: Review Request: rofi - A window switcher, run dialog and dmenu replacement

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396761

Bug ID: 1396761
   Summary: Review Request: rofi - A window switcher, run dialog
and dmenu replacement
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: opensou...@till.name
  Reporter: ignate...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: extras...@fedoraproject.org, ignate...@redhat.com,
jakub.jedel...@gmail.com, murmansks...@gmail.com,
nob...@fedoraproject.org, opensou...@till.name,
package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/region51/rofi/rofi.git/plain/rofi.spec?id=1523dd3c64b16df67724ce89e19ba0f194c34006
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/region51/rofi/fedora-rawhide-x86_64/00175931-rofi/rofi-1.0.0-1.fc25.src.rpm
Description: A popup window switcher roughly based on superswitcher, requiring
only xlib and pango.
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369535] Review Request: sassc - Wrapper around libsass to compile CSS stylesheet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369535

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:19:50



--- Comment #8 from Fedora Update System  ---
sassc-3.3.6-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON data interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394252
Bug 1394252 depends on bug 1394167, which changed state.

Bug 1394167 Summary: Review Request: perl-Data-ICal-TimeZone - Time zones for 
Data::ICal
https://bugzilla.redhat.com/show_bug.cgi?id=1394167

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394167] Review Request: perl-Data-ICal-TimeZone - Time zones for Data::ICal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394167

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:19:45



--- Comment #9 from Fedora Update System  ---
perl-Data-ICal-TimeZone-1.23-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366862] Review Request: gimp-focusblur-plugin - Simulate an out-of-focus blur

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366862

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:19:25



--- Comment #8 from Fedora Update System  ---
gimp-focusblur-plugin-3.2.6-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370533] Review Request: python-django-pgjson - PostgreSQL json field support for Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370533

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-11-12 17:31:01 |2016-11-19 16:19:22



--- Comment #9 from Fedora Update System  ---
python-django-pgjson-0.3.1-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370611] Review Request: python-serpy - Ridiculously fast object serialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370611

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:19:19



--- Comment #7 from Fedora Update System  ---
python-serpy-0.1.1-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1367819] Review Request: znc-clientbuffer - ZNC module for client specific buffers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367819

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:19:16



--- Comment #7 from Fedora Update System  ---
znc-clientbuffer-0-0.1gitfe0f368.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393899] Review Request: libdirq - C implementation of the simple directory queue algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393899

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:18:55



--- Comment #15 from Fedora Update System  ---
libdirq-0.4-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:16:58



--- Comment #23 from Fedora Update System  ---
mpg123-1.23.8-3.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394148] Review Request: gstreamer1-plugin-mpg123 - GStreamer mp3 playback plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394148
Bug 1394148 depends on bug 1394147, which changed state.

Bug 1394147 Summary: Review Request: mpg123 - mp3 audio playback library
https://bugzilla.redhat.com/show_bug.cgi?id=1394147

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-11-11 13:42:30 |2016-11-19 16:17:09



--- Comment #20 from Fedora Update System  ---
tempus-fugit-1.2-0.1.SNAPSHOT.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365319] Review Request: EPEL vcftools - newest version 0.1.14

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365319

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||vcftools-0.1.14-1.fc25
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:14:34



--- Comment #9 from Fedora Update System  ---
vcftools-0.1.14-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1234664] Review Request: jchart2d - Real-time charting library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1234664
Bug 1234664 depends on bug 1244709, which changed state.

Bug 1244709 Summary: Add maven pom
https://bugzilla.redhat.com/show_bug.cgi?id=1244709

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227



--- Comment #14 from Fedora Update System  ---
pidgin-groupchat-typing-notifications-0-2.git33a75f9.fc25 has been pushed to
the Fedora 25 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1363923] Review Request: springframework4 - Spring Java Application Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363923
Bug 1363923 depends on bug 1390156, which changed state.

Bug 1390156 Summary: Review Request: jsonassert - JUnit extension to write JSON 
unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1390156

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390156] Review Request: jsonassert - JUnit extension to write JSON unit tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390156

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:13:21



--- Comment #11 from Fedora Update System  ---
jsonassert-1.4.0-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391892] Review Request: python-vitrageclient - Python client for Virage REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391892

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:11:54



--- Comment #12 from Fedora Update System  ---
python-vitrageclient-1.0.1-4.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387447] Review Request: php-sentry - PHP client for Sentry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387447



--- Comment #23 from Fedora Update System  ---
php-sentry-0.22.0-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1202470] Review Request: validator-htmlparser - An implementation of the HTML5 parsing algorithm in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1202470

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:09:52



--- Comment #19 from Fedora Update System  ---
validator-htmlparser-1.4-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387291] Review Request: python-lazr-delegates - Easily write objects that delegate behavior

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387291

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:09:43



--- Comment #7 from Fedora Update System  ---
python-lazr-delegates-2.0.3-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387518] Review Request: python-lazr-config - Create configuration schemas, and process and validate configurations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387518
Bug 1387518 depends on bug 1387291, which changed state.

Bug 1387291 Summary: Review Request: python-lazr-delegates - Easily write 
objects that delegate behavior
https://bugzilla.redhat.com/show_bug.cgi?id=1387291

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1365839] Review Request: python-django-notifications-hq - GitHub notifications alike app for Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365839
Bug 1365839 depends on bug 1375222, which changed state.

Bug 1375222 Summary: Review Request: python-django-jsonfield - A reusable 
Django field that allows you to store validated JSON in your model
https://bugzilla.redhat.com/show_bug.cgi?id=1375222

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1297281] Review Request: endless-sky - Space exploration, trading, and combat game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297281

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 16:08:03



--- Comment #29 from Fedora Update System  ---
endless-sky-0.9.4-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381661] Review Request: obs-build - A generic package build script

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381661



--- Comment #15 from Fedora Update System  ---
obs-build-20161025-231.1.1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375222

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-09-12 10:23:49 |2016-11-19 16:08:08



--- Comment #24 from Fedora Update System  ---
python-django-jsonfield-1.0.3-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382875] Review Request: psad - Port Scan Attack Detector (psad) watches for suspect traffic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382875

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-11-03 14:21:10 |2016-11-19 16:02:18



--- Comment #17 from Fedora Update System  ---
psad-2.4.3-3.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383725] Review Request: python-restructuredtext-lint - reStructuredText linter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383725



--- Comment #11 from Fedora Update System  ---
python-restructuredtext-lint-0.17.2-3.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350257] Review Request: petsc - Portable Extensible Toolkit for Scientific Computation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350257



--- Comment #59 from Fedora Update System  ---
petsc-3.7.4-12.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389784] Review Request: python-scour - An SVG scrubber

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389784



--- Comment #14 from Fedora Update System  ---
inkscape-0.92-5.pre2.fc25, python-scour-0.35-2.fc25 has been pushed to the
Fedora 25 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382926] Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382926



--- Comment #11 from Fedora Update System  ---
perl-HTTP-MultiPartParser-0.01-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279087] Review Request: sharpfont - Cross-platform FreeType bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279087

Fedora Update System  changed:

   What|Removed |Added

 Resolution|NEXTRELEASE |ERRATA



--- Comment #20 from Fedora Update System  ---
sharpfont-4.0.1-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388344] Review Request: javapoet - API for generating .java sources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388344

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-11-03 14:21:37 |2016-11-19 16:02:50



--- Comment #9 from Fedora Update System  ---
javapoet-1.7.0-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383447] Review Request: python-winrm - Python library for Windows Remote Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383447



--- Comment #13 from Fedora Update System  ---
python-winrm-0.2.1-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327989] Review Request: python-jupyter-client - Jupyter protocol implementation and client libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327989

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-09-26 15:49:33 |2016-11-19 16:00:31



--- Comment #15 from Fedora Update System  ---
python-jupyter-client-4.4.0-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327981] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327981
Bug 1327981 depends on bug 1327989, which changed state.

Bug 1327989 Summary: Review Request: python-jupyter-client - Jupyter protocol 
implementation and client libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1327989

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979
Bug 1327979 depends on bug 1327989, which changed state.

Bug 1327989 Summary: Review Request: python-jupyter-client - Jupyter protocol 
implementation and client libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1327989

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380



--- Comment #2 from Till Maas  ---
Actually icebox.py is also a module and not a proper script.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380

Till Maas  changed:

   What|Removed |Added

 CC||opensou...@till.name



--- Comment #1 from Till Maas  ---
It is awesome, that you want to package this. Unfortunately I have found some
issues at first glance:

- The README file contains mostly the license, therefore IMHO it should be
included with %license.

- Have you considered shipping the examples and doc dirs as %doc?

- iceboxdb.py seems to be a module and not a program, therefore it does not
belong to /usr/bin but rather %python_sitelib I think. It might be a good idea
to discuss the proper path with upstream. For future-proofness it might be a
good idea to put it in a directory in %python_sitelib such as icebox and put it
in a db.py file there. Having it in /usr/bin also creates the problem that it
might create .pyc/.pyo files there, since iceboxdb.py is imported

- Also the files in /usr/bin should not have a .py suffix

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942

Pavel Alexeev  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #15 from Pavel Alexeev  ---
I'm not expert in java packaging but it seams good for me.

Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1277260] Review Request: rofi - A window switcher, run dialog and dmenu replacement

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277260



--- Comment #16 from Till Maas  ---
(In reply to Igor Gnatenko from comment #15)
> Okay, nevermind. I can take care about this package.
> 
> Till, can you do review?

Yes, but IIRC you need to open a new bug report, otherwise the checking script
for new package requests in pkgdb will report an error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #16 from Antonio Trande  ---
(In reply to Ryan H. Lewis (rhl) from comment #13)
> where do the so-versioned parts of libEl go? how about the the other shared
> objects? 
> 
> why do they belong in a devel package? What belongs in the elemental-openmpi
> package? there would be nothing left in elemental-mpich/openmpi packages
> then. 
> 
> Similar to the base package `elemental`. There is nothing there for it.

Unversioned libraries (*.so, symbolic links to the versioned ones) go in devel
packages.

> 
> 
> <
> rpmlint shows an sqrt 'undefined-non-weak-symbol' warning, the library looks
> correctly linked with libm.so.

This warning shouldn't be there since library is correctly linked to libm
(-lm).

> 
> <
> 'unused-direct-shlib-dependency /usr/lib64/mpich/lib/libElSuiteSparse.so
> /usr/lib64/mpich/lib/libmpi.so.12' looks wrong, too.
> 
> Do we need to address these issues?

I'm not sure they are real bugs, but it's strange that library has an unused
dependence against libmpi.so .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396331] Review Request: elfio - C++ library for reading and generating ELF files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396331



--- Comment #2 from Orion Poplawski  ---
Thanks for the review.  Issues have been fixed.

* Sat Nov 19 2016 Orion Poplawski  - 3.2-2
- Fix source url
- Add BR gcc-c++
- Add %%check
- Other cleanup

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374898] Review Request: quasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898



--- Comment #8 from Ben Rosser  ---
Thanks for the review!

Upstream bugs filed:

* https://github.com/phhusson/QuasselC/issues/4

* https://github.com/phhusson/QuasselC/issues/5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #15 from Ryan H. Lewis (rhl)  ---
I've edited the spec for:

1. use -Wl, --as-needed (should clean up unused-direct-shlib-dependency)
2. no postin/postun
3. arch versioning with %{?_isa}

I've issued a code fix for:

1. PMRRR calling exit
2. invalid-soname
3. undefined-non-weak-symbol `sqrt` which an explicit link against libm on
LINUX

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396273] Review Request: python3-netifaces - Python library to retrieve information about network interfaces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396273



--- Comment #2 from Orion Poplawski  ---
I'll do Name, but I like to keep URL clickable from within the text file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 476234] Review Request: mindi-busybox - Busybox version suited for Mindi

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=476234

Till Maas  changed:

   What|Removed |Added

 CC||opensou...@till.name



--- Comment #26 from Till Maas  ---
(In reply to Bruno Cornec from comment #23)
> buffer has now been built for fedora, so I'd like to work on this one again.
> I've requested the package on branch master

The package needs to pass review before it can be imported into Fedora/you can
request a branch. It seems there was an oversight, therefore I retired the
package for now. Once the review is done, you can request it to be unretired.

Btw. I noticed that the package is not yet using %license. Also I would prefer
I comment about why you do not want to build a debug package.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376035] Review Request: modulemd - Module metadata manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376035



--- Comment #20 from Fedora Update System  ---
modulemd-1.0.2-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a749e2d8e4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394267] Review Request: perl-NNTPClient - Perl 5 module to talk to NNTP (RFC977) server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394267



--- Comment #9 from Fedora Update System  ---
perl-NNTPClient-0.37-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-eac4ab186a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394146] Review Request: perl-Convert-Base64 - Encoding and decoding of Base64 strings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394146



--- Comment #11 from Fedora Update System  ---
perl-Convert-Base64-0.001-1.fc24, perl-Mail-JMAPTalk-0.02-1.fc24 has been
pushed to the Fedora 24 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-df16f5afba

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394151] Review Request: perl-Mail-JMAPTalk - Perl client for JMAP protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394151



--- Comment #9 from Fedora Update System  ---
perl-Convert-Base64-0.001-1.fc24, perl-Mail-JMAPTalk-0.02-1.fc24 has been
pushed to the Fedora 24 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-df16f5afba

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
python-wcsaxes-0.9-3.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8b93ef0700

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374898] Review Request: quasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+
   |needinfo?(ignatenko@redhat. |
   |com)|



--- Comment #7 from Igor Gnatenko  ---
* %global shortcommit0 fcd9669 -> %global shortcommit0 %(c=%{commit0}; echo
${c:0:7})

quasselc.x86_64: W: shared-lib-calls-exit /usr/lib64/libquasselc.so.0
exit@GLIBC_2.2.5
-> worth reporting upstream

quasselc.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquasselc.so.0
handle_backlog
quasselc.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquasselc.so.0
handle_message
quasselc.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquasselc.so.0
handle_sync
quasselc.x86_64: W: undefined-non-weak-symbol /usr/lib64/libquasselc.so.0
handle_event
-> same

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #14 from Ryan H. Lewis (rhl)  ---
Also, what do you mean by "this looks wrong." what is wrong?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1280480] Review Request: python-duecredit - Automated collection and reporting of citations for used software /methods/datasets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1280480



--- Comment #2 from Igor Gnatenko  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> OK, the usual question: are the scripts in /usr/bin python-version specific,
> or is one script sufficient to use on both python2 and python3 code?
One script is sufficient.

I willupdate all this stuff.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395396] Review Request: python-sphinx_gallery - Sphinx extension to automatically generate an examples gallery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395396



--- Comment #1 from Athos Ribeiro  ---
License: BSD licenses require the full license text to be shipped with the
package. You should ask upstream to prepare a new version of the package with
the license text. Note that the github repository has a LICENSE file, which is
not shipped with the pypi package (This is a blocker).

You set PKG-INFO as the license file, but that is not the license text.

Requires: There is a import on matplotlib in one of the modules (gen_rst.py).
Why isn't it listed as a requirement?

Also, this is a sphinx extension, what are your thoughts on requiring sphinx
here?

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[!]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original 

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #13 from Ryan H. Lewis (rhl)  ---
where do the so-versioned parts of libEl go? how about the the other shared
objects? 

why do they belong in a devel package? What belongs in the elemental-openmpi
package? there would be nothing left in elemental-mpich/openmpi packages then. 

Similar to the base package `elemental`. There is nothing there for it.


<
rpmlint shows an sqrt 'undefined-non-weak-symbol' warning, the library looks
correctly linked with libm.so.

<
'unused-direct-shlib-dependency /usr/lib64/mpich/lib/libElSuiteSparse.so
/usr/lib64/mpich/lib/libmpi.so.12' looks wrong, too.

Do we need to address these issues?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395396] Review Request: python-sphinx_gallery - Sphinx extension to automatically generate an examples gallery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395396

Athos Ribeiro  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||athoscribe...@gmail.com
   Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396513

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392090] Review Request: pychromecast: Python library to communicate with the Google Chromecast.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392090
Bug 1392090 depends on bug 1209685, which changed state.

Bug 1209685 Summary: protobuf-v3.1.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1209685

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1200115] Review Request: libphonenumber - Library to handle international phone numbers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1200115
Bug 1200115 depends on bug 1209685, which changed state.

Bug 1209685 Summary: protobuf-v3.1.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1209685

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359246] Review Request: netty41 - An asynchronous event-driven network application framework and tools for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359246
Bug 1359246 depends on bug 1209685, which changed state.

Bug 1209685 Summary: protobuf-v3.1.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1209685

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909



--- Comment #16 from Orion Poplawski  ---
Yeah, I'm afraid the package can only be built on a EL7 system.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909



--- Comment #15 from Raphael Groner  ---
% fedora-review -v -m epel-7-x86_64 -b 1309909
…
error: Package already exists: %package -n python3-tornado
DEBUG: ReviewError: "Can't parse specfile: can't parse specfile\n"

Any ideas?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388945] Review Request: gnome-shell-extension-media-player-indicator - Control MPRIS2 capable media players : Rhythmbox, Banshee, Clementine and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388945



--- Comment #5 from MartinKG  ---
Spec URL:
https://martinkg.fedorapeople.org/Review/SPECS/gnome-shell-extension-media-player-indicator.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/gnome-shell-extension-media-player-indicator-0.1-0.4.20161119git3946aba.fc25.src.rpm

%changelog
* Sat Nov 19 2016 Martin Gansser  -
0.1-0.4.20161119git3946aba
- Update to new git snapshot 0.1-0.4.20161119git3946aba

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1115365] Review Request: python-pluginbase - A support library for building plugins sytems in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1115365

Fabian Affolter  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||m...@fabian-affolter.ch
 Resolution|--- |DUPLICATE
Last Closed||2016-11-19 11:32:16



--- Comment #5 from Fabian Affolter  ---


*** This bug has been marked as a duplicate of bug 1394969 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394969] Review Request: python-pluginbase - A support library for building plugins systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394969

Fabian Affolter  changed:

   What|Removed |Added

 CC||rku...@redhat.com



--- Comment #9 from Fabian Affolter  ---
*** Bug 1115365 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1304052] Review Request: python-sphinx-argparse - Automatic Sphinx documentation for argparse

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304052

Fabian Affolter  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||m...@fabian-affolter.ch
 Resolution|--- |RAWHIDE
Last Closed||2016-11-19 11:27:40



--- Comment #5 from Fabian Affolter  ---
https://admin.fedoraproject.org/pkgdb/package/rpms/python-sphinx-argparse/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909

Raphael Groner  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396748] New: Review Request: mingw-openal-soft - MinGW port of Open Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396748

Bug ID: 1396748
   Summary: Review Request: mingw-openal-soft - MinGW port of Open
Audio Library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ngomp...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/ngompa/mingw-openal-soft/mingw-openal-soft.git/plain/mingw-openal-soft.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/mingw-openal-soft/fedora-rawhide-x86_64/00478735-mingw-openal-soft/mingw-openal-soft-1.17.2-1.fc26.src.rpm
Description: 
OpenAL Soft is a cross-platform software implementation of the OpenAL 3D
audio API. It's built off of the open-sourced Windows version available
originally from the SVN repository at openal.org. OpenAL provides
capabilities for playing audio in a virtual 3d environment. Distance
attenuation, doppler shift, and directional sound emitters are among
the features handled by the API. More advanced effects, including air
absorption, low-pass filters, and reverb, are available through the
EFX extension. It also facilitates streaming audio, multi-channel buffers,
and audio capture.

This package provides the port of OpenAL to the Win32 and Win64 targets.

Fedora Account System Username: ngompa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395522] Review Request: sng - Lossless editing of PNGs via a textual representation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395522

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2016-11-19 10:09:38



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
Built in rawhide, updates submitted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396273] Review Request: python3-netifaces - Python library to retrieve information about network interfaces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396273

Thomas Andrejak  changed:

   What|Removed |Added

 CC||thomas.andre...@gmail.com



--- Comment #1 from Thomas Andrejak  ---
I'm not a packager yet, hence the review is unofficial but I think you should
use %{pypi_name} in Name: and URL: entry

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396513

Vitaly Zaitsev  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #3 from Vitaly Zaitsev  ---
I think this can be fixed during package import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396513



--- Comment #2 from Vitaly Zaitsev  ---
= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.

OK.

[ ]: Package contains no static executables.

OK.

[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.

OK.

[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "BSD (3 clause)", "GPL (v2 or later)", "GPL
 (v3 or later)", "Unknown or generated". 31 files have unknown license.
 Detailed output of licensecheck in /home/vitaly/1396513-nitrokey-
 app/licensecheck.txt

Apache (v2.0)
-
nitrokey-app-0.5.1/src/utils/base32.cpp
nitrokey-app-0.5.1/src/utils/base32.h

BSD (3 clause)
--
nitrokey-app-0.5.1/src/inttypes.h

GPL (v2 or later)
-
nitrokey-app-0.5.1/src/ui/splash.cpp
nitrokey-app-0.5.1/src/ui/splash.h
nitrokey-app-0.5.1/src/utils/gui.cpp
nitrokey-app-0.5.1/src/utils/gui.h

GPL (v3 or later)
-
All others.

[ ]: License file installed when any subpackage combination is installed.

OK.

[ ]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/udev,
 /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/22x22/apps,
 /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/24x24,
 /usr/lib/udev/rules.d, /usr/share/icons/hicolor/scalable/apps,
 /usr/share/icons/hicolor/scalable

Add hicolor-icon-theme and systemd-udev to Requires of package.

[ ]: %build honors applicable compiler flags or justifies otherwise.

OK.

[ ]: Package contains no bundled libraries without FPC exception.

OK.

[ ]: Changelog in prescribed format.

OK.

[ ]: Sources contain only permissible code or content.

OK.

[ ]: Development files must be in a -devel package

OK.

[ ]: Package uses nothing in %doc for runtime.

OK.

[ ]: The spec file handles locales properly.

OK.

[ ]: Package consistently uses macros (instead of hard-coded directory
 names).

OK.

[ ]: Package is named according to the Package Naming Guidelines.

OK.

[ ]: Package does not generate any conflict.

OK.

[ ]: Package obeys FHS, except libexecdir and /usr/target.

OK.

[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.

OK.

[ ]: Requires correct, justified where necessary.

Add hicolor-icon-theme and systemd-udev to Requires of package.

[ ]: Spec file is legible and written in American English.

OK.

[ ]: Package contains systemd file(s) if in need.

OK.

[ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.

OK..

[ ]: Useful -debuginfo package or justification otherwise.

OK.

[ ]: Package is not known to require an ExcludeArch tag.

OK.

[ ]: Package complies to the Packaging Guidelines

OK.

= SHOULD items =

Generic:
[ ]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.

OK.

[ ]: Final provides and requires are sane (see attachments).

OK.

[ ]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 nitrokey-app-debuginfo

OK.

[ ]: Package functions as described.

OK.

[ ]: Latest version is packaged.

OK.

[ ]: Package does not include license text files separate from upstream.

OK.

[ ]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.

OK.

[ ]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.

OK.

[ ]: Package should compile and build into binary rpms on all supported
 architectures.

OK.

[ ]: %check is present and all tests pass.

OK.

[ ]: Packages should try to preserve timestamps of original installed
 files.

OK.

[x]: Reviewer should test that the package builds in mock.

Tested. Works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396513



--- Comment #1 from Vitaly Zaitsev  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: make gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2


= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "BSD (3 clause)", "GPL (v2 or later)", "GPL
 (v3 or later)", "Unknown or generated". 31 files have unknown license.
 Detailed output of licensecheck in /home/vitaly/1396513-nitrokey-
 app/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/udev,
 /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/22x22/apps,
 /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/24x24,
 /usr/lib/udev/rules.d, /usr/share/icons/hicolor/scalable/apps,
 /usr/share/icons/hicolor/scalable
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in nitrokey-app
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[ ]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final 

[Bug 1394250] Review Request: python-async-timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250



--- Comment #10 from Fedora Update System  ---
python-async-timeout-1.1.0-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-da89a216e8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] Review Request: python-async-timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384133] Review Request: python3-suds - A python SOAP client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384133



--- Comment #8 from Fedora Update System  ---
python3-suds-0.6-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384729] Review Request: python3-decorator - Module to simplify usage of decorators

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384729



--- Comment #8 from Fedora Update System  ---
python3-decorator-4.0.10-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383445] Review Request: python-requests_ntlm - HTTP NTLM authentication using the requests library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383445



--- Comment #10 from Fedora Update System  ---
python-requests_ntlm-0.3.0-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383434] Review Request: python-ntlm3 - Python 3 compatible NTLM library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383434



--- Comment #11 from Fedora Update System  ---
python-ntlm3-1.0.2-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396513

Vitaly Zaitsev  changed:

   What|Removed |Added

 CC||vit...@easycoding.org
   Assignee|nob...@fedoraproject.org|vit...@easycoding.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395522] Review Request: sng - Lossless editing of PNGs via a textual representation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395522

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #12 from Antonio Trande  ---
(In reply to Ryan H. Lewis (rhl) from comment #11)
> I believe the latest spec should work.

<
$ mock -r fedora-rawhide-x86_64 --no-clean --shell 'rpm -q --list
elemental-openmpi| grep lib64'
Start: shell
/usr/lib64/openmpi/lib/libEl.so
/usr/lib64/openmpi/lib/libEl.so.0
/usr/lib64/openmpi/lib/libEl.so.86-dev
/usr/lib64/openmpi/lib/libElSuiteSparse.so
/usr/lib64/openmpi/lib/libpmrrr.so

$ mock -r fedora-rawhide-x86_64 --no-clean --shell 'rpm -q --list
elemental-mpich| grep lib64'
Start: shell
/usr/lib64/mpich/lib/libEl.so
/usr/lib64/mpich/lib/libEl.so.0
/usr/lib64/mpich/lib/libEl.so.86-dev
/usr/lib64/mpich/lib/libElSuiteSparse.so
/usr/lib64/mpich/lib/libpmrrr.so

'/usr/lib64/mpich/lib/libEl.so' and '/usr/lib64/openmpi/lib/libEl.so' must be
packed in 'elemental-mpich-devel' and 'elemental-openmpi-devel' respectively.
>

<
%package openmpi-examples
Summary: OpenMPI variant of Elemental
Group: Development/Libraries
** Requires: %{name}-openmpi = %{version}-%{release} **
%description openmpi-examples
Contains the example drivers built against OpenMPI

Required package is not arched, use
Requires: %{name}-openmpi%{?_isa} = %{version}-%{release}
Requires: %{name}-mpich%{?_isa} = %{version}-%{release}
>

<
$ mock -r fedora-rawhide-x86_64 --no-clean --shell 'rpmlint elemental-mpich'
Start: shell
elemental-mpich.x86_64: E: invalid-soname
/usr/lib64/mpich/lib/libElSuiteSparse.so libElSuiteSparse.so
elemental-mpich.x86_64: W: undefined-non-weak-symbol
/usr/lib64/mpich/lib/libElSuiteSparse.so sqrt
elemental-mpich.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/mpich/lib/libElSuiteSparse.so /usr/lib64/mpich/lib/libmpi.so.12
elemental-mpich.x86_64: E: invalid-soname /usr/lib64/mpich/lib/libpmrrr.so
libpmrrr.so
elemental-mpich.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/mpich/lib/libpmrrr.so /lib64/libopenblas.so.0
elemental-mpich.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/mpich/lib/libpmrrr.so /lib64/libgfortran.so.3
elemental-mpich.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/mpich/lib/libpmrrr.so /lib64/libpthread.so.0
elemental-mpich.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/mpich/lib/libpmrrr.so /lib64/libqd.so.0
elemental-mpich.x86_64: W: shared-lib-calls-exit
/usr/lib64/mpich/lib/libpmrrr.so exit@GLIBC_2.2.5
elemental-mpich.x86_64: W: no-documentation
elemental-mpich.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/mpich/lib/libEl.so
elemental-mpich.x86_64: E: library-without-ldconfig-postin
/usr/lib64/mpich/lib/libEl.so.86-dev
elemental-mpich.x86_64: E: library-without-ldconfig-postun
/usr/lib64/mpich/lib/libEl.so.86-dev
1 packages and 0 specfiles checked; 4 errors, 9 warnings.
Finish: shell

rpmlint shows an sqrt 'undefined-non-weak-symbol' warning, the library looks
correctly linked with libm.so.

'unused-direct-shlib-dependency /usr/lib64/mpich/lib/libElSuiteSparse.so
/usr/lib64/mpich/lib/libmpi.so.12' looks wrong, too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364736] Review Request: python-stackclimber - Allow a function to discover the module or script name of its caller , or its caller's caller.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364736

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #3 from Igor Gnatenko  ---
* https://github.com/drcloud/stackclimber/archive/%{version}.tar.gz ->
https://github.com/drcloud/stackclimber/archive/%{version}/%{modulename}-%{version}.tar.gz

* BuildRequires:  python3-pytest
* BuildRequires:  python3-pytest-runner
You can wipe out those and just do %{__pythonX} test.py

* Reduce description to 80 characters per line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364738] Review Request: python-ahab - Docker event handling with Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364738

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364737] Review Request: python-magiclog - Easy logger management for libraries and CLI tools.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364737

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



--- Comment #1 from Igor Gnatenko  ---
1.0.2 is available in upstream, can you update?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1371810] Review Request: python-iowait - Platform-independent module for I/O completion events

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1371810

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1371810] Review Request: python-iowait - Platform-independent module for I/O completion events

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1371810



--- Comment #3 from Fedora Update System  ---
python-iowait-0.2-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-68d5a2ff69

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384729] Review Request: python3-decorator - Module to simplify usage of decorators

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384729

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-19 04:50:35



--- Comment #7 from Fedora Update System  ---
python3-decorator-4.0.10-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org