[Bug 1352215] Review Request: llvm3.7 -- Versioned LLVM 3.7

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1352215



--- Comment #16 from Jens Petersen  ---
(Works great for me with ghc-8.0 FWIW.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375765] Review Request: yosys - Yosys Open SYnthesis Suite, including Verilog synthesizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375765



--- Comment #14 from Fedora Update System  ---
yosys-0.7-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d4d3573847

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375765] Review Request: yosys - Yosys Open SYnthesis Suite, including Verilog synthesizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375765

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375383] Review Request: arachne-pnr - Place and route for FPGA compilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375383



--- Comment #1 from Eric Smith  ---
Spec URL: https://fedorapeople.org/~brouhaha/arachne-pnr/arachne-pnr.spec
SRPM URL:
https://fedorapeople.org/~brouhaha/arachne-pnr/arachne-pnr-0.1-0.2.20160813git52e69ed.fc24.src.rpm

Updated icebox directory path to /usr/share/icestorm for consistency with
latest icestorm package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375380] Review Request: icestorm - Lattice iCE40 FPGA bitstream creation/analysis/ programming tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375380



--- Comment #3 from Eric Smith  ---
Spec URL: https://fedorapeople.org/~brouhaha/icestorm/icestorm.spec
SRPM URL:
https://fedorapeople.org/~brouhaha/icestorm/icestorm-0-0.2.20161101git01b9822.fc24.src.rpm

Updated to latest upstream, and updated per comments #1 and #2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401276] Review Request: python-grako - Python grammer compiler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401276



--- Comment #2 from Eric Smith  ---
Spec URL: https://fedorapeople.org/~brouhaha/python-grako/python-grako.spec
SRPM URL:
https://fedorapeople.org/~brouhaha/python-grako/python-grako-3.18.0-1.fc24.src.rpm

Updated to latest upstream, and updated spec per review comments, including
%check section. Patched Makefiles to use Python 3 for %check, since package is
only being built for Python 3.

Verified to build w/ koji for rawhide, F25, F24, and EPEL7.

The reason for the for loop that changes the shebang and perms for only one
file:
1) copied from another spec file that works - if it ain't broke don't fix it
2) future upstream releases might have more files that need this treatment

If you feel strongly about removing the for loop, let me know and I'll take it
out.

Thanks!
Eric

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 23:49:32



--- Comment #18 from Fedora Update System  ---
pgcenter-0.3.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1197517] Review Request: elmon - Performance monitoring tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197517



--- Comment #24 from Fedora Update System  ---
elmon-13b1-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938



--- Comment #23 from Fedora Update System  ---
libprelude-3.1.0-26.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-3fe04fb903

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765



--- Comment #16 from Fedora Update System  ---
dolphin-emu-5.0-7.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-54c2c61f57

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #5 from Joël Krähemann  ---
Hi

The new SRPM is here:

Spec URL: http://gsequencer.org/fedora/rpmbuild/gsequencer.spec
SRPM URL:
http://gsequencer.org/fedora/rpmbuild/SRPMS/gsequencer-0.7.115-0.fc25.src.rpm

bests,
Joël

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #22 from Fedora Update System  ---
libprelude-3.1.0-26.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6e12f43ea4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379765] Review Request: dolphin-emu - GameCube / Wii / Triforce Emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379765

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
dolphin-emu-5.0-7.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-445d5858db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #4 from Joël Krähemann  ---
Hi

Just fixed copyright notice in upstream:

gsequencer-devel.x86_64: E: incorrect-fsf-address

So I provide a new package 0.7.115

Bests,
Joël

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400542] Review Request: colm - Programming language designed for the analysis and transformation of computer languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400542



--- Comment #11 from Fedora Update System  ---
colm-0.13.0.4-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398799] Review Request: php-phpiredis - Client extension for Redis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398799



--- Comment #12 from Fedora Update System  ---
php-phpiredis-1.0.0-2.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396513



--- Comment #14 from Fedora Update System  ---
nitrokey-app-0.6.1-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400626



--- Comment #14 from Fedora Update System  ---
php-gecko-packages-gecko-php-unit-2.0.0-1.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1197517] Review Request: elmon - Performance monitoring tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197517



--- Comment #23 from Fedora Update System  ---
elmon-13b1-3.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267340] Review Request: rubygem-minitest-around - Around block for minitest

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267340



--- Comment #15 from Fedora Update System  ---
rubygem-minitest-around-0.4.0-3.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393934] Review Request: php-http-interop-http-middleware - Common interface for HTTP middleware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393934



--- Comment #14 from Fedora Update System  ---
php-http-interop-http-middleware-0.2.0-1.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403423] Review Request: vbam - High compatibility Gameboy Advance Emulator combining VBA builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403423

Jeremy Newton  changed:

   What|Removed |Added

 Whiteboard|NotReady|



--- Comment #1 from Jeremy Newton  ---
I've been submitting fixes upstream, which included as a patch (datafiles
fixes). I added a workaround for the emulation speed/throttling issue, which
merged I merged with the gcc6 patch (I've also reported the issue upstream).
See the spec file for details.

Spec URL: https://dl.dropboxusercontent.com/u/42480493/vbam.spec
SRPM URL:
https://dl.dropboxusercontent.com/u/42480493/vbam-2.0.0-0.2.beta2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914

Jeremy Newton  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #29 from Jeremy Newton  ---
Just some documentation fixes to silence some rpmlint warnings:

- Use the following for portal's description:
Summary:Lollypop flatpak portal (advanced features)

- youtube should be spelt YouTube

- playlists I believe should be "play-lists"

But other than that, looks good! Approved!

Remember to fix these before submitting.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 19:29:16



--- Comment #20 from Fedora Update System  ---
jwebunit-3.3-4.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400542] Review Request: colm - Programming language designed for the analysis and transformation of computer languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400542

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 19:29:11



--- Comment #10 from Fedora Update System  ---
colm-0.13.0.4-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400626] Review Request: php-gecko-packages-gecko-php-unit - Additional PHPUnit tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400626

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 19:29:09



--- Comment #13 from Fedora Update System  ---
php-gecko-packages-gecko-php-unit-2.0.0-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267340] Review Request: rubygem-minitest-around - Around block for minitest

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267340

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 19:28:15



--- Comment #14 from Fedora Update System  ---
rubygem-minitest-around-0.4.0-3.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1399367] Review Request: ocaml-ocplib-simplex - Simplex algorithm for solving systems of linear inequalities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1399367

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 19:28:12



--- Comment #8 from Fedora Update System  ---
ocaml-ocplib-simplex-0.3-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1267342] Review Request: rubygem-default_value_for - Provides a way to specify default values for ActiveRecord models

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267342
Bug 1267342 depends on bug 1267340, which changed state.

Bug 1267340 Summary: Review Request: rubygem-minitest-around - Around block for 
minitest
https://bugzilla.redhat.com/show_bug.cgi?id=1267340

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398799] Review Request: php-phpiredis - Client extension for Redis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398799

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 19:27:35



--- Comment #11 from Fedora Update System  ---
php-phpiredis-1.0.0-2.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393934] Review Request: php-http-interop-http-middleware - Common interface for HTTP middleware

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393934

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 19:27:28



--- Comment #13 from Fedora Update System  ---
php-http-interop-http-middleware-0.2.0-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398690] Review Request: perl-Module-Extract-Use - Pull out the modules a module explicitly uses

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398690



--- Comment #15 from Fedora Update System  ---
perl-Module-Extract-Use-1.04-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398432] Review Request: playitagainsam - Record and replay interactive terminal sessions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398432

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 19:27:25



--- Comment #6 from Fedora Update System  ---
playitagainsam-0.5.0-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383416] Review Request: python-influxdb - InfluxDB Python client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383416



--- Comment #21 from Fedora Update System  ---
python-influxdb-3.0.0-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1197517] Review Request: elmon - Performance monitoring tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197517



--- Comment #22 from Fedora Update System  ---
elmon-13b1-3.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396513] Review Request: nitrokey-app - Nitrokey's Application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396513

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 19:27:05



--- Comment #13 from Fedora Update System  ---
nitrokey-app-0.6.1-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382755] Review Request: legion - A data-centric parallel programming system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382755



--- Comment #13 from Christoph Junghans  ---
Added mpi subpackages:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16809701

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395244] Review Request: python3-zope-event - Zope Event Publication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395244



--- Comment #5 from Fedora Update System  ---
python3-zope-event-4.2.0-1.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-2d276b670c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395244] Review Request: python3-zope-event - Zope Event Publication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395244

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401334

Igor Gnatenko  changed:

   What|Removed |Added

  Flags|fedora-review-  |fedora-review?



--- Comment #5 from Igor Gnatenko  ---
Randy, fedora-review- is for packages which can't be fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909



--- Comment #24 from Fedora Update System  ---
python-pika-0.10.0-7.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-752692aca7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403030] Review Request: hdfview - Java HDF5 Object viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403030



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
Thanks for looking into this.

BR:ant was missing. Hm, I think I know how I missed that: I was building in a
prepopulated mock because I needed to install nom-tam-fits and unbuilt jhdf5 by
hand. nom-tam-fits has gone through review and is now available for koji
builds, but jhdf5 3.2.1 still need to be installed by hand. I do the following:

  mock -i
https://kojipkgs.fedoraproject.org//work/tasks/1360/16821360/jhdf5-3.2.1-1.fc26.x86_64.rpm
  mock -n hdfview-2.13.0-1.fc26.src.rpm

fedora-review can also be instucted to use a pre-populated mock:

  fedora-review -o ' -n' -b 1403030

scratch koji build for updated jhdf5:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16821359

Spec URL: http://in.waw.pl/~zbyszek/fedora/hdfview/hdfview.spec
SRPM URL:
http://in.waw.pl/~zbyszek/fedora/hdfview/hdfview-2.13.0-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1197517] Review Request: elmon - Performance monitoring tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197517

Raphael Groner  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 15:20:28



--- Comment #21 from Raphael Groner  ---
Thanks for pushing. Closing here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #3 from Joël Krähemann  ---
Hi all

Just updated the files gsequencer.spec and gsequencer-0.7.114-0.fc25.src.rpm

about %{_datadir}/xml/gsequencer/ I'm unsure

Bests,
Joël

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402540] Review Request: git-fame - Pretty-print git repository collaborators sorted by contributions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402540

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Igor Gnatenko  ---
git is required at least for directory ownership. but it's spawned by
subprocess as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368157] Review Request: python-pika-pool - Pools for pikas ( rename of python-pika_pool)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368157

Raphael Groner  changed:

   What|Removed |Added

 CC||karlthe...@gmail.com
  Flags||needinfo?(karlthered@gmail.
   ||com)



--- Comment #4 from Raphael Groner  ---
Are you still interested in doing this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403030] Review Request: hdfview - Java HDF5 Object viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403030



--- Comment #4 from Jos de Kloe  ---
Hi, first thanks for your effort on this package.

However, unfortunately it does not build on my side.
Both the fedora-review and a manual mock command for rawhide fails.
It seems a missing build requirement, since at the end of the build.log I get:

Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.tUdUcd
+ umask 022
+ cd /builddir/build/BUILD
+ cd hdfview-2.13.0-Source
+ ant jar
/var/tmp/rpm-tmp.tUdUcd: line 31: ant: command not found
error: Bad exit status from /var/tmp/rpm-tmp.tUdUcd (%build)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.tUdUcd (%build)
Child return code was: 1
EXCEPTION: [Error()]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401334



--- Comment #4 from Miro Hrončok  ---
Fixed: https://github.com/WoLpH/python-utils/blob/develop/LICENSE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402540] Review Request: git-fame - Pretty-print git repository collaborators sorted by contributions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402540



--- Comment #5 from Fabio Alessandro Locati  ---
Thanks Igor :)

* Consider taking REAL sources, not the PyPI waste
* /usr/libexec -> %{_libexecdir}
* /usr/bin -> %{_bindir}
* %{python3_sitelib}/gitfame -> %{python3_sitelib}/gitfame/
* %{python3_sitelib}/git_fame-%{version}-py?.?.egg-info ->
%{python3_sitelib}/git_fame-*/

Should all be done till here

* I think Requires: git is missing (or even git-core, depends what it really
requires)

Git is actually not required

* Consider using Cython version, because it's faster (BR: python3-Cython and
--cython to the %py3_build/install executions)

Not sure if this would give us real advantages

* I would also add Recommends: python3-tabulate

In v1.2 is now needed, so I've included as required

* Tests are not ran

They need some packages that are not present in Fedora (ie: nose-timer)

SPEC: https://fale.fedorapeople.org/rpms/git-fame.spec
SRPM: https://fale.fedorapeople.org/rpms/git-fame-1.2.0-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401334



--- Comment #3 from Miro Hrončok  ---
https://github.com/WoLpH/python-utils/issues/1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401334



--- Comment #2 from Miro Hrončok  ---
The setup.py contains this information:

license='BSD',
classifiers=['License :: OSI Approved :: BSD License'],

I will talk to upstream to include the license text, but i would say it's not a
blocker.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1402456] Review Request: python3-idna - Internationalized Domain Names in Applications (IDNA)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1402456

Tim Orling  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Tim Orling  ---
Koji EPEL7 build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16811045

Koji EL6 build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16811047

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Package contains BR: python2-devel or python3-devel
  => OK: uses python%{python3_pkgversion}-devel is used and is EPEL only.
- Warning about invalid license: Unicode
  => Appears is should be Unicode-TOU:
 https://spdx.org/licenses/Unicode-TOU.html
  [!] Please address when package is created

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 16 files have unknown license. Detailed
 output of licensecheck in
 /home/parallels/1402456-python3-idna/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
 => OK: LICENSE file breaks down the licenses
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/licenses
 => EPEL has no default owner for /usr/share/licenses
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/licenses
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to 

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #2 from Michael Schwendt  ---
$ fedora-review -b 1403417
INFO: Processing bugzilla bug: 1403417
...
INFO: Downloading .spec and .srpm files
error: %changelog entries must start with *


So, the fedora-review tool cannot even build this one. No %changelog section at
all in the spec file?

https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs


Then a look at the src.rpm, which contains a different spec file:

-- gsequencer.spec 2016-12-09 22:08:56.0 +0100
+++ gsequencer.spec.ticket  2016-12-10 02:08:17.0 +0100
@@ -46,6 +46,7 @@

 %files -n gsequencer
 %license COPYING
+%changelog ChangeLog
 %{_libdir}/libags.*
 %{_libdir}/libags_thread.*
 %{_libdir}/libags_server.*


That won't work. %changelog starts an own section in the spec file. It is not a
macro to use for including a doc file.

[...]

A couple of early finds based on skimming over the package:


Since you use pkg-config for detecting and using build dependencies, be aware
of:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_based_on_pkg-config

There are also automatically added RPM dependencies for the pkg-config .pc file
inter-dependencies. See output of "rpm -qpR
gsequencer-devel-0.7.114-0.fc25.x86_64.rpm", for example. If you rely on
pkg-config based dependencies, you would not need to add explicit Requires to
your -devel package and maintain that list manually.


> %files -n gsequencer

The "-n gsequencer" is superfluous, because for the main package it defaults to
%name. No need to respecify the package name.


> %{_defaultdocdir}/gsequencer/

Unless your configure script explicitly uses something related to
%_defaultdocdir, for brevity you may want to prefer the shorter %{_docdir}
which also expands to /usr/share/doc (= %_datadir/doc). You will see
documentation mention %_docdir more often than %_defaultdocdir. Currently they
expand to the same, however.


> %{_libdir}/libags.*
> %{_libdir}/libags_thread.*
> %{_libdir}/libags_server.*
> %{_libdir}/libags_gui.*
> %{_libdir}/libags_audio.*

https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries
https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages


> %{_datadir}/applications/gsequencer.desktop

https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files


> %{_datadir}/doc-base/gsequencer-documentation

What about %_datadir/doc-base/?

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging:UnownedDirectories


> %{_datadir}/xml/gsequencer/

Will the %_datadkir/xml directory always be available? Or is a dependency
missing?


> %package -n gsequencer-devel

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

If requiring the base, there is also no need to duplicate the license in the
-devel package.


> %package -n gsequencer-devel-docs

The guidelines recommend a -doc ending:
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation


> Requires: devhelp

Not strictly needed for plain HTML documentation.


> %{_datadir}/gtk-doc/html/*

https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417

Michael Schwendt  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)



--- Comment #1 from Michael Schwendt  ---
Adding FE-NEEDSPONSOR blocker as per 2.1.12:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Create_Your_Review_Request


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403030] Review Request: hdfview - Java HDF5 Object viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403030



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
Yikes.

Spec URL: http://in.waw.pl/~zbyszek/fedora/hdfview/hdfview.spec
SRPM URL:
http://in.waw.pl/~zbyszek/fedora/hdfview/hdfview-2.13.0-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403030] Review Request: hdfview - Java HDF5 Object viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403030

Jos de Kloe  changed:

   What|Removed |Added

 CC||josdek...@gmail.com



--- Comment #2 from Jos de Kloe  ---
I get a Forbidden error when I try to download your srpm:

Forbidden

You don't have permission to access
/~zbyszek/hdfview/hdfview-2.13.0-1.fc26.src.rpm on this server.

please fix this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938



--- Comment #21 from Fedora Update System  ---
libprelude-3.1.0-26.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-3fe04fb903

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938



--- Comment #20 from Fedora Update System  ---
libprelude-3.1.0-26.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6e12f43ea4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #28 from MartinKG  ---
(In reply to Jeremy Newton from comment #27)
> (In reply to MartinKG from comment #26)
> 
> The issue of the portal dependency still exists. lollypop should require
> lollypop-portal, not the other way around.
> 
> Right now portal has the following requirement:
> > Requires:   %{name} = %{version}-%{release}
> 
> This should be removed and the following should be added on the base package:
> > Requires:   %{name}-portal = %{version}-%{release}
> 
> This also allows a user to only install lollypop-portal, if they wish to use
> the flatpak instead.

done
> 
> As well, is --prefix=/usr should not be used for autogen.sh. I would
> personally suggestion running autogen with NOCONFIGURE set, thus to prevent
> configure from running, then configure using the %configure macro.
> 
> I'm assuming something like this would work:
> > pushd %{subpkg}-%{commit0}
> > NOCONFIGURE=1 ./autogen.sh
> > %configure
> > popd

done 


Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.223-2.fc25.src.rpm

%changelog
* Sat Dec 10 2016 Martin Gansser  - 0.9.223-2
- Add Requires to base package
- Remove Requires on the subpkg lollypop-portal
- Add NOCONFIGURE=1 ./autogen.sh to subpkg lollypop-portal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401329] Review Request: beesu - Graphical wrapper for su

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401329

Wolfgang Ulbrich  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-10 03:16:23



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org